Debian Bug report logs - #571683
dkms: should dkms clean up after itself?

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michael Gilbert <michael.s.gilbert@gmail.com>

To: submit@bugs.debian.org

Subject: dkms: should dkms clean up after itself?

Date: Sat, 27 Feb 2010 02:04:26 -0500

package: dkms
version: 2.1.1.2-2
severity: normal

when removing a kernel which has previously had dkms modules built
for it, the user will see the following message:

  rmdir: failed to remove `/lib/modules/2.6.32-2-amd64': Directory not empty
  dpkg: warning: while removing linux-image-2.6.32-2-amd64, directory '/lib/modules/2.6.32-2-amd64' not empty so not removed.

this is because dkms doesn't have any cleanup code to remove the
modules and files it creates.  would it be make sense to add some
dkms cleanup code to the kernel's postrm?  if i find the time, i
will look into this (if it sounds reasonable).

mike

Message #10 received at 571683@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: Michael Gilbert <michael.s.gilbert@gmail.com>

Cc: 571683@bugs.debian.org

Subject: Re: [Pkg-dkms-maint] Bug#571683: dkms: should dkms clean up after itself?

Date: Tue, 2 Mar 2010 17:48:42 +0100

[Message part 1 (text/plain, inline)]

Hello,

On Saturday 27 February 2010 08:04:26, Michael Gilbert wrote:
> package: dkms
> version: 2.1.1.2-2
> severity: normal
> 
> when removing a kernel which has previously had dkms modules built
> for it, the user will see the following message:
> 
>   rmdir: failed to remove `/lib/modules/2.6.32-2-amd64': Directory not
>  empty dpkg: warning: while removing linux-image-2.6.32-2-amd64, directory
>  '/lib/modules/2.6.32-2-amd64' not empty so not removed.
> 
> this is because dkms doesn't have any cleanup code to remove the
> modules and files it creates.

I believe this should be handled by kernels' prerm; the only thing we could do 
is providing a wrapper to which the prerm passes the removed version (and 
inside which we issue the proper command for cleaning up DKMS modules).

David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|----
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 571683@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Iuculano <giuseppe@iuculano.it>

To: Michael Gilbert <michael.s.gilbert@gmail.com>, 571683@bugs.debian.org, DKMS maintainers <pkg-dkms-maint@lists.alioth.debian.org>

Subject: Re: [Pkg-dkms-maint] Bug#571683: dkms: should dkms clean up after itself?

Date: Wed, 03 Mar 2010 16:37:15 +0100

[Message part 1 (text/plain, inline)]

Il 27/02/2010 08:04, Michael Gilbert ha scritto:
> this is because dkms doesn't have any cleanup code to remove the
> modules and files it creates.  would it be make sense to add some
> dkms cleanup code to the kernel's postrm?  if i find the time, i
> will look into this (if it sounds reasonable).
> 

Strange.. we have already /etc/kernel/prerm.d/dkms

Cheers,
Giuseppe.

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 571683-close@bugs.debian.org (full text, mbox, reply):

From: Michael Gilbert <michael.s.gilbert@gmail.com>

To: 571683-close@bugs.debian.org

Subject: Re: [Pkg-dkms-maint] Bug#571683: dkms: should dkms clean up after itself?

Date: Wed, 3 Mar 2010 12:22:22 -0500

On Wed, 03 Mar 2010 16:37:15 +0100, Giuseppe Iuculano wrote:
> Il 27/02/2010 08:04, Michael Gilbert ha scritto:
> > this is because dkms doesn't have any cleanup code to remove the
> > modules and files it creates.  would it be make sense to add some
> > dkms cleanup code to the kernel's postrm?  if i find the time, i
> > will look into this (if it sounds reasonable).
> > 
> 
> Strange.. we have already /etc/kernel/prerm.d/dkms

hmmm, looks like i didn't look closely enough.  

i just tested this again, and can't reproduce it.  maybe since my
original report was for an older kernel that was installed with an
older dkms the remove scripts weren't called for some reason.

anyway, i'm closing the bug and will reopen if it happens again in the
future.  but it was probably just a temporary issue.

mike

Send a report that this bug log contains spam.