Debian Bug report logs - #56973
Patch to display "MBR" at bootup.

version graph

Package: mbr; Maintainer for mbr is Santiago Garcia Mantinan <manty@debian.org>; Source for mbr is src:mbr.

Reported by: Tom Rothamel <tom-10991@onegeek.org>

Date: Fri, 4 Feb 2000 04:33:00 UTC

Severity: wishlist

Found in version 1.1.1-1

Done: Santiago Vila <sanvila@unex.es>

Bug is archived. No further changes may be made.

Forwarded to Neil Turton <neilt@chiark.greenend.org.uk>

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to Tom Rothamel <tom-10991@onegeek.org>:
New Bug report received and forwarded. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Tom Rothamel <tom-10991@onegeek.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Patch to display "MBR" at bootup.
Date: Thu, 03 Feb 2000 23:32:03 -0500
Package: mbr
Version: 1.1.1-1
Severity: wishlist

What follows is a patch to MBR that makes it print out "MBR<cr>" as the 
first thing that it does. This would help to combat the lack of
knowledge that some seem to have that MBR is even running. 

--- mbr-1.1.1/mbr.S86	Mon Jan 10 15:06:50 2000
+++ mbr-tom/mbr.S86	Thu Feb  3 10:25:56 2000
@@ -15,6 +15,7 @@
 !    along with this program; if not, write to the Free Software
 !    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 !
+#define LOGO
 #undef COMPAT
 !
 ! We are loaded at 0:0x7c00 by the BIOS, but need to load boot sectors
@@ -40,7 +41,27 @@
 	mov si,#table+0x30 ! Set bootable flags from partition table
 	mov al,#8 ! AH=0 is set from above
 	jmp 0:cont ! Switch to the newly made copy. From now on labels work.
-cont:	cmpb drive,#0xFF ! If drive==0xFF, use the value in DL instead.
+cont:	
+#ifdef LOGO
+	! Code to print the word "MBR" at boot time, to let people
+	! know that we are here. - Tom Rothamel <tom-10990@onegeek.org>
+	! Inspired by a discussion on debian-devel.
+logolen	equ 4 	! The length of the logo string.
+
+	pusha
+	mov ah,#0xe
+	mov si,#logo
+	xor bx,bx
+	mov cx,#logolen
+logol:
+	mov al,[si]
+	int 0x10
+	inc si
+	loop logol
+	popa
+#endif
+		
+	cmpb drive,#0xFF ! If drive==0xFF, use the value in DL instead.
 	jne ptloop
 	mov drive,dl ! Now DL is free for use
 ptloop:	cmpb [si],#0 ! Check for bootable flag
@@ -199,6 +220,9 @@
 lbit:	cmp 0x7dfe,#0xaa55
 	jnz il3
 	jmp 0:0x7c00
+#ifdef LOGO
+logo:	.ascii "MBR\r"
+#endif
 request:.byte 0x10, 0, 1, 0
 	.word 0x7c00, 0
 	.word 0, 0, 0, 0


-- System Information
Debian Release: potato
Architecture: i386
Kernel: Linux rei.onegeek.org 2.2.10-rei #3 Sat Aug 21 20:40:57 EDT 1999 i586



Reply sent to Santiago Vila <sanvila@unex.es>:
You have marked Bug as forwarded. Full text and rfc822 format available.

Message #8 received at 56973-forwarded@bugs.debian.org (full text, mbox):

From: Santiago Vila <sanvila@unex.es>
To: Neil Turton <neilt@chiark.greenend.org.uk>
Cc: 56973-forwarded@bugs.debian.org, Tom Rothamel <tom-10991@onegeek.org>
Subject: Bug#56973: Patch to display "MBR" at bootup. (fwd)
Date: Fri, 4 Feb 2000 13:34:46 +0100 (CET)
Hello.

Background: There has been a great discussion about the MBR these days in
debian-devel. The various install-mbr options already solve most of the
"problems" people seem to found. However, one of the things that were
raised in the discussion is that some people do not even know that the
14FA: prompt comes from the MBR (LILO identifies itself when it runs).

I have just received this patch which tries to address this problem.

Thanks.

---------- Forwarded message ----------
Date: Thu, 03 Feb 2000 23:32:03 -0500
From: Tom Rothamel <tom-10991@onegeek.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: #56973: Patch to display "MBR" at bootup.

Package: mbr
Version: 1.1.1-1
Severity: wishlist

What follows is a patch to MBR that makes it print out "MBR<cr>" as the 
first thing that it does. This would help to combat the lack of
knowledge that some seem to have that MBR is even running. 

--- mbr-1.1.1/mbr.S86	Mon Jan 10 15:06:50 2000
+++ mbr-tom/mbr.S86	Thu Feb  3 10:25:56 2000
@@ -15,6 +15,7 @@
 !    along with this program; if not, write to the Free Software
 !    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 !
+#define LOGO
 #undef COMPAT
 !
 ! We are loaded at 0:0x7c00 by the BIOS, but need to load boot sectors
@@ -40,7 +41,27 @@
 	mov si,#table+0x30 ! Set bootable flags from partition table
 	mov al,#8 ! AH=0 is set from above
 	jmp 0:cont ! Switch to the newly made copy. From now on labels work.
-cont:	cmpb drive,#0xFF ! If drive==0xFF, use the value in DL instead.
+cont:	
+#ifdef LOGO
+	! Code to print the word "MBR" at boot time, to let people
+	! know that we are here. - Tom Rothamel <tom-10990@onegeek.org>
+	! Inspired by a discussion on debian-devel.
+logolen	equ 4 	! The length of the logo string.
+
+	pusha
+	mov ah,#0xe
+	mov si,#logo
+	xor bx,bx
+	mov cx,#logolen
+logol:
+	mov al,[si]
+	int 0x10
+	inc si
+	loop logol
+	popa
+#endif
+		
+	cmpb drive,#0xFF ! If drive==0xFF, use the value in DL instead.
 	jne ptloop
 	mov drive,dl ! Now DL is free for use
 ptloop:	cmpb [si],#0 ! Check for bootable flag
@@ -199,6 +220,9 @@
 lbit:	cmp 0x7dfe,#0xaa55
 	jnz il3
 	jmp 0:0x7c00
+#ifdef LOGO
+logo:	.ascii "MBR\r"
+#endif
 request:.byte 0x10, 0, 1, 0
 	.word 0x7c00, 0
 	.word 0, 0, 0, 0


-- System Information
Debian Release: potato
Architecture: i386
Kernel: Linux rei.onegeek.org 2.2.10-rei #3 Sat Aug 21 20:40:57 EDT 1999 i586



-- 
 "02933fd6ae78e3be63ba8b3d7dc4c5e1" (a truly random sig)



Message #9 received at 56973-forwarded@bugs.debian.org (full text, mbox):

From: Neil Turton <neilt@chiark.greenend.org.uk>
To: Santiago Vila <sanvila@unex.es>
Cc: Neil Turton <neilt@chiark.greenend.org.uk>, 56973-forwarded@bugs.debian.org, Tom Rothamel <tom-10991@onegeek.org>
Subject: Bug#56973: Patch to display "MBR" at bootup. (fwd)
Date: Tue, 8 Feb 2000 11:26:29 +0000 (GMT)
Hello,

Santiago Vila writes:
 > However, one of the things that were raised in the discussion is
 > that some people do not even know that the 14FA: prompt comes from
 > the MBR (LILO identifies itself when it runs).
 > 
 > I have just received this patch which tries to address this problem.

I tried the patch, and it doesn't seem to do the right thing.  It
appears to display the logo whenever it doesn't display the prompt
(since the logo gets overwritten by the prompt).  How about displaying
the logo just before the prompt, as follows?

  MBR-14FA:

I don't think the logo needs to appear if the prompt doesn't.  The
following patch implements this.  What does everyone else think?

Neil.

 --- mbr.S86.orig	2000/01/10 20:23:30
 +++ mbr.S86	2000/02/07 20:16:51
 @@ -15,6 +15,7 @@
  !    along with this program; if not, write to the Free Software
  !    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  !
 +#define LOGO
  #undef COMPAT
  !
  ! We are loaded at 0:0x7c00 by the BIOS, but need to load boot sectors
 @@ -83,13 +84,26 @@
	 inc al
	 add si,#0x10
	 loop l5 ! Try next partition
 -l3:	mov cl,flags ! Interrupted (or no default)
 +
 +	! Display the prompt
 +l3:	mov ah,#0xe ! Print char
 +	xor bx,bx
 +#ifdef LOGO
 +       ! Code to print the word "MBR" at boot time, to let people
 +       ! know that we are here. - Tom Rothamel <tom-10990@onegeek.org>
 +       ! Inspired by a discussion on debian-devel.
 +       mov si,#logo
 +       mov cx,#logolen
 +logol:
 +       lodsb
 +       int 0x10
 +       loop logol
 +#endif
 +	mov cl,flags ! Interrupted (or no default)
	 mov si,#chars ! List of chars to print
  l9:	lodsb
	 shr cl,#1 ! Shift next bit into carry
	 jnb l8
 -	mov ah,#0xe ! Print char
 -	xor bx,bx
	 int 0x10
  l8:	or cl,cl ! Any more bits set?
	 jnz l9
 @@ -199,6 +213,11 @@
  lbit:	cmp 0x7dfe,#0xaa55
	 jnz il3
	 jmp 0:0x7c00
 +#ifdef LOGO
 +logo:  .ascii "MBR-"
 +logo_end:
 +logolen equ logo_end-logo   ! The length of the logo string.
 +#endif
  request:.byte 0x10, 0, 1, 0
	 .word 0x7c00, 0
	 .word 0, 0, 0, 0


Message #10 received at 56973-forwarded@bugs.debian.org (full text, mbox):

From: Tom Rothamel <tom-mutt-1@onegeek.org>
To: Neil Turton <neilt@chiark.greenend.org.uk>
Cc: Santiago Vila <sanvila@unex.es>, 56973-forwarded@bugs.debian.org
Subject: Re: Bug#56973: Patch to display "MBR" at bootup. (fwd)
Date: Tue, 8 Feb 2000 14:53:16 -0500
On Tue, Feb 08, 2000 at 11:26:29AM +0000, Neil Turton wrote:

> I don't think the logo needs to appear if the prompt doesn't.  The
> following patch implements this.  What does everyone else think?

I sorta think that if the logo doesn't appear when the prompt doesn't,
it defeats the whole point of having it in the first place. (Which was
to raise MBR's profile in the boot sequence, since many people didn't
know that it even was installed in the first place.)

Did you see the thread on debian-devel regarding this?

BTW, nice use of lodsb to save a few bytes. 

-- 
Tom Rothamel --------- http://onegeek.org/~tom/ ---------- Using GNU/Linux
	"Students who successfully accomplish this task will be given 
	 extra credit (and a complete psychiatric examination)."
		- Andrew S. Tannenbaum, _Structured Computer Organization_


Information forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to Joey Hess <joeyh@debian.org>:
Extra info received and forwarded to list. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #15 received at 56973@bugs.debian.org (full text, mbox):

From: Joey Hess <joeyh@debian.org>
To: 56973@bugs.debian.org, Neil Turton <neilt@chiark.greenend.org.uk>
Subject: Re: Patch to display "MBR" at bootup.
Date: Tue, 8 Feb 2000 12:29:32 -0800
Neil writes:
> I tried the patch, and it doesn't seem to do the right thing.  It
> appears to display the logo whenever it doesn't display the prompt
> (since the logo gets overwritten by the prompt).  How about displaying
> the logo just before the prompt, as follows?
> 
> I don't think the logo needs to appear if the prompt doesn't.  The
> following patch implements this.  What does everyone else think?

I think you're missing the point of the original patch. We had a big
flamewar because people don't know debian has a special MBR. This bug report
was filed with the stated intention to "combat the lack of knowledge that
some seem to have that MBR is even running". It's not going to combat that
very well if they never see the logo!

I think the logo should appear at all times. So normal boot would look like:

MBR
LILO loading linux ...........

Boot with the menu brought up could look like:

MBR 14FA:

-- 
see shy jo


Information forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to Neil Turton <neilt@chiark.greenend.org.uk>:
Extra info received and forwarded to list. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #20 received at 56973@bugs.debian.org (full text, mbox):

From: Neil Turton <neilt@chiark.greenend.org.uk>
To: Joey Hess <joeyh@debian.org>
Cc: 56973@bugs.debian.org, Tom Rothamel <tom-mutt-1@onegeek.org>
Subject: Re: Patch to display "MBR" at bootup.
Date: Wed, 9 Feb 2000 15:47:56 +0000 (GMT)
Hi all,

  I've read the flamewar now, so I can see where you're coming from.

Joey Hess writes:
 > I think the logo should appear at all times. So normal boot would
 > look like:
 > 
 > MBR
 > LILO loading linux ...........
 > 
 > Boot with the menu brought up could look like:
 > 
 > MBR 14FA:

This looks reasonable and doable.  I'll probably have this done
tomorrow.  Doesn't anyone think this isn't what's needed?

Neil.


Information forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to Tom Rothamel <tom-mutt-1@onegeek.org>:
Extra info received and forwarded to list. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #25 received at 56973@bugs.debian.org (full text, mbox):

From: Tom Rothamel <tom-mutt-1@onegeek.org>
To: Neil Turton <neilt@chiark.greenend.org.uk>
Cc: Joey Hess <joeyh@debian.org>, 56973@bugs.debian.org, Tom Rothamel <tom-mutt-1@onegeek.org>
Subject: Re: Patch to display "MBR" at bootup.
Date: Wed, 9 Feb 2000 11:21:39 -0500
On Wed, Feb 09, 2000 at 03:47:56PM +0000, Neil Turton wrote:
> This looks reasonable and doable.  I'll probably have this done
> tomorrow.  Doesn't anyone think this isn't what's needed?

I think that this is exactly what is needed. It's got my vote[1]. 

[1] Or at least it would if this was a democracy, which it isn't.

-- 
Tom Rothamel --------- http://onegeek.org/~tom/ ---------- Using GNU/Linux
	"Students who successfully accomplish this task will be given 
	 extra credit (and a complete psychiatric examination)."
		- Andrew S. Tannenbaum, _Structured Computer Organization_


Information forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to Santiago Vila <sanvila@unex.es>:
Extra info received and forwarded to list. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #30 received at 56973@bugs.debian.org (full text, mbox):

From: Santiago Vila <sanvila@unex.es>
To: Joey Hess <joeyh@debian.org>, 56973@bugs.debian.org
Cc: Neil Turton <neilt@chiark.greenend.org.uk>
Subject: Re: Bug#56973: Patch to display "MBR" at bootup.
Date: Thu, 10 Feb 2000 11:46:29 +0100 (CET)
On Tue, 8 Feb 2000, Joey Hess wrote:

> I think the logo should appear at all times. So normal boot would look like:
> 
> MBR
> LILO loading linux ...........
> 
> Boot with the menu brought up could look like:
> 
> MBR 14FA:

I fully agree with this.

Thanks.

-- 
 "8c98ca688a14710f6f4a3a5c201b20d5" (a truly random sig)



Information forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to Neil Turton <neilt@chiark.greenend.org.uk>:
Extra info received and forwarded to list. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #35 received at 56973@bugs.debian.org (full text, mbox):

From: Neil Turton <neilt@chiark.greenend.org.uk>
To: Santiago Vila <sanvila@unex.es>
Cc: Joey Hess <joeyh@debian.org>, 56973@bugs.debian.org, Neil Turton <neilt@chiark.greenend.org.uk>
Subject: Re: Bug#56973: Patch to display "MBR" at bootup.
Date: Thu, 10 Feb 2000 18:40:02 +0000 (GMT)
Hi all,

  The logo code is now in.  It was a squeeze, but it fits.  I had to
throw some (hopefully redundant) code out to get it in.  Let me know
if I've broken anything.  The new version is available from:

  http://www.chiark.greenend.org.uk/~neilt/mbr-1.1.2.tgz

Any ideas what to do with the remaining 6 bytes?  :)

Neil.


Information forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to Santiago Vila <sanvila@unex.es>:
Extra info received and forwarded to list. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #40 received at 56973@bugs.debian.org (full text, mbox):

From: Santiago Vila <sanvila@unex.es>
To: Neil Turton <neilt@chiark.greenend.org.uk>, 56973@bugs.debian.org
Cc: Joey Hess <joeyh@debian.org>, Tom Rothamel <tom-10991@onegeek.org>
Subject: Re: Bug#56973: Patch to display "MBR" at bootup.
Date: Fri, 11 Feb 2000 14:02:18 +0100 (CET)
On Thu, 10 Feb 2000, Neil Turton wrote:

> Hi all,
> 
>   The logo code is now in.  It was a squeeze, but it fits.  I had to
> throw some (hopefully redundant) code out to get it in.  Let me know
> if I've broken anything.  The new version is available from:
> 
>   http://www.chiark.greenend.org.uk/~neilt/mbr-1.1.2.tgz

Thanks a lot.

I've uploaded it to "unstable" for testing as 1.1.2-0.

After a few days of testing, and if the release manager approves it,
I could upload it to frozen too (I think this is a worthy improvement).

> Any ideas what to do with the remaining 6 bytes?  :)

Let us save them for now :-)

-- 
 "0f49f571e465f49882e82727cd9b11e8" (a truly random sig)



Information forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to Joey Hess <joeyh@debian.org>:
Extra info received and forwarded to list. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #45 received at 56973@bugs.debian.org (full text, mbox):

From: Joey Hess <joeyh@debian.org>
To: Santiago Vila <sanvila@unex.es>
Cc: 56973@bugs.debian.org
Subject: Re: Bug#56973: Patch to display "MBR" at bootup.
Date: Fri, 11 Feb 2000 10:17:50 -0800
Santiago Vila wrote:
> Let us save them for now :-)

Aw, come on -- I was hoping for a TCP/IP stack and webserver ...

-- 
see shy jo


Information forwarded to debian-bugs-dist@lists.debian.org, Santiago Vila <sanvila@ctv.es>:
Bug#56973; Package mbr. Full text and rfc822 format available.

Acknowledgement sent to "Paul J. Keenan" <paul@funkiest.demon.co.uk>:
Extra info received and forwarded to list. Copy sent to Santiago Vila <sanvila@ctv.es>. Full text and rfc822 format available.

Message #50 received at 56973@bugs.debian.org (full text, mbox):

From: "Paul J. Keenan" <paul@funkiest.demon.co.uk>
To: 56973@bugs.debian.org
Subject: Re: Bug#56973: Patch to display "MBR" at bootup.
Date: Fri, 11 Feb 2000 20:02:24 +0000
On Thu, Feb 10, 2000 at 06:40:02PM +0000, Neil Turton wrote:
> Any ideas what to do with the remaining 6 bytes?  :)
> 
> Neil.

An animated penguin jumping up and down shouting "Linux!".

-- 
Regards,
Paul


Reply sent to Santiago Vila <sanvila@unex.es>:
You have taken responsibility. Full text and rfc822 format available.

Notification sent to Tom Rothamel <tom-10991@onegeek.org>:
Bug acknowledged by developer. Full text and rfc822 format available.

Message #55 received at 56973-done@bugs.debian.org (full text, mbox):

From: Santiago Vila <sanvila@unex.es>
To: Tom Rothamel <tom-10991@onegeek.org>, 56973-done@bugs.debian.org
Subject: Re: Bug#56973: Patch to display "MBR" at bootup.
Date: Mon, 6 Mar 2000 11:19:05 +0100 (CET)
On Thu, 3 Feb 2000, Tom Rothamel wrote:

> Package: mbr
> Version: 1.1.1-1
> Severity: wishlist
> 
> What follows is a patch to MBR that makes it print out "MBR<cr>" as the 
> first thing that it does. This would help to combat the lack of
> knowledge that some seem to have that MBR is even running. 

The author has released a new version of mbr based on this idea.
mbr-1.1.2-1 is now available in potato.

Thanks a lot!

-- 
 "6df0575b6f82f962352dccd7005b0ede" (a truly random sig)



Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed Apr 23 17:17:28 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.