Debian Bug report logs - #569028
nagios-plugins-standard: please move some depends to recommends

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Helmut Grohne <helmut@subdivi.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: nagios-plugins-standard: please move some depends to recommends

Date: Tue, 9 Feb 2010 16:49:49 +0100

Package: nagios-plugins-standard
Version: 1.4.14-1
Severity: normal

The nagios-plugins-standard package pulls in tons of dependencies that
are completely useless to me. This is the depends header:

Depends:
	libc6 (>= 2.3),
Unavoidable.
	libldap-2.4-2 (>= 2.4.7),
	libmysqlclient16 (>= 5.1.21-1),
	libpq5 (>= 8.4~0cvs20090328),
	libradiusclient-ng2,
The four above are probably not required by all setups, so they might be
candidates for recommends. Having binaries with missing libraries is a
bit weird, these are better kept.
	zlib1g (>= 1:1.1.4),
Probably unavoidable.
	fping,
	snmp,
	radiusclient1,
	libnet-snmp-perl,
	dnsutils,
	bind9-host | host,
	smbclient,
The seven above are good candidates for recommends.
	ucf,
Probably unavoidable.
	nagios-plugins-basic (>= 1.4.5-2)
This is better kept.

So please move some dependencies to recommends and make a smaller
installation possible.

Helmut

Message #12 received at 569028@bugs.debian.org (full text, mbox, reply):

From: Jan Wagner <waja@cyconet.org>

To: Helmut Grohne <helmut@subdivi.de>

Cc: 569028@bugs.debian.org

Subject: Re: [Pkg-nagios-devel] Bug#569028: nagios-plugins-standard: please move some depends to recommends

Date: Thu, 11 Mar 2010 22:46:44 +0100

[Message part 1 (text/plain, inline)]

Hi Helmut,

thanks for your bugreport.

On Tuesday, 9. February 2010, Helmut Grohne wrote:
> The nagios-plugins-standard package pulls in tons of dependencies that
> are completely useless to me. This is the depends header:

When the package was created, there was no automatically installation of 
recommands. As know, this changed over the time. Anyways ... the purpos for 
the standard package was, to provide checks which has depencies, so this 
package has indeed a amount of dependencies.
 
Under the actual conditions, we can improve the situation. Technical, it's 
easy to move the packages, which are not linked by nagios-plugins-standard, to 
Recommands. Anyways, it would be nice to give the users a plan, which plugin 
binary of the nagios-plugins-standard package depends on what package.
For this purpos I created README.Debian.plugins.

> Depends:
> 	libc6 (>= 2.3),
> Unavoidable.

ACK

> 	libldap-2.4-2 (>= 2.4.7),
> 	libmysqlclient16 (>= 5.1.21-1),
> 	libpq5 (>= 8.4~0cvs20090328),
> 	libradiusclient-ng2,
> The four above are probably not required by all setups, so they might be
> candidates for recommends. Having binaries with missing libraries is a
> bit weird, these are better kept.
> 	zlib1g (>= 1:1.1.4),
> Probably unavoidable.

These depencies are created by the ${shlibs:Depends} macro and dh_shlibdeps, 
cause the where used at link time. Indeed, this maybe can turned into 
Recommands, something similar is done by collectd, but it requires more work 
and substantial changes to the package. I'm unlikely to change this in a hurry 
short before the freeze.
Maybe some more work will follow (possible post squeeze), but patches are 
welcome anytime.

> 	fping,
> 	snmp,
> 	radiusclient1,
> 	libnet-snmp-perl,
> 	dnsutils,
> 	bind9-host | host,
> 	smbclient,
> The seven above are good candidates for recommends.

As told, I moved them to Redcommands and tried to document the dependencies in 
README.Debian.plugins. As there is no common way how the binaries are used 
(e.g. via values) within the plugins and as it is a mix of perl- and c-code, 
it's not so easy to spot them, I hopefully didn't have missed any. As always 
... improvements and fixes are welcome.

The changes[1] are medium size, the commit is r1860:

 README.Debian         |    9 ++++++++
 README.Debian.plugins |   54 
++++++++++++++++++++++++++++++++++++++++++++++++++
 changelog             |    4 ++-
 control               |    6 ++---
 docs                  |    1 
 5 files changed, 70 insertions(+), 4 deletions(-)


> 	ucf,
> Probably unavoidable.
> 	nagios-plugins-basic (>= 1.4.5-2)
> This is better kept.

ACK

With kind regards, Jan.
[1] http://svn.debian.org/wsvn/pkg-nagios/?op=comp&compare[]=%2Fnagios-
plugins@1859&compare[]=%2Fnagios-plugins@1860
-- 
Never write mail to <waja@spamfalle.info>, you have been warned!
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GIT d-- s+: a C+++ UL++++ P+ L+++ E--- W+++ N+++ o++ K++ w--- O M V- PS PE Y++
PGP++ t-- 5 X R tv- b+ DI D+ G++ e++ h---- r+++ y++++ 
------END GEEK CODE BLOCK------

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 569028-close@bugs.debian.org (full text, mbox, reply):

From: Jan Wagner <waja@cyconet.org>

To: 569028-close@bugs.debian.org

Subject: Bug#569028: fixed in nagios-plugins 1.4.15-4

Date: Wed, 18 May 2011 15:02:14 +0000

Source: nagios-plugins
Source-Version: 1.4.15-4

We believe that the bug you reported is fixed in the latest version of
nagios-plugins, which is due to be installed in the Debian FTP archive:

nagios-plugins-basic_1.4.15-4_i386.deb
  to main/n/nagios-plugins/nagios-plugins-basic_1.4.15-4_i386.deb
nagios-plugins-standard_1.4.15-4_i386.deb
  to main/n/nagios-plugins/nagios-plugins-standard_1.4.15-4_i386.deb
nagios-plugins_1.4.15-4.diff.gz
  to main/n/nagios-plugins/nagios-plugins_1.4.15-4.diff.gz
nagios-plugins_1.4.15-4.dsc
  to main/n/nagios-plugins/nagios-plugins_1.4.15-4.dsc
nagios-plugins_1.4.15-4_all.deb
  to main/n/nagios-plugins/nagios-plugins_1.4.15-4_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 569028@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jan Wagner <waja@cyconet.org> (supplier of updated nagios-plugins package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 18 May 2011 16:31:35 +0200
Source: nagios-plugins
Binary: nagios-plugins nagios-plugins-basic nagios-plugins-standard
Architecture: source all i386
Version: 1.4.15-4
Distribution: unstable
Urgency: low
Maintainer: Debian Nagios Maintainer Group <pkg-nagios-devel@lists.alioth.debian.org>
Changed-By: Jan Wagner <waja@cyconet.org>
Description: 
 nagios-plugins - Plugins for the nagios network monitoring and management system
 nagios-plugins-basic - Plugins for the nagios network monitoring and management system
 nagios-plugins-standard - Plugins for the nagios network monitoring and management system
Closes: 569028 611914 623702
Changes: 
 nagios-plugins (1.4.15-4) unstable; urgency=low
 .
   * Add 13_check_smtp_greeting.dpatch (Closes: #611914), thanks Daniel Piddock
     for spotting and Holger Weiss for providing a fix
     - Abort immediately if we don't receive a server greeting or if the
       greeting doesn't contain the "--expect"ed string (by default: "220")
       instead of blindly sending the EHLO/HELO line.
   * Add 14_check_icmp_multiple_ips.dpatch (Closes: #623702), thanks Max Kosmach
     for spotting and Sebastian Harl for providing a fix
     - When specifying a host-name on the command line, each of its IPs is added
       to the host table (and each one is pinged). So, the buffer has to be large
       enough to hold all of the respective host objects. (argc - 1) only fits
       hosts with a single IP.
   * Move libraries linked at compile time against checks of
     nagios-plugins-standard from Depends to Recommends (Closes: #569028)
     - Add slightly modified bin/gen_plugin_deps.pl from collectd source package
     - Add linked libraries via bin/gen_plugin_deps.pl into
       /usr/share/doc/nagios-plugins-standard/README.Debian.plugins
     - Build-Depend on perl
     - Create customized substvars for nagios-plugins-standard via
       dpkg-shlibdeps in debian/rules
     - Remove temporary files via clean target in debian/rules
     - Add hint to NEWS.Debian
Checksums-Sha1: 
 7621c8b7af6b8d5ac26e8dfb10256553de7bdb06 1548 nagios-plugins_1.4.15-4.dsc
 7a94ac5b4bf82db055feec3ab845e5bf524eae07 35359 nagios-plugins_1.4.15-4.diff.gz
 6784b27de1e3d6818c2d7e545bb4ae5a6979af01 21552 nagios-plugins_1.4.15-4_all.deb
 e6441ac6670a35ee51d61fa79ebe2e5666c93581 777798 nagios-plugins-basic_1.4.15-4_i386.deb
 0eca11d83b7e5500c4384e346e41f54b69832f99 378542 nagios-plugins-standard_1.4.15-4_i386.deb
Checksums-Sha256: 
 41991c4035578ae6210a30a0a59f7b9a8213913b594abdde12e03450336778bc 1548 nagios-plugins_1.4.15-4.dsc
 5098ce1517027f9a49d54dedc1ee147af8bf872eede9af6c01dde7bd221b103f 35359 nagios-plugins_1.4.15-4.diff.gz
 5dc8bb441636a8abb796ce43d9d277b90d5057a510b769d754ca904462f0a5c1 21552 nagios-plugins_1.4.15-4_all.deb
 2c54b3bdc6215135acc3118117dfee0ff38e8bbf1381e69f126ceaba50c825f7 777798 nagios-plugins-basic_1.4.15-4_i386.deb
 b39b79cd304aafc88aad8283783bb8f0595963502b1b2244a5ae7fc9b8f28b58 378542 nagios-plugins-standard_1.4.15-4_i386.deb
Files: 
 e3f3455554c8b1a8fd4ad4420480741b 1548 net extra nagios-plugins_1.4.15-4.dsc
 b6e0be4fae7c555b684e7d51a46b872b 35359 net extra nagios-plugins_1.4.15-4.diff.gz
 b5737189bd8ae1275190110601db27b5 21552 net extra nagios-plugins_1.4.15-4_all.deb
 a17da7173e9c1ac02c49beee8f437fd0 777798 net extra nagios-plugins-basic_1.4.15-4_i386.deb
 120d6a0ca20171315a49ad4e03cdc04c 378542 net extra nagios-plugins-standard_1.4.15-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFN091w9u6Dud+QFyQRAsbKAJ9o4w9dzgBNdaqJ0C9ArNO8/fU5owCg0Kkg
YcocnvtCdnAhcXEfkQB3UIE=
=HTcR
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.