Debian Bug report logs - #568591
dkms: dh_dkms postinst snippet exits on success

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Frédéric Brière <fbriere@fbriere.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dkms: dh_dkms postinst snippet exits on success

Date: Fri, 05 Feb 2010 19:55:11 -0500

Package: dkms
Version: 2.1.1.1-1
Severity: normal

The dh_dkms postinst snippet uses exit on success, which will bypass
anything else that might appear afterward.  (These files are *included*
in the final postinst, and not merely run individually.)


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.29.6 (SMP w/1 CPU core)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dkms depends on:
ii  build-essential              11.4        Informational list of build-essent
ii  dpkg-dev                     1.15.5.6    Debian package development tools
ii  gcc                          4:4.4.2-3   The GNU C compiler
ii  make                         3.81-7      An utility for Directing compilati
ii  module-init-tools            3.12~pre1-1 tools for managing Linux kernel mo

Versions of packages dkms recommends:
ii  fakeroot           1.14.4-1              Gives a fake root environment
ii  linux-headers-2.6- 2.6.32+23             Header files for Linux 2.6-686
ii  linux-headers-2.6. 2.6.29.6-10.00.Custom Header files related to Linux kern
ii  linux-headers-2.6. 2.6.31-2              Header files for Linux 2.6.31-1-68
ii  linux-headers-2.6. 2.6.32-5              Header files for Linux 2.6.32-trun
ii  linux-image-2.6.26 2.6.26.8-10.00.Custom Linux kernel binary image for vers
ii  linux-image-2.6.29 2.6.29.6-10.00.Custom Linux kernel binary image for vers
ii  lsb-release        3.2-23                Linux Standard Base version report
ii  menu               2.1.43                generates programs menu for all me
ii  patch              2.6-2                 Apply a diff file to an original
ii  sudo               1.7.2p1-1             Provide limited super user privile

dkms suggests no packages.

-- no debconf information

Message #10 received at 568591-close@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Iuculano <iuculano@debian.org>

To: 568591-close@bugs.debian.org

Subject: Bug#568591: fixed in dkms 2.1.1.1-2

Date: Sun, 14 Feb 2010 11:17:23 +0000

Source: dkms
Source-Version: 2.1.1.1-2

We believe that the bug you reported is fixed in the latest version of
dkms, which is due to be installed in the Debian FTP archive:

dkms_2.1.1.1-2.diff.gz
  to main/d/dkms/dkms_2.1.1.1-2.diff.gz
dkms_2.1.1.1-2.dsc
  to main/d/dkms/dkms_2.1.1.1-2.dsc
dkms_2.1.1.1-2_all.deb
  to main/d/dkms/dkms_2.1.1.1-2_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 568591@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Giuseppe Iuculano <iuculano@debian.org> (supplier of updated dkms package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 14 Feb 2010 12:02:42 +0100
Source: dkms
Binary: dkms
Architecture: source all
Version: 2.1.1.1-2
Distribution: unstable
Urgency: low
Maintainer: Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>
Changed-By: Giuseppe Iuculano <iuculano@debian.org>
Description: 
 dkms       - Dynamic Kernel Module Support Framework
Closes: 568580 568589 568591
Changes: 
 dkms (2.1.1.1-2) unstable; urgency=low
 .
   [ David Paleino ]
   * [d56bce9] Add -V flag to dh_dkms, thanks to Frédéric Brière
     <fbriere@fbriere.net> for the patch. (Closes: #568589)
   * [dc7e358] dh_dkms: don't return an error if there's nothing to do
     (Closes: #568580)
   * [ecfc1c7] debian/scripts/postinst-dkms: don't exit on success, only
     do it on errors (Closes: #568591)
 .
   [ Giuseppe Iuculano ]
   * [adb3042] Really remove obsolete conffiles
   * [3fe380c] Do not install /etc/header_postinst.d/dkms, at this moment
     Debian kernel doesn't support it
   * [ad6a1f2] Bump Standards-Version (no changes).
Checksums-Sha1: 
 a193d8c89b101b9c49b0a5fae41f8c5fd779816c 1264 dkms_2.1.1.1-2.dsc
 66f1eb4af49dc59d43df047351c9e646713c9ef9 12391 dkms_2.1.1.1-2.diff.gz
 cdd704efa6ae1b9a6e09f2f054e2afa000c33956 69244 dkms_2.1.1.1-2_all.deb
Checksums-Sha256: 
 f33f36ccd0d20408434cabbd43124d7fb97f7196b29335f6af0285e25f5dde89 1264 dkms_2.1.1.1-2.dsc
 ddff9abe1f97def40912e5ae7e425518983de613f9f10e7d3d6cefb8babc0879 12391 dkms_2.1.1.1-2.diff.gz
 9b8df9c40353b67b33bbe53c40c01f6ff1a019160ed4eb79bb62567a6ad0e677 69244 dkms_2.1.1.1-2_all.deb
Files: 
 c68bc72996a1b0e8abad2585983d298a 1264 kernel optional dkms_2.1.1.1-2.dsc
 a44d4ccb6c7c8bf35f6be00e8d6a2a96 12391 kernel optional dkms_2.1.1.1-2.diff.gz
 a23fe9c7ee875105765dc8575407780f 69244 kernel optional dkms_2.1.1.1-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkt32MUACgkQNxpp46476aqxfQCglv5p+n++p6dqQs9mz7JnemcR
cgoAnjKsRTH6h8kfh1bm1Hd873ThA3/i
=3peo
-----END PGP SIGNATURE-----

Message #17 received at 568591@bugs.debian.org (full text, mbox, reply):

From: Frédéric Brière <fbriere@fbriere.net>

To: 568591@bugs.debian.org

Subject: Re: Bug#568591 closed by Giuseppe Iuculano <iuculano@debian.org> (Bug#568591: fixed in dkms 2.1.1.1-2)

Date: Tue, 16 Feb 2010 20:59:29 -0500

On Sun, Feb 14, 2010 at 11:21:18AM +0000, Debian Bug Tracking System wrote:
>    * [ecfc1c7] debian/scripts/postinst-dkms: don't exit on success, only
>      do it on errors (Closes: #568591)

No dice.  On success, control will fall through the loop and hit the
error message below.

Is this error message necessary?  After all, misc:Depends should take
care of everything, no?  If you get rid of it, a simple break would be
enough.

(BTW, the if/exit is unnecessary, as postinsts are run with set -e.)

(Also, the warning message will be needlessly triggered on the first
file when using legacy support on an old dkms.  Again, does it serve a
purpose?)


-- 
* SynrG notes that the number of configuration questions to answer in sendmail
  is NON-TRIVIAL
		-- Seen on #Debian

Message #22 received at 568591@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: 568591@bugs.debian.org,control@bugs.debian.org,568591-submitter@bugs.debian.org

Subject: [cdda61c] Fix for Bug#568591 committed to git

Date: Wed, 17 Feb 2010 18:23:37 +0000

tags 568591 + pending
thanks

Hello,

     The following change has been committed for this bug by
 David Paleino <dapal@debian.org> on Wed, 17 Feb 2010 19:17:37 +0100.
 The fix will be in the next upload. 
=========================================================================
debian/scripts/postinst-dkms: really make sure the error is thrown when nothing is found. (Closes: #568591)


=========================================================================

You can check the diff of the fix at:

    http://git.debian.org/?p=collab-maint/dkms.git;a=commitdiff;h=cdda61c

Message #32 received at 568591@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: Frédéric Brière <fbriere@fbriere.net>

Cc: 568591@bugs.debian.org

Subject: Re: [Pkg-dkms-maint] Bug#568591: closed by Giuseppe Iuculano <iuculano@debian.org> (Bug#568591: fixed in dkms 2.1.1.1-2)

Date: Wed, 17 Feb 2010 19:20:58 +0100

[Message part 1 (text/plain, inline)]

On Wednesday 17 February 2010 02:59:29, Frédéric Brière wrote:
> On Sun, Feb 14, 2010 at 11:21:18AM +0000, Debian Bug Tracking System wrote:
> >    * [ecfc1c7] debian/scripts/postinst-dkms: don't exit on success, only
> >      do it on errors (Closes: #568591)
> 
> No dice.  On success, control will fall through the loop and hit the
> error message below.

Gar. I must've been in a hurry when fixing all these bugs, sorry :( (I'm not 
so cavalier usually..)

> Is this error message necessary?  After all, misc:Depends should take
> care of everything, no?  If you get rid of it, a simple break would be
> enough.

misc:Depends should take care of everything, yes, but only if the maintainer 
is using dh_dkms in a good way :)

Fixed in git.

Kindly,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|----
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 568591-close@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Iuculano <iuculano@debian.org>

To: 568591-close@bugs.debian.org

Subject: Bug#568591: fixed in dkms 2.1.1.2-1

Date: Mon, 22 Feb 2010 15:33:17 +0000

Source: dkms
Source-Version: 2.1.1.2-1

We believe that the bug you reported is fixed in the latest version of
dkms, which is due to be installed in the Debian FTP archive:

dkms_2.1.1.2-1.diff.gz
  to main/d/dkms/dkms_2.1.1.2-1.diff.gz
dkms_2.1.1.2-1.dsc
  to main/d/dkms/dkms_2.1.1.2-1.dsc
dkms_2.1.1.2-1_all.deb
  to main/d/dkms/dkms_2.1.1.2-1_all.deb
dkms_2.1.1.2.orig.tar.gz
  to main/d/dkms/dkms_2.1.1.2.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 568591@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Giuseppe Iuculano <iuculano@debian.org> (supplier of updated dkms package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 22 Feb 2010 15:34:12 +0100
Source: dkms
Binary: dkms
Architecture: source all
Version: 2.1.1.2-1
Distribution: unstable
Urgency: low
Maintainer: Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>
Changed-By: Giuseppe Iuculano <iuculano@debian.org>
Description: 
 dkms       - Dynamic Kernel Module Support Framework
Closes: 568580 568591
Changes: 
 dkms (2.1.1.2-1) unstable; urgency=low
 .
   [ David Paleino ]
   * [ff95487] dh_dkms: continue the loop if there's nothing to do on the
     current package. (Closes: #568580)
   * [73dd83f] dh_dkms: specify that version mangling only happens if
     PACKAGE_VERSION=#MODULE_VERSION# in dkms.conf
   * [cdda61c] debian/scripts/postinst-dkms: really make sure the error
     is thrown when nothing is found. (Closes: #568591)
 .
   [ Frédéric Brière ]
   * [2930aa9] Insert the package version directly into postinst at
     creation time
   * [9ccbdc7] Skip prerm removal if there are no modules for that
     version
 .
   [ Giuseppe Iuculano ]
   * [898ab8c] Imported Upstream version 2.1.1.2
   * [4fff928] Removed 01_shell_error.patch, merged in upstream
   * [c5566c7] Removed 02_header_postinst.patch to avoid delta with
     Ubuntu. Hopefully /etc/kernel/header_postinst.d directory will be
     supported in Debian soon
   * [e8aeb49] Add a comment in debian/patches/series and fix quilt-
     build-dep-but-no-series-file lintian warning
   * [bc89600] Fixed a minor spelling error in dh_dkms man page
Checksums-Sha1: 
 9726b3c1cfdea28a9f5ea1c8b7a732ef1ff4952d 1264 dkms_2.1.1.2-1.dsc
 84826053ed0f7ff51f67fcecb9bfc6dfa6f2d30e 81156 dkms_2.1.1.2.orig.tar.gz
 972fdfed8e3411257c2b7f83cc21bcc81bef2043 12311 dkms_2.1.1.2-1.diff.gz
 bbe14e3e0ffb018dff83041009bfe8e320febb03 69852 dkms_2.1.1.2-1_all.deb
Checksums-Sha256: 
 848f8a3480fe45436c995763b0b68f4ac4540fe95be84c61956f866cb5206ef6 1264 dkms_2.1.1.2-1.dsc
 382380eac258aea2ac88fdc9d089ee324af2ede705c484920219d722e45aa490 81156 dkms_2.1.1.2.orig.tar.gz
 4a24ac7372fd1d0cc4c926f311354e5bfa9e69516a04bef53ac9731df87a8603 12311 dkms_2.1.1.2-1.diff.gz
 ac1ef231b70ab4e066d7b60b50e7845184f0697f16fc507abfb0a244fd978e04 69852 dkms_2.1.1.2-1_all.deb
Files: 
 d8a9315a0812d0ea409790f075727818 1264 kernel optional dkms_2.1.1.2-1.dsc
 f8e5f1a2ac065b75c10b1fdaa2ef342f 81156 kernel optional dkms_2.1.1.2.orig.tar.gz
 21fe9eef7a1500f022752276f794fd35 12311 kernel optional dkms_2.1.1.2-1.diff.gz
 6bc1bcc90644fd68b4be0134b5cdcbc7 69852 kernel optional dkms_2.1.1.2-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkuCllwACgkQNxpp46476aofSQCfb7Y8AqiH7WNs2q1O/zwgxNyN
Q5YAnR9lktwHZteJp0XZVE/woKuQxwu8
=GVr4
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.