Debian Bug report logs - #567681
please add -a to fsck.btrfs

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sten Heinze <shze@gmx.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: btrfs-tools: fsck.btrfs dies on startup with "could not open -a"

Date: Sat, 30 Jan 2010 18:49:15 +0100

Package: btrfs-tools
Version: 0.19-8
Severity: normal

After conversion of a partition (with btrfs-convert) to btrfs and changes to 
fstab, my system boots fine with only one error message:
Could not open -a
fsck did with exit status 1.

This is caused by a call to fsck.btrfs, which does not support -a. Please add 
the -a option to fsck.btrfs.

Thanks,
Sten

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-trunk-686 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Message #16 received at 567681@bugs.debian.org (full text, mbox, reply):

From: Sten Heinze <sten.heinze@gmx.de>

To: 567681@bugs.debian.org

Subject: Bug#567681: btrfs-tools: please add -a to fsck.btrfs

Date: Mon, 8 Feb 2010 05:59:23 +0100

[Message part 1 (text/plain, inline)]

Hi,

I have attached a patch (which goes on top of 0.19-10) that makes btrfsck 
ignore all options (all parameters that are not a device to scan). While it 
might not be perfect it makes btrfsck run on boot without errors for me.

Let me know if it needs changes or improvements.

Thanks,
Sten

[08-allow-fsck-options.patch (text/x-patch, attachment)]

Message #21 received at 567681@bugs.debian.org (full text, mbox, reply):

From: Daniel Baumann <daniel@debian.org>

To: 567681-submitter@bugs.debian.org, 567681@bugs.debian.org

Subject: Re: please add -a to fsck.btrfs

Date: Tue, 09 Feb 2010 20:19:20 +0100

Hi,

could you please bring your patch to the upstream maintainers attention
on linux-btrfs@vger.kernel.org and let them comment on it?

Regards,
Daniel

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/

Message #29 received at 567681@bugs.debian.org (full text, mbox, reply):

From: Sten Heinze <sten.heinze@gmx.de>

To: linux-btrfs@vger.kernel.org

Cc: 567681@bugs.debian.org

Subject: Patch: Allow options to be passed to btrfsck

Date: Thu, 11 Feb 2010 13:59:43 +0100

This patch makes btrfsck ignore (for now) options passed to it. This makes 
btrfsck runs on startup not failing. I was asked to post my patch here by the 
Debian Maintainer of btrfs-tools.

Background: On Startup all filesystem (on a Debian system) are fsck'ed. A 
option to allow non-interactive filesystem checks on startup is passed to fsck, 
usually -a or -y. 
Currently btrfsck expects the device as the only parameter and fails if run 
with any option e.g. btrfsck -a /dev/hda1 (returns error code 1). My patch 
fixes this by allowing options to be passed, although all options are ignored 
at the moment. (The attached patch is slightly improved from the one I sent to 
the Debian bug report [1] before.)

Please comment if this is acceptable for inclusion in btrfsck. If not, I would 
be happy to improve the patch.

Thanks,
Sten

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=567681

Message #34 received at 567681@bugs.debian.org (full text, mbox, reply):

From: Sten Heinze <sten.heinze@gmx.de>

To: linux-btrfs@vger.kernel.org

Cc: 567681@bugs.debian.org

Subject: Re: Patch: Allow options to be passed to btrfsck

Date: Thu, 11 Feb 2010 14:09:39 +0100

[Message part 1 (text/plain, inline)]

[This time with the patch attached.]

[Please CC: me, as I am not subscribed to the linux-btrfs mailing list.]

This patch makes btrfsck ignore (for now) options passed to it. This makes 
btrfsck runs on startup not failing. I was asked to post my patch here by the 
Debian Maintainer of btrfs-tools.

Background: On Startup all filesystem (on a Debian system) are fsck'ed. A 
option to allow non-interactive filesystem checks on startup is passed to fsck, 
usually -a or -y.
Currently btrfsck expects the device as the only parameter and fails if run 
with any option e.g. btrfsck -a /dev/hda1 (returns error code 1). My patch 
fixes this by allowing options to be passed, although all options are ignored 
at the moment. (The attached patch is slightly improved from the one I sent to 
the Debian bug report [1] before.)

Please comment if this is acceptable for inclusion in btrfsck. If not, I would 
be happy to improve the patch.
 
Thanks,
Sten

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=567681

[08-allow-fsck-options.patch (text/x-patch, attachment)]

Message #39 received at 567681@bugs.debian.org (full text, mbox, reply):

From: Iain Buclaw <ibuclaw@ubuntu.com>

To: 567681@bugs.debian.org

Date: Sun, 14 Feb 2010 21:01:24 +0000

[Message part 1 (text/plain, inline)]

I personally think it would be better to use getopt() here.

Regards

-- 
Iain Bucław

*(p < e ? p++ : p) = (c & 0x0f) + '0';

[Message part 2 (text/html, inline)]

[btrfsck-parseopts.patch (text/x-patch, attachment)]

Message #64 received at 567681-close@bugs.debian.org (full text, mbox, reply):

From: Daniel Baumann <daniel.baumann@progress-technologies.net>

To: 567681-close@bugs.debian.org

Subject: Bug#567681: fixed in btrfs-tools 0.19+20120328-3

Date: Wed, 13 Jun 2012 15:03:34 +0000

Source: btrfs-tools
Source-Version: 0.19+20120328-3

We believe that the bug you reported is fixed in the latest version of
btrfs-tools, which is due to be installed in the Debian FTP archive:

btrfs-tools-dbg_0.19+20120328-3_i386.deb
  to main/b/btrfs-tools/btrfs-tools-dbg_0.19+20120328-3_i386.deb
btrfs-tools-udeb_0.19+20120328-3_i386.udeb
  to main/b/btrfs-tools/btrfs-tools-udeb_0.19+20120328-3_i386.udeb
btrfs-tools_0.19+20120328-3.debian.tar.gz
  to main/b/btrfs-tools/btrfs-tools_0.19+20120328-3.debian.tar.gz
btrfs-tools_0.19+20120328-3.dsc
  to main/b/btrfs-tools/btrfs-tools_0.19+20120328-3.dsc
btrfs-tools_0.19+20120328-3_i386.deb
  to main/b/btrfs-tools/btrfs-tools_0.19+20120328-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 567681@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <daniel.baumann@progress-technologies.net> (supplier of updated btrfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 13 Jun 2012 16:00:13 +0200
Source: btrfs-tools
Binary: btrfs-tools btrfs-tools-udeb btrfs-tools-dbg
Architecture: source i386
Version: 0.19+20120328-3
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <daniel.baumann@progress-technologies.net>
Changed-By: Daniel Baumann <daniel.baumann@progress-technologies.net>
Description: 
 btrfs-tools - Checksumming Copy on Write Filesystem utilities
 btrfs-tools-dbg - Checksumming Copy on Write Filesystem utilities (debug)
 btrfs-tools-udeb - Checksumming Copy on Write Filesystem utilities (udeb) (udeb)
Closes: 567681 571300 585568 612809 634658 638778 642302 653632 668832
Changes: 
 btrfs-tools (0.19+20120328-3) unstable; urgency=low
 .
   * Adding udev rule to automatically call 'btrfs scan' upon discovering
     btrfs devices in order to allow using btrfs raid devices
     automatically (Closes: #585568, #634658, #653632).
   * Adding patch to update btrfs manpage to match /sbin/btrfs (Closes:
     #638778, #642302).
   * Also including /sbin/btrfs in udeb.
   * Adding patch from Sten Heinze <shze@gmx.de> to ignore all arguments
     starting with -a in btrfsck for the time being (Closes: #567681,
     #571300, #612809, #668832).
   * Adding back symlink for fsck.btrfs.
Checksums-Sha1: 
 4efdfc048d66127949392438d0886f9f56596496 1339 btrfs-tools_0.19+20120328-3.dsc
 cf6580067f46115b1ee9159e00d0a2cdb7011d13 9043 btrfs-tools_0.19+20120328-3.debian.tar.gz
 f162921cea5af9920053c52210e9f4c2a895cd6e 1173790 btrfs-tools_0.19+20120328-3_i386.deb
 84abb003ed5c4a0b55a7b60fe5447695e79317f8 104622 btrfs-tools-udeb_0.19+20120328-3_i386.udeb
 4187c9cc7969b9c13904c120d94929fe57524f98 3836424 btrfs-tools-dbg_0.19+20120328-3_i386.deb
Checksums-Sha256: 
 90daf54742c19b83f6a832d0ea56ddddf2cd63e5730250896d5dfdf3e254c9ef 1339 btrfs-tools_0.19+20120328-3.dsc
 1881ca47b49d6e17aafd2dc54b5e908861b4aa1b2c3a9d85b7d12c5d437538af 9043 btrfs-tools_0.19+20120328-3.debian.tar.gz
 12ab6d3c468c1277a3821aa764b4820841e6543ab89341a307e286596dceb808 1173790 btrfs-tools_0.19+20120328-3_i386.deb
 1c429a90b86cdae50e058393db4224f1788b7b6227d39bda1b829ae7b2b2f000 104622 btrfs-tools-udeb_0.19+20120328-3_i386.udeb
 c7fd45963c5fb2f65f1745c2729b377a588300c944313d16f0a3200ad5c87523 3836424 btrfs-tools-dbg_0.19+20120328-3_i386.deb
Files: 
 fa56ea2f1fe66c26b0c3899e51769cb0 1339 admin optional btrfs-tools_0.19+20120328-3.dsc
 96b50748fb4dd937902c69d104d9b743 9043 admin optional btrfs-tools_0.19+20120328-3.debian.tar.gz
 c2e9c7e2c01632ebb07e3af8b452d559 1173790 admin optional btrfs-tools_0.19+20120328-3_i386.deb
 debd19bd53f1a2ea33500ee3b53b29c2 104622 debian-installer optional btrfs-tools-udeb_0.19+20120328-3_i386.udeb
 1e55f6484e287c5239d36b46d30f6ec7 3836424 debug extra btrfs-tools-dbg_0.19+20120328-3_i386.deb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk/YnZkACgkQ+C5cwEsrK54pOQCgk/yPeK8r9vvt5/W93dj5L9yv
3w4AoI4Z0xf3QYEsW9ZoqNVliv2Jn3OT
=M/i1
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.