Debian Bug report logs - #567065
avoid mount -t unknown

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: avoid mount -t unknown

Date: Tue, 26 Jan 2010 21:05:35 -0500

[Message part 1 (text/plain, inline)]

Package: initramfs-tools
Version: 0.93.4
Severity: normal
Tag: patch

Since fstype does not support btrfs (#548047),
and since udev 150, vol_id no longer exists,
get_fstype sets FSTYPE to "unknown", and
then the root filesystem is mounted using
"mount -t unknown /dev/hda2 /root". 

Of course, that fails, and with a really unhelpful error message
("mount: device doesnot exist")

Why not just skip the -t parameter if FSTYPE=unknown?
Mounting the root fs was going to fail, so letting
mount autodetect the fs type can't be worse.

Attached patch does that and got my root on btrfs working.

Workaround: boot with rootfstype=btrfs

-- Package-specific info:
-- /proc/cmdline
root=/dev/hda2 ro

-- /proc/filesystems
	btrfs
	ext3
	fuseblk

-- lsmod
Module                  Size  Used by
i915                  217023  2 
drm_kms_helper         17183  1 i915
drm                   107507  3 i915,drm_kms_helper
i2c_algo_bit            3497  1 i915
ppdev                   4058  0 
lp                      5570  0 
parport                22554  2 ppdev,lp
sco                     5837  2 
bridge                 32851  0 
stp                      996  1 bridge
bnep                    7376  2 
l2cap                  21677  3 bnep
crc16                   1027  1 l2cap
bluetooth              36259  5 sco,bnep,l2cap
acpi_cpufreq            4907  0 
cpufreq_powersave        602  0 
cpufreq_conservative     4018  0 
cpufreq_stats           1940  0 
cpufreq_userspace       1444  0 
binfmt_misc             4875  1 
uinput                  4796  1 
fuse                   43554  1 
tun                     8728  2 
sit                     6816  0 
tunnel4                 1469  1 sit
ext3                   93828  1 
jbd                    31965  1 ext3
mbcache                 3762  1 ext3
loop                    9721  0 
dm_crypt                9059  0 
joydev                  6771  0 
snd_hda_codec_realtek   162851  1 
snd_hda_intel          15263  1 
snd_hda_codec          45998  2 snd_hda_codec_realtek,snd_hda_intel
snd_hwdep               4054  1 snd_hda_codec
snd_pcm_oss            28479  0 
snd_mixer_oss          10461  1 snd_pcm_oss
snd_pcm                47350  3 snd_hda_intel,snd_hda_codec,snd_pcm_oss
snd_seq_midi            3480  0 
arc4                     974  2 
snd_rawmidi            12313  1 snd_seq_midi
ecb                     1405  2 
snd_seq_midi_event      3684  1 snd_seq_midi
snd_seq                35303  2 snd_seq_midi,snd_seq_midi_event
snd_timer              12258  2 snd_pcm,snd_seq
snd_seq_device          3673  3 snd_seq_midi,snd_rawmidi,snd_seq
iwlagn                 62199  0 
snd                    33551  13 snd_hda_codec_realtek,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_pcm_oss,snd_mixer_oss,snd_pcm,snd_rawmidi,snd_seq,snd_timer,snd_seq_device
iwlcore                67306  1 iwlagn
dell_laptop             1533  0 
i2c_i801                6442  0 
psmouse                44409  0 
mac80211              121381  2 iwlagn,iwlcore
soundcore               3450  1 snd
dcdbas                  3860  1 dell_laptop
serio_raw               2916  0 
battery                 3782  0 
jmb38x_ms               5502  0 
i2c_core               12612  4 i915,drm,i2c_algo_bit,i2c_i801
rng_core                2178  0 
pcspkr                  1207  0 
cfg80211               86910  3 iwlagn,iwlcore,mac80211
ac                      1640  0 
rfkill                 10196  4 bluetooth,dell_laptop,cfg80211
memstick                4348  1 jmb38x_ms
snd_page_alloc          4977  2 snd_hda_intel,snd_pcm
evdev                   5609  22 
processor              25803  3 acpi_cpufreq
dm_mod                 45854  1 dm_crypt
ide_gd_mod             17103  3 
ide_pci_generic         1924  0 
ata_generic             2015  0 
libata                113728  1 ata_generic
scsi_mod              101073  1 libata
uhci_hcd               15953  0 
video                  14605  1 i915
r8169                  24568  0 
ehci_hcd               27230  0 
piix                    3564  2 
output                  1204  1 video
mii                     2714  1 r8169
sdhci_pci               4493  0 
sdhci                  12079  1 sdhci_pci
intel_agp              20145  1 
agpgart                19516  2 drm,intel_agp
mmc_core               38095  1 sdhci
led_class               1757  2 iwlcore,sdhci
ide_core               63850  3 ide_gd_mod,ide_pci_generic,piix
usbcore                97930  3 uhci_hcd,ehci_hcd
button                  3598  1 i915
nls_base                4541  1 usbcore
thermal                 9206  0 
fan                     2586  0 
thermal_sys             9378  4 processor,video,thermal,fan
btrfs                 362358  1 
zlib_deflate           15822  1 btrfs
crc32c                  2172  1 
libcrc32c                730  1 btrfs

-- /etc/kernel-img.conf
# Kernel image management overrides
# See kernel-img.conf(5) for details
do_symlinks = yes
relative_links = yes
do_bootloader = no
do_bootfloppy = no
do_initrd = yes
link_in_boot = no
postinst_hook = update-grub
postrm_hook   = update-grub

-- /etc/initramfs-tools/initramfs.conf
MODULES=most
BUSYBOX=y
KEYMAP=n
BOOT=local
DEVICE=eth0
NFSROOT=auto

-- /etc/crypttab
# <target name>	<source device>		<key file>	<options>


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-trunk-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages initramfs-tools depends on:
ii  cpio                          2.10-1     GNU cpio -- a program to manage ar
ii  findutils                     4.4.2-1    utilities for finding files--find,
ii  klibc-utils                   1.5.15-1   small utilities built with klibc f
ii  module-init-tools             3.11-1     tools for managing Linux kernel mo
ii  udev                          150-2      /dev/ and hotplug management daemo

Versions of packages initramfs-tools recommends:
ii  busybox                       1:1.14.2-2 Tiny utilities for small and embed

initramfs-tools suggests no packages.

-- debconf-show failed

-- 
see shy jo

[patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 567065@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <max@stro.at>

To: Joey Hess <joeyh@debian.org>, 567065@bugs.debian.org

Subject: Re: Bug#567065: avoid mount -t unknown

Date: Wed, 27 Jan 2010 10:27:43 +0100

On Tue, Jan 26, 2010 at 09:05:35PM -0500, Joey Hess wrote:
> 
> Since fstype does not support btrfs (#548047),
> and since udev 150, vol_id no longer exists,
> get_fstype sets FSTYPE to "unknown", and
> then the root filesystem is mounted using
> "mount -t unknown /dev/hda2 /root". 
> 
> Of course, that fails, and with a really unhelpful error message
> ("mount: device doesnot exist")
> 
> Why not just skip the -t parameter if FSTYPE=unknown?
> Mounting the root fs was going to fail, so letting
> mount autodetect the fs type can't be worse.
> 
> Attached patch does that and got my root on btrfs working.

right that sounds good, will merge soon.

also it should no longer use the gone udev vol_id,
but blkid, haven't come around to see it's invocation pattern,
that should fix it also.
 
> Workaround: boot with rootfstype=btrfs
> 

> --- scripts/local.orig	2010-01-26 20:58:30.298669269 -0500
> +++ scripts/local	2010-01-26 20:59:28.974718882 -0500
> @@ -127,7 +127,11 @@
>  
>  	# FIXME This has no error checking
>  	# Mount root
> -	mount ${roflag} -t ${FSTYPE} ${ROOTFLAGS} ${ROOT} ${rootmnt}
> +	if [ "${FSTYPE}" != "unknown" ]; then
> +		mount ${roflag} -t ${FSTYPE} ${ROOTFLAGS} ${ROOT} ${rootmnt}
> +	else
> +		mount ${roflag} ${ROOTFLAGS} ${ROOT} ${rootmnt}
> +	fi
>  
>  	[ "$quiet" != "y" ] && log_begin_msg "Running /scripts/local-bottom"
>  	run_scripts /scripts/local-bottom

Message #15 received at 567065@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: maximilian attems <max@stro.at>

Cc: 567065@bugs.debian.org

Subject: Re: Bug#567065: avoid mount -t unknown

Date: Wed, 27 Jan 2010 11:31:25 -0500

[Message part 1 (text/plain, inline)]

maximilian attems wrote:
> right that sounds good, will merge soon.

Thanks.

> also it should no longer use the gone udev vol_id,
> but blkid, haven't come around to see it's invocation pattern,
> that should fix it also.

If you have blkid on the initramfs, you can use:

FSTYPE=$(blkid -o value -s TYPE $ROOT)

(It will exit nonzero if it cannot determine the type.)

I was thinking about trying to add btrfs magic to fstype, but if you
plan to switch to blkid, I will avoid spending time on it.

-- 
see shy jo

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 567065@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <max@stro.at>

To: Joey Hess <joeyh@debian.org>, 567065@bugs.debian.org

Subject: Re: Bug#567065: avoid mount -t unknown

Date: Sat, 30 Jan 2010 20:00:04 +0100

On Wed, 27 Jan 2010, Joey Hess wrote:

> maximilian attems wrote:
> > right that sounds good, will merge soon.
> 
> Thanks.

applied, pushing out on repo as soon as back on net.. :)
 
> > also it should no longer use the gone udev vol_id,
> > but blkid, haven't come around to see it's invocation pattern,
> > that should fix it also.
> 
> If you have blkid on the initramfs, you can use:
> 
> FSTYPE=$(blkid -o value -s TYPE $ROOT)
> 
> (It will exit nonzero if it cannot determine the type.)

ok thanks for the hint!
commited.
 
> I was thinking about trying to add btrfs magic to fstype, but if you
> plan to switch to blkid, I will avoid spending time on it.

yes blkid should be fallback for squeeze
(as vol_id was for lenny) and then take over for squeeze+1

Message #27 received at 567065-close@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@debian.org>

To: 567065-close@bugs.debian.org

Subject: Bug#567065: fixed in initramfs-tools 0.94

Date: Mon, 05 Apr 2010 22:12:54 +0000

Source: initramfs-tools
Source-Version: 0.94

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.94.dsc
  to main/i/initramfs-tools/initramfs-tools_0.94.dsc
initramfs-tools_0.94.tar.gz
  to main/i/initramfs-tools/initramfs-tools_0.94.tar.gz
initramfs-tools_0.94_all.deb
  to main/i/initramfs-tools/initramfs-tools_0.94_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 567065@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
maximilian attems <maks@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 05 Apr 2010 05:25:48 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.94
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: maximilian attems <maks@debian.org>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 415474 433708 465760 487409 506533 519800 523735 524534 525606 533903 534201 535008 536195 541864 543568 545728 547365 548711 554873 559535 559619 560266 561289 562561 565386 565416 567065 567189 568527 569033 570678 572858 573761 574553 575154 575157 576429
Changes: 
 initramfs-tools (0.94) unstable; urgency=low
 .
   * The "Litte Bang" release
 .
   [ maximilian attems ]
   * Nuke kernelextras hooks.
   * Create a klibc hook script.
   * Redefinde MODULES=most to not carry any fb driver per default.
   * Nuke framebuffer boot script.
   * Revert "hook-functions: Add hid_* modules."
   * Move busybox addition to a hook script.
   * mkinitramfs fix comment.
   * hook-functions: Fix mounted /sys check for openvz container.
   * initramfs-tools.8: fix boot example script to execute.
     scripts/functions. (closes: #545728)
   * Fix out-of-date-standards-version.
   * /etc/kernel hook script support for make deb-pkg generated linux-images
     and kernel-package. (closes: #523735, #561289)
   * update-initramfs: allow -t takeover on delete.
   * /etc/kernel/postrm.d/i-t: use now takeover on delete.
     (closes: #524534, #547365, #559619)
   * Nuke useless unused dir.
   * kernel hook scripts: Fix typo, add comments.
   * hook-funcitions: Only warn about missing firmware if /proc/modules
     exists. (closes: #560266, #575154)
   * mkinitramfs: Be opportunistic when calling modprobe thus showing
     errors. (closes: #554873)
   * copy_exec: Check if ldd is around.
   * scripts/local: Use blkid as backup fstype detection. (closes: #568527)
   * mkinitramfs: only copy modprobe conf files. (closes: #506533)
   * blacklist earlier at init-top stage.
   * scripts/local: fix blkid invocation.
   * init: export and unset BOOTIF.
   * init: rexport resume to reallow it's hardcoded usage. (closes: #572858)
   * update-initramfs: -d delete .bak file. (closes: #559535)
   * control: bump standards version without changes.
   * control: Clean up Uploaders field.
   * switch from cdbs to debhelper 7.
   * update-initramfs: Stop second guessing lilo usage. (closes: #574553)
   * mkinitramfs: allow to build initramfs for unmodular linux images.
     (closes: #415474, #433708)
   * initramfs.conf.5: document UMASK variable for sensitive initramfs.
     (closes: #536195)
   * update-initramfs: only run elilo if configured. (closes: #534201)
   * update-initramfs: fix previous elilo commit.
   * MODULES=DEP Use driver/module syfs attribute. (closes: #567189)
   * panic: quote variable.
   * MODULES=DEP: Check rootfs on mkinitramfs. (closes: #519800)
   * Use ata_generic driver on all_generic_ide bootarg
   * scripts/functions: add get_fstype() from scripts/local. (closes: #487409)
   * mkinitramfs.8: update date.
   * Keep acpi modules in initramfs so that udev can load them early.
   * mkinitramfs: no longer copy depmod.
   * init: Silence "Loading essential drivers..." on quiet boot.
   * hook-functions: Add btrfs to base modules.
   * init: export BOOT for casper and friends.
   * hooks/klibc: Keep gzip in initramfs.
   * modernize docs to todays standards.
   * examples: shipp old framebuffer boot script.
   * initramfs.conf.5, update-initramfs.conf.5: Add FILES section.
     (closes: #565386)
   * mkinitramfs: be silent if no modules.map was generated in first place.
   * debian/control: Add a breaks cryptsetup.
 .
   [ Tormod Volden ]
   * blacklist boot hook write to /etc/modprobe.d/initramfs.conf.
     (closes: #541864)
 .
   [ Michael Prokop ]
   * Fix path to nfsroot.txt in documentation.
   * hook-functions: Avoid firmware copy error. (closes: #570678)
 .
   [ Joey Hess ]
   * scripts/local: avoid mount -t unknown. (closes: #567065)
 .
   [ Avi Rozen ]
   * mkinitramfs: add all usb storage devices. (closes: #543568)
 .
   [ Ferenc Wagner ]
   * initramfs-tools: make the panic argument available in the rescue
     shell. (closes: #569033)
 .
   [ Maximilian Gass ]
   * mkinitramfs: KEYMAP option fails to work due to missing keymap.
     (closes: #565416)
 .
   [ Vagrant Cascadian ]
   * configure_networking: support BOOTIF variable set by pxelinux.
     (closes: #535008)
 .
   [ Ben Hutchings ]
   * copy_modules_dir: Take a list of exclusions after the base directory.
   * auto_add_modules: Copy all modules from net, excluding some
     subdirectories.
 .
   [ Scott James Remnant ]
   * init: Mount devtmpfs on /dev.
   * mkinitramfs: Call depmod before packing the initramfs.
     (closes: #465760, #562561)
   * init: load the netconsole module with netconsole bootarg
   * init: mount /dev/pts as well as /dev.
 .
   [ Ben Collins ]
   * update-initramfs: Default to not keep .bak backups.
 .
   [ Piotr Lewandowski ]
   * update-initramfs breaks if /etc/mtab is a symlink to /proc/mounts.
     (closes: #525606)
 .
   [ Martin Michlmayr ]
   * MODULES=dep fix boot with MMC. (closes: #548711)
 .
   [ Nikolaus Schulz ]
   * hook-functions: let dep_add_modules() recurse into lvm slave devices.
     (closes: 573761)
 .
   [ Anna Jonna Armannsdottir ]
   * configure_networking: Try repeatedly ipconfig with increasing
     timeout.
 .
   [ Colin Watson ]
   * mkinitramfs: Filter out looping or broken symlinks from the
     initramfs. (closes: #575157)
   * mkinitramfs: set initramfs root to 755.
 .
   [ Bert Schulze ]
   * initramfs-tools: support different compression tools in mkinitramfs.
     (closes: #533903)
   * mkinitramfs: -c compression support / commandline override.
     (closes: #576429)
Checksums-Sha1: 
 5afd5d57aa19a5c0209eaecc9b1b1f9465753318 922 initramfs-tools_0.94.dsc
 509fb16736997ecba36f641127ceab5bea18f68d 71586 initramfs-tools_0.94.tar.gz
 02aca8c6e29acf625100c1551faf1dbc5b4a17d0 78974 initramfs-tools_0.94_all.deb
Checksums-Sha256: 
 aee9a553dd3844532c464d9f649cbff02928568d037415dc8126bb6591e2b817 922 initramfs-tools_0.94.dsc
 25580b8f761e154cfa4efe6d4657b69b8a6403f7097dcfe2d50c2e64cc6f4e9b 71586 initramfs-tools_0.94.tar.gz
 a8abc65bdbf74bedb0bb77a8079d34b0b0ef8b41adde923e4748a673af770f3c 78974 initramfs-tools_0.94_all.deb
Files: 
 c1dbcaa6efb98082c45257309ba20312 922 utils optional initramfs-tools_0.94.dsc
 0295a063638ef0e44a38ef9fa3d7f93f 71586 utils optional initramfs-tools_0.94.tar.gz
 c66b55ac5c3d7e19cb57057489defa1d 78974 utils optional initramfs-tools_0.94_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAku6RlIACgkQeW7Lc5tEHqh9MgCaAwfEx8qpBHws+lusrsXjVDTP
OTMAmwU4vowqNyQHgtoTdNywtdHts2q5
=MCMB
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.