Debian Bug report logs - #566795
python-launchpadlib: Always depend on python-simplejson

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <martin.pitt@ubuntu.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: python-launchpadlib: Always depend on python-simplejson

Date: Mon, 25 Jan 2010 09:13:50 +0100

[Message part 1 (text/plain, inline)]

Package: python-launchpadlib
Version: 1.5.4-1
Severity: important
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu lucid ubuntu-patch

https://launchpad.net/bugs/510129 reports that installing
python-launchpadlib does not automatically pull in python-simplejson,
although it is a required dependency. This causes consumers of
p-launchpadlib to crash with

  ImportError: No module named simplejson

Please apply the patch that we did in Ubuntu:

  * debian/control: Always depend on python-simplejson, drop the alternative
    "python2.6" dependency. While python2.6 also ships a json module, it has
    at least a different module name, and possibly even a different API.
    (LP: #510129)

Thank you for considering!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[python-launchpadlib.simplejson-depends.debdiff (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #12 received at 566795@bugs.debian.org (full text, mbox, reply):

From: Piotr Ożarowski <piotr@debian.org>

To: 566795@bugs.debian.org

Subject: Re: [Python-modules-team] Bug#566795: python-launchpadlib: Always depend on python-simplejson

Date: Mon, 1 Feb 2010 19:05:54 +0100

[Martin Pitt, 2010-01-25]
>   * debian/control: Always depend on python-simplejson, drop the alternative
>     "python2.6" dependency. While python2.6 also ships a json module, it has
>     at least a different module name, and possibly even a different API.
>     (LP: #510129)

how about patching launchpadlib instead to use something like:

  try:
      import json
  except ImportError:
      import simplejson as json

(and use json instead of simplejson later).
json module from stdlib is actually (a little bit cleaned) simplejson

From what I've seen in the sources it should be ok.

PS note that simplejson will have to be removed from install_requires in
setup.py (and thus from require.txt
-- 
Piotr Ożarowski                         Debian GNU/Linux Developer
www.ozarowski.pl          www.griffith.cc           www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645

Message #17 received at 566795-close@bugs.debian.org (full text, mbox, reply):

From: Luca Falavigna <dktrkranz@debian.org>

To: 566795-close@bugs.debian.org

Subject: Bug#566795: fixed in python-launchpadlib 1.5.4-2

Date: Sat, 13 Feb 2010 13:32:12 +0000

Source: python-launchpadlib
Source-Version: 1.5.4-2

We believe that the bug you reported is fixed in the latest version of
python-launchpadlib, which is due to be installed in the Debian FTP archive:

python-launchpadlib_1.5.4-2.diff.gz
  to main/p/python-launchpadlib/python-launchpadlib_1.5.4-2.diff.gz
python-launchpadlib_1.5.4-2.dsc
  to main/p/python-launchpadlib/python-launchpadlib_1.5.4-2.dsc
python-launchpadlib_1.5.4-2_all.deb
  to main/p/python-launchpadlib/python-launchpadlib_1.5.4-2_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 566795@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luca Falavigna <dktrkranz@debian.org> (supplier of updated python-launchpadlib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 13 Feb 2010 14:12:53 +0100
Source: python-launchpadlib
Binary: python-launchpadlib
Architecture: source all
Version: 1.5.4-2
Distribution: unstable
Urgency: low
Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
Changed-By: Luca Falavigna <dktrkranz@debian.org>
Description: 
 python-launchpadlib - Launchpad web services client library
Closes: 566795
Changes: 
 python-launchpadlib (1.5.4-2) unstable; urgency=low
 .
   * Always depend on python-simplejson, drop the alternative python2.6
     dependency, as launchpadlib explicitly needs simplejson, not json
     provided by python2.6, thanks Martin Pitt! (Closes: #566795).
   * Bump Standards-Version to 3.8.4, no changes required.
Checksums-Sha1: 
 78a0016e0f240f3997bdeab8aab5d9e742e12a4a 1462 python-launchpadlib_1.5.4-2.dsc
 6d11170a57e47eb996b6de18a94dbcb8e00b2b08 3232 python-launchpadlib_1.5.4-2.diff.gz
 76966cf1f17059725eaca2fe2a54e32a6ced84de 44104 python-launchpadlib_1.5.4-2_all.deb
Checksums-Sha256: 
 2938edbb511387c0905f239d725db6291dacf5b1fed71e741f1cfc8d40c1290a 1462 python-launchpadlib_1.5.4-2.dsc
 a64f88da8d0ab470c293c4c8a732c6f38d2ef1cc8ec5d77810555a0619ba7aae 3232 python-launchpadlib_1.5.4-2.diff.gz
 cb184d060e90b35d8c0cb931de4a40365b63c14bbce40d8bef19e971226d1c69 44104 python-launchpadlib_1.5.4-2_all.deb
Files: 
 adbd5217b0c544081724827a86fa48f3 1462 python optional python-launchpadlib_1.5.4-2.dsc
 51cd19abe34f7b7e633e0405367390a8 3232 python optional python-launchpadlib_1.5.4-2.diff.gz
 03e55a24ee0625c8a9624838d5198a2e 44104 python optional python-launchpadlib_1.5.4-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkt2pogACgkQnXjXEYa8KlBLvwCgmuNh6rtmWFjZQi7qHeWNgKgo
/00An3D3q1gl2MsdzDMVmQfZRMFDocZh
=6TWN
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.