Debian Bug report logs - #565788
Upgrading SDL breaks Wesnoth

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Mark de Wever <koraq@xs4all.nl>

To: submit@bugs.debian.org

Subject: Upgrading SDL breaks Wesnoth

Date: Mon, 18 Jan 2010 21:38:32 +0100

Package: libsdl1.2debian-all
Version: 1.2.14-3
Severity: critical
Tags: upstream

Upgrading libsdl from 1.2.13-5 to 1.2.14-3 breaks Wesnoth. I tested with
both Wesnoth 1.6.5-1 and a recent upstream Wesnoth trunk revision.
Somebody did some more testing [1] and the problem seems to depend on
the WM (I use fvwm). We also have a conversation with Sam Lantinga on
our mailinglist [2][3][4].

The problem is that after the upgrade the buttons in the user interface
no longer work. Clicking with the mouse on a button in the main menu
does nothing at all, rendering Wesnoth completely unusable. I did some
testing and it seems the widgets only receive a mouse button up event
and no mouse button down event. The Wesnoth engine expects both events
before registering a click on the widget.

I haven't tested other applications that use SDL, but I can do that if
you want me to.

[1] https://gna.org/bugs/index.php?14770#comment6
[2] https://mail.gna.org/public/wesnoth-dev/2009-11/msg00002.html
[3] https://mail.gna.org/public/wesnoth-dev/2009-12/msg00006.html
[4] https://mail.gna.org/public/wesnoth-dev/2010-01/msg00001.html

-- 
Regards,
Mark de Wever
(Wesnoth developer)

Message #12 received at 565788@bugs.debian.org (full text, mbox, reply):

From: Micheas Herman <m@micheas.net>

To: 565788@bugs.debian.org

Subject: Upgrading SDL breaks Wesnoth

Date: Mon, 01 Mar 2010 13:52:53 -0800

Einstein does not close either.

A side not about wesnoth, if you hold down the right mouse button and
click the left mouse button a left click is registered, and vice versa.

With a little experimentation the games are usually playable, but in a
broken manner. (The degree of breakage varies, but the quit button
normally cannot close the game.)

Strangely, I can get a game to close when clicking on the quit button a
small random percentage of the time, but I cannot be sure that I am not
triggering a crash as a side effect of an unrelated bug. 

This is all on amd64.



-- 
All generalizations are false, including this one.
		-- Mark Twain

Message #19 received at 565788@bugs.debian.org (full text, mbox, reply):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>

To: Mark de Wever <koraq@xs4all.nl>, 565788@bugs.debian.org

Cc: Micheas Herman <m@micheas.net>

Subject: Re: Bug#565788: Upgrading SDL breaks Wesnoth

Date: Tue, 06 Apr 2010 21:19:11 +0100

[Message part 1 (text/plain, inline)]

tag 565788 + patch
thanks

Hi,

On Mon, 2010-01-18 at 21:38 +0100, Mark de Wever wrote:
> Upgrading libsdl from 1.2.13-5 to 1.2.14-3 breaks Wesnoth. I tested with
> both Wesnoth 1.6.5-1 and a recent upstream Wesnoth trunk revision.
> Somebody did some more testing [1] and the problem seems to depend on
> the WM (I use fvwm). We also have a conversation with Sam Lantinga on
> our mailinglist [2][3][4].
> 
> The problem is that after the upgrade the buttons in the user interface
> no longer work. Clicking with the mouse on a button in the main menu
> does nothing at all, rendering Wesnoth completely unusable.

I've replicated this issue using fvwm on amd64 and have found the cause.

After importing the svn repository in to git and "git bisect"ing, the
problem appears to be due to the first hunk of upstream r4872 (fixing
their #716); the attached diff makes the mouse work as expected in my
testing.

I've uploaded pre-built amd64 binaries to
http://people.debian.org/~adsb/libsdl1.2/ if they're any use in
confirming the fix.

Regards,

Adam

[libsdl1.2-1.2.14-4.1.diff (text/x-patch, inline)]

diff -u libsdl1.2-1.2.14/debian/changelog libsdl1.2-1.2.14/debian/changelog
--- libsdl1.2-1.2.14/debian/changelog
+++ libsdl1.2-1.2.14/debian/changelog
@@ -1,3 +1,12 @@
+libsdl1.2 (1.2.14-4.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Add 310_fixmouseclicks.diff to fix problems with left-mouse clicks
+    not working in Wesnoth in windowed mode.  Partially reverts the fix
+    for upstream bug #716 (r4872).  (Closes: #565788).
+
+ -- Adam D. Barratt <adam@adam-barratt.org.uk>  Tue, 06 Apr 2010 19:31:12 +0100
+
 libsdl1.2 (1.2.14-4) unstable; urgency=low
 
   * Move -dev Recommends back to Depends, as other packages may want to 
diff -u libsdl1.2-1.2.14/debian/patches/series libsdl1.2-1.2.14/debian/patches/series
--- libsdl1.2-1.2.14/debian/patches/series
+++ libsdl1.2-1.2.14/debian/patches/series
@@ -17,0 +18 @@
+310_fixmouseclicks
only in patch2:
unchanged:
--- libsdl1.2-1.2.14.orig/debian/patches/310_fixmouseclicks
+++ libsdl1.2-1.2.14/debian/patches/310_fixmouseclicks
@@ -0,0 +1,25 @@
+Index: libsdl1.2-1.2.14/src/video/x11/SDL_x11events.c
+===================================================================
+--- libsdl1.2-1.2.14.orig/src/video/x11/SDL_x11events.c	2010-04-06 19:29:05.000000000 +0100
++++ libsdl1.2-1.2.14/src/video/x11/SDL_x11events.c	2010-04-06 19:29:46.000000000 +0100
+@@ -423,12 +423,15 @@
+ if ( xevent.xcrossing.mode == NotifyUngrab )
+ printf("Mode: NotifyUngrab\n");
+ #endif
+-		if ( this->input_grab == SDL_GRAB_OFF ) {
+-			posted = SDL_PrivateAppActive(1, SDL_APPMOUSEFOCUS);
++		if ( (xevent.xcrossing.mode != NotifyGrab) &&
++		     (xevent.xcrossing.mode != NotifyUngrab) ) {
++			if ( this->input_grab == SDL_GRAB_OFF ) {
++				posted = SDL_PrivateAppActive(1, SDL_APPMOUSEFOCUS);
++			}
++			posted = SDL_PrivateMouseMotion(0, 0,
++					xevent.xcrossing.x,
++					xevent.xcrossing.y);
+ 		}
+-		posted = SDL_PrivateMouseMotion(0, 0,
+-				xevent.xcrossing.x,
+-				xevent.xcrossing.y);
+ 	    }
+ 	    break;
+ 

Message #26 received at 565788@bugs.debian.org (full text, mbox, reply):

From: Mark de Wever <koraq@xs4all.nl>

To: "Adam D. Barratt" <adam@adam-barratt.org.uk>

Cc: 565788@bugs.debian.org, Micheas Herman <m@micheas.net>, Gerfried Fuchs <rhonda@deb.at>

Subject: Re: Bug#565788: Upgrading SDL breaks Wesnoth

Date: Thu, 8 Apr 2010 20:15:34 +0200

On Tue, Apr 06, 2010 at 09:19:11PM +0100, Adam D. Barratt wrote:
> On Mon, 2010-01-18 at 21:38 +0100, Mark de Wever wrote:
> > Upgrading libsdl from 1.2.13-5 to 1.2.14-3 breaks Wesnoth. I tested with
> > both Wesnoth 1.6.5-1 and a recent upstream Wesnoth trunk revision.
> > Somebody did some more testing [1] and the problem seems to depend on
> > the WM (I use fvwm). We also have a conversation with Sam Lantinga on
> > our mailinglist [2][3][4].
> > 
> > The problem is that after the upgrade the buttons in the user interface
> > no longer work. Clicking with the mouse on a button in the main menu
> > does nothing at all, rendering Wesnoth completely unusable.
> 
> I've replicated this issue using fvwm on amd64 and have found the cause.
> 
> After importing the svn repository in to git and "git bisect"ing, the
> problem appears to be due to the first hunk of upstream r4872 (fixing
> their #716); the attached diff makes the mouse work as expected in my
> testing.

Thanks for your effort in investigating and fixing this bug. I build a
package with your patch on my system (i386 architecture). After
installing the package the mouse buttons in Wesnoth work again as
expected, so your patch fixes the issue for me.

-- 
Regards,
Mark de Wever
(Wesnoth developer)

Message #31 received at 565788@bugs.debian.org (full text, mbox, reply):

From: Barry deFreese <bdefreese@verizon.net>

To: Mark de Wever <koraq@xs4all.nl>, 565788@bugs.debian.org

Cc: "Adam D. Barratt" <adam@adam-barratt.org.uk>, Micheas Herman <m@micheas.net>, Gerfried Fuchs <rhonda@deb.at>

Subject: Re: Bug#565788: Upgrading SDL breaks Wesnoth

Date: Thu, 08 Apr 2010 15:57:33 -0400

On 4/8/2010 2:15 PM, Mark de Wever wrote:
> On Tue, Apr 06, 2010 at 09:19:11PM +0100, Adam D. Barratt wrote:
>> On Mon, 2010-01-18 at 21:38 +0100, Mark de Wever wrote:
>>> Upgrading libsdl from 1.2.13-5 to 1.2.14-3 breaks Wesnoth. I tested with
>>> both Wesnoth 1.6.5-1 and a recent upstream Wesnoth trunk revision.
>>> Somebody did some more testing [1] and the problem seems to depend on
>>> the WM (I use fvwm). We also have a conversation with Sam Lantinga on
>>> our mailinglist [2][3][4].
>>>
>>> The problem is that after the upgrade the buttons in the user interface
>>> no longer work. Clicking with the mouse on a button in the main menu
>>> does nothing at all, rendering Wesnoth completely unusable.
>>
>> I've replicated this issue using fvwm on amd64 and have found the cause.
>>
>> After importing the svn repository in to git and "git bisect"ing, the
>> problem appears to be due to the first hunk of upstream r4872 (fixing
>> their #716); the attached diff makes the mouse work as expected in my
>> testing.
> 
> Thanks for your effort in investigating and fixing this bug. I build a
> package with your patch on my system (i386 architecture). After
> installing the package the mouse buttons in Wesnoth work again as
> expected, so your patch fixes the issue for me.
> 

My apologies that I haven't been keeping up with SDL lately, real life is killing me.  I will see if
I can get this tested also, and then updated.

Thanks!

Barry deFreese

Message #38 received at 565788-close@bugs.debian.org (full text, mbox, reply):

From: Barry deFreese <bdefreese@debian.org>

To: 565788-close@bugs.debian.org

Subject: Bug#565788: fixed in libsdl1.2 1.2.14-5

Date: Sat, 17 Apr 2010 01:18:59 +0000

Source: libsdl1.2
Source-Version: 1.2.14-5

We believe that the bug you reported is fixed in the latest version of
libsdl1.2, which is due to be installed in the Debian FTP archive:

libsdl1.2-dev_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2-dev_1.2.14-5_i386.deb
libsdl1.2_1.2.14-5.diff.gz
  to main/libs/libsdl1.2/libsdl1.2_1.2.14-5.diff.gz
libsdl1.2_1.2.14-5.dsc
  to main/libs/libsdl1.2/libsdl1.2_1.2.14-5.dsc
libsdl1.2debian-all_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2debian-all_1.2.14-5_i386.deb
libsdl1.2debian-alsa_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2debian-alsa_1.2.14-5_i386.deb
libsdl1.2debian-arts_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2debian-arts_1.2.14-5_i386.deb
libsdl1.2debian-esd_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2debian-esd_1.2.14-5_i386.deb
libsdl1.2debian-nas_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2debian-nas_1.2.14-5_i386.deb
libsdl1.2debian-oss_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2debian-oss_1.2.14-5_i386.deb
libsdl1.2debian-pulseaudio_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2debian-pulseaudio_1.2.14-5_i386.deb
libsdl1.2debian-udeb_1.2.14-5_i386.udeb
  to main/libs/libsdl1.2/libsdl1.2debian-udeb_1.2.14-5_i386.udeb
libsdl1.2debian_1.2.14-5_i386.deb
  to main/libs/libsdl1.2/libsdl1.2debian_1.2.14-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 565788@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Barry deFreese <bdefreese@debian.org> (supplier of updated libsdl1.2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 16 Apr 2010 09:26:29 -0400
Source: libsdl1.2
Binary: libsdl1.2debian libsdl1.2debian-all libsdl1.2debian-alsa libsdl1.2debian-oss libsdl1.2debian-esd libsdl1.2debian-arts libsdl1.2debian-nas libsdl1.2debian-pulseaudio libsdl1.2debian-udeb libsdl1.2-dev
Architecture: source i386
Version: 1.2.14-5
Distribution: unstable
Urgency: low
Maintainer: Debian SDL packages maintainers <pkg-sdl-maintainers@lists.alioth.debian.org>
Changed-By: Barry deFreese <bdefreese@debian.org>
Description: 
 libsdl1.2-dev - Simple DirectMedia Layer development files
 libsdl1.2debian - Simple DirectMedia Layer
 libsdl1.2debian-all - Simple DirectMedia Layer (with all available options)
 libsdl1.2debian-alsa - Simple DirectMedia Layer (with X11 and ALSA options)
 libsdl1.2debian-arts - Simple DirectMedia Layer (with X11 and aRts options)
 libsdl1.2debian-esd - Simple DirectMedia Layer (with X11 and esound options)
 libsdl1.2debian-nas - Simple DirectMedia Layer (with X11 and NAS options)
 libsdl1.2debian-oss - Simple DirectMedia Layer (with X11 and OSS options)
 libsdl1.2debian-pulseaudio - Simple DirectMedia Layer (with X11 and PulseAudio options)
 libsdl1.2debian-udeb - Simple DirectMedia Layer (with directfb graphics and no sound) (udeb)
Closes: 565788
Changes: 
 libsdl1.2 (1.2.14-5) unstable; urgency=low
 .
   * Add 310_fixmouseclicks.diff to fix problems with left-mouse clicks
       not working in Wesnoth in windowed mode.  Partially reverts the fix
       for upstream bug #716 (r4872).  (Closes: #565788).
       Thanks to Adam D. Barratt for the fix.
Checksums-Sha1: 
 674f003e7dc37db0c43cc30610fd700dc5a28c4f 1985 libsdl1.2_1.2.14-5.dsc
 7266293c72e17b82a4d9ad6b92edd457539895ff 324208 libsdl1.2_1.2.14-5.diff.gz
 51417371ce5d821af8368a50253da1e8c8520d5d 20718 libsdl1.2debian_1.2.14-5_i386.deb
 ca0e1a96cbfa51a4053955d4dee33d4063b184df 218942 libsdl1.2debian-all_1.2.14-5_i386.deb
 2b4a1bb1efc2d1319eb2ef73eb7c534ae7a60c74 207512 libsdl1.2debian-alsa_1.2.14-5_i386.deb
 72bed9b2de13499e322d63585b378608a31b6781 207786 libsdl1.2debian-oss_1.2.14-5_i386.deb
 c9e0e2114b899044ebe65b1b71849a41db21ddb2 205906 libsdl1.2debian-esd_1.2.14-5_i386.deb
 5546e28bc1b07887fbca7658ca930c2c6cff8475 205922 libsdl1.2debian-arts_1.2.14-5_i386.deb
 e374527b6964ce33bfae0fabc1a3d81dad7e1a1f 206258 libsdl1.2debian-nas_1.2.14-5_i386.deb
 991db534f4c76b87f60c5fa36d0d4b13bde9d2c2 206738 libsdl1.2debian-pulseaudio_1.2.14-5_i386.deb
 836919273a0f5896e28451a0ff8ec81e728c1ad5 111932 libsdl1.2debian-udeb_1.2.14-5_i386.udeb
 1eb1cda686cdeaafa9d714f9158f8e83ed73666b 851144 libsdl1.2-dev_1.2.14-5_i386.deb
Checksums-Sha256: 
 18aebba6e589f657a437908d011d3179c14baf47b79c07cd55c570cee64c71a2 1985 libsdl1.2_1.2.14-5.dsc
 f9326f349d8637ceb6e0e1c73a029927c8f22efea8cb56422096c37ac4780171 324208 libsdl1.2_1.2.14-5.diff.gz
 95c213dc1387c123e9065712cdc9565af72f20392b2c4a339c25511ff53d3bf0 20718 libsdl1.2debian_1.2.14-5_i386.deb
 c751a679d8a89ad438ad0f50db638ec479bbe853eebeb879ec3cbd9c84293e90 218942 libsdl1.2debian-all_1.2.14-5_i386.deb
 e6987d704c04bd5630c5114909377b66bf2c550feb01d2b0c5fc89d6d13ecadf 207512 libsdl1.2debian-alsa_1.2.14-5_i386.deb
 440576dbc112f0a9f94a969ced2954339f644ab9a5ec91bfe507a77cc47c8160 207786 libsdl1.2debian-oss_1.2.14-5_i386.deb
 b0b6232d5c88e974aba2a070406c3b768fdf2c3b56fef43e9a665cfc2793bc79 205906 libsdl1.2debian-esd_1.2.14-5_i386.deb
 bea0c4f0206a4f8abf1732263e6852aa4301d06641409eb7889289b02028f725 205922 libsdl1.2debian-arts_1.2.14-5_i386.deb
 d20be884a380f003d4d0003ef65d9d7ae5bf20e6ef7f4d11acebd6ce94976b56 206258 libsdl1.2debian-nas_1.2.14-5_i386.deb
 13dd6cbd7e49c276059c3f6bd5d9283762edc4de9519d405a910dedfd48221ac 206738 libsdl1.2debian-pulseaudio_1.2.14-5_i386.deb
 69068a66fe8662e6ad9f8e450bd71424a2583983efbe610041e1384c2715d380 111932 libsdl1.2debian-udeb_1.2.14-5_i386.udeb
 c8265f04539784049c856da0a05571a369efc80515ff1de3ea4e52a165a98869 851144 libsdl1.2-dev_1.2.14-5_i386.deb
Files: 
 8ec318820aff1e474a6907b0c7b1bf5f 1985 libs optional libsdl1.2_1.2.14-5.dsc
 acff6b3caf0cfa3e30a6370eca63c696 324208 libs optional libsdl1.2_1.2.14-5.diff.gz
 d57069ed9397cc9697b8f775b7319b61 20718 libs optional libsdl1.2debian_1.2.14-5_i386.deb
 4d9335794d7b91ef9b7a6052e7ab65c5 218942 libs optional libsdl1.2debian-all_1.2.14-5_i386.deb
 0b3feea066d02d3400f56c805dc70098 207512 libs extra libsdl1.2debian-alsa_1.2.14-5_i386.deb
 bb9fc9d6206c282a7828f0d26c1c8146 207786 libs extra libsdl1.2debian-oss_1.2.14-5_i386.deb
 0f5d5434e40aedec5747c133d8c991a0 205906 libs extra libsdl1.2debian-esd_1.2.14-5_i386.deb
 6427bfff89a454bc081615640caac50d 205922 libs extra libsdl1.2debian-arts_1.2.14-5_i386.deb
 8a5086237788c28d57e4d3ac6d085d19 206258 libs extra libsdl1.2debian-nas_1.2.14-5_i386.deb
 4a44b3ebf70a8e6edf57240488e53853 206738 libs extra libsdl1.2debian-pulseaudio_1.2.14-5_i386.deb
 49edb8ac55e9d682c05ec606173f6566 111932 debian-installer extra libsdl1.2debian-udeb_1.2.14-5_i386.udeb
 95ee35ad898782414f5b311bb6dc0b7b 851144 libdevel optional libsdl1.2-dev_1.2.14-5_i386.deb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvJCcwACgkQ5ItltUs5T350ugCgs49EWSmF2XeuCrD6tiuXs9ue
dZ4AnArTnWH25TEJzHPZ1X7wDexzy6Jj
=urU+
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.