Debian Bug report logs - #558260
Output from "gpasswd" is not properly suppressed

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Jörg Sommer <joerg@alea.gnuu.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: --quiet doesn't make adduser $user $group quiet

Date: Fri, 27 Nov 2009 13:56:43 +0100

[Message part 1 (text/plain, inline)]

Package: adduser
Version: 3.111
Severity: normal

Hi,

# adduser --quiet joerg adm
Adding user joerg to group adm
#

This message comes from gpasswd in line 357

% grep -C 1 -n gpasswd =adduser
355-    &invalidate_nscd();
356:    my $gpasswd = &which('gpasswd');
357:    &systemcall($gpasswd, '-a',$existing_user,$existing_group);
358-    &invalidate_nscd();

Bye, Jörg.

-- System Information:
Debian Release: unstable/experimental
  APT prefers unstable
  APT policy: (900, 'unstable'), (700, 'experimental')
Architecture: powerpc (ppc)

Kernel: Linux 2.6.32-rc5
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages adduser depends on:
ii  debconf [debconf-2.0]        1.5.28      Debian configuration management sy
ii  passwd                       1:4.1.4.2-1 change and administer password and
ii  perl-base                    5.10.1-5    minimal Perl system

adduser recommends no packages.

Versions of packages adduser suggests:
ii  liblocale-gettext-perl        1.05-6     Using libc functions for internati
ii  perl-modules                  5.10.1-5   Core Perl modules

-- debconf information excluded

[signature.asc (application/pgp-signature, inline)]

Message #12 received at 558260@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 558260@bugs.debian.org

Cc: Jörg Sommer <joerg@alea.gnuu.de>

Subject: Re: --quiet doesn't make adduser quiet

Date: Fri, 31 Mar 2017 22:49:28 +0100

Hi,

> --quiet doesn't make adduser  quiet

This is because whilst adduser respects --quiet for its own message, it
does not silence the call out to gpasswd:

   353     printf gtx("Adding user `%s' to group `%s' ...\n"),$existing_user,$existing_group
   354         if $verbose;
   355     &invalidate_nscd();
   356     my $gpasswd = &which('gpasswd');
   357     &systemcall($gpasswd, '-a',$existing_user,$existing_group);


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 558260@bugs.debian.org (full text, mbox, reply):

From: "Franklin, Jason" <jason.franklin@quoininc.com>

To: 558260@bugs.debian.org

Cc: Chris Lamb <lamby@debian.org>

Subject: Re: --quiet doesn't make adduser quiet

Date: Thu, 12 Nov 2020 09:31:46 -0500

Greetings, Chris:

> This is because whilst adduser respects --quiet for its own message, it
> does not silence the call out to gpasswd:

I think that adduser should mimic the behavior of deluser here to avoid
being unnecessarily noisy.

The "deluser" utility does the following...

440    #systemcall("usermod","-G", join(",",@groups), $user );
441    my $gpasswd = &which('gpasswd');
442    &systemcall($gpasswd,'-M', join(',',@members), $group);
443    &invalidate_nscd();
444    s_print (gtx("Done.\n"));

The "-M" option to gpasswd accepts a new list of users to belong to a
group and has the benefit of being silent.  Thus, invoking...

  deluser --quiet foo bar

... behaves as expected and is not noisy.

The deluser utility builds a list, and removes the user from the list
which it then passes to the "-M" option.  The adduser utility simply has
to do the opposite and add the user to the existing list of users in the
specified group.

Then, everyone is happy. :)

-- 
Jason Franklin

Message #28 received at 558260-submitter@bugs.debian.org (full text, mbox, reply):

From: Marc Haber <mh+debian-packages@zugschlus.de>

To: 558260-submitter@bugs.debian.org

Subject: Bug#558260 marked as pending in adduser

Date: Wed, 16 Feb 2022 15:46:49 +0000

Control: tag -1 pending

Hello,

Bug #558260 in adduser reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/debian/adduser/-/commit/a7c40dcd86aefe6b4d6fa926a8101222dc1bad01

------------------------------------------------------------------------
Prefer "usermod" when adding a user to a group

This change will preserve functionality while preventing output from
the "gpasswd" command leaking through to the user.

Closes: #558260
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/558260

Message #35 received at 558260-quiet@bugs.debian.org (full text, mbox, reply):

From: Marc Haber <mh+debian-packages@zugschlus.de>

To: 558260-quiet@bugs.debian.org

Subject: Re: Bug#558260: marked as pending in adduser

Date: Wed, 16 Feb 2022 16:57:26 +0100

Control: outlook -1 upload second week of march

The upload is planned for the second week of march

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany    |  lose things."    Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421

Message #42 received at 558260-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 558260-close@bugs.debian.org

Subject: Bug#558260: fixed in adduser 3.119

Date: Sat, 05 Mar 2022 21:33:52 +0000

Source: adduser
Source-Version: 3.119
Done: Marc Haber <mh+debian-packages@zugschlus.de>

We believe that the bug you reported is fixed in the latest version of
adduser, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 558260@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Marc Haber <mh+debian-packages@zugschlus.de> (supplier of updated adduser package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 03 Mar 2022 11:36:10 +0100
Source: adduser
Binary: adduser
Architecture: source all
Version: 3.119
Distribution: unstable
Urgency: medium
Maintainer: Debian Adduser Developers <adduser@packages.debian.org>
Changed-By: Marc Haber <mh+debian-packages@zugschlus.de>
Description:
 adduser    - add and remove users and groups
Closes: 473379 503153 558260 559423 573155 630750 846242 974658 1004710
Changes:
 adduser (3.119) unstable; urgency=medium
 .
   [ Jason Franklin ]
   * Remove a spurious warning that a group is empty. (Closes: #473379)
   * Edit the "--gid" and "--ingroup" man page text. (Closes: #503153)
   * Prefer "usermod" when adding a user to a group. (Closes: #558260)
   * Make "delgroup --system" succeed with a nonexistent group.
     (Closes: #559423)
   * Fix an invalid command in the "adduser -h" output (Closes: #573155)
   * Document currently supported short options. (Closes: #846242)
   * Strip trailing dots from man page descriptions. (Closes: #974658)
   * Pass "-r" to "useradd" when creating a system user. (Closes: #1004710)
   * Run "wrap-and-sort"
   * Make the "deluser" script executable in working tree.
   * Remove editor-specific directives.
   * Remove the "COMMON OPTIONS" man page sections.
   * Edit "general options" in each usage message.
 .
   [ Marc Haber ]
   * Fix NAME_REGEX the intended way.
     Thanks to Georgios M. Zarkadas, Daniel Convissor, Henry Lin,
     Laurent Martelli (Closes: 630750)
   * add basic salsa-ci
   * convert ca.po, nb.po, pl.po to utf-8
   * Bump debhelper from old 9 to 13
   * Rules-Requires-Root: binary-targets
   * give pot file headers proper copyright
   * DEP-5 debian/copyright
   * Standards-Version: 4.6.0 (no changes necessary)
   * override update-debian-copyright for files in debian/po.
 .
   [ Debian Janitor ]
   * Trim trailing whitespace.
   * Fix day-of-week for changelog entries: 3.63, 3.13.
   * Wrap long lines in changelog entries: 3.107, 2.10.
   * Fix misspelling of "Close" => "Closes".
 .
   [ Ondřej Nový ]
   * debian/changelog: Remove trailing whitespaces
Checksums-Sha1:
 d6ae0d1126bf0cc0a545bf18aeafe93cd922a69b 1677 adduser_3.119.dsc
 0e0a7915686be52b89737ba1293db36a0625e5cd 214340 adduser_3.119.tar.xz
 21d12273958e0e7279931032dd9e5668f4c2744b 232388 adduser_3.119_all.deb
 916e0bf91600a17371eed178a75f3ba2a148b9b4 6051 adduser_3.119_amd64.buildinfo
Checksums-Sha256:
 39ede3eac15923f92f6dce252c1ee925a4ac66abebe23cfaf36bff8ae57fb2ee 1677 adduser_3.119.dsc
 c7065a030b58895c2927e110a83247b9707914b3d44791889d8199ec8ebc0ae0 214340 adduser_3.119.tar.xz
 10e64cbd67c3da94bf09d0edebe0c2076994503e163fc9bf348eb4cf0b8b167e 232388 adduser_3.119_all.deb
 c6825604f71c480505c11275e3fc6521a867ab2b0bc6639bae36e267b535ced5 6051 adduser_3.119_amd64.buildinfo
Files:
 ebc51d219ebd835d11b8143f4ee490cd 1677 admin important adduser_3.119.dsc
 a84350e3c4660defb47805be3e467fab 214340 admin important adduser_3.119.tar.xz
 bd352895a7403080a5866a0e90069cf6 232388 admin important adduser_3.119_all.deb
 fa64f0dea90bcd19c29c8eaefe34edfd 6051 admin important adduser_3.119_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE6QL5UJ/L0pcuNEbjj3cgEwEyBEIFAmIj0owACgkQj3cgEwEy
BEKzQRAAgRvyoCuU4V6nlkBO8cfX+TcSOe7oYipMeqoRpcMLqWlfub8/DavBexgJ
rYO6buRXMHsV//oiRpC/5D5WHkLx7CB3uSfLSrpsIa47igXRSkmkY/VFqC1Ucnnt
3xc1qRTzgVruijyJoxonyANV6VqXaJqjCKpJOfIGj2IgFdamUZSjG1pjDvyo2gjl
8EOgns1AqQZEmUCiAq1okac2wIbaqBlxit5JpO6C3DTUdP6qnSMvhar8mHwvU4T8
jIzKNDijSbzJE8zQwj0mOLgffQF88ZhLlQU1T6Qpc2t1UUWOTbXc//u0EopgPxr9
KtfBiNf2g5A0flDPCCXA7t/146GWmIi89ivEUe7mmXYSjgmg8RdVvMO+vIIlpxoq
aNSJvC5NgLmoEd7+Q2vHuoaQGZktz2t5LnSOrwmjwH/UfPqEqaefHtyBfYNuJTrM
Q/USm+NpADeRY2LWmx4KuR8qwpufRMRHWFWWprjJZDpFN54NMSzlxuuQ8LyzfYNo
eV/DzrOKmEoIIQwKEpe0QFT2V7yu+pjmnCcx5aeY18s/xTWGX88+NW2y/o5qFYKR
j59/Q9NdLLsSQrXsGpVRUJ38NiMPSN0+yAceuQK+W+in2B/WkC9/lPzmChK6OGcq
bQDBiKsdiV6oRTh7WLiLM7HZ8htXN/JyePvaFu8tRTlptBMxqG4=
=UFgz
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.