Debian Bug report logs - #557307
debhelper: exists_make_target in makefile.pm may cause infinite loop

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: أحمد المحمودي <aelmahmoudy@users.sourceforge.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: debhelper: exists_make_target in makefile.pm may cause infinite loop

Date: Sat, 21 Nov 2009 06:41:38 +0200

[Message part 1 (text/plain, inline)]

Package: debhelper
Version: 7.4.5
Severity: normal

Hello,

  I stumbled on a case where 'exists_make_target' subroutine in 
  Debian/Debhelper/Buildsystem/makefile.pm runs into an infinite loop.

  Please check the attached Makefile that caused this problem.
  In this Makefile, the 'stamp-i18n' target (which is a dependancy of 
  'all' target) calls: make install

  So, upstream recreated 'stamp-i18n' stamp before and after running 
  'make install' to avoid that make runs into an infinite loop.

  Now, since 'exists_make_target' runs 'make -n <target>' to check for 
  the target, this stamp doesn't get created, which caused make to go 
  into an infinite loop.

-- System Information:
Debian Release: squeeze/sid
  APT prefers karmic-updates
  APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic-proposed'), (500, 'karmic-backports'), (500, 'karmic')
Architecture: i386 (i686)

Kernel: Linux 2.6.31-15-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages debhelper depends on:
ii  binutils                2.20-0ubuntu2    The GNU assembler, linker and bina
ii  dpkg-dev                1.15.4ubuntu2    Debian package development tools
ii  file                    5.03-1ubuntu1    Determines file type using "magic"
ii  html2text               1.3.2a-14        advanced HTML to text converter
ii  man-db                  2.5.6-2          on-line manual pager
ii  perl                    5.10.0-24ubuntu4 Larry Wall's Practical Extraction 
ii  perl-base               5.10.0-24ubuntu4 minimal Perl system
ii  po-debconf              1.0.16           tool for managing templates file t

debhelper recommends no packages.

Versions of packages debhelper suggests:
ii  dh-make                       0.50       tool that converts source archives

-- no debconf information

[Makefile (text/plain, attachment)]

Message #10 received at 557307-close@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: 557307-close@bugs.debian.org

Subject: Bug#557307: fixed in debhelper 7.4.7

Date: Sat, 21 Nov 2009 19:17:19 +0000

Source: debhelper
Source-Version: 7.4.7

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive:

debhelper_7.4.7.dsc
  to main/d/debhelper/debhelper_7.4.7.dsc
debhelper_7.4.7.tar.gz
  to main/d/debhelper/debhelper_7.4.7.tar.gz
debhelper_7.4.7_all.deb
  to main/d/debhelper/debhelper_7.4.7_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 557307@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 21 Nov 2009 13:35:22 -0500
Source: debhelper
Binary: debhelper
Architecture: source all
Version: 7.4.7
Distribution: unstable
Urgency: low
Maintainer: Joey Hess <joeyh@debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description: 
 debhelper  - helper programs for debian/rules
Closes: 557307
Changes: 
 debhelper (7.4.7) unstable; urgency=low
 .
   * make: Avoid infinite make recursion that occurrs when testing existence
     of a target in a certian horribly broken makefile, by making the test stop
     after it sees one line of output from make. (This may be better replaced
     with dh's makefile parser in the future.) Closes: #557307
Checksums-Sha1: 
 540fd871767f5567218f715abe265bbca9a603a1 1547 debhelper_7.4.7.dsc
 193f58e6bd835d31291be75d95e441328f19f2fa 348835 debhelper_7.4.7.tar.gz
 85508d3ebeb2509c71144f8b7b717d3edf94e66b 457168 debhelper_7.4.7_all.deb
Checksums-Sha256: 
 0e1d2cce1034d335538b180e40119993ff053c0b5c21dbccaf1c4fbaf32e0a8e 1547 debhelper_7.4.7.dsc
 7eead6e766c88d644ae0a70ebf229a265b0687107aa7a91c4fa272f744de50fd 348835 debhelper_7.4.7.tar.gz
 eb32401768412988648672b4dd856359673bc04488064d2e1e3aa566789a4e35 457168 debhelper_7.4.7_all.deb
Files: 
 d187f497c37dd7c8ff7d04d2813d3bcd 1547 devel optional debhelper_7.4.7.dsc
 abf44d62ff30a1c670de63e8fb41d0b3 348835 devel optional debhelper_7.4.7.tar.gz
 29341a5f4abc1d198b178be03370b46a 457168 devel optional debhelper_7.4.7_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIVAwUBSwg0BckQ2SIlEuPHAQjd+hAAqIk+4WbqoIRXeQBqpzdtSM2mlreTn15p
UeSUDUyGooKftwBOoNfGkRrPZP2DEpUeWWZuz7gqBphYLpeNO5xHfylJ69NCuRAg
/MWKpJUNOz8nrC+vBu6WAS9lwqM1WfYn0f5296rurWp+2eVL7fg++IDSI//P/ieL
+gupYFimcXLm5Zhh201hiwtiyh04yN4bK9Jg0fJ1o0b0gcPZePB3TIHclwd0ZlIq
gLhOCk7h5SRzWihBtFDCTIzAbj1SRdYewk41wKxWwuLv9SzHXZuFIaRbJ1pW8jyk
BjY1vVOqDKqOgdBBF3lmTosPGe/vcEWRE9h8WyLFX3R342RxU6zlbAh7IUOZhgyZ
JKB1OQZGjwpvHk3wkq2EOKUCJwCwh5LxDBK9/Z25namHMQdGHpmX+LKT+WHgNi6e
0TZcKDztj7uqd3OE/jz4UHse+N5dMdfixVJehqVbS+fP21sroqWhFaeB70+0RKhd
7Jsj4KblV3xg+XPsUz2ug2cyF66atBrgD0B/2gbqnH8P/QXUKOVDwumdwDMBy805
oI0uH5qvRB+sBzofd5JWS60BgdwRyVKAljOCEbMlG9Mxn+dlIeFAX81PJ0fTAQ0j
WRyJglw/iy4Q+xm8EMJax3tBNbP7mzZPwoVsDwCLs6P3qbXrlfaipQx4o2yC05w4
/ZSUr8E7AXg=
=Cm/8
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.