Debian Bug report logs -
#554168
dkms sets wrong permissions for files and folders
Reported by: Patrick Matthäi <pmatthaei@debian.org>
Date: Tue, 3 Nov 2009 14:57:03 UTC
Severity: important
Found in version dkms/2.1.0.1-1
Fixed in version dkms/2.1.0.1-2
Done: Giuseppe Iuculano <iuculano@debian.org>
Bug is archived. No further changes may be made.
Toggle useless messages
Report forwarded
to debian-bugs-dist@lists.debian.org, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>:
Bug#554168; Package dkms.
(Tue, 03 Nov 2009 14:57:20 GMT) (full text, mbox, link).
Acknowledgement sent
to Patrick Matthäi <pmatthaei@debian.org>:
New Bug report received and forwarded. Copy sent to Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>.
(Tue, 03 Nov 2009 14:57:20 GMT) (full text, mbox, link).
Message #5 received at submit@bugs.debian.org (full text, mbox, reply):
Package: dkms
Version: 2.1.0.1-1
Severity: important
Hello,
I have got the following problem:
1) dkms.conf:
PACKAGE_NAME="fglrx"
PACKAGE_VERSION="9-10"
BUILT_MODULE_NAME[0]="$PACKAGE_NAME"
DEST_MODULE_LOCATION[0]="/updates/dkms/"
AUTOINSTALL=yes
PRE_BUILD="chmod 0755 ${dkms_tree}/fglrx/9-10/build/2.6.x"
MAKE[0]="pushd ${dkms_tree}/fglrx/9-10/build; sh make.sh --nohints --norootcheck; popd"
CLEAN="rm -f *.*o"
Note the PRE_BUILD thing was just a try to workaround it, but it doesn't help.
2) Our package looks like this:
$ dpkg-deb -c ../fglrx-modules-dkms_9-10-2_i386.deb
drwxr-xr-x root/root 0 2009-11-03 11:33 ./
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/share/
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/share/doc/
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/share/doc/fglrx-modules-dkms/
-rw-r--r-- root/root 14227 2009-11-03 11:32 ./usr/share/doc/fglrx-modules-dkms/changelog.Debian.gz
-rw-r--r-- root/root 902 2009-11-03 11:32 ./usr/share/doc/fglrx-modules-dkms/NEWS.Debian.gz
-rw-r--r-- root/root 12764 2009-11-03 11:32 ./usr/share/doc/fglrx-modules-dkms/copyright
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/share/lintian/
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/share/lintian/overrides/
-rw-r--r-- root/root 846 2009-11-03 11:32 ./usr/share/lintian/overrides/fglrx-modules-dkms
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/src/
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/src/fglrx-9-10/
-rw-r--r-- root/root 3558 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_pci.h
-rw-r--r-- root/root 25056 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_acpi.c
-rw-r--r-- root/root 7519 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_str.c
-rw-r--r-- root/root 9660 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_pci.c
-rw-r--r-- root/root 2925 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_str.h
-rw-r--r-- root/root 5797 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_acpi.h
-rw-r--r-- root/root 31451 2009-10-05 22:23 ./usr/src/fglrx-9-10/drmP.h
-rw-r--r-- root/root 4920 2009-10-05 22:23 ./usr/src/fglrx-9-10/drm_os_linux.h
-rw-r--r-- root/root 2819 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_io.h
-rw-r--r-- root/root 5715 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_io.c
-rw-r--r-- root/root 1529 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_osconfig.h
-rw-r--r-- root/root 2703 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_ioctl.h
-rw-r--r-- root/root 4359 2009-10-05 22:23 ./usr/src/fglrx-9-10/fglrxko_pci_ids.h
-rw-r--r-- root/root 1793 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_wait.h
-rw-r--r-- root/root 2241608 2009-10-05 22:23 ./usr/src/fglrx-9-10/libfglrx_ip.a.GCC3
-rw-r--r-- root/root 4568 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_debug.c
-rw-r--r-- root/root 304 2009-11-03 11:33 ./usr/src/fglrx-9-10/dkms.conf
-rw-r--r-- root/root 37807 2009-10-05 22:23 ./usr/src/fglrx-9-10/firegl_public.h
-rw-r--r-- root/root 7202 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_debug.h
-rw-r--r-- root/root 161641 2009-11-03 11:32 ./usr/src/fglrx-9-10/firegl_public.c
-rw-r--r-- root/root 3448 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_wait.c
-rwxr-xr-x root/root 15958 2009-11-03 11:07 ./usr/src/fglrx-9-10/make.sh
-rw-r--r-- root/root 6271 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_ioctl.c
-rw-r--r-- root/root 4363 2009-10-05 22:23 ./usr/src/fglrx-9-10/drm_compat.h
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/src/fglrx-9-10/2.6.x/
-rwxr-xr-x root/root 3660 2009-10-05 22:23 ./usr/src/fglrx-9-10/2.6.x/Makefile
-rw-r--r-- root/root 12172 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_agp.c
-rw-r--r-- root/root 1863 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_type.h
-rw-r--r-- root/root 2610 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_agp.h
-rw-r--r-- root/root 21251 2009-10-05 22:23 ./usr/src/fglrx-9-10/drm.h
-rw-r--r-- root/root 2241608 2009-10-05 22:23 ./usr/src/fglrx-9-10/libfglrx_ip.a.GCC4
-rw-r--r-- root/root 1578 2009-10-05 22:23 ./usr/src/fglrx-9-10/kcl_config.h
-rw-r--r-- root/root 15405 2009-10-05 22:23 ./usr/src/fglrx-9-10/drm_proc.h
Please note this dir:
drwxr-xr-x root/root 0 2009-11-03 11:33 ./usr/src/fglrx-9-10/2.6.x/
If dkms starts the building of the package, it FTBFS, because the make.sh changes to the
directory 2.6.x with: cd 2.6.x and it gets a permission denied, because the permissions
of the folder have been changed:
$ ls -ld /var/lib/dkms/fglrx/9-10/build/2.6.x/
drw-r-xr-x 2 nobody root 4096 3. Nov 11:35 /var/lib/dkms/fglrx/9-10/build/2.6.x/
Where is the u+x?
At all it looks like this:
me@gnu:~$ ls -l /var/lib/dkms/fglrx/9-10/build/
insgesamt 4864
drw-r-xr-x 2 nobody root 4096 3. Nov 11:35 2.6.x
-rw-r--r-- 1 nobody root 304 3. Nov 11:35 dkms.conf
-rw-r--r-- 1 nobody root 4363 3. Nov 11:35 drm_compat.h
-rw-r--r-- 1 nobody root 21251 3. Nov 11:35 drm.h
-rw-r--r-- 1 nobody root 4920 3. Nov 11:35 drm_os_linux.h
-rw-r--r-- 1 nobody root 31451 3. Nov 11:35 drmP.h
-rw-r--r-- 1 nobody root 15405 3. Nov 11:35 drm_proc.h
-rw-r--r-- 1 nobody root 4359 3. Nov 11:35 fglrxko_pci_ids.h
-rw-r--r-- 1 nobody root 161641 3. Nov 11:35 firegl_public.c
-rw-r--r-- 1 nobody root 37807 3. Nov 11:35 firegl_public.h
-rw-r--r-- 1 nobody root 25056 3. Nov 11:35 kcl_acpi.c
-rw-r--r-- 1 nobody root 5797 3. Nov 11:35 kcl_acpi.h
-rw-r--r-- 1 nobody root 12172 3. Nov 11:35 kcl_agp.c
-rw-r--r-- 1 nobody root 2610 3. Nov 11:35 kcl_agp.h
-rw-r--r-- 1 nobody root 1578 3. Nov 11:35 kcl_config.h
-rw-r--r-- 1 nobody root 4568 3. Nov 11:35 kcl_debug.c
-rw-r--r-- 1 nobody root 7202 3. Nov 11:35 kcl_debug.h
-rw-r--r-- 1 nobody root 5715 3. Nov 11:35 kcl_io.c
-rw-r--r-- 1 nobody root 6271 3. Nov 11:35 kcl_ioctl.c
-rw-r--r-- 1 nobody root 2703 3. Nov 11:35 kcl_ioctl.h
-rw-r--r-- 1 nobody root 2819 3. Nov 11:35 kcl_io.h
-rw-r--r-- 1 nobody root 1529 3. Nov 11:35 kcl_osconfig.h
-rw-r--r-- 1 nobody root 9660 3. Nov 11:35 kcl_pci.c
-rw-r--r-- 1 nobody root 3558 3. Nov 11:35 kcl_pci.h
-rw-r--r-- 1 nobody root 7519 3. Nov 11:35 kcl_str.c
-rw-r--r-- 1 nobody root 2925 3. Nov 11:35 kcl_str.h
-rw-r--r-- 1 nobody root 1863 3. Nov 11:35 kcl_type.h
-rw-r--r-- 1 nobody root 3448 3. Nov 11:35 kcl_wait.c
-rw-r--r-- 1 nobody root 1793 3. Nov 11:35 kcl_wait.h
-rw-r--r-- 1 nobody root 2241608 3. Nov 11:35 libfglrx_ip.a.GCC3
-rw-r--r-- 1 nobody root 2241608 3. Nov 11:35 libfglrx_ip.a.GCC4
-rw-r--r-- 1 nobody root 504 3. Nov 11:36 make.log
-rwxr-xr-x 1 nobody root 15958 3. Nov 11:35 make.sh
-rw-r--r-- 1 nobody nogroup 839 3. Nov 11:36 make.sh.log
Also have a look in /usr/share/doc/base-passwd/users-and-groups.txt.gz, which
says, that no files should be owned by nobody:nogroup.
In the time where you hopefully fix it, do you have got a workaround for it?
-- System Information:
Debian Release: 5.0.3
APT prefers stable
APT policy: (500, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.28.4-xxxx-std-ipv6-32 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Information forwarded
to debian-bugs-dist@lists.debian.org, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>:
Bug#554168; Package dkms.
(Tue, 03 Nov 2009 18:09:10 GMT) (full text, mbox, link).
Acknowledgement sent
to pmatthaei@debian.org:
Extra info received and forwarded to list. Copy sent to Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>.
(Tue, 03 Nov 2009 18:09:11 GMT) (full text, mbox, link).
Message #10 received at 554168@bugs.debian.org (full text, mbox, reply):
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Very cute.
This autobuilder, which starts on booting the machine, built the module
correctly, which would mean, that it was built there as user root, but
calling it from the maintainer scripts => nobody..
- --
/*
Mit freundlichem Gruß / With kind regards,
Patrick Matthäi
GNU/Linux Debian Developer
E-Mail: pmatthaei@debian.org
patrick@linux-dev.org
Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkrwZngACgkQ2XA5inpabMc/ygCfaAsA9HGvPYNdS/e8y0Yu0kI9
KPoAn0jcTlK18oL3Ms1/M15k0J1R1WRd
=tDeE
-----END PGP SIGNATURE-----
Information forwarded
to debian-bugs-dist@lists.debian.org, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>:
Bug#554168; Package dkms.
(Tue, 03 Nov 2009 19:36:21 GMT) (full text, mbox, link).
Acknowledgement sent
to Giuseppe Iuculano <giuseppe@iuculano.it>:
Extra info received and forwarded to list. Copy sent to Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>.
(Tue, 03 Nov 2009 19:36:21 GMT) (full text, mbox, link).
Message #15 received at 554168@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Patrick Matthäi ha scritto:
> Very cute.
> This autobuilder, which starts on booting the machine, built the module
> correctly, which would mean, that it was built there as user root, but
> calling it from the maintainer scripts => nobody..
>
Where we can find the fglrx-modules-dkms package? dkms simply run a mkdir -p
"$dkms_tree/$module/$module_version/build"
Cheers,
Giuseppe.
[signature.asc (application/pgp-signature, attachment)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>:
Bug#554168; Package dkms.
(Tue, 03 Nov 2009 20:27:13 GMT) (full text, mbox, link).
Acknowledgement sent
to pmatthaei@debian.org:
Extra info received and forwarded to list. Copy sent to Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>.
(Tue, 03 Nov 2009 20:27:13 GMT) (full text, mbox, link).
Message #20 received at 554168@bugs.debian.org (full text, mbox, reply):
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Giuseppe Iuculano schrieb:
> Patrick Matthäi ha scritto:
>> Very cute.
>> This autobuilder, which starts on booting the machine, built the module
>> correctly, which would mean, that it was built there as user root, but
>> calling it from the maintainer scripts => nobody..
>>
>
> Where we can find the fglrx-modules-dkms package? dkms simply run a mkdir -p
> "$dkms_tree/$module/$module_version/build"
This may be, the build directory has the right permissions, but not
subfolders delivered by the package.
>
> Cheers,
> Giuseppe.
>
It is not uploaded (because it does not work because of this bug), yet.
I am currently preparing the package. But here you will find everything
you need:
Vcs-Browser: http://svn.debian.org/wsvn/pkg-fglrx/fglrx-driver/trunk
Vcs-Svn: svn://svn.debian.org/svn/pkg-fglrx/fglrx-driver/trunk
There is the tarball (use the fglrx_driver-9.10.orig.tar.gz) and
everything else is in trunk.
- --
/*
Mit freundlichem Gruß / With kind regards,
Patrick Matthäi
GNU/Linux Debian Developer
E-Mail: pmatthaei@debian.org
patrick@linux-dev.org
Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkrwixYACgkQ2XA5inpabMcKTwCgoX/hqLoiyhMxro4GNODJgGsK
x9QAn2z4qj+riQ34+8kb73auVn0mDV7+
=zMAI
-----END PGP SIGNATURE-----
Information forwarded
to debian-bugs-dist@lists.debian.org, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>:
Bug#554168; Package dkms.
(Tue, 03 Nov 2009 22:03:10 GMT) (full text, mbox, link).
Acknowledgement sent
to Giuseppe Iuculano <iuculano@debian.org>:
Extra info received and forwarded to list. Copy sent to Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>.
(Tue, 03 Nov 2009 22:03:10 GMT) (full text, mbox, link).
Message #25 received at 554168@bugs.debian.org (full text, mbox, reply):
tags 554168 + pending
thanks
Hello,
The following change has been committed for this bug by
Giuseppe Iuculano <iuculano@debian.org> on Tue, 3 Nov 2009 22:47:51 +0100.
The fix will be in the next upload.
=========================================================================
Do not build as a nobody user and don't chown the build directory, no files should be owned by nobody.
Closes: #554168
=========================================================================
You can check the diff of the fix at:
;a=commitdiff;h=27f707a
Added tag(s) pending.
Request was from Giuseppe Iuculano <iuculano@debian.org>
to control@bugs.debian.org.
(Tue, 03 Nov 2009 22:03:11 GMT) (full text, mbox, link).
Message sent on
to Patrick Matthäi <pmatthaei@debian.org>:
Bug#554168.
(Tue, 03 Nov 2009 22:03:14 GMT) (full text, mbox, link).
Reply sent
to Giuseppe Iuculano <iuculano@debian.org>:
You have taken responsibility.
(Wed, 04 Nov 2009 01:57:23 GMT) (full text, mbox, link).
Notification sent
to Patrick Matthäi <pmatthaei@debian.org>:
Bug acknowledged by developer.
(Wed, 04 Nov 2009 01:57:24 GMT) (full text, mbox, link).
Message #35 received at 554168-close@bugs.debian.org (full text, mbox, reply):
Source: dkms
Source-Version: 2.1.0.1-2
We believe that the bug you reported is fixed in the latest version of
dkms, which is due to be installed in the Debian FTP archive:
dkms_2.1.0.1-2.diff.gz
to main/d/dkms/dkms_2.1.0.1-2.diff.gz
dkms_2.1.0.1-2.dsc
to main/d/dkms/dkms_2.1.0.1-2.dsc
dkms_2.1.0.1-2_all.deb
to main/d/dkms/dkms_2.1.0.1-2_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 554168@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Giuseppe Iuculano <iuculano@debian.org> (supplier of updated dkms package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 03 Nov 2009 22:52:30 +0100
Source: dkms
Binary: dkms
Architecture: source all
Version: 2.1.0.1-2
Distribution: unstable
Urgency: low
Maintainer: Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>
Changed-By: Giuseppe Iuculano <iuculano@debian.org>
Description:
dkms - Dynamic Kernel Module Support Framework
Closes: 553600 554168
Changes:
dkms (2.1.0.1-2) unstable; urgency=low
.
[ David Paleino ]
* [47e453e] debian/patches/02-improve_error_message.patch: improve
error message, and add Debian/Ubuntu specific suggestion.
(Closes: #553600)
.
[ Giuseppe Iuculano ]
* [27f707a] Do not build as a nobody user and don't chown the build
directory, no files should be owned by nobody. (Closes: #554168)
Checksums-Sha1:
eeab213849d32c9623c87daeadf64b7fe6e2e650 1280 dkms_2.1.0.1-2.dsc
b7b0720982ff0e57c7c0b36bb61597e587a3833c 7663 dkms_2.1.0.1-2.diff.gz
f2bf5e7bffcbea615037a4c96d45bb64efa61ed5 61182 dkms_2.1.0.1-2_all.deb
Checksums-Sha256:
44316cf074f7628a98870535ad5f5dc3e699056166d77aebf7c9ee08ac43fb57 1280 dkms_2.1.0.1-2.dsc
324cbb8a610bf7a58d6c62d11d0c1bc92cdf6224e13a16051b1d12f1bfffd8c6 7663 dkms_2.1.0.1-2.diff.gz
160a0adb8ada9ba3170ce5ecf1676e1fab5780a2c92e59ccbea484b94381cb6e 61182 dkms_2.1.0.1-2_all.deb
Files:
0b3fc0c57d2fccb7d96321502f9e072d 1280 kernel optional dkms_2.1.0.1-2.dsc
1ee840c7651059dbc9b53024c089e1b1 7663 kernel optional dkms_2.1.0.1-2.diff.gz
85370e33735fded12989768120932ec2 61182 kernel optional dkms_2.1.0.1-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkrwp5gACgkQNxpp46476apoeACfSA/G0PUyxJYN8HtwXYfeuB8k
IcYAn2zo6MEE5/ex9qCmmMtkZaEmG0i3
=sOZo
-----END PGP SIGNATURE-----
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Sun, 13 Dec 2009 07:39:36 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
Debian bug tracking system administrator <owner@bugs.debian.org>.
Last modified:
Sun Jul 2 06:23:50 2023;
Machine Name:
buxtehude
Debian Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.