Debian Bug report logs - #551929
adduser: /etc/deluser.conf is not considered

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Denis Laxalde <dlaxalde@free.fr>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: adduser: /etc/deluser.conf is not considered

Date: Wed, 21 Oct 2009 16:40:02 -0400

Package: adduser
Version: 3.111
Severity: important

In version 3.111, the configuration file /etc/deluser.conf seems not to
be considered any more when deluser is invoked.
In particular,
 - a backup archive is created when options --remove-home or
   --remove-all-files are used despite `BACKUP = 0` in /etc/deluser.conf
 - file system proc (among others maybe) is scanned when option
   --remove-all-files is used despite 
   `EXCLUDE_FSTYPES = "(proc|sysfs|usbfs|devpts|tmpfs)"` in /etc/deluser.conf

With 3.110, deluser behaves correctly.


-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'stable'), (200, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-2-amd64 (SMP w/1 CPU core)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages adduser depends on:
ii  debconf [debconf-2.0]        1.5.27      Debian configuration management sy
ii  passwd                       1:4.1.4.2-1 change and administer password and
ii  perl-base                    5.10.1-5    minimal Perl system

adduser recommends no packages.

Versions of packages adduser suggests:
ii  liblocale-gettext-perl        1.05-6     Using libc functions for internati
ii  perl-modules                  5.10.1-5   Core Perl modules

-- debconf information:
  adduser/homedir-permission: true

Message #12 received at 551929@bugs.debian.org (full text, mbox, reply):

From: Frans Pop <elendil@planet.nl>

To: 551929@bugs.debian.org

Subject: deluser: creates backup of user's files when not requested

Date: Fri, 18 Dec 2009 21:40:41 +0100

severity 551929 serious
thanks

I ran into this too. Raising severity as IMO this bug makes the current 
version of adduser unsuitable to be released with Squeeze.

deluser should not be creating a backup tarball when not asked to do so.

$ sudo deluser --remove-home thibaut
Looking for files to backup/remove ...
Backing up files to be removed to . ...
backup_name = ./thibaut.tar/bin/tar: Removing leading `/' from member names
Removing files ...
Removing user `thibaut' ...
Warning: group `thibaut' has no more members.
Done.

My config file is (comments removed):
$ cat /etc/deluser.conf
REMOVE_HOME = 0
REMOVE_ALL_FILES = 0
BACKUP = 0
BACKUP_TO = "."
ONLY_IF_EMPTY = 0
EXCLUDE_FSTYPES = "(proc|sysfs|usbfs|devpts|tmpfs)"

Cheers,
FJP

Message #19 received at 551929@bugs.debian.org (full text, mbox, reply):

From: Stephen Gran <sgran@debian.org>

To: Frans Pop <elendil@planet.nl>, 551929@bugs.debian.org

Subject: Re: [Adduser-devel] Bug#551929: deluser: creates backup of user's files when not requested

Date: Fri, 18 Dec 2009 21:05:39 +0000

[Message part 1 (text/plain, inline)]

This one time, at band camp, Frans Pop said:
> I ran into this too. Raising severity as IMO this bug makes the current 
> version of adduser unsuitable to be released with Squeeze.
> 
> deluser should not be creating a backup tarball when not asked to do so.

Hi there,

> BACKUP_TO = "."

This is the problem.  In response to #535857, a fix was committed to
make --backup-to imply --backup.  I'm not (yet) sure how to reconcile
"deluser should not be creating a backup tarball when not asked to do so"
with option a in #535857, "--backup-to should .. imply --backup".

Both of these requests are completely reasonable, but conflict, so I
think probably what I'll do is go for option b, and have deluser fail
if --backup-to is set but --backup isn't.  Given that we ship a default
of '.', that should at least be the pronciple of least surprise.

Thoughts?  Objections?  If not, I'll commit something tomorrow.

Cheers,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran@debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 551929@bugs.debian.org (full text, mbox, reply):

From: Frans Pop <elendil@planet.nl>

To: 551929@bugs.debian.org

Subject: Re: [Adduser-devel] Bug#551929: deluser: creates backup of user's files when not requested

Date: Fri, 18 Dec 2009 22:32:04 +0100

On Friday 18 December 2009, Stephen Gran wrote:
> Both of these requests are completely reasonable, but conflict, so I
> think probably what I'll do is go for option b, and have deluser fail
> if --backup-to is set but --backup isn't.  Given that we ship a default
> of '.', that should at least be the pronciple of least surprise.
>
> Thoughts?  Objections?  If not, I'll commit something tomorrow.

It is obviously completely unacceptable to ignore the BACKUP = 0 setting 
from the config file.

Given that wanting to set a different default location for backups in the 
config file without wanting to enable backups by default seems reasonable, 
option b looks like the more reasonable solution to me.

For reference, option b) was:
   --backup-to should loudly refuse to act without --backup


However, *if* the config file is read before parsing options, there is 
another solution: make --backup-to imply --backup, but *only* if passed on 
the command line.

This may require slightly more complex coding, but should be possible to 
implement.

Cheers,
FJP

Message #29 received at 551929@bugs.debian.org (full text, mbox, reply):

From: Stephen Gran <sgran@debian.org>

To: Frans Pop <elendil@planet.nl>, 551929@bugs.debian.org

Subject: Re: [Adduser-devel] Bug#551929: Bug#551929: deluser: creates backup of user's files when not requested

Date: Sat, 19 Dec 2009 10:56:13 +0000

[Message part 1 (text/plain, inline)]

This one time, at band camp, Frans Pop said:
> However, *if* the config file is read before parsing options, there is 
> another solution: make --backup-to imply --backup, but *only* if passed on 
> the command line.

Excellent idea.  This is what I've juct committed as r821.  I'll have a
look to make sure there's no other low hanging fruit out there to close
before upload, and get an upload out soon.  In the meantime, if you want
to double check my commit, some testing would be helpful, as always.

Cheers,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran@debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 551929-close@bugs.debian.org (full text, mbox, reply):

From: Stephen Gran <sgran@debian.org>

To: 551929-close@bugs.debian.org

Subject: Bug#551929: fixed in adduser 3.112

Date: Wed, 23 Dec 2009 16:32:07 +0000

Source: adduser
Source-Version: 3.112

We believe that the bug you reported is fixed in the latest version of
adduser, which is due to be installed in the Debian FTP archive:

adduser_3.112.dsc
  to main/a/adduser/adduser_3.112.dsc
adduser_3.112.tar.gz
  to main/a/adduser/adduser_3.112.tar.gz
adduser_3.112_all.deb
  to main/a/adduser/adduser_3.112_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 551929@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stephen Gran <sgran@debian.org> (supplier of updated adduser package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 19 Dec 2009 11:03:31 +0000
Source: adduser
Binary: adduser
Architecture: source all
Version: 3.112
Distribution: unstable
Urgency: low
Maintainer: Debian Adduser Developers <adduser-devel@lists.alioth.debian.org>
Changed-By: Stephen Gran <sgran@debian.org>
Description: 
 adduser    - add and remove users and groups
Closes: 551929 555307 559661
Changes: 
 adduser (3.112) unstable; urgency=low
 .
   * deluser: --backup-to implies --backup, but only if passed on the command
     line (addresses: #535857) (closes: #551929)
   * deluser: explicitly set $PATH, patch from Martin Pitt
     <martin.pitt@ubuntu.com> (closes: #555307)
   * Translations:
     - ru: thanks Yuri Kozlov <yuray@komyakino.ru> (closes: #559661)
Checksums-Sha1: 
 0f3478793d2c6f9b86746d9531387f523fb85ba5 1029 adduser_3.112.dsc
 d03a9f8790dabf6bd1f1a999c4888146adb0c6c7 279257 adduser_3.112.tar.gz
 15d1c196d1a0902fe070ca8c35121dd812655a6a 156542 adduser_3.112_all.deb
Checksums-Sha256: 
 fcbeeea3de5f66e2f34abc18960bf9c626f8b6187392dee41ae81453dfe31ff1 1029 adduser_3.112.dsc
 d3f06a7effbc8a727927fcd1e41446ef9e64546b3025a33bd602ebe7dc9cd9f5 279257 adduser_3.112.tar.gz
 e1d21360d9fa5a70d25375d592d6adb5dbd94e89d1c6f8e6675f8dbd4b208e3a 156542 adduser_3.112_all.deb
Files: 
 12afbfc7358e2504dbc95147f0a46726 1029 admin important adduser_3.112.dsc
 724b882b8774cb2bf2aadb9316d1a7e0 279257 admin important adduser_3.112.tar.gz
 ceeed03d3bbb55e841725ffcb9beb18e 156542 admin important adduser_3.112_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAksyQUUACgkQSYIMHOpZA47KngCbBE3XuYl7kGnk22M5KCEtdNtE
ANQAmwSXwF1ahuzRStG9F+JmgUVYQhj3
=MtnM
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.