Debian Bug report logs - #551707
handle move of dlocate completion between packages

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Norbert Preining <preining@logic.at>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: bash-completion: does not complete dlocate

Date: Tue, 20 Oct 2009 10:26:42 +0900

Package: bash-completion
Version: 1:1.1-1
Severity: normal

Hi David,

again me

dlocate /usr/sh<TAB><TAB>   ...nothing

Again, that would be solved by what I have reported in another bug, namely
that bash-completion defaults to path completion if nothing else can be
found ....

uaaaa, sorry, but this will probably the last bug I report, I am killing
this package from my disk, it is more in my way then helping.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-rc5 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages bash-completion depends on:
ii  bash                          4.0-7      The GNU Bourne Again SHell

bash-completion recommends no packages.

bash-completion suggests no packages.

-- no debconf information

Message #10 received at 551707@bugs.debian.org (full text, mbox, reply):

From: David Paleino <d.paleino@gmail.com>

To: Norbert Preining <preining@logic.at>

Cc: 551707@bugs.debian.org

Subject: Re: bash-completion: does not complete dlocate

Date: Sun, 27 Dec 2009 17:54:16 +0100

[Message part 1 (text/plain, inline)]

tags 551707 unreproducible
thanks

On Tuesday 20 October 2009 03:26:42, Norbert Preining wrote:
> Package: bash-completion
> Version: 1:1.1-1
> Severity: normal
> 
> Hi David,

Hello Norbert,
sorry for the late reply :)

> again me
> 
> dlocate /usr/sh<TAB><TAB>   ...nothing

Sorry, you must be doing something extremely wrong on your system.

  $ dlocate /usr/sh<TAB>

becomes

  $ dlocate /usr/share/

For this, I just installed dlocate, and didn't touch anything else. And no, we 
still don't have a dlocate completion :)

> Again, that would be solved by what I have reported in another bug, namely
> that bash-completion defaults to path completion if nothing else can be
> found ....

I believe this would involve changing each completion, providing "compgen -f" 
in COMPREPLY if nothing is found.

Have nice holidays!
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 551707@bugs.debian.org (full text, mbox, reply):

From: Norbert Preining <preining@logic.at>

To: David Paleino <d.paleino@gmail.com>

Cc: 551707@bugs.debian.org

Subject: Re: bash-completion: does not complete dlocate

Date: Mon, 28 Dec 2009 06:07:45 +0900

On Sun, 27 Dec 2009, David Paleino wrote:
> tags 551707 unreproducible

Strange. I had bash-completion purged from my system.

Now I installed it.

Then I did
	dlocate /usr/s<TAB><TAB>
and again nothing nothing nothing.

Can you guarantee that you are not using something else then what there
is in the sid repository???

Please tell me what info I can provide to debug that, but I have to
purge bash-completion until you ask me, because currently it is as
useful as a keyboard filled with coke.

> > Again, that would be solved by what I have reported in another bug, namely
> > that bash-completion defaults to path completion if nothing else can be
> > found ....
> 
> I believe this would involve changing each completion, providing "compgen -f" 
> in COMPREPLY if nothing is found.

Well, still that is something that might be interesting, maybe implemented
in a different way.

The point here is that if nothing is found, maybe the completion 
algorithm is incomplete ... or forgot some options ... you never know
in what ways people abuse the system. And then it should fall back
to what normal bash would do by default, namely complete the path.

Best wishes

Norbert

----------------------------------------------------------------------------
Norbert Preining                preining@{jaist.ac.jp, logic.at, debian.org}
JAIST, Japan               TU Wien, Austria            Debian TeX Task Force
gpg DSA: 0x09C5B094   fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
----------------------------------------------------------------------------
NYBSTER (n.)
Sort of person who takes the lift to travel one floor.
			--- Douglas Adams, The Meaning of Liff

Message #22 received at 551707@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: Norbert Preining <preining@logic.at>

Cc: 551707@bugs.debian.org, dlocate@packages.debian.org

Subject: Re: dlocate does not complete filenames

Date: Sun, 27 Dec 2009 22:49:31 +0100

[Message part 1 (text/plain, inline)]

tags 551707 - unreproducible
tags 551707 confirmed patch
reassign 551707 dlocate
thanks

On Sunday 27 December 2009 22:07:45, Norbert Preining wrote:
> On Sun, 27 Dec 2009, David Paleino wrote:
> > tags 551707 unreproducible
> 
> Strange. I had bash-completion purged from my system.
> 
> Now I installed it.
> 
> Then I did
> 	dlocate /usr/s<TAB><TAB>
> and again nothing nothing nothing.

..and, turns out that we're not handling it, at all. It's in the dlocate 
package, bug reassigned.

> Can you guarantee that you are not using something else then what there
> is in the sid repository???

Just re-checked it on a sid chroot, and I'm now confirming it. Sorry for not 
doing this at first :)

> Please tell me what info I can provide to debug that, [..]

Nothing, I'm attaching a patch which fixes the problem. On first try I just 
forgot to re-login, thus I wasn't really using bash-completion on it. Sorry 
for the noise :)

dlocate maintainers: you could also consider letting us (bash-completion) 
handle the completion upstream; this way we would keep it up-to-date with our 
API (see note about _get_pword in >1.1).
If you want it to be included upstream, please file a bug against us, I will 
handle that. Thanks :)

> but I have to purge bash-completion until you ask me, because currently it
> is as useful as a keyboard filled with coke.

Please, please, don't continue on this line.
I'm more than willing to fix bugs and implement new things, like all other 
people in the team do, but please don't act like this, nobody is forcing you 
to use it ;)
And, as always, if you don't like something, patches are welcome!

> > > Again, that would be solved by what I have reported in another bug,
> > > namely that bash-completion defaults to path completion if nothing else
> > > can be found ....
> >
> > I believe this would involve changing each completion, providing "compgen
> > -f" in COMPREPLY if nothing is found.
> 
> Well, still that is something that might be interesting, maybe implemented
> in a different way.
> 
> The point here is that if nothing is found, maybe the completion
> algorithm is incomplete ... or forgot some options ... you never know
> in what ways people abuse the system. And then it should fall back
> to what normal bash would do by default, namely complete the path.

AFAICT, with the current structure of bash-completion, you can't do any 
"global" thing. So you can't "complete on filenames" when "nothing is found" 
-- you have to handle it per each completion.

Please file a separate bug if you want to continue on this point, as we're 
also planning a rewrite of bash-completion in future, so we might consider 
some "global wrapper", which would fit this particular need.


Ciao Norbert, e Buone Feste! :)
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[fix_551707.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 551707@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: Craig Sanders <cas@taz.net.au>, Norbert Preining <preining@logic.at>

Cc: 551707@bugs.debian.org

Subject: Re: Processed: Re: dlocate does not complete filenames

Date: Sun, 27 Dec 2009 23:35:15 +0100

[Message part 1 (text/plain, inline)]

On Sunday 27 December 2009 23:27:33, Craig Sanders wrote:
> how should we handle this? should I release a new dlocate without
> completion first, or will you divert the completion file to your
> package?

It would be best if you released a dlocate without completion, and next I 
release a package Conflicting with dlocate (<< new_version).
I think that's sufficient. Any other idea?

For the upstream team: the conflict is obviously only related to the Debian 
package, to avoid file conflicts on installation.

Thanks for the quick response,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[signature.asc (application/pgp-signature, inline)]

Message #40 received at 551707@bugs.debian.org (full text, mbox, reply):

From: Craig Sanders <cas@taz.net.au>

To: control@bugs.debian.org

Cc: David Paleino <dapal@debian.org>, Norbert Preining <preining@logic.at>, 551707@bugs.debian.org

Subject: Re: Processed: Re: dlocate does not complete filenames

Date: Mon, 28 Dec 2009 09:27:33 +1100

reassign 551707 bash-completion
thanks

On Sun, 27 Dec 2009 at 22:49:31 +0100, David Paleino <dapal@debian.org> wrote:

> dlocate maintainers: you could also consider letting us (bash-completion) 
> handle the completion upstream; this way we would keep it up-to-date with our 
> API (see note about _get_pword in >1.1).
>
> If you want it to be included upstream, please file a bug against us, I will 
> handle that. Thanks :)

that would be greatly appreciated, thanks.  /etc/bash_completion.d/dlocate
was provided by a dlocate user, and I don't use it myself.  I just tested
that it worked (it did, back in June) and accepted it.

how should we handle this? should I release a new dlocate without
completion first, or will you divert the completion file to your
package?

craig

-- 
craig sanders <cas@taz.net.au>

Message #49 received at 551707@bugs.debian.org (full text, mbox, reply):

From: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>

To: <551707@bugs.debian.org>

Cc: Craig Sanders <cas@taz.net.au>

Subject: Re: Processed: Re: dlocate does not complete filenames

Date: Sat, 24 Nov 2018 16:27:15 -0200

On Sun, 27 Dec 2009 23:35:15 +0100 David Paleino <dapal@debian.org> wrote:
> On Sunday 27 December 2009 23:27:33, Craig Sanders wrote:
> > how should we handle this? should I release a new dlocate without
> > completion first, or will you divert the completion file to your
> > package?
> 
> It would be best if you released a dlocate without completion, and next I 
> release a package Conflicting with dlocate (<< new_version).
> I think that's sufficient. Any other idea?

Hi, Craig,

Are you still willing to move the completion file for dlocate from the
dlocate package to bash-completion (upstream and downstream)?

If so, I'll prepare a patch for upstream bash-completion, as well as an
upload for downstream bash-completion and wait for your upload removing
it from dlocate.

> For the upstream team: the conflict is obviously only related to the Debian 
> package, to avoid file conflicts on installation.

This conflict is not really necessary anymore, because completion files
are now installed under /usr/share/bash-completion/completions, and
dlocate still uses the obsolete dir, i.e.: /etc/bash_completion.d/,
thus, there would be no installation conflicts.


Thanks,
Gabriel

Send a report that this bug log contains spam.