Debian Bug report logs - #548551
dancer-services: Incorrect dependencies in init.d LSB header

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: submit@bugs.debian.org

Subject: dancer-services: Incorrect dependencies in init.d LSB header

Date: Sun, 27 Sep 2009 09:28:47 +0200

Package:  dancer-services
Version:  1.8.0.6.3-6
Severity: important
Tags:     patch
User:     initscripts-ng-devel@lists.alioth.debian.org
Usertags: incorrect-dependency
User:     debian-qa@lists.debian.org
Usertags: piuparts

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script of this package.  The script have a hard
dependency on dancer-ircd, yet the package only recommend dancer-ircd.
Because of this, the init.d dependency should be a soft dependency.
Further, the script uses files in /usr/ and should depend on
$remote_fs not $local_fs, and I believe such dependency should be
hard.

I discovered these things from piuparts, which failed to install the
package.  See
<URLhttp://piuparts.debian.org/sid/fail/dancer-services_1.8.0.6.3-6.log>.
Here are the relevant parts:

  insserv: Service dancer-ircd has to be enabled to start service
    dancer-services
  insserv: exiting now!

I'm setting severity important and not serous, as dancer-ircd is a
recommended package to dancer-services and thus will be installed on
most systems.

This patch should solve it.

diff -ur ../dancer-services-1.8.0.6.3/debian/init.d ../dancer-services-1.8.0.6.3-pere/debian/init.d
--- ../dancer-services-1.8.0.6.3/debian/init.d  2009-09-27 08:33:27.000000000 +0200
+++ ../dancer-services-1.8.0.6.3-pere/debian/init.d     2009-09-27 09:17:06.000000000 +0200
@@ -2,10 +2,10 @@

 ### BEGIN INIT INFO
 # Provides:          dancer-services
-# Required-Start:    $syslog dancer-ircd
-# Required-Stop:     $syslog dancer-ircd
-# Should-Start:      $local_fs $network $named
-# Should-Stop:       $local_fs $network $named
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
+# Should-Start:      $network $named dancer-ircd
+# Should-Stop:       $network $named dancer-ircd
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Dancer-Services daemon init.d script

Happy hacking,
-- 
Petter Reinholdtsen

Message #14 received at 548551-close@bugs.debian.org (full text, mbox, reply):

From: Jari Aalto <jari.aalto@cante.net>

To: 548551-close@bugs.debian.org

Subject: Bug#548551: fixed in dancer-services 1.8.0.6.3-6.1

Date: Thu, 18 Mar 2010 05:32:09 +0000

Source: dancer-services
Source-Version: 1.8.0.6.3-6.1

We believe that the bug you reported is fixed in the latest version of
dancer-services, which is due to be installed in the Debian FTP archive:

dancer-services_1.8.0.6.3-6.1.diff.gz
  to main/d/dancer-services/dancer-services_1.8.0.6.3-6.1.diff.gz
dancer-services_1.8.0.6.3-6.1.dsc
  to main/d/dancer-services/dancer-services_1.8.0.6.3-6.1.dsc
dancer-services_1.8.0.6.3-6.1_i386.deb
  to main/d/dancer-services/dancer-services_1.8.0.6.3-6.1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 548551@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jari Aalto <jari.aalto@cante.net> (supplier of updated dancer-services package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 14 Feb 2010 16:32:20 +0200
Source: dancer-services
Binary: dancer-services
Architecture: source i386
Version: 1.8.0.6.3-6.1
Distribution: unstable
Urgency: low
Maintainer: Aurélien GÉRÔME <ag@roxor.cx>
Changed-By: Jari Aalto <jari.aalto@cante.net>
Description: 
 dancer-services - IRC services implementation for dancer-ircd
Closes: 548551
Changes: 
 dancer-services (1.8.0.6.3-6.1) unstable; urgency=low
 .
   [Jari Aalto]
   * Non-maintainer upload.
   * debian/init.d
     - Rearrange dependencies: The script has a hard dependency on
       dancer-ircd, yet the package only recommend dancer-ircd. Because of
       this, the init.d dependency is best declared a soft dependency. Files
       in /usr/ are used, so it is better to hard depend on $remote_fs not
       $local_fs (serious; Closes: #548551). Patch Thanks to Petter
       Reinholdtsen <pere@hungry.com>.
     - (Required-Start): Add $remote_fs, remove dancer-ircd.
     - (Required-Stop): Add $remote_fs, remove dancer-ircd.
     - (Should-Start): Add dancer-ircd, remove $local_fs.
     - (Should-Stop): Add dancer-ircd, remove $local_fs.
     - (mkrundir): New function. Create directory /var/run/dancer-services
       at "start" action.
   * debian/dirs:
     - Remove var/run/dancer-services (E: lintian).
Checksums-Sha1: 
 84c8e06329f00bee403c35b68baf465f36588b31 1172 dancer-services_1.8.0.6.3-6.1.dsc
 116390a80f4d3ed9fa1f6833ad23ef6d4c03a9b2 24821 dancer-services_1.8.0.6.3-6.1.diff.gz
 895aec7767acf9dde07cea000c80915ffd768174 236620 dancer-services_1.8.0.6.3-6.1_i386.deb
Checksums-Sha256: 
 539f91f0ec07a103e469f5efb4f97e714ea7262bbedb7599c574fd4586af3a32 1172 dancer-services_1.8.0.6.3-6.1.dsc
 b33a39a3f1efee3ec32361956a1367e0ddee7a9f09a9524959db2b88e6036b2a 24821 dancer-services_1.8.0.6.3-6.1.diff.gz
 1c22c617699703c1e871d29c707f5a8476ebea8c92c48882457dc22793381221 236620 dancer-services_1.8.0.6.3-6.1_i386.deb
Files: 
 a53be44d70e67a682006c97ff661abfd 1172 net optional dancer-services_1.8.0.6.3-6.1.dsc
 2123f7d3ae76eaa839e89d5e86d77d4f 24821 net optional dancer-services_1.8.0.6.3-6.1.diff.gz
 cc1e83fc0d691d6dda05cd017562beb0 236620 net optional dancer-services_1.8.0.6.3-6.1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkuUhMUACgkQpdwBkPlyvgMbRACfV+ehzGB0zg9h4VEzsoCSzxsL
RbAAn2aono84rx4FoL8NtuZuK0GGqS5M
=gbvY
-----END PGP SIGNATURE-----

Message #19 received at 548551@bugs.debian.org (full text, mbox, reply):

From: jari.aalto@cante.net

To: 548551@bugs.debian.org

Subject: Bug#548551 dancer-services: NMU diff for 1.8.0.6.3-6.1

Date: Thu, 18 Mar 2010 08:13:25 +0200

[Message part 1 (text/plain, inline)]

Dear maintainer,

Here is the NMU diff according to DevRef 5.11.1[1][2] for RC bug: #548551.
See the debian/patches directory for the important fixes. Feel free to
contact if you have any questions.

Thank you for maintaining the package,
Jari Aalto

[1] http://www.debian.org/doc/developers-reference/pkgs.html#nmu
[2] http://dep.debian.net/deps/dep1.html

lsdiff(1) of changes:

    dancer-services-1.8.0.6.3/debian/init.d
    dancer-services-1.8.0.6.3/debian/dirs
    dancer-services-1.8.0.6.3/debian/changelog

[dancer-services_1.8.0.6.3-6--1.8.0.6.3-6.1-nmu.diff (text/x-diff, inline)]

diffstat for dancer-services_1.8.0.6.3-6 dancer-services_1.8.0.6.3-6.1

 changelog |   22 ++++++++++++++++++++++
 dirs      |    2 +-
 init.d    |   19 +++++++++++++++----
 3 files changed, 38 insertions(+), 5 deletions(-)

diff -u dancer-services-1.8.0.6.3/debian/init.d dancer-services-1.8.0.6.3/debian/init.d
--- dancer-services-1.8.0.6.3/debian/init.d
+++ dancer-services-1.8.0.6.3/debian/init.d
@@ -2,10 +2,10 @@
 
 ### BEGIN INIT INFO
 # Provides:          dancer-services
-# Required-Start:    $syslog dancer-ircd
-# Required-Stop:     $syslog dancer-ircd
-# Should-Start:      $local_fs $network $named
-# Should-Stop:       $local_fs $network $named
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
+# Should-Start:      $network $named dancer-ircd
+# Should-Stop:       $network $named dancer-ircd
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Dancer-Services daemon init.d script
@@ -21,8 +21,19 @@
 
 set -e
 
+mkrundir ()
+{
+	if [ -d /var/run/dancer-services ]; then
+	    return 0
+	fi
+
+	mkdir -p /var/run/dancer-services
+	chown services:root /var/run/dancer-services
+}
+
 case "$1" in
   start)
+        mkrundir
 	echo "Starting $DESC: "
 	start-stop-daemon --start --quiet --pidfile /var/run/dancer-services/$NAME.pid \
 		--chuid services --exec $DAEMON
diff -u dancer-services-1.8.0.6.3/debian/dirs dancer-services-1.8.0.6.3/debian/dirs
--- dancer-services-1.8.0.6.3/debian/dirs
+++ dancer-services-1.8.0.6.3/debian/dirs
@@ -7 +7 @@
-var/run/dancer-services/
+
diff -u dancer-services-1.8.0.6.3/debian/changelog dancer-services-1.8.0.6.3/debian/changelog
--- dancer-services-1.8.0.6.3/debian/changelog
+++ dancer-services-1.8.0.6.3/debian/changelog
@@ -1,3 +1,25 @@
+dancer-services (1.8.0.6.3-6.1) unstable; urgency=low
+
+  [Jari Aalto]
+  * Non-maintainer upload.
+  * debian/init.d
+    - Rearrange dependencies: The script has a hard dependency on
+      dancer-ircd, yet the package only recommend dancer-ircd. Because of
+      this, the init.d dependency is best declared a soft dependency. Files
+      in /usr/ are used, so it is better to hard depend on $remote_fs not
+      $local_fs (serious; Closes: #548551). Patch Thanks to Petter
+      Reinholdtsen <pere@hungry.com>.
+    - (Required-Start): Add $remote_fs, remove dancer-ircd.
+    - (Required-Stop): Add $remote_fs, remove dancer-ircd.
+    - (Should-Start): Add dancer-ircd, remove $local_fs.
+    - (Should-Stop): Add dancer-ircd, remove $local_fs.
+    - (mkrundir): New function. Create directory /var/run/dancer-services
+      at "start" action.
+  * debian/dirs:
+    - Remove var/run/dancer-services (E: lintian).
+
+ -- Jari Aalto <jari.aalto@cante.net>  Sun, 14 Feb 2010 16:32:20 +0200
+
 dancer-services (1.8.0.6.3-6) unstable; urgency=medium
 
   * Switch to the DM-Upload-Allowed field.

Send a report that this bug log contains spam.