Debian Bug report logs - #536434
[checks/changelog-file] don't check debian-changelog-file-is-a-symlink for Ubuntu packages

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Benjamin Drung <benjamin.drung@gmail.com>

To: submit@bugs.debian.org

Subject: [checks/changelog-file] Do not check debian-changelog-file-is-a-symlink for Ubuntu packages

Date: Thu, 09 Jul 2009 23:26:57 +0200

[Message part 1 (text/plain, inline)]

Package: lintian
Version: 2.2.13

Ubuntu allows symlinked changelog files. So please do not report
debian-changelog-file-is-a-symlink if the package is an Ubuntu package.

I tried to write a patch for it, but Perl does not like me (or the other
way round). The check rule should look like

if (-l 'changelog' && !($version =~ /$UBUNTU_REGEX/ or $distribution =~ /$UBUNTU_REGEX/)) {
    tag "debian-changelog-file-is-a-symlink", "";
    return 0;
}

but I don't know how to determine $distribution.

Cheers,
Benjamin

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 536434@bugs.debian.org (full text, mbox, reply):

From: Russ Allbery <rra@debian.org>

To: Benjamin Drung <benjamin.drung@gmail.com>

Cc: 536434@bugs.debian.org

Subject: Re: Bug#536434: [checks/changelog-file] Do not check debian-changelog-file-is-a-symlink for Ubuntu packages

Date: Thu, 09 Jul 2009 15:42:15 -0700

Benjamin Drung <benjamin.drung@gmail.com> writes:

> Ubuntu allows symlinked changelog files. So please do not report
> debian-changelog-file-is-a-symlink if the package is an Ubuntu
> package.
>
> I tried to write a patch for it, but Perl does not like me (or the
> other way round). The check rule should look like
>
> if (-l 'changelog' && !($version =~ /$UBUNTU_REGEX/ or $distribution =~ /$UBUNTU_REGEX/)) {
>     tag "debian-changelog-file-is-a-symlink", "";
>     return 0;
> }
>
> but I don't know how to determine $distribution.

That's the problem: neither does Lintian without having access to the
changelog file, which is where the distribution is stated.

We can handle this for packages that contain ubuntu in the version
number, but I don't see any way for Lintian to know that this is an
Ubuntu package if it contains no changelog (and a dangling symlink,
which is what we see for such packages, is equivalent to having no
changelog) and doesn't have ubuntu in the version number.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>

Message #17 received at 536434-close@bugs.debian.org (full text, mbox, reply):

From: Russ Allbery <rra@debian.org>

To: 536434-close@bugs.debian.org

Subject: Bug#536434: fixed in lintian 2.2.15

Date: Mon, 14 Sep 2009 07:32:08 +0000

Source: lintian
Source-Version: 2.2.15

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_2.2.15.dsc
  to pool/main/l/lintian/lintian_2.2.15.dsc
lintian_2.2.15.tar.gz
  to pool/main/l/lintian/lintian_2.2.15.tar.gz
lintian_2.2.15_all.deb
  to pool/main/l/lintian/lintian_2.2.15_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 536434@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Russ Allbery <rra@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 14 Sep 2009 00:06:01 -0700
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.2.15
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Russ Allbery <rra@debian.org>
Description: 
 lintian    - Debian package checker
Closes: 498138 534486 536434 537737 538716 539403 540594 541372 541744 542046 542072 542389 542584 543259 543262 543641 543779 543781 543873 544004 544221 544277 545219 545430 545716 545781 546404
Changes: 
 lintian (2.2.15) unstable; urgency=low
 .
   The "BTS cleanup" release.
 .
   * Summary of tag changes:
     + Added:
       - build-depends-on-non-build-package
       - desktop-entry-limited-to-environments
       - example-interpreter-in-usr-local (pedantic)
       - example-interpreter-not-absolute
       - example-script-without-interpreter
       - example-script-uses-bin-env
       - example-shell-script-fails-syntax-check (pedantic)
       - example-wrong-path-for-interpreter
       - example-unusual-interpreter (pedantic)
       - global-data-in-games-directory
       - init.d-script-does-not-provide-itself
       - init.d-script-possible-missing-stop
       - init.d-script-provides-virtual-facility
       - init.d-script-should-depend-on-virtual-facility
       - init.d-script-starts-in-stop-runlevel
       - ocaml-custom-executable
 .
   * checks/binaries{,.desc}:
     + [RA] Add a new check for OCaml bytecode executables.  Patch from
       Stéphane Glondu.  (Closes: #498138)
     + [RA] Allow ldconfig to be statically linked.
   * checks/changelog-file:
     + [RA] Don't warn about a symlinked changelog file if the version
       contains ubuntu.  Thanks, Benjamin Drung.  (Closes: #536434)
   * checks/common_data.pm:
     + [RA] Moved the essential package list to data/fields.
   * checks/copyright-file:
     + [RA] Use Lintian::Data to read the essential package list.
   * checks/debhelper:
     + [RA] Ignore whitespace when checking debian/compat, since Perl will
       when converting it to a number.  Thanks, Niels Thykier.
       (Closes: #545430)
   * checks/fields{,.desc}:
     + [RA] Exclude base-files from the needlesly-depends-on-awk tag
       and from the warning about depending on a virtual package without
       a real package for the awk virtual package.
     + [RA] Use Lintian::Data to read the essential package list.
     + [RA] Stop allowing unversioned build dependencies on coreutils.  The
       migration from fileutils is long since finished.
     + [RA] Check for build dependencies on packages that should not be
       used for builds.  (Closes: #540594)
     + [RA] Allow architecture-dependent metapackages, since it can be
       useful for metapackages to change dependencies based on the
       architecture.  Thanks, Vagrant Cascadian.  (Closes: #544004)
   * checks/files{,.desc}:
     + [RA] Suppress non-standard-dir-perm for /tmp, /var/tmp, /var/local,
       /var/lock, and /usr/src if they have their normal owner and
       permissions.  This suppresses some Lintian tags for base-files.
     + [RA] Allow base-files to ship /var/backups and /var/local.
     + [RA] Remove swfobject.js from the known packaged Javascript
       libraries.  The version in libjs-yui is old and the new version is
       not packaged.  Thanks, Giuseppe Iuculano.  (Closes: #542046)
     + [RA] Allow t1- and xfonts- as prefixes for font packages since the
       font regex is also looking for Type 1 fonts.  Thanks, Rogério
       Brito.  (Closes: #542389)
     + [RA] Stop looking for *.pcf files outside font packages.  The check
       wasn't triggering since PCF files are always compressed, and the
       situation for PCF font packages is more complex and not suitable for
       the same check.
     + [RA] Add mootools.js to embedded-javascript-library.  Patch from
       Marcelo Jorge Vieira (metal).  (Closes: #545716)
     + [RA] Check for putting data that should be in /usr/share under
       /usr/share/games.  Patch from Raphael Geissert.  (Closes: #534486)
   * checks/init.d{,.desc}:
     + [RA] Add new checks for starting in runlevels 0 and 6, providing a
       virtual facility, not providing a facility matching the script, not
       depending on a virtual facility, and inconsistent stop runlevels.
       Patch from Raphael Geissert.  (Closes: #544221)
   * checks/manpages{,.desc}:
     + [ADB] Add HTTPS to the list of recognised protocols for URLs in manpages
       which should not cause manpage-has-errors-from-man to be emitted.
       (Closes: #543641)
     + [RA] Document the MANWIDTH variable when running man by hand to
       check for man page errors.  (Closes: #542584)
     + [RA] Adjust the exclusion of pod2man's .IX macro for the new
       output format from groff.
   * checks/menu-format{,.desc}:
     + [RA] Add a pointer to desktop-file-validate in many of the tag
       descriptions for desktop tags.  (Closes: #539403)
     + [RA] Mention in the description of desktop-entry-invalid-category
       that whitespace isn't allowed and categories are case-sensitive.
     + [RA] Add a new check for desktop entries that are limited to
       multiple environments.  NotShowIn was probably intended instead.
       Thanks, Andrew Lee.  (Closes: #537737)
   * checks/rules:
     + [RA] Anchor the dh_quilt regex to not trigger on commented-out
       calls.  Patch from Cesare Tirabassi.  (Closes: #543259)
     + [RA] When checking for out-of-order debhelper calls, take into
       account the -p flag and only check within each package.  Thanks,
       Michael Koch.  (Closes: #545219)
   * checks/scripts{,.desc}:
     + [RA] Don't warn about missing dependencies on programs if the
       program invocation is followed by || true.  Thanks, Aurelien Jarno.
       (Closes: #541372)
     + [RA] Permit diversion of a man page as long as the package is
       installing a man page by the same name in the same numeric section,
       even if the specific section is different.  Thanks, Niko Tyni.
       (Closes: #543781)
     + [RA] Check example scripts for most of the same issues as scripts
       elsewhere in the package, but report problems with a different set
       of tags with info or pedantic severity.  Patch from Damyan Ivanov.
       (Closes: #543873)
     + [RA] Add seed.  Thanks, Josselin Mouette.  (Closes: #543779)
     + [RA] Add pike 7.8.  Thanks, Magnus Holmgren.  (Closes: #543262)
   * checks/shared-libs:
     + [RA] Allow ld.so to be executable.  (Closes: #538716)
 .
   * data/fields/essential:
     + [RA] New list of essential packages.
     + [RA] Add dash.  (Closes: #541744)
     + [RA] Add diffutils and remove diff.  (Closes: #544277)
   * data/fields/no-build-depends:
     + [RA] New list of packages that should not be used as build
       dependencies, currently containing only java-propose-classpath.
       Thanks, Josh Triplett.
   * data/files/fonts:
     + [RA] Refresh and include Type 1 fonts and packages as well.
 .
   * lib/Lintian/Collect/Binary.pm:
     + [RA] Stop looking for the special OCaml symbol.  OCaml custom
       binaries are now detected another way.  Patch from Stéphane Glondu.
   * lib/Lintian/Schedule.pm:
     + [RA] If declining to add a duplicate file to the Lintian check
       schedule, return success to avoid a spurious error message.  Patch
       from Raphael Geissert.  (Closes: #542072)
   * lib/Spelling.pm:
     + [RA] Add spelling correction for "aplication."  (Closes: #546404)
 .
   * private/refresh-fonts-data:
     + [RA] To match what checks/files looks for, also look for *.pfb files
       and packages starting with t1-.
 .
   * reporting/{html_reports,templates/clean.tmpl}:
     + [JP] Don't link to full report if the maintainer only has clean
       packages. (Closes: #545781)
Checksums-Sha1: 
 38fc94e3cad1c29999df654289185621b533447b 1167 lintian_2.2.15.dsc
 dd4ea7530a0e3dfc80000ca68b3c4b85e4e3ef9e 742286 lintian_2.2.15.tar.gz
 2f6552d9dc896e454c6927707aec276fbfd7faf9 475550 lintian_2.2.15_all.deb
Checksums-Sha256: 
 840333f514921fb768eb5523bd5f84960ce47da09ee3f750beccbd83c5c773c1 1167 lintian_2.2.15.dsc
 d869737a4cd48c050d9909e949c37a7439b7efe28628d64b94797808f9fbed5c 742286 lintian_2.2.15.tar.gz
 f580a17c80f92e9700c8ebd44ad6e8ac5407010d7f4e992b3ed31a9bc3bc7504 475550 lintian_2.2.15_all.deb
Files: 
 6bdfbba75275491e3bebb17d0755ef60 1167 devel optional lintian_2.2.15.dsc
 c7c611de80b362a588121b6182a262cc 742286 devel optional lintian_2.2.15.tar.gz
 29d69bfdd60a03b49643944311d68b1f 475550 devel optional lintian_2.2.15_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqt7coACgkQ+YXjQAr8dHbFVgCfSWlIT93hKYQbDIdZEdyjOVBm
KY8AoMgUg72m7WG6p1xJFu0LDl0J92SM
=cAzU
-----END PGP SIGNATURE-----

Message #22 received at 536434@bugs.debian.org (full text, mbox, reply):

From: Benjamin Drung <bdrung@ubuntu.com>

To: 536434@bugs.debian.org

Subject: Do not check debian-changelog-file-is-a-symlink for Ubuntu packages

Date: Wed, 16 Sep 2009 13:40:20 +0200

[Message part 1 (text/plain, inline)]

reopen 536434 !
thanks

The bug was only fixed partially for packages with ubuntu in their
version. The problem is, that CDBS will link the changelog file, if the
package is build on Ubuntu. The version string does not have any
influence.

lintian should not complain if the package is build on Ubuntu. Normally
lintian is run on the same system. Therefore lintian should not complain
about the changelog, if it is run on Ubuntu. "lsb_release -si" will give
this information.

Sorry for the late response. I wanted to answer earlier.

Cheers,
Benjamin

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 536434@bugs.debian.org (full text, mbox, reply):

From: Russ Allbery <rra@debian.org>

To: Benjamin Drung <bdrung@ubuntu.com>

Cc: 536434@bugs.debian.org

Subject: Re: Bug#536434: Do not check debian-changelog-file-is-a-symlink for Ubuntu packages

Date: Wed, 16 Sep 2009 11:26:04 -0700

tags 536434 wontfix
retitle 536434 [checks/changelog-file] don't check debian-changelog-file-is-a-symlink for Ubuntu packages
thanks

Benjamin Drung <bdrung@ubuntu.com> writes:

> The bug was only fixed partially for packages with ubuntu in their
> version. The problem is, that CDBS will link the changelog file, if the
> package is build on Ubuntu. The version string does not have any
> influence.

> lintian should not complain if the package is build on Ubuntu. Normally
> lintian is run on the same system. Therefore lintian should not complain
> about the changelog, if it is run on Ubuntu. "lsb_release -si" will give
> this information.

I'm not willing to do this.  The purpose of Lintian is to check packages
for Debian against Debian Policy, and should continue to do so even if
it's being run on an Ubuntu host.

When Ubuntu makes available enough information that Lintian can adjust and
also check Ubuntu packages, I'm happy to try to support that, but it
should only be enabled when the packages are specifically Ubuntu packages,
not just Debian packages that are being checked on Ubuntu.

If, therefore, Ubuntu chooses to diverge from Debian Policy in a way that
cannot be automatically detected like this, I believe it's Ubuntu's
responsibility to bear the full support cost of that decision.  That will
probably mean Ubuntu maintaining local patches to Lintian in perpetuity,
unless the work is done to achieve consensus to change Debian Policy or
the divergence from Debian Policy is reverted.

In other words, I think this was a poorly handled choice on the part of
Ubuntu compounded by another poorly chosen decision in CDBS, and while I'm
sorry that you got caught in the middle, I don't think there's a way for
Lintian to work around it and still support its primary purpose.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>

Message #40 received at 536434@bugs.debian.org (full text, mbox, reply):

From: Benjamin Drung <bdrung@ubuntu.com>

To: Russ Allbery <rra@debian.org>

Cc: 536434@bugs.debian.org

Subject: Re: Bug#536434: Do not check debian-changelog-file-is-a-symlink for Ubuntu packages

Date: Thu, 17 Sep 2009 01:06:45 +0200

[Message part 1 (text/plain, inline)]

Hi Russ,

thanks for your help. I understand your points and agree. More cannot be
done in the Debian lintian package. You can close this bug, if you want.

Cheers,
Benjamin

[signature.asc (application/pgp-signature, inline)]

Message #47 received at 536434-done@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 536434-done@bugs.debian.org

Subject: Re: [checks/changelog-file] don't check debian-changelog-file-is-a-symlink for Ubuntu packages

Date: Mon, 15 Aug 2011 22:39:10 +0200

Source: lintian
Source-Version: 2.5.2

Done, as a part of the vendor profiles.

Send a report that this bug log contains spam.