Debian Bug report logs - #534685
libssl0.9.8: EX_DATA_CHECK macro gives helgrind errors

Package: openssl; Maintainer for openssl is Debian OpenSSL Team <pkg-openssl-devel@lists.alioth.debian.org>; Source for openssl is src:openssl.

Reported by: Russell Coker <russell@coker.com.au>

Date: Fri, 26 Jun 2009 10:48:01 UTC

Severity: normal

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian OpenSSL Team <pkg-openssl-devel@lists.alioth.debian.org>:
Bug#534685; Package libssl0.9.8. (Fri, 26 Jun 2009 10:48:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Russell Coker <russell@coker.com.au>:
New Bug report received and forwarded. Copy sent to Debian OpenSSL Team <pkg-openssl-devel@lists.alioth.debian.org>. (Fri, 26 Jun 2009 10:48:04 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Russell Coker <russell@coker.com.au>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: libssl0.9.8: EX_DATA_CHECK macro gives helgrind errors
Date: Fri, 26 Jun 2009 20:43:32 +1000
Package: libssl0.9.8
Version: 0.9.8g-15+lenny1
Severity: normal

==27623== Possible data race during read of size 8 at 0x55ef9d0 by thread #4
==27623==    at 0x52D12A6: def_get_class (ex_data.c:298)
==27623==    by 0x52D180A: int_new_ex_data (ex_data.c:404)
==27623==    by 0x5318BD7: RSA_new_method (rsa_lib.c:185)
==27623==    by 0x531B76C: rsa_cb (rsa_asn1.c:80)
==27623==    by 0x534CB42: asn1_item_ex_combine_new (tasn_new.c:177)
==27623==    by 0x53501E4: ASN1_item_ex_d2i (tasn_dec.c:399)
==27623==    by 0x53502B3: ASN1_item_d2i (tasn_dec.c:134)
==27623==    by 0x534863C: d2i_PublicKey (d2i_pu.c:96)
==27623==    by 0x534624F: X509_PUBKEY_get (x_pubkey.c:364)
==27623==    by 0x5346C07: d2i_PUBKEY (x_pubkey.c:390)
==27623==    by 0x40D480: SelectorInfo::Parse(char*) (dkimverify.cpp:1312)
==27623==    by 0x40E0A4: CDKIMVerify::GetSelector(std::string const&, std::string const&) (dkimverify.cpp:1369)
==27623==  This conflicts with a previous write of size 8 by thread #2
==27623==    at 0x52D140E: def_get_class (ex_data.c:268)
==27623==    by 0x52D180A: int_new_ex_data (ex_data.c:404)
==27623==    by 0x532684F: BIO_set (bio_lib.c:100)
==27623==    by 0x53268D9: BIO_new (bio_lib.c:76)
==27623==    by 0x5326E81: BIO_new_mem_buf (bss_mem.c:102)
==27623==    by 0x4065C4: dk_end (domainkeys.c:1843)
==27623==    by 0x406D22: dk_eom (domainkeys.c:1982)
==27623==    by 0x4034CC: domainkeys_verify(int, char const*, int, unsigned char**, char***) (dkim-test.cpp:218)

I'm getting the above output from valgrind/helgrind on my amd64 system.  Line
298 of ex_data.c is as follows:
        EX_DATA_CHECK(return NULL;)

Here is the definition of EX_DATA_CHECK:

static int ex_data_check(void)
        {
        int toret = 1;
        CRYPTO_w_lock(CRYPTO_LOCK_EX_DATA);
        if(!ex_data && ((ex_data = lh_new(ex_hash_cb, ex_cmp_cb)) == NULL))
                toret = 0;
        CRYPTO_w_unlock(CRYPTO_LOCK_EX_DATA);
        return toret;
        }
/* This macros helps reduce the locking from repeated checks because the
 * ex_data_check() function checks ex_data again inside a lock. */
#define EX_DATA_CHECK(iffail) if(!ex_data && !ex_data_check()) {iffail}

Line 268 of ex_data.c is the "if(!ex_data" line of ex_data_check().

Again it seems that a simple change to the macro would stop this error, the
following definition would do so:
#define EX_DATA_CHECK(iffail) if(!ex_data_check()) {iffail}




Reply sent to Debian FTP Masters <ftpmaster@ftp-master.debian.org>:
You have taken responsibility. (Sat, 19 Nov 2011 09:50:51 GMT) Full text and rfc822 format available.

Notification sent to Russell Coker <russell@coker.com.au>:
Bug acknowledged by developer. (Sat, 19 Nov 2011 09:50:57 GMT) Full text and rfc822 format available.

Message #10 received at 534685-done@bugs.debian.org (full text, mbox):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 351684-done@bugs.debian.org,394107-done@bugs.debian.org,431918-done@bugs.debian.org,511727-done@bugs.debian.org,520021-done@bugs.debian.org,524682-done@bugs.debian.org,526747-done@bugs.debian.org,534534-done@bugs.debian.org,534656-done@bugs.debian.org,534683-done@bugs.debian.org,534685-done@bugs.debian.org,534687-done@bugs.debian.org,534699-done@bugs.debian.org,534706-done@bugs.debian.org,534889-done@bugs.debian.org,534892-done@bugs.debian.org,536229-done@bugs.debian.org,546521-done@bugs.debian.org,556968-done@bugs.debian.org,557261-done@bugs.debian.org,561558-done@bugs.debian.org,645805-done@bugs.debian.org,
Cc: openssl098@packages.debian.org, openssl098@packages.qa.debian.org
Subject: Bug#641975: Removed package(s) from unstable
Date: Sat, 19 Nov 2011 09:44:37 +0000
Version: 0.9.8o-7+rm

Dear submitter,

as the package openssl098 has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/641975

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@debian.org.

Debian distribution maintenance software
pp.
Luca Falavigna (the ftpmaster behind the curtain)




Bug No longer marked as fixed in versions 0.9.8o-7+rm and reopened. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 19 Nov 2011 10:57:47 GMT) Full text and rfc822 format available.

Bug reassigned from package 'libssl0.9.8' to 'openssl'. Request was from Kurt Roeckx <kurt@roeckx.be> to control@bugs.debian.org. (Sat, 19 Nov 2011 10:58:00 GMT) Full text and rfc822 format available.

Bug No longer marked as found in versions openssl/0.9.8g-15+lenny1. Request was from Kurt Roeckx <kurt@roeckx.be> to control@bugs.debian.org. (Sat, 19 Nov 2011 10:58:00 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Thu Apr 17 07:56:09 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.