Debian Bug report logs - #532212
openarena: Segfault when deleting non-existent ban address 0

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Guillaume Delacour <gui@iroqwa.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: openarena: Segfault when deleting non-existent ban address 0

Date: Sun, 07 Jun 2009 18:09:11 +0200

Package: openarena
Version: 0.8.1-4
Severity: -1

When trying to delete a banned address with "bandel" command, i do a mistake and delete address with id 0
(non-existent ban list start from #1) in the built-in console and crash the server:

Starting program: /usr/games/openarena-server +set dedicated 2 +exec server1.cfg
[...]
]listbans  
]banaddr 192.168.0.10
Added ban: 192.168.0.10/32
]listbans            
Ban #1: 192.168.0.10/32
Program received signal SIGSEGV, Segmentation fault.
0xb7e226a3 in memmove () from /lib/i686/cmov/libc.so.6
#0  0xb7e226a3 in memmove () from /lib/i686/cmov/libc.so.6
No symbol table info available.
#1  0x08051230 in SV_DelBanFromList (isexception=<value optimized out>) at code/server/sv_ccmds.c:773

The patch attached correct the problem (do nothing if id to del is lower and equal to 0).

-- System Information:
Debian Release: 5.0.1
  APT prefers stable
  APT policy: (500, 'stable'), (100, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages openarena depends on:
ii  libc6                     2.7-18         GNU C Library: Shared libraries
ii  libcurl3-gnutls           7.18.2-8lenny2 Multi-protocol file transfer libra
ii  libgl1-mesa-glx [libgl1]  7.0.3-7        A free implementation of the OpenG
ii  libogg0                   1.1.3-4        Ogg Bitstream Library
ii  libopenal1                1:1.4.272-2    Software implementation of the Ope
ii  libsdl1.2debian           1.2.13-2       Simple DirectMedia Layer
ii  libspeex1                 1.2~rc1-1      The Speex codec runtime library
ii  libspeexdsp1              1.2~rc1-1      The Speex extended runtime library
ii  libvorbis0a               1.2.0.dfsg-3.1 The Vorbis General Audio Compressi
ii  libvorbisfile3            1.2.0.dfsg-3.1 The Vorbis General Audio Compressi
ii  openarena-data            0.8.1-2        OpenArena game data

openarena recommends no packages.

openarena suggests no packages.

-- no debconf information

*** /tmp/sv_ccmds.c.diff
--- /tmp/sv_ccmds.c	2008-08-09 22:22:37.000000000 +0200
+++ /tmp/openarena-0.8.1/code/server/sv_ccmds.c	2009-06-07 17:40:51.000000000 +0200
@@ -752,7 +752,7 @@
 
 	todel = atoi(Cmd_Argv(1));
 
-	if(todel < 0 || todel > serverBansCount)
+	if(todel <= 0 || todel > serverBansCount)
 		return;
 	
 	for(index = count = 0; index < serverBansCount; index++)

Message #10 received at 532212@bugs.debian.org (full text, mbox, reply):

From: Guillaume Delacour <gui@iroqwa.org>

To: 532212@bugs.debian.org

Subject: Additional informations

Date: Sun, 7 Jun 2009 16:15:37 +0200

[Message part 1 (text/plain, inline)]

The correct steps to reproduce:

]listbans  
]banaddr 192.168.0.10
Added ban: 192.168.0.10/32
]listbans            
Ban #1: 192.168.0.10/32
]bandel 0
Program received signal SIGSEGV, Segmentation fault.
0xb7e226a3 in memmove () from /lib/i686/cmov/libc.so.6
#0  0xb7e226a3 in memmove () from /lib/i686/cmov/libc.so.6
No symbol table info available.
#1  0x08051230 in SV_DelBanFromList (isexception=<value optimized out>)
at code/server/sv_ccmds.c:773

The patch previously attached correct the problem (do nothing if id to
del is lower "or" equal to 0).


-- 

Guillaume Delacour

[signature.asc (application/pgp-signature, attachment)]

Message #17 received at submit@bugs.debian.org (full text, mbox, reply):

From: Gonéri Le Bouder <goneri@rulezlan.org>

To: Guillaume Delacour <gui@iroqwa.org>, 532212@bugs.debian.org

Cc: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Re: Bug#532212: openarena: Segfault when deleting non-existent ban address 0

Date: Fri, 21 Aug 2009 23:43:48 +0200

On Sun, Jun 07, 2009 at 06:09:11PM +0200, Guillaume Delacour wrote:

> The patch attached correct the problem (do nothing if id to del is lower and equal to 0).
Thank you for the bug report and the your patch.

Cheers,

     Gonéri

Message #29 received at 532212-close@bugs.debian.org (full text, mbox, reply):

From: Gonéri Le Bouder <goneri@rulezlan.org>

To: 532212-close@bugs.debian.org

Subject: Bug#532212: fixed in openarena 0.8.1-5

Date: Sat, 22 Aug 2009 10:22:31 +0000

Source: openarena
Source-Version: 0.8.1-5

We believe that the bug you reported is fixed in the latest version of
openarena, which is due to be installed in the Debian FTP archive:

openarena-server_0.8.1-5_i386.deb
  to pool/main/o/openarena/openarena-server_0.8.1-5_i386.deb
openarena_0.8.1-5.diff.gz
  to pool/main/o/openarena/openarena_0.8.1-5.diff.gz
openarena_0.8.1-5.dsc
  to pool/main/o/openarena/openarena_0.8.1-5.dsc
openarena_0.8.1-5_i386.deb
  to pool/main/o/openarena/openarena_0.8.1-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 532212@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gonéri Le Bouder <goneri@rulezlan.org> (supplier of updated openarena package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 21 Aug 2009 20:16:35 +0200
Source: openarena
Binary: openarena openarena-server
Architecture: source i386
Version: 0.8.1-5
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Gonéri Le Bouder <goneri@rulezlan.org>
Description: 
 openarena  - fast-paced 3D first-person shooter
 openarena-server - game server for the game OpenArena
Closes: 532212
Changes: 
 openarena (0.8.1-5) unstable; urgency=low
 .
   [ Gonéri Le Bouder ]
   * Segfault when deleting non-existent ban address 0, thanks Guillaume
     Delacour (Closes: #532212)
   * Standards version: 3.8.3
    - README.source to explain how the quilt patch system works
 .
   [ Paul Wise ]
   * Drop the dh_desktop call
Checksums-Sha1: 
 95a4d75f49ccd8edf7cf7d1fad4ac195d8398eae 1455 openarena_0.8.1-5.dsc
 00789398e99a9b6948b4cba48d0a0a9ebeb466e1 24405 openarena_0.8.1-5.diff.gz
 a55266ae2682f6e3b19022abb67604560772e159 733150 openarena_0.8.1-5_i386.deb
 429eb557f45fd9a4ea9892301ee7cd6cab2425e3 365154 openarena-server_0.8.1-5_i386.deb
Checksums-Sha256: 
 b94d42985ae09bf81a3bcd99cd63166e85979e981eb1647326e20c405cf9b44d 1455 openarena_0.8.1-5.dsc
 aaf608f01663c9ed727771b321df046942bd7ec453b0afb0d8922f111b2e5283 24405 openarena_0.8.1-5.diff.gz
 3450c0054948e73b1087e8fd976c0ea8645426e079363bae1004a10a36c7ca81 733150 openarena_0.8.1-5_i386.deb
 c02016f2fdf83d13da360c4ff6226bac2c95e04623db2cfd7afa7d2b57950130 365154 openarena-server_0.8.1-5_i386.deb
Files: 
 f69250303b448b43ab148ac9fc7b2e71 1455 games optional openarena_0.8.1-5.dsc
 ec1cc561eb4512c9c21f439fcacace38 24405 games optional openarena_0.8.1-5.diff.gz
 ccb303d0523b675c5b9aad4e4e7bd98f 733150 games optional openarena_0.8.1-5_i386.deb
 37fdb6aec178fa8f40e62d2c7ae97443 365154 games optional openarena-server_0.8.1-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqPvUYACgkQsKTFpDfZQSyhiwCfYxSu9PDJbEl87H4TqRhErp4z
UxcAn1vxlsrfZWN458ysR6Wyq2aBC03x
=7kdc
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.