Debian Bug report logs - #529059
dkms: please use dpkg-divert

[Message part 1 (text/plain, inline)]
Package: dkms
Version: 2.0.21.1-1
Severity: wishlist

hi,

when dkms installs, it may override an existing kernel module
by a new one. To this end, dkms moves away the old module using 'mv'

But this breaks if the kernel is upated/reinstalled (as for example
after the recent security updates). 

There is though a more effective way, and it is to use dpkg-divert

The attached patch is a proof-of-concept.

a.

-- System Information:
Debian Release: 5.0.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/2 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages dkms depends on:
ii  build-essential               11.4       Informational list of build-essent
ii  dpkg-dev                      1.14.25    Debian package development tools
ii  gcc                           4:4.3.2-2  The GNU C compiler
ii  make                          3.81-5     The GNU version of the "make" util
ii  module-init-tools             3.4-1      tools for managing Linux kernel mo

Versions of packages dkms recommends:
ii  fakeroot                 1.11            Gives a fake root environment
ii  linux-headers-2.6.26-1-6 2.6.26-13lenny2 Header files for Linux 2.6.26-1-68
ii  linux-headers-2.6.26-2-6 2.6.26-15lenny2 Header files for Linux 2.6.26-2-68
ii  linux-image-2.6.26-1-686 2.6.26-13lenny2 Linux 2.6.26 image on PPro/Celeron
ii  linux-image-2.6.26-2-686 2.6.26-15lenny2 Linux 2.6.26 image on PPro/Celeron
ii  lsb-release              3.2-20          Linux Standard Base version report
ii  menu                     2.1.41          generates programs menu for all me
ii  patch                    2.5.9-5         Apply a diff file to an original
ii  sudo                     1.6.9p17-2      Provide limited super user privile

dkms suggests no packages.

-- no debconf information

-- 
Andrea Mennucc
 "E' un mondo difficile. Che vita intensa!" (Tonino Carotone)

[diff2 (text/plain, attachment)]
tags 529059 +pending
thanks

Hello,

     The following change has been committed for this bug by
 Giuseppe Iuculano <giuseppe@iuculano.it> on Mon, 18 May 2009 22:10:30 +0200.
 The fix will be in the next upload. 
=========================================================================
debian/patches/16_dpkg-divert.patch: Use dpkg-divert to override an existing kernel module, thanks to Andrea Mennucci. (Closes: #529059)

when dkms installs, it may override an existing kernel module
by a new one. To this end, dkms moves away the old module using 'mv'

But this breaks if the kernel is upated/reinstalled (as for example
after the recent security updates).

There is though a more effective way, and it is to use dpkg-divert
=========================================================================

You can check the diff of the fix at:

    http://git.debian.org/?p=users/hanska-guest/dkms.git;a=commitdiff;h=f4a197f

[Message part 1 (text/plain, inline)]
Hi,

A Mennucc ha scritto:
> when dkms installs, it may override an existing kernel module
> by a new one. To this end, dkms moves away the old module using 'mv'
> 
> But this breaks if the kernel is upated/reinstalled (as for example
> after the recent security updates). 
> 
> There is though a more effective way, and it is to use dpkg-divert
> 
> The attached patch is a proof-of-concept.

Could you point me a DKMS package that updates an in-tree module? I would like
to test the dpkg-divert patch.

Cheers,
Giuseppe.

[signature.asc (application/pgp-signature, attachment)]
[Message part 1 (text/plain, inline)]
Hi Giuseppe:

If you are using 2.6.30 or later, take a look at the Dell WMI package on
the dell PPA.  http://launchpad.net/dell/ppa/+archive

Regards

Giuseppe Iuculano wrote:
> Hi,
>
>
> A Mennucc ha scritto:
>   
>
> Could you point me a DKMS package that updates an in-tree module? I would like
> to test the dpkg-divert patch.
>
> Cheers,
> Giuseppe.
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Pkg-dkms-maint mailing list
> Pkg-dkms-maint@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-dkms-maint
>   

-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com

[Message part 2 (text/html, inline)]
[signature.asc (application/pgp-signature, attachment)]
[Message part 1 (text/plain, inline)]
Err actually the URL is https://launchpad.net/~dell-team/+archive/ppa .
My bad.

Mario Limonciello wrote:
> Hi Giuseppe:
>
> If you are using 2.6.30 or later, take a look at the Dell WMI package
> on the dell PPA.  http://launchpad.net/dell/ppa/+archive
>
> Regards
>
> Giuseppe Iuculano wrote:
>> Hi,
>>
>>
>> A Mennucc ha scritto:
>>   
>>
>> Could you point me a DKMS package that updates an in-tree module? I would like
>> to test the dpkg-divert patch.
>>
>> Cheers,
>> Giuseppe.
>>
>>   
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Pkg-dkms-maint mailing list
>> Pkg-dkms-maint@lists.alioth.debian.org
>> http://lists.alioth.debian.org/mailman/listinfo/pkg-dkms-maint
>>   
>
> -- 
> Mario Limonciello
> *Dell | Linux Engineering*
> mario_limonciello@dell.com
> ------------------------------------------------------------------------
>
> _______________________________________________
> Pkg-dkms-maint mailing list
> Pkg-dkms-maint@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-dkms-maint
>   

-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com

[Message part 2 (text/html, inline)]
[signature.asc (application/pgp-signature, attachment)]
[Message part 1 (text/plain, inline)]
Hi Mario,

Mario Limonciello ha scritto:
> Hi Giuseppe:
> 
> If you are using 2.6.30 or later, take a look at the Dell WMI package on

Unfortunately I don't have that kernel.

Cheers,
Giuseppe.

[signature.asc (application/pgp-signature, attachment)]
On Fri, May 22, 2009 at 10:27:54PM +0200, Giuseppe Iuculano wrote:
> Could you point me a DKMS package that updates an in-tree module? I would like
> to test the dpkg-divert patch.

hi,

the modules that I know come from 
http://ppa.launchpad.net/mactel-support/ubuntu/pool/main/
and they do delete a kernel modele

for example, the package applesmc-dkms
deletes /lib/modules/2.6.26-2-686/kernel/drivers/hwmon/applesmc.ko
and puts /lib/modules/2.6.26-2-686/updates/dkms/applesmc.ko

a.

ps: I did not test the proposed patch due to another 
DKMS bug I will post later on

hi,

I downloaded  git://git.debian.org/git/users/hanska-guest/dkms.git
and built the Debian package dkmg 2.0.22.0-1
so that I can help in fixing this problem

I am though a bit puzzled by the behaviour of the purpose
 of the code, in particular, around line 1235, at
what is the need for
 $archive_pref1  $archive_pref2 $archive_pref3  $archive_pref4
? 

a.

[Message part 1 (text/plain, inline)]
hi,

this patch against 2.0.22.0-1 
correctly sets the dpkg-diversion for an existing module

but I still could not write some code that would 
remove the diversion on module removal

a.

[d (text/plain, attachment)]
[Message part 1 (text/plain, inline)]
Hi,

A Mennucc ha scritto:
> correctly sets the dpkg-diversion for an existing module

What's the purpose of this patch? By default dkms install the module in
/lib/modules/<kernelversion>/updates/dkms (see override_dest_module_location()
), why we need to divert the old one?

Cheers,

Giuseppe.

[signature.asc (application/pgp-signature, attachment)]
On Sun, Jun 07, 2009 at 07:27:22PM +0200, Giuseppe Iuculano wrote:
> Hi,
> 
> A Mennucc ha scritto:
> > correctly sets the dpkg-diversion for an existing module
> 
> 
> What's the purpose of this patch? By default dkms install the module in
> /lib/modules/<kernelversion>/updates/dkms (see override_dest_module_location()
> ), why we need to divert the old one?

(I am quite puzzled at this moment)

if you have, lets say, two copies of applesmc.ko in the kernel
tree, which version will 'modprobe' load ? 
is there a way to tell?

moreover, AFAICS, dkms (the upstream version) goes to great length to mv 
away the  old module when it installs a new module. There is a lot of 
code to do  that.

a.

[Message part 1 (text/plain, inline)]
On Mon, 2009-06-08 at 09:39 +0200, A Mennucc wrote:
> On Sun, Jun 07, 2009 at 07:27:22PM +0200, Giuseppe Iuculano wrote:
> > Hi,
> > 
> > A Mennucc ha scritto:
> > > correctly sets the dpkg-diversion for an existing module
> > 
> > 
> > What's the purpose of this patch? By default dkms install the module in
> > /lib/modules/<kernelversion>/updates/dkms (see override_dest_module_location()
> > ), why we need to divert the old one?
> 
> (I am quite puzzled at this moment)
> 
> if you have, lets say, two copies of applesmc.ko in the kernel
> tree, which version will 'modprobe' load ? 
> is there a way to tell?
[...]

It will load the one under the "updates" subdirectory.

Ben.

-- 
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky

[signature.asc (application/pgp-signature, inline)]
[Message part 1 (text/plain, inline)]
A Mennucc ha scritto:
> moreover, AFAICS, dkms (the upstream version) goes to great length to mv 
> away the  old module when it installs a new module. There is a lot of 
> code to do  that.

Yes, but my last patch removes that code.

Cheers,
Giuseppe.

[signature.asc (application/pgp-signature, attachment)]
Source: dkms
Source-Version: 2.0.22.0-1

We believe that the bug you reported is fixed in the latest version of
dkms, which is due to be installed in the Debian FTP archive:

dkms_2.0.22.0-1.diff.gz
  to pool/main/d/dkms/dkms_2.0.22.0-1.diff.gz
dkms_2.0.22.0-1.dsc
  to pool/main/d/dkms/dkms_2.0.22.0-1.dsc
dkms_2.0.22.0-1_all.deb
  to pool/main/d/dkms/dkms_2.0.22.0-1_all.deb
dkms_2.0.22.0.orig.tar.gz
  to pool/main/d/dkms/dkms_2.0.22.0.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 529059@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Giuseppe Iuculano <giuseppe@iuculano.it> (supplier of updated dkms package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Format: 1.8
Date: Fri, 05 Jun 2009 22:00:35 +0200
Source: dkms
Binary: dkms
Architecture: source all
Version: 2.0.22.0-1
Distribution: unstable
Urgency: low
Maintainer: Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>
Changed-By: Giuseppe Iuculano <giuseppe@iuculano.it>
Description: 
 dkms       - Dynamic Kernel Module Support Framework
Closes: 529038 529059
Changes: 
 dkms (2.0.22.0-1) unstable; urgency=low
 .
   * [023618e] Imported Upstream version 2.0.22.0
   * [d6e0b15] Deleted patches merged in upstream: 01-fix_manpage.patch
     02-fix_distribution.patch 04-use_su-to-root.patch 05-
     do_not_check_admin_group.patch 06-fakeroot.patch 07-exit-if-build-
     fails.patch 09-lilo_detection.patch 10-lsb.patch 11-bash-
     completion.patch 12-use_invoke-rc.d.patch 13-template.patch
     14_new_module-init-tools.patch 08-support_kernel-img.conf.patch
   * [c5b7822] debian/patches/15_modprobe.patch: do not create an empty
     /etc/modprobe.d/package_name.conf. It is opened and parsed every
     time modprobe is run (and it is run very often at boot time). Create
     it only if necessary.
   * [3731c00] debian/patches/08-support_kernel-img.conf.patch: Use
     update-initramfs, it is the default in Debian/Ubuntu and it also computes
     and stores some checksums. (Closes: #529038)
   * [f4a197f] debian/patches/16_old_module.patch: Do not move away the old
     module, by default dkms install the new one in
     /lib/modules/<kernelversion>/updates/dkms (Closes: #529059)
   * [db7ffe7] debian/patches/01_kernel_postinst.patch: shut up "which" in the
     the kernel kernel_postinst.d script, only the exit code is needed.
Checksums-Sha1: 
 a34c0ea7e1133e00e1d2c25ab555e322a8e39d66 1284 dkms_2.0.22.0-1.dsc
 7fd3224e80ffdb50e5a8d17113405229a6f3a55c 71546 dkms_2.0.22.0.orig.tar.gz
 5a76341573499701e907abbe833e8caff5c01652 8502 dkms_2.0.22.0-1.diff.gz
 306bf3ccb7d7df8ba6d64982ca320ebcde66ea58 58496 dkms_2.0.22.0-1_all.deb
Checksums-Sha256: 
 28617808a0b57b7c86368e56c4842b230ef6292c2199b7829672ea2de74f54bd 1284 dkms_2.0.22.0-1.dsc
 1e3377b4e9c754e28cae2aa1ff6463467ad3ba74761fc281f47658f937b22307 71546 dkms_2.0.22.0.orig.tar.gz
 8c1943611e931a4ab230419d48dbb18f3a1b12d8fd59531263b9eead021825df 8502 dkms_2.0.22.0-1.diff.gz
 9a88c12ef21f3335b4c4c4e1ddab3c11de6e9500c48c32c04a56cd79120d4fb2 58496 dkms_2.0.22.0-1_all.deb
Files: 
 ce277d574edd7fc28c83a1b6ab1839d6 1284 kernel optional dkms_2.0.22.0-1.dsc
 3e10e107ea46f57af39912fcd300fc72 71546 kernel optional dkms_2.0.22.0.orig.tar.gz
 6df9b967fd3750c33244ac149d40dfc0 8502 kernel optional dkms_2.0.22.0-1.diff.gz
 e20068d358021e87fb488a27ae253a93 58496 kernel optional dkms_2.0.22.0-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFKP+hZ79ZNCRIGYgcRA8bLAJ4+yJdl53V9yXeC/uYgXOcL4OG45ACfeL0v
FetGoSPhXMh7bWKBuqglXmw=
=9wGD
-----END PGP SIGNATURE-----

Debian Bug report logs - #529059 dkms: please use dpkg-divert

Debian Bug report logs - #529059
dkms: please use dpkg-divert