Debian Bug report logs - #527714
pornview: FTBFS: gtkcellrendererpixmap.h:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gtk_cell_renderer_pixmap_get_type'

version graph

Package: pornview; Maintainer for pornview is (unknown);

Reported by: Lucas Nussbaum <lucas@lucas-nussbaum.net>

Date: Fri, 8 May 2009 18:00:47 UTC

Severity: serious

Tags: patch

Found in version pornview/0.2pre1-9

Fixed in versions pornview/0.2pre1-11, 0.2pre1-11.1+rm

Done: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, anderson@netsweng.com (Stuart R. Anderson):
Bug#527714; Package pornview. (Fri, 08 May 2009 18:00:50 GMT) (full text, mbox, link).


Acknowledgement sent to Lucas Nussbaum <lucas@lucas-nussbaum.net>:
New Bug report received and forwarded. Copy sent to anderson@netsweng.com (Stuart R. Anderson). (Fri, 08 May 2009 18:00:50 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Lucas Nussbaum <lucas@lucas-nussbaum.net>
To: submit@bugs.debian.org
Subject: pornview: FTBFS: gtkcellrendererpixmap.h:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gtk_cell_renderer_pixmap_get_type'
Date: Fri, 8 May 2009 19:45:35 +0200
Package: pornview
Version: 0.2pre1-9
Severity: serious
User: debian-qa@lists.debian.org
Usertags: qa-ftbfs-20090508 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -D_REENTRANT -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I../ -Wall -g -O2 -Wall -c gtkcellrendererpixmap.c  -fPIC -DPIC -o gtkcellrendererpixmap.lo
> In file included from gtkcellrendererpixmap.c:19:
> gtkcellrendererpixmap.h:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gtk_cell_renderer_pixmap_get_type'
> gtkcellrendererpixmap.c:63: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gtk_cell_renderer_pixmap_get_type'
> gtkcellrendererpixmap.c: In function 'gtk_cell_renderer_pixmap_get_property':
> gtkcellrendererpixmap.c:168: warning: implicit declaration of function 'GTK_CHECK_CAST'
> gtkcellrendererpixmap.c:168: warning: implicit declaration of function 'gtk_cell_renderer_pixmap_get_type'
> gtkcellrendererpixmap.c:168: error: expected expression before 'GtkCellRendererPixmap'
> gtkcellrendererpixmap.c:168: warning: initialization makes pointer from integer without a cast
> gtkcellrendererpixmap.c: In function 'gtk_cell_renderer_pixmap_set_property':
> gtkcellrendererpixmap.c:220: error: expected expression before 'GtkCellRendererPixmap'
> gtkcellrendererpixmap.c:220: warning: initialization makes pointer from integer without a cast
> make[6]: *** [gtkcellrendererpixmap.lo] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2009/05/08/pornview_0.2pre1-9_lsid64.buildlog

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.

-- 
| Lucas Nussbaum
| lucas@lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
| jabber: lucas@nussbaum.fr             GPG: 1024D/023B3F4F |




Information forwarded to debian-bugs-dist@lists.debian.org, anderson@netsweng.com (Stuart R. Anderson):
Bug#527714; Package pornview. (Mon, 14 Sep 2009 02:36:04 GMT) (full text, mbox, link).


Acknowledgement sent to Daniel Leidert <daniel.leidert@wgdd.de>:
Extra info received and forwarded to list. Copy sent to anderson@netsweng.com (Stuart R. Anderson). (Mon, 14 Sep 2009 02:36:04 GMT) (full text, mbox, link).


Message #10 received at 527714@bugs.debian.org (full text, mbox, reply):

From: Daniel Leidert <daniel.leidert@wgdd.de>
To: Debian Bug Tracking System <527714@bugs.debian.org>
Subject: Proposed fix
Date: Mon, 14 Sep 2009 04:32:20 +0200
[Message part 1 (text/plain, inline)]
Package: pornview
Version: 0.2pre1-9
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The issue is caused by gtkcellrendererpixmap.c defining
GTK_DISABLE_DEPRECATED. Commenting it makes the package build.

Patch attached.

Regards, Daniel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkqtqy8ACgkQm0bx+wiPa4zNDwCg1AyeKn4WY+EY7P95TBcaEK8Y
7uwAn33mzlvp5NKgc24ZfGrEZbnGOIOA
=GFIF
-----END PGP SIGNATURE-----
[pornview-0.2pre1_src_support_widgets_gtkcellrendererpixmap.c (text/x-c, attachment)]

Added tag(s) patch. Request was from Daniel Leidert (dale) <daniel.leidert@wgdd.de> to control@bugs.debian.org. (Mon, 14 Sep 2009 02:36:12 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, anderson@netsweng.com (Stuart R. Anderson):
Bug#527714; Package pornview. (Sat, 14 Nov 2009 13:12:06 GMT) (full text, mbox, link).


Acknowledgement sent to "M. van Brummelen" <martijn@brumit.nl>:
Extra info received and forwarded to list. Copy sent to anderson@netsweng.com (Stuart R. Anderson). (Sat, 14 Nov 2009 13:12:06 GMT) (full text, mbox, link).


Message #17 received at 527714@bugs.debian.org (full text, mbox, reply):

From: "M. van Brummelen" <martijn@brumit.nl>
To: 527714@bugs.debian.org
Subject: patch
Date: Sat, 14 Nov 2009 14:09:35 +0100
[Message part 1 (text/plain, inline)]
Hi,

Like suggested I added quilt to Build-Depends added a directory
"patches" in /debian.  I placed he patch into the patches directory and
renamed it to gtkcellrendererpixmap_fix .
I fixed the rules file so it invokes dh_quilt_patch/dh_quilt_unpatch .

I also preppered a NMU package on mentors.debian.net but I did not ask
for a sponsor yet.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/p/pornview
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget
http://mentors.debian.net/debian/pool/main/p/pornview/pornview_0.2pre1-9.1.dsc

Regards,
Martijn van Brummelen
[pornview_0.2pre1-9.1.dsc.diff (text/x-patch, inline)]
diff -u pornview-0.2pre1/debian/changelog pornview-0.2pre1/debian/changelog
--- pornview-0.2pre1/debian/changelog
+++ pornview-0.2pre1/debian/changelog
@@ -1,3 +1,13 @@
+pornview (0.2pre1-9.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Added quilt to Build-Depends
+  * Added directory patches
+  * Added gtkcellrendererpixmap_fix to patches directory (Closes: #527714)
+  * Invoke dh_quilt_patch/dh_quilt_unpatch in rules file
+
+ -- Martijn van Brummelen <martijn@brumit.nl>  Sat, 14 Nov 2009 13:08:19 +0100
+
 pornview (0.2pre1-9) unstable; urgency=low
 
   * Avoid crash if we don't get a valid iterator. (Closes: #485820) 
diff -u pornview-0.2pre1/debian/control pornview-0.2pre1/debian/control
--- pornview-0.2pre1/debian/control
+++ pornview-0.2pre1/debian/control
@@ -2,7 +2,7 @@
 Section: utils
 Priority: optional
 Maintainer: Stuart R. Anderson <anderson@netsweng.com>
-Build-Depends: debhelper (>> 4.0.0), libgtk2.0-dev, libpng12-0-dev, libxine-dev (>= 1-beta1-1)
+Build-Depends: debhelper (>> 4.0.0), libgtk2.0-dev, libpng12-0-dev, libxine-dev (>= 1-beta1-1), quilt
 Standards-Version: 3.7.2
 
 Package: pornview
diff -u pornview-0.2pre1/debian/rules pornview-0.2pre1/debian/rules
--- pornview-0.2pre1/debian/rules
+++ pornview-0.2pre1/debian/rules
@@ -26,6 +26,7 @@
 
 build-stamp:  config.status
 	dh_testdir
+	dh_quilt_patch
 
 	$(MAKE)
 
@@ -34,6 +35,7 @@
 clean:
 	dh_testdir
 	rm -f build-stamp 
+	dh_quilt_unpatch
 
 	-$(MAKE) distclean
 
only in patch2:
unchanged:
--- pornview-0.2pre1.orig/debian/patches/series
+++ pornview-0.2pre1/debian/patches/series
@@ -0,0 +1,2 @@
+#fix stupid bug
+gtkcellrendererpixmap_fix
only in patch2:
unchanged:
--- pornview-0.2pre1.orig/debian/patches/gtkcellrendererpixmap_fix
+++ pornview-0.2pre1/debian/patches/gtkcellrendererpixmap_fix
@@ -0,0 +1,14 @@
+--- pornview-0.2pre1.orig/src/support/widgets/gtkcellrendererpixmap.c
++++ pornview-0.2pre1/src/support/widgets/gtkcellrendererpixmap.c
+@@ -12,9 +12,9 @@
+  *  Copyright (C) 2000  Red Hat, Inc.,  Jonathan Blandford <jrb@redhat.com>
+  */
+ 
+-#ifndef GTK_DISABLE_DEPRECATED
++/* #ifndef GTK_DISABLE_DEPRECATED
+ #define GTK_DISABLE_DEPRECATED
+-#endif /* GTK_DISABLE_DEPRECATED */
++#endif */ /* GTK_DISABLE_DEPRECATED */
+ 
+ #include "gtkcellrendererpixmap.h"
+ 
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, anderson@netsweng.com (Stuart R. Anderson):
Bug#527714; Package pornview. (Sat, 14 Nov 2009 16:42:02 GMT) (full text, mbox, link).


Acknowledgement sent to "M. van Brummelen" <martijn@brumit.nl>:
Extra info received and forwarded to list. Copy sent to anderson@netsweng.com (Stuart R. Anderson). (Sat, 14 Nov 2009 16:42:03 GMT) (full text, mbox, link).


Message #22 received at 527714@bugs.debian.org (full text, mbox, reply):

From: "M. van Brummelen" <martijn@brumit.nl>
To: 527714@bugs.debian.org
Subject: patch
Date: Sat, 14 Nov 2009 17:40:14 +0100
[Message part 1 (text/plain, inline)]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Like suggested I added quilt to Build-Depends added a directory
"patches" in /debian.  I placed the patch into the patches directory and
renamed it to gtkcellrendererpixmap_fix, I added some comment to the
series file .
I fixed the rules file so it invokes dh_quilt_patch/dh_quilt_unpatch .

I also preppered a NMU package on mentors.debian.net but I did not ask
for a sponsor yet.

The package can be found on mentors.debian.net:
- - URL: http://mentors.debian.net/debian/pool/main/p/pornview
- - Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- - dget
http://mentors.debian.net/debian/pool/main/p/pornview/pornview_0.2pre1-9.1.dsc

Regards,
Martijn van Brummelen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkr+3W0ACgkQ4yGTtsQpvi+ElgCeImGT8i3f84CS7knj3IVPzp1R
gSMAn1uByJ4KbVQ4kmaGtKCeUpx+ju1E
=OG1G
-----END PGP SIGNATURE-----
[pornview_0.2pre1-9.1.dsc.diff (text/x-patch, inline)]
diff -u pornview-0.2pre1/debian/changelog pornview-0.2pre1/debian/changelog
--- pornview-0.2pre1/debian/changelog
+++ pornview-0.2pre1/debian/changelog
@@ -1,3 +1,13 @@
+pornview (0.2pre1-9.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Added quilt to Build-Depends
+  * Added directory patches
+  * Added gtkcellrendererpixmap_fix to patches directory (Closes: #527714)
+  * Invoke dh_quilt_patch/dh_quilt_unpatch in rules file
+
+ -- Martijn van Brummelen <martijn@brumit.nl>  Sat, 14 Nov 2009 13:08:19 +0100
+
 pornview (0.2pre1-9) unstable; urgency=low
 
   * Avoid crash if we don't get a valid iterator. (Closes: #485820) 
diff -u pornview-0.2pre1/debian/control pornview-0.2pre1/debian/control
--- pornview-0.2pre1/debian/control
+++ pornview-0.2pre1/debian/control
@@ -2,7 +2,7 @@
 Section: utils
 Priority: optional
 Maintainer: Stuart R. Anderson <anderson@netsweng.com>
-Build-Depends: debhelper (>> 4.0.0), libgtk2.0-dev, libpng12-0-dev, libxine-dev (>= 1-beta1-1)
+Build-Depends: debhelper (>> 4.0.0), libgtk2.0-dev, libpng12-0-dev, libxine-dev (>= 1-beta1-1), quilt
 Standards-Version: 3.7.2
 
 Package: pornview
diff -u pornview-0.2pre1/debian/rules pornview-0.2pre1/debian/rules
--- pornview-0.2pre1/debian/rules
+++ pornview-0.2pre1/debian/rules
@@ -26,6 +26,7 @@
 
 build-stamp:  config.status
 	dh_testdir
+	dh_quilt_patch
 
 	$(MAKE)
 
@@ -34,6 +35,7 @@
 clean:
 	dh_testdir
 	rm -f build-stamp 
+	dh_quilt_unpatch
 
 	-$(MAKE) distclean
 
only in patch2:
unchanged:
--- pornview-0.2pre1.orig/debian/patches/series
+++ pornview-0.2pre1/debian/patches/series
@@ -0,0 +1,2 @@
+#fix FTBFS bug (Closes: #527714) 
+gtkcellrendererpixmap_fix
only in patch2:
unchanged:
--- pornview-0.2pre1.orig/debian/patches/gtkcellrendererpixmap_fix
+++ pornview-0.2pre1/debian/patches/gtkcellrendererpixmap_fix
@@ -0,0 +1,14 @@
+--- pornview-0.2pre1.orig/src/support/widgets/gtkcellrendererpixmap.c
++++ pornview-0.2pre1/src/support/widgets/gtkcellrendererpixmap.c
+@@ -12,9 +12,9 @@
+  *  Copyright (C) 2000  Red Hat, Inc.,  Jonathan Blandford <jrb@redhat.com>
+  */
+ 
+-#ifndef GTK_DISABLE_DEPRECATED
++/* #ifndef GTK_DISABLE_DEPRECATED
+ #define GTK_DISABLE_DEPRECATED
+-#endif /* GTK_DISABLE_DEPRECATED */
++#endif */ /* GTK_DISABLE_DEPRECATED */
+ 
+ #include "gtkcellrendererpixmap.h"
+ 
[pornview_0.2pre1-9.1.dsc.diff.sig (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, anderson@netsweng.com (Stuart R. Anderson):
Bug#527714; Package pornview. (Sat, 14 Nov 2009 17:12:03 GMT) (full text, mbox, link).


Acknowledgement sent to Stuart Anderson <anderson@netsweng.com>:
Extra info received and forwarded to list. Copy sent to anderson@netsweng.com (Stuart R. Anderson). (Sat, 14 Nov 2009 17:12:03 GMT) (full text, mbox, link).


Message #27 received at 527714@bugs.debian.org (full text, mbox, reply):

From: Stuart Anderson <anderson@netsweng.com>
To: "M. van Brummelen" <martijn@brumit.nl>, 527714@bugs.debian.org
Subject: Re: Bug#527714: patch
Date: Sat, 14 Nov 2009 12:00:40 -0500 (EST)
Martijn,
 	That's for the work here! Please give me a few days to dust things
off, and I'll take your patch and just make a normal upload with it (and
possibly one other). If for some reason, I don't accomplish that, then your
NMU is OK with me.



                                 Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149




Information stored :
Bug#527714; Package pornview. (Wed, 18 Nov 2009 00:06:15 GMT) (full text, mbox, link).


Acknowledgement sent to Tim Retout <tim@retout.co.uk>:
Extra info received and filed, but not forwarded. (Wed, 18 Nov 2009 00:06:16 GMT) (full text, mbox, link).


Message #32 received at 527714-quiet@bugs.debian.org (full text, mbox, reply):

From: Tim Retout <tim@retout.co.uk>
To: Martijn van Brummelen <martijn@brumit.nl>
Cc: 527714-quiet@bugs.debian.org, 516338-quiet@bugs.debian.org, anderson@netsweng.com
Subject: pornview NMU
Date: Wed, 18 Nov 2009 00:01:30 +0000
Martijn, FYI there's now a patch for #516338 as well, which should be
included if you end up doing an NMU.

Regards,

-- 
Tim Retout <tim@retout.co.uk>




Information stored :
Bug#527714; Package pornview. (Mon, 23 Nov 2009 02:57:06 GMT) (full text, mbox, link).


Acknowledgement sent to Stuart Anderson <anderson@netsweng.com>:
Extra info received and filed, but not forwarded. (Mon, 23 Nov 2009 02:57:06 GMT) (full text, mbox, link).


Message #37 received at 527714-quiet@bugs.debian.org (full text, mbox, reply):

From: Stuart Anderson <anderson@netsweng.com>
To: 516338-quiet@bugs.debian.org
Cc: 527714-quiet@bugs.debian.org
Subject: Re: Bug#516338: pornview NMU
Date: Sun, 22 Nov 2009 21:45:26 -0500 (EST)
I've never seen these issue on a 32-bit pornview, but can reproduce them on
a 64-bit version. I suspect there is some underlying problem here that needs
to be found and fixed. Looking at these patches, I don't see where 32-vs-64
would matter, so I suspect they are fixing the symptom, but not the problem.

These fixes do make pornview usable on 64-bit systems, and are appreciated.
I'll use them if I can't figure out what's really going on w/ a 64-bit build.


                                Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                 BD03 0A62 E534 37A7 9149




Information stored :
Bug#527714; Package pornview. (Mon, 23 Nov 2009 23:27:16 GMT) (full text, mbox, link).


Acknowledgement sent to Tim Retout <tim@retout.co.uk>:
Extra info received and filed, but not forwarded. (Mon, 23 Nov 2009 23:27:16 GMT) (full text, mbox, link).


Message #42 received at 527714-quiet@bugs.debian.org (full text, mbox, reply):

From: Tim Retout <tim@retout.co.uk>
To: Stuart Anderson <anderson@netsweng.com>
Cc: 516338-quiet@bugs.debian.org, 527714-quiet@bugs.debian.org
Subject: Re: Bug#516338: pornview NMU
Date: Mon, 23 Nov 2009 23:24:54 +0000
Hi Stuart,

I don't think there's anything complicated going on here. The 'priv'
pointer is not initialized to NULL in 'cb_tree_cursor_changed', so
contains random memory values.

On i386 this happens to work a lot of the time, but produces garbage:

(gdb) print priv
$1 = (PrefsWinPagePrivate *) 0xbfffcd38
(gdb) print priv->page
$2 = (PrefsWinPage *) 0xbfffcd58
(gdb) print priv->page->path
$3 = (const gchar * const) 0xbfffcde8 "\b\317\377\277\017o\215\267\270>\036\b"

On amd64 it doesn't:

(gdb) print priv
$3 = (PrefsWinPagePrivate *) 0x415a78
(gdb) print priv->page
$4 = (PrefsWinPage *) 0xd06800278d1a25ff
(gdb) print priv->page->path
Cannot access memory at address 0xd06800278d1a25ff

Note that priv->page->path is meant to be a human-readable string like
"/General".

I can confirm that the other bug (#527714) happens on my i386 sid
system, and is also happening on the buildds for kfreebsd-i386.

Regards,

-- 
Tim Retout <tim@retout.co.uk>




Bug Marked as fixed in versions pornview/0.2pre1-11. Request was from Luk Claes <luk@debian.org> to control@bugs.debian.org. (Sat, 28 Nov 2009 16:48:14 GMT) (full text, mbox, link).


Reply sent to Debian FTP Masters <ftpmaster@ftp-master.debian.org>:
You have taken responsibility. (Thu, 26 Jul 2012 15:54:29 GMT) (full text, mbox, link).


Notification sent to Lucas Nussbaum <lucas@lucas-nussbaum.net>:
Bug acknowledged by developer. (Thu, 26 Jul 2012 15:54:29 GMT) (full text, mbox, link).


Message #49 received at 527714-done@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 171969-done@bugs.debian.org,193778-done@bugs.debian.org,200865-done@bugs.debian.org,432536-done@bugs.debian.org,527714-done@bugs.debian.org,557732-done@bugs.debian.org,588615-done@bugs.debian.org,665738-done@bugs.debian.org,
Cc: pornview@packages.debian.org, pornview@packages.qa.debian.org
Subject: Bug#682757: Removed package(s) from unstable
Date: Thu, 26 Jul 2012 15:52:41 +0000
Version: 0.2pre1-11.1+rm

Dear submitter,

as the package pornview has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/682757

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@debian.org.

Debian distribution maintenance software
pp.
Alexander Reichle-Schmehl (the ftpmaster behind the curtain)



Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 24 Aug 2012 07:25:55 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sat Jan 13 21:31:22 2018; Machine Name: beach

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.