Debian Bug report logs - #524190
bash-completion: SSH completion of know hosts doesn't handle multiple host files

version graph

Package: bash-completion; Maintainer for bash-completion is Gabriel F. T. Gomes <gabriel@debian.org>; Source for bash-completion is src:bash-completion (PTS, buildd, popcon).

Reported by: Thomas Nilsson <thomas.nilsson@unixangst.com>

Date: Wed, 15 Apr 2009 11:45:01 UTC

Severity: normal

Tags: confirmed, fixed-upstream, upstream

Merged with 525293

Found in version bash-completion/1:1.0-2

Fixed in version bash-completion/1:1.1-1

Done: David Paleino <d.paleino@gmail.com>

Bug is archived. No further changes may be made.

Forwarded to https://alioth.debian.org/tracker/?func=detail&aid=311595

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, thomas.nilsson@unixangst.com, Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>:
Bug#524190; Package bash-completion. (Wed, 15 Apr 2009 11:45:04 GMT) (full text, mbox, link).


Acknowledgement sent to Thomas Nilsson <thomas.nilsson@unixangst.com>:
New Bug report received and forwarded. Copy sent to thomas.nilsson@unixangst.com, Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>. (Wed, 15 Apr 2009 11:45:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Thomas Nilsson <thomas.nilsson@unixangst.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: bash-completion: SSH completion of know hosts doesn't handle multiple host files
Date: Wed, 15 Apr 2009 13:41:55 +0200
[Message part 1 (text/plain, inline)]
Package: bash-completion
Version: 1:1.0-2
Severity: normal
Tags: patch


I have a few IPs that has their OS replaced on a regular basis, for
these I have /dev/null set as their UserKnownHostsFile.

The eval line used to expand $HOME etc, is dangerous (probably only for
the users of a system if you have a BOFH). With multiple entries the
next entry will be tried to be executed;

knirch@traktor:~$ grep UserKnownHostsFile .ssh/config 
	UserKnownHostsFile "/tmp/lo l"
	#UserKnownHostsFile /dev/null
	UserKnownHostsFile /dev/null
knirch@traktor:~$ ssh [TAB]bash: /dev/null: Permission denied

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=sv_SE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages bash-completion depends on:
ii  bash                          3.2-5      The GNU Bourne Again SHell

bash-completion recommends no packages.

bash-completion suggests no packages.

-- debconf-show failed
[support_multiple_hosts_files.patch (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>:
Bug#524190; Package bash-completion. (Wed, 15 Apr 2009 12:36:06 GMT) (full text, mbox, link).


Acknowledgement sent to David Paleino <d.paleino@gmail.com>:
Extra info received and forwarded to list. Copy sent to Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>. (Wed, 15 Apr 2009 12:36:06 GMT) (full text, mbox, link).


Message #10 received at 524190@bugs.debian.org (full text, mbox, reply):

From: David Paleino <d.paleino@gmail.com>
To: bash-completion-devel@lists.alioth.debian.org
Cc: Thomas Nilsson <thomas.nilsson@unixangst.com>, 524190@bugs.debian.org
Subject: Re: [Bash-completion-devel] Bug#524190: bash-completion: SSH completion of know hosts doesn't handle multiple host files
Date: Wed, 15 Apr 2009 14:34:08 +0200
[Message part 1 (text/plain, inline)]
forwarded 524190 https://alioth.debian.org/tracker/?func=detail&aid=311595
tags 524190 upstream confirmed
thanks

Hello Thomas,

On Wed, 15 Apr 2009 13:41:55 +0200, Thomas Nilsson wrote:

> Package: bash-completion
> Version: 1:1.0-2
> Severity: normal
> Tags: patch

Thank you for the patch! From a quick look, I believe we'll merge it upstream.
I'll ask for comments to other team members though.

> [..]
> 
> The eval line used to expand $HOME etc, is dangerous (probably only for
> the users of a system if you have a BOFH). With multiple entries the
> next entry will be tried to be executed;

This is a known issue, already reported in our upstream tracker (see the URL
above).

Thank you for reporting,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
[signature.asc (application/pgp-signature, attachment)]

Noted your statement that Bug has been forwarded to https://alioth.debian.org/tracker/?func=detail&aid=311595. Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Wed, 15 Apr 2009 12:36:10 GMT) (full text, mbox, link).


Tags added: upstream, confirmed Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Wed, 15 Apr 2009 12:36:10 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>:
Bug#524190; Package bash-completion. (Wed, 15 Apr 2009 13:03:13 GMT) (full text, mbox, link).


Acknowledgement sent to bash-completion-devel@lists.alioth.debian.org:
Extra info received and forwarded to list. Copy sent to Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>. (Wed, 15 Apr 2009 13:03:13 GMT) (full text, mbox, link).


Message #19 received at 524190@bugs.debian.org (full text, mbox, reply):

From: bash-completion-devel@lists.alioth.debian.org
To: David Paleino <d.paleino@gmail.com>
Cc: Thomas Nilsson <thomas.nilsson@unixangst.com>, 524190@bugs.debian.org
Subject: Re: [Bash-completion-devel] Bug#524190: bash-completion: SSH completion of know hosts doesn't handle multiple host files
Date: Wed, 15 Apr 2009 14:57:12 +0200
David Paleino wrote:

>> The eval line used to expand $HOME etc, is dangerous (probably only for
>> the users of a system if you have a BOFH). With multiple entries the
>> next entry will be tried to be executed;
> 
> This is a known issue, already reported in our upstream tracker (see the URL
> above).

The patch solves half that problem (but won't help if the file is 
defined like $() `` etc)




Tags removed: patch Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Thu, 18 Jun 2009 10:36:02 GMT) (full text, mbox, link).


Tags added: fixed-upstream Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Thu, 18 Jun 2009 10:36:04 GMT) (full text, mbox, link).


Forcibly Merged 524190 525293. Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Thu, 18 Jun 2009 10:36:04 GMT) (full text, mbox, link).


Added tag(s) pending. Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Wed, 16 Sep 2009 12:42:08 GMT) (full text, mbox, link).


Reply sent to David Paleino <d.paleino@gmail.com>:
You have taken responsibility. (Sat, 10 Oct 2009 17:06:09 GMT) (full text, mbox, link).


Notification sent to Thomas Nilsson <thomas.nilsson@unixangst.com>:
Bug acknowledged by developer. (Sat, 10 Oct 2009 17:06:09 GMT) (full text, mbox, link).


Message #32 received at 524190-close@bugs.debian.org (full text, mbox, reply):

From: David Paleino <d.paleino@gmail.com>
To: 524190-close@bugs.debian.org
Subject: Bug#524190: fixed in bash-completion 1:1.1-1
Date: Sat, 10 Oct 2009 16:47:18 +0000
Source: bash-completion
Source-Version: 1:1.1-1

We believe that the bug you reported is fixed in the latest version of
bash-completion, which is due to be installed in the Debian FTP archive:

bash-completion_1.1-1.diff.gz
  to pool/main/b/bash-completion/bash-completion_1.1-1.diff.gz
bash-completion_1.1-1.dsc
  to pool/main/b/bash-completion/bash-completion_1.1-1.dsc
bash-completion_1.1-1_all.deb
  to pool/main/b/bash-completion/bash-completion_1.1-1_all.deb
bash-completion_1.1.orig.tar.gz
  to pool/main/b/bash-completion/bash-completion_1.1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 524190@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Paleino <d.paleino@gmail.com> (supplier of updated bash-completion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 10 Oct 2009 18:11:00 +0200
Source: bash-completion
Binary: bash-completion
Architecture: source all
Version: 1:1.1-1
Distribution: unstable
Urgency: low
Maintainer: d.paleino@gmail.com
Changed-By: David Paleino <d.paleino@gmail.com>
Description: 
 bash-completion - programmable completion for the bash shell
Closes: 504213 518561 524190 524961 531337 531343 534901 535105 535585 540033 544024 545743 545978 547550
Changes: 
 bash-completion (1:1.1-1) unstable; urgency=low
 .
   * New upstream release
     - fix svk completion using $filenames instead of $default
       (Closes: #524961)
     - fix typo in .ass subtitles completion for mplayer
       (Closes: #531337)
     - fix regression on man(1) completion: also complete on local .3pm
       files (Closes: #531343)
     - added avahi-discovered hosts to _known_hosts_real()
       (Closes: #518561)
     - added m4v completion to mplayer (Closes: #504213)
     - improve qemu completion (Closes: #534901)
     - added sshfs completion (shares the same as scp) (Closes: #545978)
     - added --no-generate to "apt-cache pkgnames" calls, make it faster
       on certain configurations (Closes: #547550)
     - add *.ogv to xine-based players (Closes: #540033)
     - fix sbcl file/dirname completion (Closes: #545743)
     - fix _quote_readline on bash 4 (Closes: #544024)
     - patched _known_hosts() to support multiple
       {Global,User}KnownHosts in SSH config files, thanks to Thomas
       Nilsson (Closes: #524190)
     - fix completing multiple hosts (Closes: #535585)
   * debian/extra/bash-completion.pm moved to bash_completion.pm
     (Closes: #535105)
   * debian/patches/ removed, merged upstream
   * debian/rules:
     - passing debian/CHANGES to dh_installchangelogs, it's missing from
       upstream tarball :(
     - rewritten using dh7
   * debian/control:
     - debhelper Build-Dependency bumped to >= 7.0.50
     - removed quilt Build-Dependency, no more used
     - added ${misc:Depends} dependency
     - Standards-Version bumped to 3.8.3, no changes needed
   * debian/compat bumped to 7
   * debian/docs added
   * debian/install updated, using upstream buildsystem
Checksums-Sha1: 
 a489a8bf5170f225b095bceb87799f23828fe2bf 1317 bash-completion_1.1-1.dsc
 0e666ebda3d577571ab62bcecc16e1024922cd18 163598 bash-completion_1.1.orig.tar.gz
 7ab79801fa680b8c7855f30a160c06b78e4dc710 15493 bash-completion_1.1-1.diff.gz
 b6cbe3b49e729bcd77c2a11e24af62ebb3f73d70 126996 bash-completion_1.1-1_all.deb
Checksums-Sha256: 
 055ac8a7cf5eb335a871017b63031946a127c3f7ef2c869a72dbf996a2dda047 1317 bash-completion_1.1-1.dsc
 53369b32493b58c3d0d7d45630c329faa3ca209ed6e7a6c5392a19e67904721b 163598 bash-completion_1.1.orig.tar.gz
 7911adcce7ce05951186bd4d875e5e1527d870ae9fc7e91f663fb58c2778adce 15493 bash-completion_1.1-1.diff.gz
 acfe70a65d6a162677c0de8e6711f49510d8916e5058e1e2bca1259ec3b8cc19 126996 bash-completion_1.1-1_all.deb
Files: 
 4443a225e5af2f644f7457aac8c8c7ed 1317 shells standard bash-completion_1.1-1.dsc
 593d3edcf287b9e9d735049bd4d3f229 163598 shells standard bash-completion_1.1.orig.tar.gz
 8c259b4cf3747a0029acf4bca140be91 15493 shells standard bash-completion_1.1-1.diff.gz
 f41ce223bce595a8a3324ff8a9579e16 126996 shells standard bash-completion_1.1-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkrQsvwACgkQ5qqQFxOSsXQBOQCfZnO7RvncKmbvQDed4izHoCZO
v80AnRsQyOCYzq4zJgKnSqZbfMS55Mmd
=Lf6B
-----END PGP SIGNATURE-----





Reply sent to David Paleino <d.paleino@gmail.com>:
You have taken responsibility. (Sat, 10 Oct 2009 17:06:10 GMT) (full text, mbox, link).


Notification sent to Rapha?l Hertzog <hertzog@debian.org>:
Bug acknowledged by developer. (Sat, 10 Oct 2009 17:06:10 GMT) (full text, mbox, link).


Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Thu, 26 Nov 2009 07:32:58 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Jul 2 09:33:51 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.