Debian Bug report logs - #519931
mlmmj: sends welcome E-mail when 'submod' is enabled

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sebastian Harl <sh@tokkee.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Cc: mlmmj@mmj.dk

Subject: mlmmj: sends welcome E-mail when 'submod' is enabled

Date: Mon, 16 Mar 2009 10:21:53 +0100

[Message part 1 (text/plain, inline)]

Package: mlmmj
Version: 1.2.15-1.1
Severity: normal

Hi,

(Cc'ing the mlmmj mailinglist - a comment would be appreciated.)

When using mlmmj-sub without -c (i.e. subscription is supposed to happen
silently), mlmmj sends a welcome E-mail to the newly added user after
approving her when 'submod' is enabled. The user also gets a
notification that her subscription is waiting for approval by the
moderator.

Imho, it's not even desired that moderation should take place when
adding a user from the command line.

In any case, it would be nice if the user does not get any E-mails
unless -c is used.

TIA,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

[signature.asc (application/pgp-signature, inline)]

Message #12 received at 519931@bugs.debian.org (full text, mbox, reply):

From: "Morten K. Poulsen" <mopo@fabletech.com>

To: Sebastian Harl <sh@tokkee.org>

Cc: mlmmj@mmj.dk, 519931@bugs.debian.org

Subject: Re: mlmmj: sends welcome E-mail when 'submod' is enabled

Date: Mon, 16 Mar 2009 16:55:53 +0100

Hi Sebastian,

On Mon, 2009-03-16 at 10:21 +0100, Sebastian Harl wrote:
> Imho, it's not even desired that moderation should take place when
> adding a user from the command line.

I agree, but there should be a flag to enable moderation even if the
command line tool is used.

> In any case, it would be nice if the user does not get any E-mails
> unless -c is used.

Yes, although this is difficult (with the current design) if
subscription moderation is in use.

It would be great if you (or someone else) would write the code, and
send us a patch :)

Best regards,
Morten

-- 
Morten K. Poulsen <mopo@fabletech.com>
CTO, FableTech
http://fabletech.com/

Message #17 received at 519931@bugs.debian.org (full text, mbox, reply):

From: Sebastian Harl <sh@tokkee.org>

To: "Morten K. Poulsen" <mopo@fabletech.com>

Cc: mlmmj@mmj.dk, 519931@bugs.debian.org

Subject: Re: mlmmj: sends welcome E-mail when 'submod' is enabled

Date: Mon, 16 Mar 2009 17:46:11 +0100

[Message part 1 (text/plain, inline)]

Hi Morten,

On Mon, Mar 16, 2009 at 04:55:53PM +0100, Morten K. Poulsen wrote:
> On Mon, 2009-03-16 at 10:21 +0100, Sebastian Harl wrote:
> > Imho, it's not even desired that moderation should take place when
> > adding a user from the command line.
> 
> I agree, but there should be a flag to enable moderation even if the
> command line tool is used.

Yep - fully agreed. To not break backward-compatibility (if that's
desired), a flag could be added to _disable_ moderation while the
default behavior would still be to have moderation enabled.

> > In any case, it would be nice if the user does not get any E-mails
> > unless -c is used.
> 
> Yes, although this is difficult (with the current design) if
> subscription moderation is in use.

I have to admit that I did not yet look at the mlmmj internals at all,
but, I suppose, the current state of a subscription (before it has been
approved by the moderator) needs to be stored somewhere. So, possibly,
that place could be used to store additional flags as well.

> It would be great if you (or someone else) would write the code, and
> send us a patch :)

Sure. I might get to that later this week.

Thanks for the fast reply!

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 519931@bugs.debian.org (full text, mbox, reply):

From: Alexander Zangerl <az@debian.org>

To: Debian Bug Tracking System <519931@bugs.debian.org>

Subject: Re: sends welcome E-mail when 'submod' is enabled

Date: Wed, 13 Apr 2011 20:50:55 +1000

[Message part 1 (text/plain, inline)]

Package: mlmmj
Severity: normal
Tags: patch

looks like the original submitter never "got around" to a patch,
and the problem is still present in version 1.2.17-2.
recently i've run into the same (two) problems and so i've created 
a patch fixing them; would you please forward the patch upstream, too?

let's quickly recap the issues (this bug report is 2 years old) and 
my solutions:

* first, the cmdline mlmmj-sub command behaves badly when submod is on: it 
sends a "please wait" mail to the email in question (undesirable if we're
subscribing somebody in an automated fashion) and a "sub mod required" to 
the admin - and then all progress stalls until the admin responds to the 
sub mod email. this is bad because it makes automating subscriptions
via the cmdline tool impossible.

solution: i added the -X option to mlmmj-sub which disables submod for 
this run of mlmmj-sub. so, with -X given (by a human admin) mlmmj-sub lets
you subscribe somebody on the go. without -X you geht the normal behaviour 
just like before. i've updated the manpage, too.

* second, when subscriptions are handled via email, one cannot
switch off the welcome/goodbye emails that the subscriber receives.
(on the command line mlmmj-sub/unsub can be told not to send greetings by
leaving out the -c option.) 

solution: i've added a boolean tunable called nogreetings (plus docs) which,
when set and only if nosubconfirm is on as well, prevents the welcome/goodbye
messages. why did i decide to make this conditional on nosubconfirm?
rule of least surprise. without nosubconfirm the subscriber has to go 
through challenge/confirmation anyway, so first having them jump through 
these hoops and then not telling them about the success of the procedure 
seems silly. 

note: nogreetings doesn't affect submod and its "please wait" mail - i'm 
undecided as to whether it should or not.

regards
az

[10_submod_cmdline.dpatch (text/x-shellscript, attachment)]

Message #27 received at 519931@bugs.debian.org (full text, mbox, reply):

From: Alexander Zangerl <az@snafu.priv.at>

To: 519931@bugs.debian.org

Subject: mlmmj: sends welcome E-mail when 'submod' is enabled (update)

Date: Sun, 29 Jun 2014 11:49:55 +1000

[Message part 1 (text/plain, inline)]

this open bug is getting a tad...old, to put it politely.

anyway, there has been *some* progress and version 1.2.18 
now fixes half of the problem: it is now possible to bypass moderation 
when using mlmmj-sub on the commandline, by giving the new option "-f".

however, the second half isn't fixed: if a subscription happens via email,
then mlmmj still sends out welcome mails and there is no mechanism to disable 
that (look for "-c" in src/listcontrol.c).

the patch that i provided in 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=519931#22
doesn't apply to the new version, but i still think that a tunable to
disable welcomes/greetings would be the appropriate solution for this issue.

regards
az


-- 
Alexander Zangerl + GPG Key 0xB963BD5F (or 0x42BD645D) + http://snafu.priv.at/
"First let me say that this is a very difficult document to write 
without sounding pejorative." -- an unnamed network consultant's report

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 519931@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: 519931@bugs.debian.org, Alexander Zangerl <az@snafu.priv.at>

Subject: Re: mlmmj: sends welcome E-mail when 'submod' is enabled (update)

Date: Sun, 29 Jun 2014 15:42:56 +0800

Hi,

Alexander, if you want this to be fixed, the only way is to get it fixed
upstream. I don't really want to carry a patch which I'd have to rebase
each time there's a new upstream release.

The severity of this bug is "normal", though I really think it's more a
wishlist than anything else.

Cheers,

Thomas Goirand (zigo)

Message #37 received at 519931-done@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: 519931-done@bugs.debian.org

Subject: Closing this one

Date: Thu, 23 Nov 2017 12:43:46 +0100

Seems that's an upstream thing, and that we don't wish to carry debian
specific patch, I'm closing this bug. Please forward to upstream
directly if you want change to happen.

Cheers,

Thomas Goirand (zigo)

Send a report that this bug log contains spam.