Debian Bug report logs - #518463
initscripts: skip live specific file systems

Package: initscripts; Maintainer for initscripts is Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>; Source for initscripts is src:sysvinit.

Reported by: daniel@debian.org

Date: Fri, 6 Mar 2009 11:12:02 UTC

Owned by: debian-live@lists.debian.org

Severity: wishlist

Tags: patch

Done: Daniel Baumann <daniel@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>, debian-live@lists.debian.org:
Bug#518463; Package initscripts. (Fri, 06 Mar 2009 11:12:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to daniel@debian.org:
New Bug report received and forwarded. Copy sent to Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>, debian-live@lists.debian.org. (Fri, 06 Mar 2009 11:12:04 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Daniel Baumann <daniel@debian.org>
To: submit@bugs.debian.org
Subject: initscripts: skip live specific file systems
Date: Fri, 06 Mar 2009 12:08:24 +0100
Package: initscripts
Severity: wishlist
Tags: patch
Owner: debian-live@lists.debian.org

Hi,

/etc/init.d/umountfs unmounts both temporary and local filesystems.
however, in case of a live system, trying to unmount /cow, /live* or
/filesystem* will not work and therefore results in an (end-user
confusing) warning, that the respective fs could not have been unmounted
because it's busy.

In the latest version of live-initramfs we do workaround this at runtime
by patching the script. However, it would be nice if this could be
improved and integrated into the umountfs script itself.

Note that the namespace (/live*, /filesystem* etc.) is stable, it is
already part of some excluding/including mechanisms in gnome-vfs and
live-installer. so you don't have to fear that even if you hardcode it,
that you don't need to change it soon again. However, if you would
prefere something with an exclude mechanism by sourcing from another
file that would be only there on live-systems, that's fine too. Please
let me know what you'd prefere.

Anyway, here is what we do currently:

sed -i  -e 's#pioodl $TMPFS_MTPTS)#pioodl $TMPFS_MTPTS | sed -e "s@\\
@\\n@" | grep -v ^/live)#' \
        -e 's#pioodl $REG_MTPTS)#pioodl $REG_MTPTS | sed -e "s@\\ @\\n@"
| grep -v ^/live | grep -v ^/filesystem) /#' \
/etc/init.d/umountfs

in the second replace, we also add '/' so that $REG_MTPTS is never
empty. it would be nice if you can make the whole unmounting of local
filesystems conditional, so that the script doesn't try to do anything
when there's nothing to unmount.

Regards,
Daniel

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/




Information forwarded to debian-bugs-dist@lists.debian.org, Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>, debian-live@lists.debian.org:
Bug#518463; Package initscripts. (Wed, 03 Jun 2009 07:57:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kel Modderman <kel@otaku42.de>:
Extra info received and forwarded to list. Copy sent to Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>, debian-live@lists.debian.org. (Wed, 03 Jun 2009 07:57:02 GMT) Full text and rfc822 format available.

Message #10 received at 518463@bugs.debian.org (full text, mbox):

From: Kel Modderman <kel@otaku42.de>
To: pkg-sysvinit-devel@lists.alioth.debian.org, daniel@debian.org, 518463@bugs.debian.org
Subject: Re: [Pkg-sysvinit-devel] Bug#518463: initscripts: skip live specific file systems
Date: Wed, 3 Jun 2009 17:54:57 +1000
[Message part 1 (text/plain, inline)]
On Friday 06 March 2009 21:08:24 Daniel Baumann wrote:
> Package: initscripts
> Severity: wishlist
> Tags: patch
> Owner: debian-live@lists.debian.org
> 
> Hi,
> 
> /etc/init.d/umountfs unmounts both temporary and local filesystems.
> however, in case of a live system, trying to unmount /cow, /live* or
> /filesystem* will not work and therefore results in an (end-user
> confusing) warning, that the respective fs could not have been unmounted
> because it's busy.
> 
> In the latest version of live-initramfs we do workaround this at runtime
> by patching the script. However, it would be nice if this could be
> improved and integrated into the umountfs script itself.
> 
> Note that the namespace (/live*, /filesystem* etc.) is stable, it is
> already part of some excluding/including mechanisms in gnome-vfs and
> live-installer. so you don't have to fear that even if you hardcode it,
> that you don't need to change it soon again. However, if you would
> prefere something with an exclude mechanism by sourcing from another
> file that would be only there on live-systems, that's fine too. Please
> let me know what you'd prefere.
> 
> Anyway, here is what we do currently:
> 
> sed -i  -e 's#pioodl $TMPFS_MTPTS)#pioodl $TMPFS_MTPTS | sed -e "s@\\
> @\\n@" | grep -v ^/live)#' \
>         -e 's#pioodl $REG_MTPTS)#pioodl $REG_MTPTS | sed -e "s@\\ @\\n@"
> | grep -v ^/live | grep -v ^/filesystem) /#' \
> /etc/init.d/umountfs

How about something like:
---
--- debian/initscripts/etc/init.d/umountfs	(revision 1331)
+++ debian/initscripts/etc/init.d/umountfs	(working copy)
@@ -79,6 +79,10 @@
 				continue
 			fi
 			;;
+		  /filesystem*|/live*)
+			# used by live-initramfs
+			continue
+			;;
 		esac
 		case "$FSTYPE" in 
 		  proc|procfs|linprocfs|devfs|sysfs|usbfs|usbdevfs|devpts)
---

> 
> in the second replace, we also add '/' so that $REG_MTPTS is never
> empty. it would be nice if you can make the whole unmounting of local
> filesystems conditional, so that the script doesn't try to do anything
> when there's nothing to unmount.

I do not know why adding / to REG_MTPTS helps. What is the rationale for it?

Thanks, Kel.
[Message part 2 (text/html, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>, debian-live@lists.debian.org:
Bug#518463; Package initscripts. (Wed, 03 Jun 2009 08:33:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to daniel@debian.org:
Extra info received and forwarded to list. Copy sent to Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>, debian-live@lists.debian.org. (Wed, 03 Jun 2009 08:33:03 GMT) Full text and rfc822 format available.

Message #15 received at 518463@bugs.debian.org (full text, mbox):

From: Daniel Baumann <daniel@debian.org>
To: Kel Modderman <kel@otaku42.de>, pkg-sysvinit-devel@lists.alioth.debian.org, 518463@bugs.debian.org
Subject: Re: [Pkg-sysvinit-devel] Bug#518463: initscripts: skip live specific file systems
Date: Wed, 03 Jun 2009 10:30:24 +0200
Kel Modderman wrote:
> How about something like:
> + /filesystem*|/live*)
> + # used by live-initramfs
> + continue
> + ;;

looks good.

>> in the second replace, we also add '/' so that $REG_MTPTS is never
>> empty. it would be nice if you can make the whole unmounting of local
>> filesystems conditional, so that the script doesn't try to do anything
>> when there's nothing to unmount.
> 
> I do not know why adding / to REG_MTPTS helps. What is the rationale for it?

if $REG_MTPTS is empty, the script fails with an error.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/




Information forwarded to debian-bugs-dist@lists.debian.org, Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>, debian-live@lists.debian.org:
Bug#518463; Package initscripts. (Wed, 03 Jun 2009 09:09:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kel Modderman <kel@otaku42.de>:
Extra info received and forwarded to list. Copy sent to Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>, debian-live@lists.debian.org. (Wed, 03 Jun 2009 09:09:03 GMT) Full text and rfc822 format available.

Message #20 received at 518463@bugs.debian.org (full text, mbox):

From: Kel Modderman <kel@otaku42.de>
To: daniel@debian.org
Cc: pkg-sysvinit-devel@lists.alioth.debian.org, 518463@bugs.debian.org
Subject: Re: [Pkg-sysvinit-devel] Bug#518463: initscripts: skip live specific file systems
Date: Wed, 3 Jun 2009 18:54:29 +1000
[Message part 1 (text/plain, inline)]
On Wednesday 03 June 2009 18:30:24 Daniel Baumann wrote:
> Kel Modderman wrote:
> > How about something like:
> > + /filesystem*|/live*)
> > + # used by live-initramfs
> > + continue
> > + ;;
> 
> looks good.
> 
> >> in the second replace, we also add '/' so that $REG_MTPTS is never
> >> empty. it would be nice if you can make the whole unmounting of local
> >> filesystems conditional, so that the script doesn't try to do anything
> >> when there's nothing to unmount.
> > 
> > I do not know why adding / to REG_MTPTS helps. What is the rationale for it?
> 
> if $REG_MTPTS is empty, the script fails with an error.
> 

Hmm, there is already a check to see if $REG_MTPTS is empty:
---
	if [ "$REG_MTPTS" ]
	then
		REG_MTPTS="$(pioodl $REG_MTPTS)"
	...
---
Could it be that the error may have been introduced by piping pioodl function
output through `grep -v /live' as in your current hack?

Thanks, Kel.
[Message part 2 (text/html, inline)]

Reply sent to daniel@debian.org:
You have taken responsibility. (Fri, 28 May 2010 07:09:04 GMT) Full text and rfc822 format available.

Notification sent to daniel@debian.org:
Bug acknowledged by developer. (Fri, 28 May 2010 07:09:04 GMT) Full text and rfc822 format available.

Message #25 received at 518463-done@bugs.debian.org (full text, mbox):

From: Daniel Baumann <daniel@debian.org>
To: 518463-done@bugs.debian.org
Subject: Re: initscripts: skip live specific file systems
Date: Fri, 28 May 2010 09:06:18 +0200
Hi,

the root cause for this request was, that live-initramfs did lock the
cow mounts and the initscripts therefore showed a warning that those
mounts could not be unmounted cleanly at shutdown, hence the request to
ignore them.

however, in february, i could fix the cow handling, so on shutdown,
everything is cleanly unmounted now and there's no need anymore to
ignore anything in initscripts, therefore i'm closing this bug now.

Regards,
Daniel

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 25 Jun 2010 07:36:20 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Mon Apr 21 02:36:15 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.