Debian Bug report logs - #514616
bad pidfile handling on ENOSPC

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: michal.suchanek@ruk.cuni.cz

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: tor: restart on upgrade fails

Date: Mon, 09 Feb 2009 15:21:13 +0100

Package: tor
Version: 0.2.0.32-1
Severity: normal


Hello

I upgraded tor and the package scripts fail to restart the daemon.

Apparently it is still running when the upgrade is finished but the
scripts are not aware of it running. Start during package configuration
fails because the port is in use.

Observer on two different systems with default configuration.


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.28-macmini (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages tor depends on:
ii  adduser                3.110             add and remove users and groups
ii  libc6                  2.7-16            GNU C Library: Shared libraries
ii  libevent1              1.3e-3            An asynchronous event notification
ii  libssl0.9.8            0.9.8g-14         SSL shared libraries
ii  tsocks                 1.8beta5-9.1      transparent network access through
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

Versions of packages tor recommends:
ii  logrotate                     3.7.1-5    Log rotation utility
ii  privoxy                       3.0.9-1    Privacy enhancing HTTP Proxy
ii  socat                         1.6.0.1-1  multipurpose relay for bidirection
ii  tor-geoipdb                   0.2.0.32-1 geoIP database for Tor

Versions of packages tor suggests:
pn  anon-proxy                    <none>     (no description available)
pn  mixmaster                     <none>     (no description available)
pn  mixminion                     <none>     (no description available)

-- no debconf information

Message #10 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Peter Palfrader <weasel@debian.org>

To: michal.suchanek@ruk.cuni.cz, 514616@bugs.debian.org

Subject: Re: Bug#514616: tor: restart on upgrade fails

Date: Mon, 9 Feb 2009 15:27:27 +0100

On Mon, 09 Feb 2009, michal.suchanek@ruk.cuni.cz wrote:

> I upgraded tor and the package scripts fail to restart the daemon.
> 
> Apparently it is still running when the upgrade is finished but the
> scripts are not aware of it running. Start during package configuration
> fails because the port is in use.
> 
> Observer on two different systems with default configuration.

How was it started prior to the package upgrade?  Manually as some other
user, or was it running as debian-tor and had been started with the init
script?  Which version did you upgrade from?

Peter
-- 
                           |  .''`.  ** Debian GNU/Linux **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/

Message #15 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Michal Suchanek <michal.suchanek@ruk.cuni.cz>

To: Peter Palfrader <weasel@debian.org>

Subject: Re: Bug#514616: tor: restart on upgrade fails

Date: Mon, 09 Feb 2009 15:36:05 +0100

On 02/09/2009 03:27 PM, Peter Palfrader wrote:
> On Mon, 09 Feb 2009, michal.suchanek@ruk.cuni.cz wrote:
>
>> I upgraded tor and the package scripts fail to restart the daemon.
>>
>> Apparently it is still running when the upgrade is finished but the
>> scripts are not aware of it running. Start during package configuration
>> fails because the port is in use.
>>
>> Observer on two different systems with default configuration.
>
> How was it started prior to the package upgrade?  Manually as some other
> user, or was it running as debian-tor and had been started with the init
> script?  Which version did you upgrade from?
>


It was started by the init script, I never start it in another way.

upgrade tor 0.2.0.32-1 0.2.0.33-1

USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
105       9076  0.0  5.6  17428 14508 ?        S     2008  15:58 
/usr/sbin/tor

debian-tor:x:105:104::/var/lib/tor:/bin/bash

Thanks

Michal

Message #20 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Peter Palfrader <peter@palfrader.org>

To: Michal Suchanek <michal.suchanek@ruk.cuni.cz>

Cc: 514616@bugs.debian.org

Subject: Re: Bug#514616: tor: restart on upgrade fails

Date: Mon, 9 Feb 2009 17:00:28 +0100

On Mon, 09 Feb 2009, Michal Suchanek wrote:

> >How was it started prior to the package upgrade?  Manually as some other
> >user, or was it running as debian-tor and had been started with the init
> >script?  Which version did you upgrade from?
> 
> It was started by the init script, I never start it in another way.
> 
> upgrade tor 0.2.0.32-1 0.2.0.33-1
> 
> USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
> 105       9076  0.0  5.6  17428 14508 ?        S     2008  15:58 
> /usr/sbin/tor

Is it still running?  What does the /var/run/tor/tor.pid file say?  If
the md5sum of your /etc/init.d/tor file isn't
d373ea1cd482577b83813e3b3210a5be, how does it look like?

-- 
                           |  .''`.  ** Debian GNU/Linux **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/

Message #25 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Michal Suchanek <michal.suchanek@ruk.cuni.cz>

To: Peter Palfrader <peter@palfrader.org>

Cc: "514616@bugs.debian.org" <514616@bugs.debian.org>

Subject: Re: Bug#514616: tor: restart on upgrade fails

Date: Tue, 10 Feb 2009 10:24:42 +0100

Peter Palfrader wrote:
> On Mon, 09 Feb 2009, Michal Suchanek wrote:
>
>
>>> How was it started prior to the package upgrade?  Manually as some other
>>> user, or was it running as debian-tor and had been started with the init
>>> script?  Which version did you upgrade from?
>>>
>> It was started by the init script, I never start it in another way.
>>
>> upgrade tor 0.2.0.32-1 0.2.0.33-1
>>
>> USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
>> 105       9076  0.0  5.6  17428 14508 ?        S     2008  15:58
>> /usr/sbin/tor
>>
>
> Is it still running?
Yes, it's the process 9076 I would think.
> What does the /var/run/tor/tor.pid file say?
It's empty.
> If
> the md5sum of your /etc/init.d/tor file isn't
> d373ea1cd482577b83813e3b3210a5be, how does it look like?
>
>
It has that checksum.


The system probably ran out of disk space at some point.

Thanks

Michal

Message #30 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Peter Palfrader <weasel@debian.org>

To: Michal Suchanek <michal.suchanek@ruk.cuni.cz>

Cc: "514616@bugs.debian.org" <514616@bugs.debian.org>

Subject: Re: Bug#514616: tor: restart on upgrade fails

Date: Tue, 10 Feb 2009 10:38:58 +0100

On Tue, 10 Feb 2009, Michal Suchanek wrote:

> >>upgrade tor 0.2.0.32-1 0.2.0.33-1
> >>
> >>USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
> >>105       9076  0.0  5.6  17428 14508 ?        S     2008  15:58
> >>/usr/sbin/tor
> >>

> >Is it still running?
> Yes, it's the process 9076 I would think.

> >What does the /var/run/tor/tor.pid file say?
> It's empty.

> >If
> >the md5sum of your /etc/init.d/tor file isn't
> >d373ea1cd482577b83813e3b3210a5be, how does it look like?
> >
> >
> It has that checksum.
> 
> 
> The system probably ran out of disk space at some point.

Oh.  Well, then it couldn't create its pidfile then.  Unixes never like
when you run out of disk space.

If you write the proper pid into the pidfile it should all work out.  Or
you kill the tor process and start it again.

I think we can close this bug?

Peter
-- 
                           |  .''`.  ** Debian GNU/Linux **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/

Message #35 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Michal Suchanek <michal.suchanek@ruk.cuni.cz>

To: Peter Palfrader <weasel@debian.org>

Cc: 514616@bugs.debian.org

Subject: Re: Bug#514616: tor: restart on upgrade fails

Date: Tue, 10 Feb 2009 10:58:14 +0100

On 02/10/2009 10:38 AM, Peter Palfrader wrote:
> On Tue, 10 Feb 2009, Michal Suchanek wrote:
>
>>>> upgrade tor 0.2.0.32-1 0.2.0.33-1
>>>>
>>>> USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
>>>> 105       9076  0.0  5.6  17428 14508 ?        S     2008  15:58
>>>> /usr/sbin/tor
>>>>
>
>>> Is it still running?
>> Yes, it's the process 9076 I would think.
>
>>> What does the /var/run/tor/tor.pid file say?
>> It's empty.
>
>>> If
>>> the md5sum of your /etc/init.d/tor file isn't
>>> d373ea1cd482577b83813e3b3210a5be, how does it look like?
>>>
>>>
>> It has that checksum.
>>
>>
>> The system probably ran out of disk space at some point.
>
> Oh.  Well, then it couldn't create its pidfile then.  Unixes never like
> when you run out of disk space.
>
> If you write the proper pid into the pidfile it should all work out.  Or
> you kill the tor process and start it again.
>
> I think we can close this bug?

Perhaps tor should check the return value of the write()/close()?

It could also write the file as root which would work ..

Thanks

Michal

Message #40 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Peter Palfrader <weasel@debian.org>

To: Michal Suchanek <michal.suchanek@ruk.cuni.cz>

Cc: 514616@bugs.debian.org

Subject: Re: Bug#514616: tor: restart on upgrade fails

Date: Tue, 10 Feb 2009 11:06:13 +0100

On Tue, 10 Feb 2009, Michal Suchanek wrote:

> >If you write the proper pid into the pidfile it should all work out.  Or
> >you kill the tor process and start it again.
> >
> >I think we can close this bug?
> 
> Perhaps tor should check the return value of the write()/close()?

Maybe.  And then what?  Just die?  We can't say anything on stdout/err,
we already detached.  This isn't as trivial as it may seem.

> It could also write the file as root which would work ..

I'm not sure this is such a good idea.

-- 
                           |  .''`.  ** Debian GNU/Linux **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/

Message #45 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Michal Suchanek <michal.suchanek@ruk.cuni.cz>

To: Peter Palfrader <weasel@debian.org>

Cc: 514616@bugs.debian.org

Subject: Re: Bug#514616: tor: restart on upgrade fails

Date: Tue, 10 Feb 2009 11:44:04 +0100

On 02/10/2009 11:06 AM, Peter Palfrader wrote:
> On Tue, 10 Feb 2009, Michal Suchanek wrote:
>
>>> If you write the proper pid into the pidfile it should all work out.  Or
>>> you kill the tor process and start it again.
>>>
>>> I think we can close this bug?
>> Perhaps tor should check the return value of the write()/close()?
>
> Maybe.  And then what?  Just die?  We can't say anything on stdout/err,
> we already detached.  This isn't as trivial as it may seem.

Log on syslog or just die. Whatever. But if it fails to create the pid 
file it is a failure and daemons normally refuse to start in that case.

It can be even done so that the daemon forks and the parent writes the 
pid file and if it fails it kills the daemon again.

Note that logging on syslog would work, it runs as root. And if even 
syslog does not work you should notice.

Thanks

Michal

Message #54 received at 514616-done@bugs.debian.org (full text, mbox, reply):

From: Peter Palfrader <weasel@debian.org>

To: 514616-done@bugs.debian.org

Subject: just don't let that happen

Date: Wed, 11 Jan 2012 21:15:36 +0100

Lots of unix programs behave weird if they run out of disk space.  I
don't think spending lots of time on tor to do much better than the
rest, or waiting for that, is a good use of anybody's resource.

Closing.
-- 
                           |  .''`.       ** Debian **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/

Message #59 received at 514616@bugs.debian.org (full text, mbox, reply):

From: Michal Suchanek <michal.suchanek@ruk.cuni.cz>

To: "514616@bugs.debian.org" <514616@bugs.debian.org>

Subject: Re: Bug#514616 closed by Peter Palfrader <weasel@debian.org> (just don't let that happen)

Date: Thu, 12 Jan 2012 13:26:19 +0100

Excerpts from Debian Bug Tracking System's message of Wed Jan 11 21:18:04 +0100 2012:
> This is an automatic notification regarding your Bug report
> which was filed against the tor package:
> 
> #514616: bad pidfile handling on ENOSPC
> 
> It has been closed by Peter Palfrader <weasel@debian.org>.
> 
> Their explanation is attached below along with your original report.
> If this explanation is unsatisfactory and you have not received a
> better one in a separate message then please contact Peter Palfrader <weasel@debian.org> by
> replying to this email.
> 
> Lots of unix programs behave weird if they run out of disk space.  I
> don't think spending lots of time on tor to do much better than the
> rest, or waiting for that, is a good use of anybody's resource.

Well, the thing is that lots of other programs *do* better.

They write the PID file as root.

Tor is standing out as behaving exceptionally poorly here.

Regards

Michal

Send a report that this bug log contains spam.