Debian Bug report logs - #507369
isomaster's .desktop file is suboptimal

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Siegfried Gevatter (RainCT)" <rainct@ubuntu.com>

To: submit@bugs.debian.org

Subject: isomaster's .desktop file is suboptimal

Date: Sun, 30 Nov 2008 16:36:09 +0100

Package: isomaster
Version: 1.3.3-1
Severity: wishlist
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

Currently isomaster has the following .desktop (isomaster.desktop.src) file:

"""
[Desktop Entry]
Name=ISO Master
GenericName=CD image editor
Comment=Graphical CD image editor for reading, modifying and writing ISO images
Exec=isomaster
Terminal=false
StartupNotify=true
Type=Application
Categories=Utility;DiscBurning;AudioVideo;AudioVideoEditing;
MimeType=application/x-iso
"""

There are some flaws with this:
 - The GenericName says that it's for CD, but I guess it can also
handle DVD images.
 - The Comment should start with a verb (GNOME HIG).
 - MimeType is missing a final ";", so this file fails to validate
with desktop-file-validate.
 - The menu entry appears in more than one menu category.

So, I propose the following changes:

--- isomaster-1.3.3.orig/isomaster.desktop.src
+++ isomaster-1.3.3/isomaster.desktop.src
@@ -1,10 +1,14 @@
 [Desktop Entry]
 Name=ISO Master
-GenericName=CD image editor
-Comment=Graphical CD image editor for reading, modifying and writing ISO images
+GenericName=ISO File Editor
+GenericName[ca]=Editor de fitxers ISO
+GenericName[es]=Editor de ficheros ISO
+Comment=Read, write and modify ISO images
+Comment[ca]=Llegiu, escriviu i modifiqueu imatges ISO
+Comment[es]=Leer, escribir i modificar imagenes ISO
 Exec=isomaster
 Terminal=false
 StartupNotify=true
 Type=Application
-Categories=Utility;DiscBurning;AudioVideo;AudioVideoEditing;
-MimeType=application/x-iso
+Categories=Utility;
+MimeType=application/x-iso;

Kind regards,

-- 
Siegfried-Angel Gevatter Pujals (RainCT)
Ubuntu Developer. Debian Contributor.

Message #10 received at 507369@bugs.debian.org (full text, mbox, reply):

From: David Johnson <dj@david-web.co.uk>

To: "Siegfried Gevatter (RainCT)" <rainct@ubuntu.com>

Cc: 507369@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#507369: isomaster's .desktop file is suboptimal

Date: Sun, 7 Dec 2008 12:21:58 +0000

tags 507369 confirmed patch
thanks

On Sunday 30 November 2008 15:36:09 Siegfried Gevatter (RainCT) wrote:
>
> So, I propose the following changes:
>
> --- isomaster-1.3.3.orig/isomaster.desktop.src
> +++ isomaster-1.3.3/isomaster.desktop.src
> @@ -1,10 +1,14 @@
>  [Desktop Entry]
>  Name=ISO Master
> -GenericName=CD image editor
> -Comment=Graphical CD image editor for reading, modifying and writing ISO
> images +GenericName=ISO File Editor
> +GenericName[ca]=Editor de fitxers ISO
> +GenericName[es]=Editor de ficheros ISO
> +Comment=Read, write and modify ISO images
> +Comment[ca]=Llegiu, escriviu i modifiqueu imatges ISO
> +Comment[es]=Leer, escribir i modificar imagenes ISO
>  Exec=isomaster
>  Terminal=false
>  StartupNotify=true
>  Type=Application
> -Categories=Utility;DiscBurning;AudioVideo;AudioVideoEditing;
> -MimeType=application/x-iso
> +Categories=Utility;
> +MimeType=application/x-iso;
>

Thanks, but I don't think isomaster should be in the utility category, since 
that's very generic and isn't where users would expect to find it.

Categories:Application;AudioVideo;DiscBurning;

Seems to do the right thing in KDE on Debian and places isomaster in the 
Multimedia menu. I don't have an Ubuntu box; can you confirm the above puts 
isomaster somewhere sane in your menu structure?

Many thanks,
David.

-- 
David Johnson
www.david-web.co.uk

Message #17 received at 507369@bugs.debian.org (full text, mbox, reply):

From: "Siegfried Gevatter (RainCT)" <rainct@ubuntu.com>

To: "David Johnson" <dj@david-web.co.uk>, 507369@bugs.debian.org

Subject: Re: Bug#507369: isomaster's .desktop file is suboptimal

Date: Sun, 7 Dec 2008 13:34:09 +0100

> Categories:Application;AudioVideo;DiscBurning;

"Application" is deprecated, so you don't need to include it (run
desktop-file-validate on the file and it will tell you the same). And
the ":" should be an "=", of course.

Looks fine otherwise.

> Seems to do the right thing in KDE on Debian and places isomaster in the
> Multimedia menu. I don't have an Ubuntu box; can you confirm the above puts
> isomaster somewhere sane in your menu structure?

It's placed under "Sound and video".

-- 
Siegfried-Angel Gevatter Pujals (RainCT)
Ubuntu Developer. Debian Contributor.

Message #22 received at 507369-close@bugs.debian.org (full text, mbox, reply):

From: David Johnson <dj@david-web.co.uk>

To: 507369-close@bugs.debian.org

Subject: Bug#507369: fixed in isomaster 1.3.4-1

Date: Mon, 15 Dec 2008 18:02:04 +0000

Source: isomaster
Source-Version: 1.3.4-1

We believe that the bug you reported is fixed in the latest version of
isomaster, which is due to be installed in the Debian FTP archive:

isomaster_1.3.4-1.diff.gz
  to pool/main/i/isomaster/isomaster_1.3.4-1.diff.gz
isomaster_1.3.4-1.dsc
  to pool/main/i/isomaster/isomaster_1.3.4-1.dsc
isomaster_1.3.4-1_amd64.deb
  to pool/main/i/isomaster/isomaster_1.3.4-1_amd64.deb
isomaster_1.3.4.orig.tar.gz
  to pool/main/i/isomaster/isomaster_1.3.4.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 507369@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Johnson <dj@david-web.co.uk> (supplier of updated isomaster package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 06 Dec 2008 16:07:12 +0000
Source: isomaster
Binary: isomaster
Architecture: source amd64
Version: 1.3.4-1
Distribution: unstable
Urgency: low
Maintainer: David Johnson <dj@david-web.co.uk>
Changed-By: David Johnson <dj@david-web.co.uk>
Description: 
 isomaster  - A graphical CD image editor
Closes: 507369
Changes: 
 isomaster (1.3.4-1) unstable; urgency=low
 .
   * New upstream release
   * Tidy .desktop file and fix categories (Closes: #507369)
Checksums-Sha1: 
 5465bca4867bd6a4c9a80997ee2000aae5f0f41c 1027 isomaster_1.3.4-1.dsc
 e7110d9d3d023d312f55890833001f88ebcfadc9 228199 isomaster_1.3.4.orig.tar.gz
 40c93accb5d84b13425f43377f27248fac60c604 3809 isomaster_1.3.4-1.diff.gz
 9955e322ae9371253403329c47c717255acf18f2 185074 isomaster_1.3.4-1_amd64.deb
Checksums-Sha256: 
 8217b99e6a3e7c8d4b6795acc28bbec199047edfe95333c4f4881ec3a20a5946 1027 isomaster_1.3.4-1.dsc
 b6c59e9ae7257269e8362064e8679292b99759b1d12931824860f56d29ed7cfe 228199 isomaster_1.3.4.orig.tar.gz
 9b9a195d0b3aff3f74a623b5cdd8320a5c133652098a99ffdd498d84f514b788 3809 isomaster_1.3.4-1.diff.gz
 2cd3ff0a2ac4a44b54c5c21ede7788b211600de78b739593a3666c1d7b8ebd52 185074 isomaster_1.3.4-1_amd64.deb
Files: 
 3c73ee5b4e01fe073868152e7cf7c50b 1027 otherosfs optional isomaster_1.3.4-1.dsc
 38f1b96e7a0bdd925106311759688710 228199 otherosfs optional isomaster_1.3.4.orig.tar.gz
 375f3e80cb45bf9dd907a9f74b94b829 3809 otherosfs optional isomaster_1.3.4-1.diff.gz
 239d14344a55b1a3d7faa65b71c8d7bf 185074 otherosfs optional isomaster_1.3.4-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEUEARECAAYFAklGl1EACgkQbMaawmho9B8IfACXdxIk/6DQhSmGdaQjjcv7opJ4
JACguPgC0u7d7JgnRvFtBUR/CNc7CxM=
=avSN
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.