Debian Bug report logs - #507242
amule-daemon: causes OOM's by leaking lots of memory

version graph

Package: amule-daemon; Maintainer for amule-daemon is Sandro Tosi <morph@debian.org>; Source for amule-daemon is src:amule (PTS, buildd, popcon).

Reported by: Klaas van den Berg <k_van_den_berg@hotmail.com>

Date: Sat, 29 Nov 2008 10:51:01 UTC

Severity: important

Tags: unreproducible

Found in version amule/2.2.1-1

Done: Sandro Tosi <morph@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Adeodato Simó <dato@net.com.org.es>:
Bug#507242; Package amule-daemon. (Sat, 29 Nov 2008 10:51:04 GMT) (full text, mbox, link).


Acknowledgement sent to Klaas van den Berg <k_van_den_berg@hotmail.com>:
New Bug report received and forwarded. Copy sent to Adeodato Simó <dato@net.com.org.es>. (Sat, 29 Nov 2008 10:51:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Klaas van den Berg <k_van_den_berg@hotmail.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: amule-daemon: causes OOM's by leaking lots of memory
Date: Sat, 29 Nov 2008 11:49:50 +0100
Package: amule-daemon
Version: 2.2.1-1
Severity: critical
Justification: breaks the whole system

Ever since upgrading to 2.2.1-1 I have had several occurrences of OOM,
after which my system became virtually unusable because of the
infamous OOM_killer kicking in. Since I never had OOM's before I started
to monitor the system more closely, using top en /proc/meminfo.

I noticed that over time the combined memory footprint of the processes
amuled and amuleweb was growing (up till 100 MB) without ever allowing the system to
reclaim any. The last OOM provided me with the 'evidence' that amule-daemon was to blame: the frozen xterm output of top 
revealed that amuleweb had used up 86% of my 1.5 GB of physical memory! All swap space had been eaten too and all I could 
do was sysrq-ing out of the situation or wait forever on OOM_killer to finish up.

Now that I have gone back to the stable version (2.1.3-1), amule-daemon's memory footprint remains at a constant amount of 
about 11 MB.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.27.7
Locale: LANG=en_US.ISO-8859-15, LC_CTYPE=en_US.ISO-8859-15 (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages amule-daemon depends on:
ii  amule-common           2.1.3-1           common files for the rest of aMule
ii  libc6                  2.7-16            GNU C Library: Shared libraries
ii  libcrypto++5.2c2a      5.2.1c2a-3        General purpose cryptographic shar
ii  libgcc1                1:4.3.2-1         GCC support library
ii  libpng12-0             1.2.27-2          PNG library - runtime
ii  libreadline5           5.2-3             GNU readline and history libraries
ii  libstdc++6             4.3.2-1           The GNU Standard C++ Library v3
ii  libwxbase2.6-0         2.6.3.2.2-3       wxBase library (runtime) - non-GUI
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

Versions of packages amule-daemon recommends:
ii  amule-utils                   2.1.3-1    utilities for aMule (command-line 

amule-daemon suggests no packages.

-- no debconf information




Information forwarded to debian-bugs-dist@lists.debian.org, Adeodato Simó <dato@net.com.org.es>:
Bug#507242; Package amule-daemon. (Wed, 03 Dec 2008 17:03:06 GMT) (full text, mbox, link).


Acknowledgement sent to <marcos.marado@sonae.com>:
Extra info received and forwarded to list. Copy sent to Adeodato Simó <dato@net.com.org.es>. (Wed, 03 Dec 2008 17:03:06 GMT) (full text, mbox, link).


Message #10 received at 507242@bugs.debian.org (full text, mbox, reply):

From: <marcos.marado@sonae.com>
To: <507242@bugs.debian.org>
Subject: Re: amule-daemon: causes OOM's by leaking lots of memory
Date: Wed, 3 Dec 2008 16:59:03 +0000
Klaas,

Can you please try the package in experimental (2.2.2-1) and test if the 
problem still happens with that? According to the 2.2.2 changelog[1], it has 
lots of bug fixes, so it might solve this issue for you.

[1] - http://www.amule.org/wiki/index.php/Changelog_latest

Best regards,
-- 
Marcos Marado




Information forwarded to debian-bugs-dist@lists.debian.org, Adeodato Simó <dato@net.com.org.es>:
Bug#507242; Package amule-daemon. (Tue, 09 Dec 2008 17:51:04 GMT) (full text, mbox, link).


Acknowledgement sent to Didier Raboud <didier@raboud.com>:
Extra info received and forwarded to list. Copy sent to Adeodato Simó <dato@net.com.org.es>. (Tue, 09 Dec 2008 17:51:04 GMT) (full text, mbox, link).


Message #15 received at 507242@bugs.debian.org (full text, mbox, reply):

From: Didier Raboud <didier@raboud.com>
To: 507242@bugs.debian.org
Cc: Klaas van den Berg <k_van_den_berg@hotmail.com>, control@bugs.debian.org
Subject: Re: amule-daemon: causes OOM's by leaking lots of memory [RC]
Date: Tue, 9 Dec 2008 18:46:28 +0100
[Message part 1 (text/plain, inline)]
tags 507242 unreproducible
thanks

Hi, 

regarding bug #507242 which you reported : I can't reproduce the memory leak 
that you mention : In installed the package and runned

$ amuled --ec-config

It runs with a constant 140M of virtual memory for an hour now.

Could you please provide a followup, from package installation to the memory 
leak, so that one could reproduce your bug ?

As mentionned by Marcos Marado, could you also try the experimental version and 
see if it consumes as much memory as your actual version.

Best regards, 

OdyX

-- 
Didier Raboud, proud Debian user.
CH-1802 Corseaux
didier@raboud.com
[signature.asc (application/pgp-signature, inline)]

Tags added: unreproducible Request was from Didier Raboud <didier@raboud.com> to control@bugs.debian.org. (Tue, 09 Dec 2008 17:51:05 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Adeodato Simó <dato@net.com.org.es>:
Bug#507242; Package amule-daemon. (Tue, 16 Dec 2008 10:27:02 GMT) (full text, mbox, link).


Acknowledgement sent to Didier Raboud <didier@raboud.com>:
Extra info received and forwarded to list. Copy sent to Adeodato Simó <dato@net.com.org.es>. (Tue, 16 Dec 2008 10:27:02 GMT) (full text, mbox, link).


Message #22 received at 507242@bugs.debian.org (full text, mbox, reply):

From: Didier Raboud <didier@raboud.com>
To: 507242@bugs.debian.org, Klaas van den Berg <k_van_den_berg@hotmail.com>
Subject: Re: amule-daemon: causes OOM's by leaking lots of memory [RC-LastCall]
Date: Tue, 16 Dec 2008 11:25:51 +0100
[Message part 1 (text/plain, inline)]
Hi again Klaas, 

As reporter of bug 507242 [0], you have been pinged twice on the 3. and on the 
9. of December, with no answer from you.

As noone else could reproduce your bug (and raised his voice) and without answer 
from you for one week (until the 23. of December), I will either close this bug 
or lower its severity to "important".

So please :

1. Try the experimental version and report back (answer to Marcos)
	and/or
2. Try to find a simple way to the memory leak (answer to me)
	and/or
3. Try to find someone else with a similar memory leak.

Best regards, 

OdyX

[0] http://bugs.debian.org/507242
-- 
Didier Raboud, proud Debian user.
CH-1802 Corseaux
didier@raboud.com
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Adeodato Simó <dato@net.com.org.es>:
Bug#507242; Package amule-daemon. (Tue, 23 Dec 2008 11:12:02 GMT) (full text, mbox, link).


Acknowledgement sent to Didier Raboud <didier@raboud.com>:
Extra info received and forwarded to list. Copy sent to Adeodato Simó <dato@net.com.org.es>. (Tue, 23 Dec 2008 11:12:02 GMT) (full text, mbox, link).


Message #27 received at 507242@bugs.debian.org (full text, mbox, reply):

From: Didier Raboud <didier@raboud.com>
To: Klaas van den Berg <k_van_den_berg@hotmail.com>
Cc: 507242@bugs.debian.org, control@bugs.debian.org
Subject: Re: amule-daemon: causes OOM's by leaking lots of memory [RC-LastCall]
Date: Tue, 23 Dec 2008 12:09:14 +0100
[Message part 1 (text/plain, inline)]
package amule-daemon
severity 507242 important
thanks

Hi again Klaas, 

As told in my previous mail, I am hereby downgrading the severity of this bug 
[0] to 'important'. I had already tagged it as 'unreproducible' and you have 
not provided any new information about this bug in 20 days.

If this bug is till valid for you, please:

> 1. Try the experimental version and report back (answer to Marcos)
> 	and/or
> 2. Try to find a simple way to the memory leak (answer to me)
> 	and/or
> 3. Try to find someone else with a similar memory leak.

Note that downgrading the severity of the bug also prevents amule-daemon to be 
removed from lenny and doesn't mean that your bug is invalid.

Best regards and have a happy end of year !

OdyX

[0] http://bugs.debian.org/507242
-- 
Didier Raboud, proud Debian user.
CH-1802 Corseaux
didier@raboud.com
[signature.asc (application/pgp-signature, inline)]

Severity set to `important' from `critical' Request was from Didier Raboud <didier@raboud.com> to control@bugs.debian.org. (Tue, 23 Dec 2008 11:12:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Adeodato Simó <dato@net.com.org.es>:
Bug#507242; Package amule-daemon. (Mon, 05 Jan 2009 20:39:02 GMT) (full text, mbox, link).


Acknowledgement sent to Klaas van den Berg <k_van_den_berg@hotmail.com>:
Extra info received and forwarded to list. Copy sent to Adeodato Simó <dato@net.com.org.es>. (Mon, 05 Jan 2009 20:39:02 GMT) (full text, mbox, link).


Message #34 received at 507242@bugs.debian.org (full text, mbox, reply):

From: Klaas van den Berg <k_van_den_berg@hotmail.com>
To: <didier@raboud.com>
Cc: <507242@bugs.debian.org>
Subject: RE: amule-daemon: causes OOM's by leaking lots of memory [RC-LastCall]
Date: Mon, 5 Jan 2009 20:35:37 +0000
[Message part 1 (text/plain, inline)]
Hi Didier,

I'm sorry for not providing new info for over a month. For some reason I haven't received your previous mail nor Marcos's.

OT: 

> > 1. Try the experimental version and report back (answer to Marcos)
Unfortunately at the moment there is no complete set of binaries in experimental to try version 2.2.2-1, but 2.2.3-1 seems underway; I'll wait until this set is complete and try that.

> > 2. Try to find a simple way to the memory leak (answer to me)
You mentioned testing amuled for an hour and not finding problems. This does not surprise me, since - I should have been more specific here - the increase in memory usage develops quite slowly and the OOM's occurred only after a day of running amuled.

> > 3. Try to find someone else with a similar memory leak.
Tried that, but didn't find anyone. I guess for now  it's just me :). I'll give the search another go, though, and let you know.

> Best regards and have a happy end of year !
A bit late perhaps, but even so, best wishes for 2009!

Regards, Klaas




> From: didier@raboud.com
> To: k_van_den_berg@hotmail.com
> Subject: Re: amule-daemon: causes OOM's by leaking lots of memory [RC-LastCall]
> Date: Tue, 23 Dec 2008 12:09:14 +0100
> CC: 507242@bugs.debian.org; control@bugs.debian.org
> 
> package amule-daemon
> severity 507242 important
> thanks
> 
> Hi again Klaas, 
> 
> As told in my previous mail, I am hereby downgrading the severity of this bug 
> [0] to 'important'. I had already tagged it as 'unreproducible' and you have 
> not provided any new information about this bug in 20 days.
> 
> If this bug is till valid for you, please:
> 
> > 1. Try the experimental version and report back (answer to Marcos)
> > 	and/or
> > 2. Try to find a simple way to the memory leak (answer to me)
> > 	and/or
> > 3. Try to find someone else with a similar memory leak.
> 
> Note that downgrading the severity of the bug also prevents amule-daemon to be 
> removed from lenny and doesn't mean that your bug is invalid.
> 
> Best regards and have a happy end of year !
> 
> OdyX
> 
> [0] http://bugs.debian.org/507242
> -- 
> Didier Raboud, proud Debian user.
> CH-1802 Corseaux
> didier@raboud.com

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
[Message part 2 (text/html, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Adeodato Simó <dato@net.com.org.es>:
Bug#507242; Package amule-daemon. (Thu, 08 Jan 2009 09:24:02 GMT) (full text, mbox, link).


Acknowledgement sent to Didier Raboud <didier@raboud.com>:
Extra info received and forwarded to list. Copy sent to Adeodato Simó <dato@net.com.org.es>. (Thu, 08 Jan 2009 09:24:02 GMT) (full text, mbox, link).


Message #39 received at 507242@bugs.debian.org (full text, mbox, reply):

From: Didier Raboud <didier@raboud.com>
To: Klaas van den Berg <k_van_den_berg@hotmail.com>
Cc: 507242@bugs.debian.org
Subject: Re: amule-daemon: causes OOM's by leaking lots of memory [RC-LastCall]
Date: Thu, 8 Jan 2009 10:20:36 +0100
[Message part 1 (text/plain, inline)]
Hi Klaas, 

Le lundi 5 janvier 2009 21:35:37 Klaas van den Berg, vous avez écrit :
> Hi Didier,
>
> I'm sorry for not providing new info for over a month. For some reason I
> haven't received your previous mail nor Marcos's.

No problem. Check your spambox... :)

> OT:
> > > 1. Try the experimental version and report back (answer to Marcos)
>
> Unfortunately at the moment there is no complete set of binaries in
> experimental to try version 2.2.2-1, but 2.2.3-1 seems underway; I'll wait
> until this set is complete and try that.

I now have 2.2.3-1 installable in experimental.

> > > 2. Try to find a simple way to the memory leak (answer to me)
>
> You mentioned testing amuled for an hour and not finding problems. This
> does not surprise me, since - I should have been more specific here - the
> increase in memory usage develops quite slowly and the OOM's occurred only
> after a day of running amuled.

Two-days of '$ amuled --ec-config' running, with perfectly constant memory 
usage.

I have no files shared nor any file being downloaded: this is just "run the 
program with nothing else".

I suspect some "corner-case" issue with some of your downloaded or shared files. 
It could then be of some use to try hand-adding each and every file with 
one-day waiting delay between the adds. Not realisable...

Do you have the "KAD" module enabled ? I mention this after Internet-search 
on "amuled memory leak", which led to

http://www.amule.org/amule/index.php?topic=11458.msg61667
and
http://www.amule.org/amule/index.php?topic=14124.0

Seems that you are not completely alone...

> > > 3. Try to find someone else with a similar memory leak.
>
> Tried that, but didn't find anyone. I guess for now  it's just me :). I'll
> give the search another go, though, and let you know.

Best regards, 

OdyX


-- 
Didier Raboud, proud Debian user.
CH-1802 Corseaux
didier@raboud.com
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Adeodato Simó <dato@net.com.org.es>:
Bug#507242; Package amule-daemon. (Sat, 24 Jan 2009 15:33:15 GMT) (full text, mbox, link).


Acknowledgement sent to Klaas van den Berg <k_van_den_berg@hotmail.com>:
Extra info received and forwarded to list. Copy sent to Adeodato Simó <dato@net.com.org.es>. (Sat, 24 Jan 2009 15:33:15 GMT) (full text, mbox, link).


Message #44 received at 507242@bugs.debian.org (full text, mbox, reply):

From: Klaas van den Berg <k_van_den_berg@hotmail.com>
To: <507242@bugs.debian.org>
Cc: <didier@raboud.com>
Subject: RE: amule-daemon: causes OOM's by leaking lots of memory [RC-LastCall]
Date: Sat, 24 Jan 2009 15:31:18 +0000
[Message part 1 (text/plain, inline)]












Hi Didier,

> No problem. Check your spambox... :)
No kiddin' :).

> I now have 2.2.3-1 installable in experimental.
Thanks a lot for this. I have been able to test 2.2.3-1 at last, but unfortunately the problem does not seem to be solved.
After 12 hours of running amuled, amuleweb was already using 14 MB of RAM, which is more than version 2.1.3-1 uses even after a couple of days. About another 24 hours later I could barely prevent another OOM from happening: amuleweb was already eating away my all swap space and all I could do was killing it. It seems the leakage of amuleweb at first progresses gradually and later on increases suddenly (the leak turning into a flood as it were).

Thanks for you suggestions and help, but for now I'll stick with the stable version, which works well enough for me.

> Two-days of '$ amuled --ec-config' running, with perfectly constant memory 
> usage.
> 
> I have no files shared nor any file being downloaded: this is just "run the 
> program with nothing else".
> 
> I suspect some "corner-case" issue with some of your downloaded or shared files. 
> It could then be of some use to try hand-adding each and every file with 
> one-day waiting delay between the adds. Not realisable...
Thanks for testing this, but without shared files or downloads to me this seems a bit like 'dry swimming'. Also I doubt the problem has got anything to do with my shared files, since there is no such problem with 2.1.3-1.
 
> Do you have the "KAD" module enabled ? I mention this after Internet-search 
> on "amuled memory leak", which led to
> 
> http://www.amule.org/amule/index.php?topic=11458.msg61667
I have KAD disabled.

> and
> http://www.amule.org/amule/index.php?topic=14124.0
> 
> Seems that you are not completely alone...
Maybe, but this topic is dated January 2008, before 2.2.1 was released (AFAIK 2008-06-11). 

Best regards,

Klaas



_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
[Message part 2 (text/html, inline)]

Message sent on to Klaas van den Berg <k_van_den_berg@hotmail.com>:
Bug#507242. (Wed, 30 Dec 2009 23:36:23 GMT) (full text, mbox, link).


Message #47 received at 507242-submitter@bugs.debian.org (full text, mbox, reply):

From: Sandro Tosi <morph@debian.org>
To: 339512@bugs.debian.org, 339512-submitter@bugs.debian.org, 350580@bugs.debian.org, 350580-submitter@bugs.debian.org, 357822@bugs.debian.org, 357822-submitter@bugs.debian.org, 359327@bugs.debian.org, 359327-submitter@bugs.debian.org, 369027@bugs.debian.org, 369027-submitter@bugs.debian.org, 398144@bugs.debian.org, 398144-submitter@bugs.debian.org, 398145@bugs.debian.org, 398145-submitter@bugs.debian.org, 410609@bugs.debian.org, 410609-submitter@bugs.debian.org, 424172@bugs.debian.org, 424172-submitter@bugs.debian.org, 425300@bugs.debian.org, 425300-submitter@bugs.debian.org, 431064@bugs.debian.org, 431064-submitter@bugs.debian.org, 431617@bugs.debian.org, 431617-submitter@bugs.debian.org, 433368@bugs.debian.org, 433368-submitter@bugs.debian.org, 442130@bugs.debian.org, 442130-submitter@bugs.debian.org, 446019@bugs.debian.org, 446019-submitter@bugs.debian.org, 449295@bugs.debian.org, 449295-submitter@bugs.debian.org, 464748@bugs.debian.org, 464748-submitter@bugs.debian.org, 472841@bugs.debian.org, 472841-submitter@bugs.debian.org, 474454@bugs.debian.org, 474454-submitter@bugs.debian.org, 480632@bugs.debian.org, 480632-submitter@bugs.debian.org, 488230@bugs.debian.org, 488230-submitter@bugs.debian.org, 488917@bugs.debian.org, 488917-submitter@bugs.debian.org, 498694@bugs.debian.org, 498694-submitter@bugs.debian.org, 498695@bugs.debian.org, 498695-submitter@bugs.debian.org, 498786@bugs.debian.org, 498786-submitter@bugs.debian.org, 507242@bugs.debian.org, 507242-submitter@bugs.debian.org, 528624@bugs.debian.org, 528624-submitter@bugs.debian.org, 529092@bugs.debian.org, 529092-submitter@bugs.debian.org, 537489@bugs.debian.org, 537489-submitter@bugs.debian.org, 546449@bugs.debian.org, 546449-submitter@bugs.debian.org
Subject: [amule] Is your bug still valid with aMule 2.2.6?
Date: Thu, 31 Dec 2009 00:31:07 +0100
Hello,
we recently uploaded in Debian unstable the new upstream release of
aMule: 2.2.6 .

We are contacting you because you reported a bug against aMule and
because we'd like to ask you to verify if your bug still applies to
the 2.2.6 version.

Since some of the bugs we are contacting are really old, there are
chances they were already fixed in a previous version (just for the
reference, Debian stable has version 2.2.1 while Debian testing has
(currently) version 2.2.5).

Your help is appreciated in screening your bug, so we close those that
are already fixed and address those that are not (yet).

Thanks in advance,
Sandro (on behalf of aMule Debian packaging team)

-- 
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi




Information forwarded to debian-bugs-dist@lists.debian.org, Debian aMule Team <pkg-amule-devel@lists.alioth.debian.org>:
Bug#507242; Package amule-daemon. (Wed, 30 Dec 2009 23:39:29 GMT) (full text, mbox, link).


Acknowledgement sent to Sandro Tosi <morph@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian aMule Team <pkg-amule-devel@lists.alioth.debian.org>. (Wed, 30 Dec 2009 23:39:29 GMT) (full text, mbox, link).


Reply sent to Sandro Tosi <morph@debian.org>:
You have taken responsibility. (Sun, 11 Jul 2010 13:18:17 GMT) (full text, mbox, link).


Notification sent to Klaas van den Berg <k_van_den_berg@hotmail.com>:
Bug acknowledged by developer. (Sun, 11 Jul 2010 13:18:17 GMT) (full text, mbox, link).


Message #57 received at 507242-done@bugs.debian.org (full text, mbox, reply):

From: Sandro Tosi <morph@debian.org>
To: 507242-done@bugs.debian.org, 369248-done@bugs.debian.org, 444152-done@bugs.debian.org, 480632-done@bugs.debian.org, 439599-done@bugs.debian.org, 350580-done@bugs.debian.org, 474454-done@bugs.debian.org
Subject: Re: [amule] Is your bug still valid with aMule 2.2.6?
Date: Sun, 11 Jul 2010 15:15:25 +0200
Hello,
these bugs are long-standing and received no reply after a ping
following 2.2.6 upload, hence I'm closing them now: please reopen if
some of them still apply.

Regards,
-- 
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 09 Aug 2010 07:33:38 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Jul 2 07:15:37 2023; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.