Debian Bug report logs - #506782
Patch 81_prevent-network-access.dpatch is not needed anymore

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Onkar Shinde" <onkarshinde@ubuntu.com>

To: BTS <submit@bugs.debian.org>

Subject: Patch 81_prevent-network-access.dpatch is not needed anymore

Date: Tue, 25 Nov 2008 00:29:36 +0530

Package: lucene2
Version: 2.4.0+ds1-1

In file contrib/highlighter/src/test/org/apache/lucene/search/highlight/HighlighterTest.java,
the xml snippet in the text testEncoding does not have reference to a
DTD anymore. So this unit test does not need any network access to
execute.

Hence patch 81_prevent-network-access.dpatch is not needed anymore.


Onkar

Message #10 received at 506782@bugs.debian.org (full text, mbox, reply):

From: Rene Engelhard <rene@debian.org>

To: Onkar Shinde <onkarshinde@ubuntu.com>, 506782@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: Bug#506782: Patch 81_prevent-network-access.dpatch is not needed anymore

Date: Wed, 26 Nov 2008 14:00:13 +0100

severity 506782 minor
thanks

Hi,

Onkar Shinde wrote:
> Package: lucene2
> Version: 2.4.0+ds1-1

Why is this a normal bug? ;-)

> In file contrib/highlighter/src/test/org/apache/lucene/search/highlight/HighlighterTest.java,
> the xml snippet in the text testEncoding does not have reference to a
> DTD anymore. So this unit test does not need any network access to
> execute.
> 
> Hence patch 81_prevent-network-access.dpatch is not needed anymore.

But it doesn't do harm, does it?

Regards,

Rene

Message #17 received at 506782@bugs.debian.org (full text, mbox, reply):

From: "Onkar Shinde" <onkarshinde@ubuntu.com>

To: "Rene Engelhard" <rene@debian.org>

Cc: 506782@bugs.debian.org

Subject: Re: Bug#506782: Patch 81_prevent-network-access.dpatch is not needed anymore

Date: Wed, 26 Nov 2008 19:11:23 +0530

On Wed, Nov 26, 2008 at 6:30 PM, Rene Engelhard <rene@debian.org> wrote:
> severity 506782 minor
> thanks
>
> Hi,
>
> Onkar Shinde wrote:
>> Package: lucene2
>> Version: 2.4.0+ds1-1
>
> Why is this a normal bug? ;-)

I wasn't sure of the priority.

>> In file contrib/highlighter/src/test/org/apache/lucene/search/highlight/HighlighterTest.java,
>> the xml snippet in the text testEncoding does not have reference to a
>> DTD anymore. So this unit test does not need any network access to
>> execute.
>>
>> Hence patch 81_prevent-network-access.dpatch is not needed anymore.
>
> But it doesn't do harm, does it?

It bypasses a unit test. Do you consider that serious?
Previously it couldn't run the unit test at all due to network access
required. So I guess it was ok to bypass it to fix build failure. But
now that unit test does not need network access, I think it is not
wise to bypass the unit test.


Onkar

Message #22 received at 506782@bugs.debian.org (full text, mbox, reply):

From: Rene Engelhard <rene@debian.org>

To: Onkar Shinde <onkarshinde@ubuntu.com>

Cc: 506782@bugs.debian.org

Subject: Re: Bug#506782: Patch 81_prevent-network-access.dpatch is not needed anymore

Date: Wed, 26 Nov 2008 14:48:47 +0100

Hi,

Onkar Shinde wrote:
> > But it doesn't do harm, does it?
> 
> It bypasses a unit test. Do you consider that serious?

Good point.

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  rene@debian.org | GnuPG-Key ID: 248AEB73
   `-   Fingerprint: 41FA F208 28D4 7CA5 19BB  7AD9 F859 90B0 248A EB73

Message #31 received at 506782-done@bugs.debian.org (full text, mbox, reply):

From: Jan-Pascal van Best <janpascal@vanbest.org>

To: 506782-done@bugs.debian.org

Subject: Fixed in lucene2 version 2.4.0+ds1-3

Date: Thu, 26 Feb 2009 23:36:55 +0100

[Message part 1 (text/plain, inline)]

Package: lucene2
Version: 2.4.0+ds1-3

The unit test that failed has been disabled upstream with the comment "remove 2 invalid tests of modified utf8 null byte".

Added a patch that disables this unit test for Debian, too.


-- 
Jan-Pascal van Best
janpascal@vanbest.org, janpascal@vanbest.eu
http://www.vanbest.org/janpascal/
GPG key fingerprint 4617 E5FB C56D ACB6 7C8C  DE64 3A4C B270 1A89 CC23 

[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.