Debian Bug report logs - #503317
function _dpkg_source contains a inappropriate exit statement

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Jonas Meyer <quitte@quitte.homeunix.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: bash completion acts weird on dpkg-source

Date: Fri, 12 May 2006 01:11:18 +0200

Package: bash
Version: 3.1-4
Severity: normal

if i type for example dpkg-source -i /u 
and press tab it changes it to:
dpkg-source -i -
and on the next tab this:
-b   -c   -D   -E   -F   -i   -I   -l   -sa  -sA  -sk  -sK  -sn  -sp  -sP
-sr  -sR  -ss  -su  -sU  -T   -U   -V   -W   -x
dpkg-source -x /u 
completes to /usr but then adds an extra space.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-1-686-smp
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)

Versions of packages bash depends on:
ii  base-files                    3.1.12     Debian base system miscellaneous f
ii  debianutils                   2.15.7     Miscellaneous utilities specific t
ii  libc6                         2.3.6-7    GNU C Library: Shared libraries
ii  libncurses5                   5.5-1.1    Shared libraries for terminal hand

bash recommends no packages.

-- no debconf information

Message #10 received at 366899@bugs.debian.org (full text, mbox, reply):

From: Frank Küster <frank@kuesterei.ch>

To: 366899@bugs.debian.org

Cc: Jonas Meyer <quitte@quitte.homeunix.org>

Subject: Re: bash completion acts weird on dpkg-source

Date: Fri, 02 Mar 2007 18:04:20 +0100

Jonas Meyer <quitte@quitte.homeunix.org> wrote:

> if i type for example dpkg-source -i /u 
> and press tab it changes it to:
> dpkg-source -i -
> and on the next tab this:
> -b   -c   -D   -E   -F   -i   -I   -l   -sa  -sA  -sk  -sK  -sn  -sp  -sP
> -sr  -sR  -ss  -su  -sU  -T   -U   -V   -W   -x
> dpkg-source -x /u 
> completes to /usr but then adds an extra space.

That the completion cannot properly handle absolute paths is not a
problem for me.  However, the added space is:

dpkg-source -x tru TAB gives

'dpkg-source -x trunk '

but of course what I want is 'dpkg-source -x trunk/'

Regards, Frank
-- 
Dr. Frank Küster
Single Molecule Spectroscopy, Protein Folding @ Inst. f. Biochemie, Univ. Zürich
Debian Developer (teTeX/TeXLive)

Message #19 received at 366899-quiet@bugs.debian.org (full text, mbox, reply):

From: David Paleino <d.paleino@gmail.com>

To: 366899-quiet@bugs.debian.org

Cc: Bash-Completion Developers <bash-completion-devel@lists.alioth.debian.org>, Jonas Meyer <quitte@quitte.homeunix.org>, Frank Küster <frank@kuesterei.ch>

Subject: Re: bash completion acts weird on dpkg-source

Date: Fri, 16 May 2008 22:51:15 +0200

[Message part 1 (text/plain, inline)]

tags 366899 wontfix confirmed
thanks

Hi Jonas, hi Frank,

On Fri, 12 May 2006 01:11:18 +0200, Jonas Meyer wrote:

> if i type for example dpkg-source -i /u 
> and press tab it changes it to:
> dpkg-source -i -
> and on the next tab this:
> -b   -c   -D   -E   -F   -i   -I   -l   -sa  -sA  -sk  -sK  -sn  -sp  -sP
> -sr  -sR  -ss  -su  -sU  -T   -U   -V   -W   -x
> dpkg-source -x /u 
> completes to /usr but then adds an extra space.

On Fri, 02 Mar 2007 18:04:20 +0100, Frank Küster wrote:

> Jonas Meyer <quitte@quitte.homeunix.org> wrote:
> 
> > if i type for example dpkg-source -i /u 
> > and press tab it changes it to:
> > dpkg-source -i -
> > and on the next tab this:
> > -b   -c   -D   -E   -F   -i   -I   -l   -sa  -sA  -sk  -sK  -sn  -sp  -sP
> > -sr  -sR  -ss  -su  -sU  -T   -U   -V   -W   -x
> > dpkg-source -x /u 
> > completes to /usr but then adds an extra space.
> 
> That the completion cannot properly handle absolute paths is not a
> problem for me.  However, the added space is:
> 
> dpkg-source -x tru TAB gives
> 
> 'dpkg-source -x trunk '
> 
> but of course what I want is 'dpkg-source -x trunk/'

I'm tagging this bug as "wontfix" (though it exists) because both of you are
using an incorrect dpkg-source syntax.

$ dpkg-source -h
Usage: dpkg-source [<option> ...] <command>

Commands:
  -x <filename>.dsc [<output-dir>]
                           extract source package.
[..]
$

What you're trying to do is using "/usr" (or "trunk") as output directories,
while dpkg-source (and its completion), "correctly" thinks they're Debian
Source Packages (and that's why it adds a space at the end -- "trunk " and not
"trunk/"; "/usr " and not "/usr/").

What you should do is:

$ dpkg-source -x filename.dsc directory/

I'm sorry that wouldn't be completed either: for the slash to be
appended, the directory must exist, but dpkg-source complains if the output
directory is already there:

$ mkdir foo
$ dpkg -x bash-completion_<TAB>
$ dpkg-source -x bash-completion_20060301-4.dsc fo<TAB>
foo  -sn  -sp  -su  
$ dpkg-source -x bash-completion_20060301-4.dsc foo/
dpkg-source: error: unpack target exists: foo
$

Thus, not adding a slash at the end of "foo" is quite correct when the
directory does not exist. If it existed, bash-completion would've added a
slash, but, once again, it *must not exist* for dpkg-source.

Kindly,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[signature.asc (application/pgp-signature, attachment)]

Message #24 received at 366899-quiet@bugs.debian.org (full text, mbox, reply):

From: Frank Küster <frank@kuesterei.ch>

To: David Paleino <d.paleino@gmail.com>

Cc: 366899-quiet@bugs.debian.org, Bash-Completion Developers <bash-completion-devel@lists.alioth.debian.org>, Jonas Meyer <quitte@quitte.homeunix.org>

Subject: Re: bash completion acts weird on dpkg-source

Date: Sat, 17 May 2008 11:04:47 +0200

David Paleino <d.paleino@gmail.com> wrote:

> I'm tagging this bug as "wontfix" (though it exists) because both of you are
> using an incorrect dpkg-source syntax.
>
> $ dpkg-source -h
> Usage: dpkg-source [<option> ...] <command>
>
> Commands:
>   -x <filename>.dsc [<output-dir>]
>                            extract source package.
> [..]
> $
>
> What you're trying to do is using "/usr" (or "trunk") as output directories,
> while dpkg-source (and its completion), "correctly" thinks they're Debian
> Source Packages (and that's why it adds a space at the end -- "trunk " and not
> "trunk/"; "/usr " and not "/usr/").

No, that's not what I'm trying to do. I'm trying to unpack a dsc that is
in a different directory:

dpkg-source -x some/where/else/whatever.dsc

But that is hard to type, because I have to type

dpkg-so TAB -x so TAB BKSP /wh TAB BKSP /e TAB BKSP /wh TAB

instead of

dpkg-so TAB -x so TAB wh TAB e TAB wh TAB

Regards, Frank

-- 
Frank Küster
Debian Developer (teTeX/TeXLive)

Message #31 received at 366899-quiet@bugs.debian.org (full text, mbox, reply):

From: David Paleino <d.paleino@gmail.com>

To: Frank Küster <frank@kuesterei.ch>

Cc: 366899-quiet@bugs.debian.org, Bash-Completion Developers <bash-completion-devel@lists.alioth.debian.org>, Jonas Meyer <jns@nebadje.org>

Subject: Re: bash completion acts weird on dpkg-source

Date: Sat, 17 May 2008 11:11:17 +0200

[Message part 1 (text/plain, inline)]

tags 366899 = confirmed
thanks

(using possible new address for Jonas)

On Sat, 17 May 2008 11:04:47 +0200, Frank Küster wrote:

> David Paleino <d.paleino@gmail.com> wrote:
> 
> > What you're trying to do is using "/usr" (or "trunk") as output directories,
> > while dpkg-source (and its completion), "correctly" thinks they're Debian
> > Source Packages (and that's why it adds a space at the end -- "trunk " and
> > not "trunk/"; "/usr " and not "/usr/").
> 
> No, that's not what I'm trying to do. I'm trying to unpack a dsc that is
> in a different directory:

ACK (sorry I didn't think that).

Tagging the bug as "confirmed" -- hope we can fix it :)

Kindly,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[signature.asc (application/pgp-signature, attachment)]

Message #36 received at 366899@bugs.debian.org (full text, mbox, reply):

From: "A.Politz" <politza@fh-trier.de>

To: Debian Bug Tracking System <366899@bugs.debian.org>

Subject: bash-completion: function _dpkg_source contains a inappropriate exit statement

Date: Mon, 20 Oct 2008 20:03:57 +0200

Package: bash-completion
Version: 20080705
Followup-For: Bug #366899


_dpkg_source contains a inappropriate exit statement, which forces
the shell to exit. I suppose this should be 'return' instead.

Reproduce: Open a bash-shell , type '_dpkg_source<RET>'.

Patch follows:

diff -c -L /su:root@localhost:/etc/bash_completion -L /tmp/buffer-content-2677a0z /tmp/tramp.2677M-C /tmp/buffer-content-2677a0z
*** /su:root@localhost:/etc/bash_completion
--- /tmp/buffer-content-2677a0z
***************
*** 4457,4463 ****
  
  	COMPREPLY=()
  	if [ "$1" != "dpkg-source" ]; then
! 		exit 1
  	fi
  	cur=`_get_cword`
  	prev=${COMP_WORDS[COMP_CWORD-1]}
--- 4457,4463 ----
  
  	COMPREPLY=()
  	if [ "$1" != "dpkg-source" ]; then
! 		return 1
  	fi
  	cur=`_get_cword`
  	prev=${COMP_WORDS[COMP_CWORD-1]}

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-486
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages bash-completion depends on:
ii  bash                          3.2-4      The GNU Bourne Again SHell

bash-completion recommends no packages.

bash-completion suggests no packages.

-- debconf-show failed

Message #51 received at 503317-close@bugs.debian.org (full text, mbox, reply):

From: David Paleino <d.paleino@gmail.com>

To: 503317-close@bugs.debian.org

Subject: Bug#503317: fixed in bash-completion 1:1.0-1

Date: Sat, 04 Apr 2009 13:47:04 +0000

Source: bash-completion
Source-Version: 1:1.0-1

We believe that the bug you reported is fixed in the latest version of
bash-completion, which is due to be installed in the Debian FTP archive:

bash-completion_1.0-1.diff.gz
  to pool/main/b/bash-completion/bash-completion_1.0-1.diff.gz
bash-completion_1.0-1.dsc
  to pool/main/b/bash-completion/bash-completion_1.0-1.dsc
bash-completion_1.0-1_all.deb
  to pool/main/b/bash-completion/bash-completion_1.0-1_all.deb
bash-completion_1.0.orig.tar.gz
  to pool/main/b/bash-completion/bash-completion_1.0.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 503317@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Paleino <d.paleino@gmail.com> (supplier of updated bash-completion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 03 Apr 2009 14:21:43 +0200
Source: bash-completion
Binary: bash-completion
Architecture: source all
Version: 1:1.0-1
Distribution: unstable
Urgency: low
Maintainer: Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>
Changed-By: David Paleino <d.paleino@gmail.com>
Description: 
 bash-completion - programmable completion for the bash shell
Closes: 272660 322238 360628 361535 489927 491856 492328 492476 494292 495142 495883 496162 496828 497074 497597 498105 499780 500316 501473 501843 502664 502804 502885 503317 503317 504141 504547 504650 506560 511789 511790 512556 512823 512917 516614 521041
Changes: 
 bash-completion (1:1.0-1) unstable; urgency=low
 .
   * New upstream release:
     - also see /usr/share/doc/bash-completion/CHANGES.gz
     - fix man -l completing filenames (Closes: #497074)
     - (Partly) fixed java classes completion (Closes: #496828). Look for
       FIXME in source.
     - dump to /dev/null error message from look(1) with no arguments
       (Closes: #495142)
     - set ssh as default for rsync (was rsh) (Closes: #492328)
     - added .oga, .ogv, .ogx to mplayer completion (Closes: #496162)
     - added .epub to unzip|zipinfo completion (Closes: #492476)
     - added ssh-copy-id completion (Closes: #491856)
     - moved ssh completion to separate file (Closes: #360628)
     - bogus completion when mounting subdirs fixed (Closes: #322238)
     - fix `apt-cache showsrc` completing only on source package names
       (Closes: #361535)
     - fixed bugs with gdb completion:
     - when an empty directory is in $PATH (thanks to Morita Sho)
       (Closes: #497597)
     - when a non-existing directory is in $PATH (Closes: #499780)
     - fix missing completion for "-n" and "-e" (we were using echo, now
       using printf) (thanks to Morita Sho) (Closes: #498105)
     - fixed gpg completion --@(export|@(?(l|nr|nrl)sign|edit)-key))
       (Closes: #500316)
     - fixed .cb[rz] completion for evince (Closes: #502885)
     - added gpg2 completion (Closes: #489927)
     - fixed mplayer -skin completion (Closes: #501473)
     - fixed errors with POSIX enabled (Closes: #502804)
     - fixed dpkg-source wrong exit() with return() (Closes: #503317)
     - added --schedule-only to aptitude's completion (Closes: #502664)
     - added build-dep to aptitude's completion (Closes: #495883)
     - added support for `-F configfile' to _known_hosts(), ssh, scp and
       sftp, thanks to Freddy Vulto (Closes: #504141)
     - fixed sed quoting bug in _known_hosts(), thanks to Freddy Vulto
       (Closes: #504650)
     - allow for comments in known_hosts files (Closes: #511789)
     - fixed perl -I/-x completion, thanks to Freddy Vulto
       (Closes: #504547)
     - README updated: explain how to use bash-completion correctly.
       (Closes: #506560)
     - added qdbus completion, thanks to Terence Simpson (LP: #257903)
     - fixed completion of environment variables, thanks to Morita Sho
       (Closes: #272660)
     - fix dpkg completion bug: it listed only non-Essential packages
       (Closes: #511790)
     - fixed _dpkg_source completion (Closes: #503317)
     - remove unused UNAME local variable in _info() (Closes: #501843)
     - added .zip to jar completions (Closes: #521041)
     - Merge from Ubuntu:
       + consume error messages in configure completion (LP: #223882)
         (Mika Fischer)
       + quote $xspec in _filedir_xspec in case it is empty, which would
         cause errors if there was no match under failglob. (LP: #194419)
         (Mika Fischer)
     - Ville Skyttä:
       + remove duplicate cpio completion, thanks to Freddy Vulto
         (Closes: #512823)
       + fix awk error in "modprobe -r /" completion (Closes: #512556)
     - Jakob Unterwurzacher:
       + ps2pdf can run on .pdf files as well.
         (Closes: #516614, LP: #316943)
   * debian/links fixed (Closes: #494292)
   * debian/control:
     - fixed typo in the long description
     - added Vcs-* fields
     - Standards-Version to 3.8.1
     - DMUA set
     - removed Luk Claes from Uploaders
     - Homepage added
   * debian/install:
     - correctly install contrib/* under /etc/bash_completion.d/
   * debian/copyright updated
   * debian/extra/dh_bash-completion:
     - updated to support a list of files in debian/<package>.bash-completion
       (Closes: #512917)
   * debian/rules:
     - install upstream CHANGES and AUTHORS too
Checksums-Sha1: 
 977d1414ca3556a4ad46aa2b48b9ca8e6e86a603 1308 bash-completion_1.0-1.dsc
 61040795731f5ff509c46e818a1edf0a7a93e11d 143578 bash-completion_1.0.orig.tar.gz
 49c583802082e3aa9a761fb0da0d5ec257f257bb 9002 bash-completion_1.0-1.diff.gz
 cb38e807d9b23e84b866e6e9d24814991a61836a 103010 bash-completion_1.0-1_all.deb
Checksums-Sha256: 
 d369f9436c02262d3de898564cd9b5269ace760cf6b7e0632e3b251ac431f2b5 1308 bash-completion_1.0-1.dsc
 bd96e7d2858f02783046908a984993736f1189d07d82e9ce4b465068dd7187ef 143578 bash-completion_1.0.orig.tar.gz
 04c46eff31bf9dfb9e79f417bd79706b6dc67888461ab05128b29cff78c9556b 9002 bash-completion_1.0-1.diff.gz
 81ab4b27a2158e787ea39c7da34619858a5df6b6251ba24d8bda6592feed46f4 103010 bash-completion_1.0-1_all.deb
Files: 
 6cb01d355c4519f911820b2b7c0feb53 1308 shells standard bash-completion_1.0-1.dsc
 cd1c5648272917fbe0eef4ba30bb93f4 143578 shells standard bash-completion_1.0.orig.tar.gz
 e78d5e31ed66fb5e97c77ea7c9f1b343 9002 shells standard bash-completion_1.0-1.diff.gz
 aefc9e1c8db0f4f2b61557c2e207ca0c 103010 shells standard bash-completion_1.0-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknXYZAACgkQ5UTeB5t8Mo0jGACfQVygJmdQ3v4i/dymRnZSVnhA
qHoAnjcS99HMQgFHzQ2NnNAY1OPvlPK6
=6i7t
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.