Debian Bug report logs - #501843
unused local variable UNAME in _info()

Toggle useless messages

Message #3 received at submit@bugs.debian.org (full text, mbox, reply):

From: Josh Triplett <josh@freedesktop.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: bash-completion: Many incorrect assumptions based on uname

Date: Tue, 07 Oct 2008 10:53:10 -0700

Package: bash-completion
Version: 20080705
Severity: normal

bash-completion extensively uses the value of uname -s to decide which
completions to provide, making assumptions that will fail for several
of Debian's non-Linux ports, or for more unusual systems running on
Linux.  In general, any reference to the uname in bash-completion
represents a bug, given that the kernel in use may not correlate with
expectations of userspace behavior.

Some of bash-completion's assumptions (not a complete list):

* bash-completion assumes that a uname of Linux implies that the "sed"
  command refers to GNU sed, while on other systems it aliases sed to
  "gsed" if present.  While not possible on Debian, someone could
  easily make a Linux system with GNU sed installed as "gsed" and some
  other standards-compliant sed installed as "sed".  Why bother having
  the check for Linux at all?  Just always use "gsed" if present.
  Incidentally, bash-completion also leaves the alias sed=gsed in
  place if added, which seems like a surprising side-effect to occur
  due to sourcing bash-completion.

* Completion for the "man", "apropos", and "whatis" commands depends
  on a uname of GNU, Linux, Darwin, FreeBSD, SunOS, Cygwin, or
  OpenBSD.  This misses at least NetBSD, if not others.  This
  completion seems applicable to any system which has the appropriate
  commands.  Furthermore, the completion function itself makes
  assumptions about how to determine manpaths based on a subset of
  those unames.

* Completion for killall, pkill, and pgrep depends on a uname of Linux
  or FreeBSD.  I suspect this relates to the identically named but
  drastically different SysV killall command, found as "killall5" on
  Debian systems.

* Completion for the commands pidof, ifup, ifdown, and ifstatus
  depends on a uname of Linux; however, these commands exist on other
  systems as well.  Checking for the presence of the command seems
  sufficient.

* Completion for the commands iwconfig, iwlist, iwspy, iwpriv, ipsec,
  and route depends on a uname of Linux.  While these commands indeed
  do run only on Linux, it seems better to simply check for the
  commands in question rather than the kernel in use.  That way, if
  the commands ever run on non-Linux systems, bash-completion will not
  need updating.  For instance, other systems have a "route" command
  which behaves similarly, though I do not know if the existing
  completions will work unmodified on it.

* Completion for the various GCC compilers occurs on any system, but
  only with a uname of GNU, Linux, or Cygwin will bash-completion add
  those same completions to the "cc" command.  bash-completion
  probably assumes that other systems will not have gcc installed as
  "cc".

* The completion for "info" declares a local variable "UNAME" but
  never uses it.

- Josh Triplett

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.27-rc7-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages bash-completion depends on:
ii  bash                          3.2-4      The GNU Bourne Again SHell

bash-completion recommends no packages.

bash-completion suggests no packages.

-- no debconf information

Message #38 received at 501843-close@bugs.debian.org (full text, mbox, reply):

From: David Paleino <d.paleino@gmail.com>

To: 501843-close@bugs.debian.org

Subject: Bug#501843: fixed in bash-completion 1:1.0-1

Date: Sat, 04 Apr 2009 13:47:04 +0000

Source: bash-completion
Source-Version: 1:1.0-1

We believe that the bug you reported is fixed in the latest version of
bash-completion, which is due to be installed in the Debian FTP archive:

bash-completion_1.0-1.diff.gz
  to pool/main/b/bash-completion/bash-completion_1.0-1.diff.gz
bash-completion_1.0-1.dsc
  to pool/main/b/bash-completion/bash-completion_1.0-1.dsc
bash-completion_1.0-1_all.deb
  to pool/main/b/bash-completion/bash-completion_1.0-1_all.deb
bash-completion_1.0.orig.tar.gz
  to pool/main/b/bash-completion/bash-completion_1.0.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 501843@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Paleino <d.paleino@gmail.com> (supplier of updated bash-completion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 03 Apr 2009 14:21:43 +0200
Source: bash-completion
Binary: bash-completion
Architecture: source all
Version: 1:1.0-1
Distribution: unstable
Urgency: low
Maintainer: Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>
Changed-By: David Paleino <d.paleino@gmail.com>
Description: 
 bash-completion - programmable completion for the bash shell
Closes: 272660 322238 360628 361535 489927 491856 492328 492476 494292 495142 495883 496162 496828 497074 497597 498105 499780 500316 501473 501843 502664 502804 502885 503317 503317 504141 504547 504650 506560 511789 511790 512556 512823 512917 516614 521041
Changes: 
 bash-completion (1:1.0-1) unstable; urgency=low
 .
   * New upstream release:
     - also see /usr/share/doc/bash-completion/CHANGES.gz
     - fix man -l completing filenames (Closes: #497074)
     - (Partly) fixed java classes completion (Closes: #496828). Look for
       FIXME in source.
     - dump to /dev/null error message from look(1) with no arguments
       (Closes: #495142)
     - set ssh as default for rsync (was rsh) (Closes: #492328)
     - added .oga, .ogv, .ogx to mplayer completion (Closes: #496162)
     - added .epub to unzip|zipinfo completion (Closes: #492476)
     - added ssh-copy-id completion (Closes: #491856)
     - moved ssh completion to separate file (Closes: #360628)
     - bogus completion when mounting subdirs fixed (Closes: #322238)
     - fix `apt-cache showsrc` completing only on source package names
       (Closes: #361535)
     - fixed bugs with gdb completion:
     - when an empty directory is in $PATH (thanks to Morita Sho)
       (Closes: #497597)
     - when a non-existing directory is in $PATH (Closes: #499780)
     - fix missing completion for "-n" and "-e" (we were using echo, now
       using printf) (thanks to Morita Sho) (Closes: #498105)
     - fixed gpg completion --@(export|@(?(l|nr|nrl)sign|edit)-key))
       (Closes: #500316)
     - fixed .cb[rz] completion for evince (Closes: #502885)
     - added gpg2 completion (Closes: #489927)
     - fixed mplayer -skin completion (Closes: #501473)
     - fixed errors with POSIX enabled (Closes: #502804)
     - fixed dpkg-source wrong exit() with return() (Closes: #503317)
     - added --schedule-only to aptitude's completion (Closes: #502664)
     - added build-dep to aptitude's completion (Closes: #495883)
     - added support for `-F configfile' to _known_hosts(), ssh, scp and
       sftp, thanks to Freddy Vulto (Closes: #504141)
     - fixed sed quoting bug in _known_hosts(), thanks to Freddy Vulto
       (Closes: #504650)
     - allow for comments in known_hosts files (Closes: #511789)
     - fixed perl -I/-x completion, thanks to Freddy Vulto
       (Closes: #504547)
     - README updated: explain how to use bash-completion correctly.
       (Closes: #506560)
     - added qdbus completion, thanks to Terence Simpson (LP: #257903)
     - fixed completion of environment variables, thanks to Morita Sho
       (Closes: #272660)
     - fix dpkg completion bug: it listed only non-Essential packages
       (Closes: #511790)
     - fixed _dpkg_source completion (Closes: #503317)
     - remove unused UNAME local variable in _info() (Closes: #501843)
     - added .zip to jar completions (Closes: #521041)
     - Merge from Ubuntu:
       + consume error messages in configure completion (LP: #223882)
         (Mika Fischer)
       + quote $xspec in _filedir_xspec in case it is empty, which would
         cause errors if there was no match under failglob. (LP: #194419)
         (Mika Fischer)
     - Ville Skyttä:
       + remove duplicate cpio completion, thanks to Freddy Vulto
         (Closes: #512823)
       + fix awk error in "modprobe -r /" completion (Closes: #512556)
     - Jakob Unterwurzacher:
       + ps2pdf can run on .pdf files as well.
         (Closes: #516614, LP: #316943)
   * debian/links fixed (Closes: #494292)
   * debian/control:
     - fixed typo in the long description
     - added Vcs-* fields
     - Standards-Version to 3.8.1
     - DMUA set
     - removed Luk Claes from Uploaders
     - Homepage added
   * debian/install:
     - correctly install contrib/* under /etc/bash_completion.d/
   * debian/copyright updated
   * debian/extra/dh_bash-completion:
     - updated to support a list of files in debian/<package>.bash-completion
       (Closes: #512917)
   * debian/rules:
     - install upstream CHANGES and AUTHORS too
Checksums-Sha1: 
 977d1414ca3556a4ad46aa2b48b9ca8e6e86a603 1308 bash-completion_1.0-1.dsc
 61040795731f5ff509c46e818a1edf0a7a93e11d 143578 bash-completion_1.0.orig.tar.gz
 49c583802082e3aa9a761fb0da0d5ec257f257bb 9002 bash-completion_1.0-1.diff.gz
 cb38e807d9b23e84b866e6e9d24814991a61836a 103010 bash-completion_1.0-1_all.deb
Checksums-Sha256: 
 d369f9436c02262d3de898564cd9b5269ace760cf6b7e0632e3b251ac431f2b5 1308 bash-completion_1.0-1.dsc
 bd96e7d2858f02783046908a984993736f1189d07d82e9ce4b465068dd7187ef 143578 bash-completion_1.0.orig.tar.gz
 04c46eff31bf9dfb9e79f417bd79706b6dc67888461ab05128b29cff78c9556b 9002 bash-completion_1.0-1.diff.gz
 81ab4b27a2158e787ea39c7da34619858a5df6b6251ba24d8bda6592feed46f4 103010 bash-completion_1.0-1_all.deb
Files: 
 6cb01d355c4519f911820b2b7c0feb53 1308 shells standard bash-completion_1.0-1.dsc
 cd1c5648272917fbe0eef4ba30bb93f4 143578 shells standard bash-completion_1.0.orig.tar.gz
 e78d5e31ed66fb5e97c77ea7c9f1b343 9002 shells standard bash-completion_1.0-1.diff.gz
 aefc9e1c8db0f4f2b61557c2e207ca0c 103010 shells standard bash-completion_1.0-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknXYZAACgkQ5UTeB5t8Mo0jGACfQVygJmdQ3v4i/dymRnZSVnhA
qHoAnjcS99HMQgFHzQ2NnNAY1OPvlPK6
=6i7t
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.