Debian Bug report logs - #501605
sympa: broken post-inst script

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Carl Fürstenberg <azatoth@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: sympa: broken post-inst script

Date: Wed, 08 Oct 2008 21:26:23 +0200

Package: sympa
Version: 5.3.4-6
Severity: grave
Justification: renders package unusable

Installation fails with following output:

Setting up sympa (5.3.4-6) ...
sed: -e expression #1, char 51: unknown option to `s'
dpkg: error processing sympa (--configure):
 subprocess post-installation script returned error exit status 1
Errors were encountered while processing:
 sympa
E: Sub-process /usr/bin/dpkg returned an error code (1)


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/1 CPU core)
Locale: LANG=sv_SE.UTF-8, LC_CTYPE=sv_SE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages sympa depends on:
ii  adduser                      3.110       add and remove users and groups
ii  cdebconf [debconf-2.0]       0.135       Debian Configuration Management Sy
ii  debconf [debconf-2.0]        1.5.23      Debian configuration management sy
ii  exim4-daemon-light [mail-tra 4.69-7      lightweight Exim MTA (v4) daemon
ii  libarchive-zip-perl          1.18-1      Module for manipulation of ZIP arc
ii  libc6                        2.7-13      GNU C Library: Shared libraries
ii  libcgi-fast-perl             5.10.0-15   CGI::Fast Perl module
ii  libcrypt-ciphersaber-perl    0.61-4      Perl module implementing CipherSab
ii  libdbd-mysql-perl            4.008-1     A Perl5 database interface to the 
ii  libdbi-perl                  1.607-1     Perl5 database interface by Tim Bu
ii  libintl-perl                 1.16-4      Uniforum message translations syst
ii  libio-stringy-perl           2.110-4     Perl modules for IO from scalars a
ii  libmailtools-perl            2.04-1      Manipulate email in perl programs
ii  libmd5-perl                  2.03-1      backwards-compatible wrapper for D
ii  libmime-charset-perl         1.006.2-2   Charset Informations for MIME
ii  libmime-encwords-perl        1.010.101-1 deal with RFC-1522 encoded words
ii  libmime-perl                 5.427-1     transitional dummy package
ii  libmime-tools-perl [libmime- 5.427-1     Perl5 modules for MIME-compliant m
ii  libmsgcat-perl               1.03-4+b1   Locale::Msgcat perl module
ii  libnet-ldap-perl             1:0.38-1    client interface to LDAP servers
ii  libtemplate-perl             2.20-1      template processing system written
ii  libxml-libxml-perl           1.66-1+b1   Perl module for using the GNOME li
ii  lsb-base                     3.2-20      Linux Standard Base 3.2 init scrip
ii  mhonarc                      2.6.16-1    Mail to HTML converter
ii  perl [libmime-base64-perl]   5.10.0-15   Larry Wall's Practical Extraction 
ii  perl-suid                    5.10.0-15   Runs setuid Perl scripts
ii  sysklogd [system-log-daemon] 1.5-5       System Logging Daemon

Versions of packages sympa recommends:
ii  doc-base                      0.8.16     utilities to manage online documen
ii  logrotate                     3.7.1-3    Log rotation utility

Versions of packages sympa suggests:
pn  libapache2-mod-fcgid          <none>     (no description available)
ii  libsoap-lite-perl             0.710.08-1 Client and server side SOAP implem
ii  lighttpd [httpd-cgi]          1.4.19-4   A fast webserver with minimal memo
ii  mysql-server-5.0 [mysql-serve 5.0.51a-15 MySQL database server binaries
ii  openssl                       0.9.8g-13  Secure Socket Layer (SSL) binary a

-- debconf information:
* sympa/listmaster: listmaster@aza.nehle.net
* wwsympa/wwsympa_url: http://aza.nehle.net/wws
* wwsympa/webserver_restart: true
* sympa/db_options:
* sympa/db_configured: false
* sympa/db_user: sympa
* wwsympa/webserver_type: Other
  sympa/wwsympa_configured: false
* sympa/language: en_US
  sympa/db_removeonpurge: false
  sympa/remove_spool: false
* sympa/hostname: aza.nehle.net
* sympa/db_hostname: localhost
* sympa/use_db: true
* sympa/use_soap: false
* wwsympa/fastcgi: true
  sympa/db_authtype: Ident-baserad
  sympa/db_port:
* sympa/db_name: sympa
* sympa/db_type: MySQL
* wwsympa/remove_spool: false
* sympa/use_wwsympa: true
* sympa/smime_support: true

Message #10 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Micah Anderson <micah@riseup.net>

To: 501605@bugs.debian.org

Cc: control@bugs.debian.org

Subject: I cannot reproduce this

Date: Wed, 8 Oct 2008 16:36:57 -0400

[Message part 1 (text/plain, inline)]

tag 501605 + unreproducible
thanks

I've just attempted to do an install of -6 myself and I did not get this
error:

Setting up sympa (5.3.4-6) ...
Configuration file read, default log level  0
Sympa 5.3.4 started
Conf::checkfiles() creating spool /var/spool/sympa/automatic
Conf::checkfiles() creating spool /var/spool/sympa/topic
Conf::checkfiles() creating spool /var/spool/sympa/bounce
Conf::checkfiles() creating spool /var/spool/sympa/subscribe
Conf::checkfiles() creating spool /var/spool/sympa/distribute
Conf::checkfiles() creating spool /var/spool/sympa/msg/bad
Conf::checkfiles() creating spool /var/spool/sympa/distribute/bad
Conf::checkfiles() creating spool /var/spool/sympa/automatic/bad
Conf::checkfiles() Updating static CSS file
/var/lib/sympa/static_content/css/style.css ; previous file renamed
Conf::checkfiles() Updating static CSS file
/var/lib/sympa/static_content/css/print.css ; previous file renamed
Conf::checkfiles() Updating static CSS file
/var/lib/sympa/static_content/css/fullPage.css ; previous file renamed
Conf::checkfiles() Updating static CSS file
/var/lib/sympa/static_content/css/print-preview.css ; previous file
renamed
Language::SetLang() Language::SetLang(), missing locale parameter
Upgrade process...
Upgrading from  to 5.3.4...
Upgrade::upgrade() Upgrade::upgrade(, 5.3.4)
Upgrade::upgrade() Rebuilding config.bin files for ALL lists...it may
take a while...
Upgrade::upgrade() Rebuilding the admin_table...
Upgrade::upgrade() Migrating templates to TT2 format...
Upgrade::upgrade() Rebuilding web archives...
Upgrade::upgrade() Initializing the new admin_table...
Upgrade::upgrade() Old web templates HTML structure is not compliant
with latest ones.
Upgrade::upgrade() Moving old-style web templates out of the
include_path...
Upgrade::upgrade() Cleaning buggy list config files...
Upgrade::upgrade() Rename archives/log. files...
Upgrade::upgrade() Updating the new robot_subscriber and robot_admin  Db
fields...
Upgrade::upgrade() Renaming web archive directories with the list
domain...
Upgrade::upgrade() Updating subscribed field of the subscriber table...
Upgrade::upgrade() 0 rows have been updated
Upgrade::upgrade() Updating subscribed field of the subscriber table...
Upgrade::upgrade() 0 rows have been updated
Upgrade::upgrade() Updating subscribed field of the subscriber table...
Upgrade::upgrade() 0 rows have been updated
Upgrade::upgrade() Updating subscribed field of the subscriber table...
Upgrade::upgrade() 0 rows have been updated
Upgrade::upgrade() Renaming bounce sub-directories adding list domain...
Upgrade::upgrade() Update lists config using include_list parameter...
Upgrade::upgrade() Looking for customized mhonarc-ressources.tt2
files...
Upgrade::upgrade() Rebuilding web archives...
Upgrade::upgrade() Q-Encoding web documents filenames...
Upgrade::upgrade() Encoding all custom files to UTF-8...
Upgrade::upgrade() 0 files have been modified
Upgrade process finished.
Starting Sympa mailing list manager: sympa.
Starting Sympa mailing list archive manager: archived.
Starting Sympa task manager: task_manager.
Starting Sympa bounce manager: bounced.
Reading package lists... Done             
Building dependency tree       
Reading state information... Done
Reading extended state information       
Initializing package states... Done
Writing extended state information... Done
Reading task descriptions... Done         

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Patrick Schoenfeld <schoenfeld@in-medias-res.com>

To: 501605@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: sympa: broken post-inst script

Date: Thu, 9 Oct 2008 13:42:39 +0200

Severity 501605 important
thanks

Hi,

I have tested the installation of sympa as well and I can't reproduce
the problem. Additional I auditted the post-inst script and I can't see
any condition under which one of the sed commands could fail. All seem
reasonable and don't fail when I test them manually in a dash or a in a
zsh with values as specified by the user.

It seems as if this is no bug, but as I'm neither the bug submitter,
nor the maintainer I don't want to close this issue. However as it does
only affect one person, isn't reproducable and there is no error visible
in the script this is clearly not rc-critical, so I'm lowering the
severity to important.

Best Regards,
Patrick

Message #24 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Niko Tyni <ntyni@debian.org>

To: Patrick Schoenfeld <schoenfeld@in-medias-res.com>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Thu, 9 Oct 2008 15:17:43 +0300

severity 501605 serious
tag 501605 - unreproducible
thanks

On Thu, Oct 09, 2008 at 01:42:39PM +0200, Patrick Schoenfeld wrote:
> Severity 501605 important
> thanks

> I have tested the installation of sympa as well and I can't reproduce
> the problem. Additional I auditted the post-inst script and I can't see
> any condition under which one of the sed commands could fail. All seem
> reasonable and don't fail when I test them manually in a dash or a in a
> zsh with values as specified by the user.

+ db_get sympa/key_password
+ _db_cmd 'GET sympa/key_password'
+ IFS=' '
+ printf '%s\n' 'GET sympa/key_password'
+ IFS='
'
+ read -r _db_internal_line
+ RET=a/b/c
+ case ${_db_internal_line%%[   ]*} in
+ return 0
+ key_password=a/b/c
+ sed -e s/@KEY_PASSWORD@/a/b/c/ /etc/sympa/sympa.conf-smime.in
sed: -e expression #1, char 20: unknown option to `s'

Line 212 in the postinst breaks if sympa/key_password contains sed
metacharacters, for instance 'a/b/c' as above.

This looks RC to me, so upgrading back.
-- 
Niko Tyni   ntyni@debian.org

Message #33 received at 501605@bugs.debian.org (full text, mbox, reply):

From: "Stefan Hornburg (Racke)" <racke@linuxia.de>

To: Niko Tyni <ntyni@debian.org>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Thu, 09 Oct 2008 14:37:23 +0200

Niko Tyni wrote:
> severity 501605 serious
> tag 501605 - unreproducible
> thanks
> 
> On Thu, Oct 09, 2008 at 01:42:39PM +0200, Patrick Schoenfeld wrote:
>> Severity 501605 important
>> thanks
> 
>> I have tested the installation of sympa as well and I can't reproduce
>> the problem. Additional I auditted the post-inst script and I can't see
>> any condition under which one of the sed commands could fail. All seem
>> reasonable and don't fail when I test them manually in a dash or a in a
>> zsh with values as specified by the user.
> 
> + db_get sympa/key_password
> + _db_cmd 'GET sympa/key_password'
> + IFS=' '
> + printf '%s\n' 'GET sympa/key_password'
> + IFS='
> '
> + read -r _db_internal_line
> + RET=a/b/c
> + case ${_db_internal_line%%[   ]*} in
> + return 0
> + key_password=a/b/c
> + sed -e s/@KEY_PASSWORD@/a/b/c/ /etc/sympa/sympa.conf-smime.in
> sed: -e expression #1, char 20: unknown option to `s'
> 
> Line 212 in the postinst breaks if sympa/key_password contains sed
> metacharacters, for instance 'a/b/c' as above.
> 
> This looks RC to me, so upgrading back.

OK, that should certainly be fixed. Thanks for the assistance.

Regards
         Racke


-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team

Message #38 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Patrick Schoenfeld <schoenfeld@in-medias-res.com>

To: Niko Tyni <ntyni@debian.org>

Cc: 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Thu, 9 Oct 2008 15:58:59 +0200

Hi,

On Thu, Oct 09, 2008 at 03:17:43PM +0300, Niko Tyni wrote:
> Line 212 in the postinst breaks if sympa/key_password contains sed
> metacharacters, for instance 'a/b/c' as above.
> 
> This looks RC to me, so upgrading back.

I already had this line in suspect, but I didn't think about that. Good.
Should be easy fixable, will provide a patch in an hour or two.

Regards,
Patrick

Message #43 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Patrick Schoenfeld <schoenfeld@in-medias-res.com>

To: Niko Tyni <ntyni@debian.org>

Cc: 501605@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Thu, 9 Oct 2008 17:25:50 +0200

[Message part 1 (text/plain, inline)]

Tags 501605 +patch
thanks

Hi,

On Thu, Oct 09, 2008 at 03:17:43PM +0300, Niko Tyni wrote:
> Line 212 in the postinst breaks if sympa/key_password contains sed
> metacharacters, for instance 'a/b/c' as above.

attached is a patch for this issue.

Best Regards,
Patrick

[501605.patch (text/x-diff, attachment)]

Message #50 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Stefan Hornburg <racke@linuxia.de>

To: Patrick Schoenfeld <schoenfeld@in-medias-res.com>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 09:46:27 +0200

Patrick Schoenfeld wrote:
> Tags 501605 +patch
> thanks
> 
> Hi,
> 
> On Thu, Oct 09, 2008 at 03:17:43PM +0300, Niko Tyni wrote:
>> Line 212 in the postinst breaks if sympa/key_password contains sed
>> metacharacters, for instance 'a/b/c' as above.
> 
> attached is a patch for this issue.

Thanks for the patch! Did you test it already?

Regards
        Racke


-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team

Message #55 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Patrick Schoenfeld <schoenfeld@in-medias-res.com>

To: Stefan Hornburg <racke@linuxia.de>

Cc: 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 09:48:36 +0200

Hi,

On Fri, Oct 10, 2008 at 09:46:27AM +0200, Stefan Hornburg wrote:
> Thanks for the patch! Did you test it already?

I tested it manually with a testscript containing only that code and 
RET="fo4b/!bar" or something. That worked fine. I didn't test it under
real conditions though. Its probably a good idea to test it under real
conditions, too.

Best Regards,
Patrick

Message #64 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Stefan Hornburg <racke@linuxia.de>

To: Patrick Schoenfeld <schoenfeld@in-medias-res.com>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 09:57:06 +0200

Patrick Schoenfeld wrote:
> Hi,
> 
> On Fri, Oct 10, 2008 at 09:46:27AM +0200, Stefan Hornburg wrote:
>> Thanks for the patch! Did you test it already?
> 
> I tested it manually with a testscript containing only that code and 
> RET="fo4b/!bar" or something. That worked fine. I didn't test it under
> real conditions though. Its probably a good idea to test it under real
> conditions, too.
> 

OK, I'll add the patch and run some tests.

Regards
         Racke



-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team

Message #69 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Olivier Berger <olivier.berger@it-sudparis.eu>

To: Patrick Schoenfeld <schoenfeld@in-medias-res.com>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 10:16:29 +0200

On Thu, Oct 09, 2008 at 05:25:50PM +0200, Patrick Schoenfeld wrote:
> Hi,
> 
> On Thu, Oct 09, 2008 at 03:17:43PM +0300, Niko Tyni wrote:
> > Line 212 in the postinst breaks if sympa/key_password contains sed
> > metacharacters, for instance 'a/b/c' as above.
> 
> attached is a patch for this issue.
> 
> Best Regards,
> Patrick

> --- sympa-5.3.4/debian/postinst	2008-10-09 17:20:42.000000000 +0200
> +++ sympa-5.3.4.patched/debian/postinst	2008-10-09 17:20:18.433756307 +0200
> @@ -208,8 +208,10 @@
>  	if ! grep -q "^#-- S/MIME configuration" /etc/sympa/sympa.conf ; then
>  	    db_get sympa/key_password
>  	    key_password="$RET"
> +	    # Escape the character which is used in the sed command
> +	    key_password="`echo $key_password|sed 's/|/\\\|/g'`"
>  
> -	    sed -e "s/@KEY_PASSWORD@/$key_password/" \
> +	    sed -e "s|@KEY_PASSWORD@|$key_password|" \
>  	    /etc/sympa/sympa.conf-smime.in >>/etc/sympa/sympa.conf
>  	    chown sympa:sympa /etc/sympa/sympa.conf
>  	fi

What if one uses something like '\' characther in the password ?

I think maintainers of other packages are instead using perl and not sed, using a variable's value in the substitution, which helps get rid of those nasty special characters meanings in sed regexps.

For instance in twiki package I noticed things like :
perl -pi~ -e '$U=q{'"$RET"'}; s{http://your.domain.com}{$U}g;' /etc/twiki/apache.conf

I'm not completely sure of what I'm proposing here, but I hope this helps.

Best regards,

Message #74 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Stefan Hornburg <racke@linuxia.de>

To: Olivier Berger <olivier.berger@it-sudparis.eu>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 10:23:43 +0200

Olivier Berger wrote:
> On Thu, Oct 09, 2008 at 05:25:50PM +0200, Patrick Schoenfeld wrote:
>> Hi,
>>
>> On Thu, Oct 09, 2008 at 03:17:43PM +0300, Niko Tyni wrote:
>>> Line 212 in the postinst breaks if sympa/key_password contains sed
>>> metacharacters, for instance 'a/b/c' as above.
>> attached is a patch for this issue.
>>
>> Best Regards,
>> Patrick
> 
>> --- sympa-5.3.4/debian/postinst	2008-10-09 17:20:42.000000000 +0200
>> +++ sympa-5.3.4.patched/debian/postinst	2008-10-09 17:20:18.433756307 +0200
>> @@ -208,8 +208,10 @@
>>  	if ! grep -q "^#-- S/MIME configuration" /etc/sympa/sympa.conf ; then
>>  	    db_get sympa/key_password
>>  	    key_password="$RET"
>> +	    # Escape the character which is used in the sed command
>> +	    key_password="`echo $key_password|sed 's/|/\\\|/g'`"
>>  
>> -	    sed -e "s/@KEY_PASSWORD@/$key_password/" \
>> +	    sed -e "s|@KEY_PASSWORD@|$key_password|" \
>>  	    /etc/sympa/sympa.conf-smime.in >>/etc/sympa/sympa.conf
>>  	    chown sympa:sympa /etc/sympa/sympa.conf
>>  	fi
> 
> What if one uses something like '\' characther in the password ?
> 
> I think maintainers of other packages are instead using perl and not sed, using a variable's value in the substitution, which helps get rid of those nasty special characters meanings in sed regexps.
> 
> For instance in twiki package I noticed things like :
> perl -pi~ -e '$U=q{'"$RET"'}; s{http://your.domain.com}{$U}g;' /etc/twiki/apache.conf
> 
> I'm not completely sure of what I'm proposing here, but I hope this helps.

I mused about that too. Also, couldn't we avoid the quoting issue at all by using
export and $ENV in Perl?

Regards
        Racke

-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team

Message #79 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Stefan Hornburg <racke@linuxia.de>

To: Patrick Schoenfeld <schoenfeld@in-medias-res.com>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 10:29:58 +0200

Patrick Schoenfeld wrote:
> Hi,
> 
> On Fri, Oct 10, 2008 at 09:46:27AM +0200, Stefan Hornburg wrote:
>> Thanks for the patch! Did you test it already?
> 
> I tested it manually with a testscript containing only that code and 
> RET="fo4b/!bar" or something. That worked fine. I didn't test it under
> real conditions though. Its probably a good idea to test it under real
> conditions, too.

It fails with a backslash as Olivier pointed out:

a/b|c\

Regards
        Racke



-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team

Message #84 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Stefan Hornburg <racke@linuxia.de>

To: Olivier Berger <olivier.berger@it-sudparis.eu>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 14:19:02 +0200

[Message part 1 (text/plain, inline)]

Olivier Berger wrote:
> On Thu, Oct 09, 2008 at 05:25:50PM +0200, Patrick Schoenfeld wrote:
>> Hi,
>>
>> On Thu, Oct 09, 2008 at 03:17:43PM +0300, Niko Tyni wrote:
>>> Line 212 in the postinst breaks if sympa/key_password contains sed
>>> metacharacters, for instance 'a/b/c' as above.
>> attached is a patch for this issue.
>>
>> Best Regards,
>> Patrick
> 
>> --- sympa-5.3.4/debian/postinst	2008-10-09 17:20:42.000000000 +0200
>> +++ sympa-5.3.4.patched/debian/postinst	2008-10-09 17:20:18.433756307 +0200
>> @@ -208,8 +208,10 @@
>>  	if ! grep -q "^#-- S/MIME configuration" /etc/sympa/sympa.conf ; then
>>  	    db_get sympa/key_password
>>  	    key_password="$RET"
>> +	    # Escape the character which is used in the sed command
>> +	    key_password="`echo $key_password|sed 's/|/\\\|/g'`"
>>  
>> -	    sed -e "s/@KEY_PASSWORD@/$key_password/" \
>> +	    sed -e "s|@KEY_PASSWORD@|$key_password|" \
>>  	    /etc/sympa/sympa.conf-smime.in >>/etc/sympa/sympa.conf
>>  	    chown sympa:sympa /etc/sympa/sympa.conf
>>  	fi
> 
> What if one uses something like '\' characther in the password ?

The attached patch is tested with the string "a/b|c\".

It should be more robust by principle as the replacement string is read from environment 
and special quoting isn't needed.

Regards
        Racke



-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team

[key_passwd.patch (text/x-diff, inline)]

Index: postinst
===================================================================
RCS file: /home/cvs/debian/sympa/debian/postinst,v
retrieving revision 1.67.2.3
diff -u -r1.67.2.3 postinst
--- postinst	5 Oct 2008 09:51:13 -0000	1.67.2.3
+++ postinst	10 Oct 2008 12:16:15 -0000
@@ -208,8 +208,9 @@
 	if ! grep -q "^#-- S/MIME configuration" /etc/sympa/sympa.conf ; then
 	    db_get sympa/key_password
 	    key_password="$RET"
+		export key_password
 
-	    sed -e "s/@KEY_PASSWORD@/$key_password/" \
+	    perl -p -e 's/\@KEY_PASSWORD\@/$ENV{key_password}/' \
 	    /etc/sympa/sympa.conf-smime.in >>/etc/sympa/sympa.conf
 	    chown sympa:sympa /etc/sympa/sympa.conf
 	fi

Message #89 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Olivier Berger <olivier.berger@it-sudparis.eu>

To: Stefan Hornburg <racke@linuxia.de>

Cc: 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 15:06:26 +0200

Le vendredi 10 octobre 2008 à 14:19 +0200, Stefan Hornburg a écrit :

> It should be more robust by principle as the replacement string is read from environment 
> and special quoting isn't needed.

Hmmm... the fact that it keeps in the environment afterwards is
something a bit problematic (thinking in paranoid mode)... maybe
something like :
key_password="$RET" perl -p -e 's/\@KEY_PASSWORD\@/$ENV{key_password}/' ... ?

My 2 cents again,
-- 
Olivier BERGER <olivier.berger@it-sudparis.eu>
http://www-public.it-sudparis.eu/~berger_o/ - OpenPGP-Id: 1024D/6B829EEC
Ingénieur Recherche - Dept INF
Institut TELECOM, SudParis (http://www.it-sudparis.eu/), Evry (France)

Message #94 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Stefan Hornburg <racke@linuxia.de>

To: Olivier Berger <olivier.berger@it-sudparis.eu>, 501605@bugs.debian.org

Subject: Re: Bug#501605: sympa: broken post-inst script

Date: Fri, 10 Oct 2008 15:20:34 +0200

Olivier Berger wrote:
> Le vendredi 10 octobre 2008 à 14:19 +0200, Stefan Hornburg a écrit :
> 
>> It should be more robust by principle as the replacement string is read from environment 
>> and special quoting isn't needed.
> 
> Hmmm... the fact that it keeps in the environment afterwards is
> something a bit problematic (thinking in paranoid mode)... maybe
> something like :
> key_password="$RET" perl -p -e 's/\@KEY_PASSWORD\@/$ENV{key_password}/' ... ?
> 

Good idea.

Regards
        Racke


-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team

Message #99 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Carl Fürstenberg <azatoth@gmail.com>

To: Debian Bug Tracking System <501605@bugs.debian.org>

Subject: sympa: the password in question

Date: Fri, 10 Oct 2008 20:02:47 +0200

Package: sympa
Followup-For: Bug #501605

As it seems that it's the password that made is break, I thought I
should give you the password in question I was using. I generated it
using pwsafe and was "%$sne_7&mCxEaOk&SL\rzg%lyG<NyDM2/ZEK"

Message #104 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Thomas Viehmann <tv@beamnet.de>

To: 501605@bugs.debian.org

Subject: status?

Date: Sat, 18 Oct 2008 14:22:01 +0200

Hi,

what's the status of this?
If we're going to keep sympa, this should be fixed, I'd like to see an
upload this weekend and will do so myself if no one else does before that.

Kind regards

T.
-- 
Thomas Viehmann, http://thomas.viehmann.net/

Message #109 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Thomas Viehmann <tv@beamnet.de>

To: 501605@bugs.debian.org

Subject: sympa: diff for NMU version 5.3.4-6.1

Date: Sun, 19 Oct 2008 23:18:54 +0200

tags 501605 + patch pending
thanks

I've prepared an NMU for sympa (versioned as 5.3.4-6.1) and uploaded it.
Note that the sympa.pl --upgrade call you introduced in your last
upload is wrong when sympa is configured to not have a database (you
ask the user whether he wants to do that, so it must work).

Kind regards

T.

diff -u sympa-5.3.4/debian/changelog sympa-5.3.4/debian/changelog
--- sympa-5.3.4/debian/changelog
+++ sympa-5.3.4/debian/changelog
@@ -1,3 +1,12 @@
+sympa (5.3.4-6.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix password handling in debian/postinst. Closes: #501605
+  * Don't call sympa.pl --upgrade when no db_type/db_name is specified.
+    Needed for testing the above change.
+
+ -- Thomas Viehmann <tv@beamnet.de>  Sun, 19 Oct 2008 23:08:14 +0200
+
 sympa (5.3.4-6) unstable; urgency=low
 
   * fix usage of $* Perl variable deprecated in Perl 5.10 
diff -u sympa-5.3.4/debian/postinst sympa-5.3.4/debian/postinst
--- sympa-5.3.4/debian/postinst
+++ sympa-5.3.4/debian/postinst
@@ -207,9 +207,8 @@
     if [ -f /usr/bin/openssl ]; then
 	if ! grep -q "^#-- S/MIME configuration" /etc/sympa/sympa.conf ; then
 	    db_get sympa/key_password
-	    key_password="$RET"
-
-	    sed -e "s/@KEY_PASSWORD@/$key_password/" \
+	    key_password="$RET" \
+	    perl -p -e 's/\@KEY_PASSWORD\@/$ENV{key_password}/' \
 	    /etc/sympa/sympa.conf-smime.in >>/etc/sympa/sympa.conf
 	    chown sympa:sympa /etc/sympa/sympa.conf
 	fi
@@ -481,7 +480,9 @@
 # The upgrade script figures out on its own
 # whether upgrade actions are necessary or not.
 
-/usr/lib/sympa/bin/sympa.pl --upgrade
+if [ $( awk '/^[\t ]*db_type[\t ]/ { a = 1 } /^[\t ]*db_name[\t ]/ { b = 1 }  END { print a+b }' /etc/sympa/sympa.conf) = 2 ] ; then
+    /usr/lib/sympa/bin/sympa.pl --upgrade
+fi
  
 ## End up with debconf
 db_stop

Message #116 received at 501605-close@bugs.debian.org (full text, mbox, reply):

From: Thomas Viehmann <tv@beamnet.de>

To: 501605-close@bugs.debian.org

Subject: Bug#501605: fixed in sympa 5.3.4-6.1

Date: Sun, 19 Oct 2008 21:32:06 +0000

Source: sympa
Source-Version: 5.3.4-6.1

We believe that the bug you reported is fixed in the latest version of
sympa, which is due to be installed in the Debian FTP archive:

sympa_5.3.4-6.1.diff.gz
  to pool/main/s/sympa/sympa_5.3.4-6.1.diff.gz
sympa_5.3.4-6.1.dsc
  to pool/main/s/sympa/sympa_5.3.4-6.1.dsc
sympa_5.3.4-6.1_amd64.deb
  to pool/main/s/sympa/sympa_5.3.4-6.1_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 501605@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Viehmann <tv@beamnet.de> (supplier of updated sympa package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 19 Oct 2008 23:08:14 +0200
Source: sympa
Binary: sympa
Architecture: source amd64
Version: 5.3.4-6.1
Distribution: unstable
Urgency: low
Maintainer: Stefan Hornburg (Racke) <racke@linuxia.de>
Changed-By: Thomas Viehmann <tv@beamnet.de>
Description: 
 sympa      - Modern mailing list manager
Closes: 501605
Changes: 
 sympa (5.3.4-6.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Fix password handling in debian/postinst. Closes: #501605
   * Don't call sympa.pl --upgrade when no db_type/db_name is specified.
     Needed for testing the above change.
Checksums-Sha1: 
 faab85eaf21dc99717f332a7ed7e6d11ac5f0d22 992 sympa_5.3.4-6.1.dsc
 07be6a18b8c32c7fe0546650fce90dc8f7b4d566 110871 sympa_5.3.4-6.1.diff.gz
 b267a49709fa9fbb287bc9770b525930462b99b4 3115328 sympa_5.3.4-6.1_amd64.deb
Checksums-Sha256: 
 f3cb7709991d60bf55ec1ac9df08a503c94347e6e03087c5b4a1be44d602d51b 992 sympa_5.3.4-6.1.dsc
 9421c6476bdde562bc7fd56ee87d99411ba0a37c586578accac1205481ad39c8 110871 sympa_5.3.4-6.1.diff.gz
 f03720bcb46445c4b4b5023fff3b3ec5ba845ab6df553ed6a64016c82b887978 3115328 sympa_5.3.4-6.1_amd64.deb
Files: 
 69bcc8c078eeadd8e5e702afd7bc2e3a 992 mail optional sympa_5.3.4-6.1.dsc
 a49e7dca771610a908090bc06cca86a3 110871 mail optional sympa_5.3.4-6.1.diff.gz
 c507daf2195c7eed37f6624241f83472 3115328 mail optional sympa_5.3.4-6.1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkj7pMoACgkQriZpaaIa1PlWAgCdFcrDE1sKAeNk3gHQT1rli1ES
Od0AoNxs0KqW4nkpBQZeCZP+mQJrsajw
=+7dM
-----END PGP SIGNATURE-----

Message #123 received at 501605@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: Tim Retout <tim.retout@credativ.co.uk>, 501605@bugs.debian.org

Subject: Re: Processed: tagging 501605

Date: Wed, 5 Aug 2009 19:42:52 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi Tim,

First off, please post to 501605@bugs.debian.org instead of privately, 
thanks.

On Wed, Aug 05, 2009 at 05:50:44PM +0100, Tim Retout wrote:
>On Wed, 2009-08-05 at 16:42 +0000, Debian Bug Tracking System wrote:
>> Processing commands for control@bugs.debian.org:
>>
>> > tags 501605 pending
>> Bug #501605 {Done: Thomas Viehmann <tv@beamnet.de>} [sympa] sympa: broken post-inst script
>               ^^^^
>Are you sure? :)

It helps tremendously if you express more elaborately what you want to 
say, to avoid risk of misunderstandings (and to not put the burden of 
guessing on the reader).

If you mean to ask if I am sure that a bug previously closed and then 
later on reopened due to regression in the packaging, then yes, I am 
pretty certain. :-)

Here is the content of most recent git commit to the sympa packaging:


commit 287ebbcf5c225865163676524b4b1c1fc5305f2e
Author: Jonas Smedegaard <dr@jones.dk>
Date:   Wed Aug 5 18:23:31 2009 +0200

    Fix password handling in debian/postinst. Closes: #501605 
(resurrected from 5.3.4-6.1), thanks to Thomas Viehmann and others.

diff --git a/debian/postinst b/debian/postinst
index d57c192..6f4b982 100644
- --- a/debian/postinst
+++ b/debian/postinst
@@ -216,9 +216,8 @@ if [ $smime = "true" ]; then
        if [ -f /usr/bin/openssl ]; then
                if ! grep -q "^#-- S/MIME configuration" "$conf" ; then
                        db_get sympa/key_password
- -                       key_password="$RET"
- -
- -                       sed -e "s/@KEY_PASSWORD@/$key_password/" \
+                       key_password="$RET" \
+                       perl -p -e 's/\@KEY_PASSWORD\@/$ENV{key_password}/' \
                        /etc/sympa/sympa.conf-smime.in >>"$conf"
                        chown sympa:sympa "$conf"
                fi


I am not _absolutely_ certain.  I can make mistakes, of course.  Like 
misunderstanding what you ask for certainty about...

So please elaborate, if you still feel that I might be wrong about this 
one.


Kind regards,

 - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCgAGBQJKecScAAoJECx8MUbBoAEhfLIP/0u0u2sBYR59EO9EE1dtjHV+
Nv7HYFNU0JMNKtJLVu3EfFX7nqIKKWqq+gyVNkGhLE0oH2vhD3FLddTQYgXj31w6
MLKFleY6u3fc6u1Jj/1+Q3H89SD4HTiiaAv2vtAM26cv4dewpltenvUduePG2GM3
xSd/kA/xIelgz+j6+DS893XQvWu/TL0S5+Oj5+jR30tOnsMVBtYKCS38vn/bYg1v
yxkDFG8tA2itKRRFfz6g0zMP99e/HURyS6YaHV7bJtIDDvWFNmLcGzKvjV3fTVDW
QFHq4IMmykA+UNMS0aRjgRZUGtfop4WbSZV1SVhDYQgyVLxDmMTZEuj7TeaKNvnp
0kn6N8+t970ooGTGRKctlYcV3dDaZGKnkgGgg4BD2y/7DUu8D8hTZNkZVBUF/mxO
kMKicwbR3nzVSu3/L846AoW0r66zs9uDrvzo1DxxVMtsuIxMsgrT1/HadreDg0Q/
1K6MGjuGXaz2+jFWVY3HoeieAbRWY9KLoCF+5Lyk0GXhCjxDXBP3LpqO+M+iVLhf
pz94gyAC93wCGfDbPDY/ncYjHY4/5kjAzv60ECjsvIoGoEkqz8X8aURew31RwW9x
9h4/e4Bvwq6H3v5zxwNS+2XZohJP1RmaUltqLogkuw5+6lnQBd83WU6MgNBpRl7D
SNOyT/V8B8sa3hgN8yXg
=QjWB
-----END PGP SIGNATURE-----

Message #128 received at 501605-close@bugs.debian.org (full text, mbox, reply):

From: Stefan Hornburg (Racke) <racke@linuxia.de>

To: 501605-close@bugs.debian.org

Subject: Bug#501605: fixed in sympa 6.0.1-1

Date: Mon, 12 Apr 2010 17:59:43 +0000

Source: sympa
Source-Version: 6.0.1-1

We believe that the bug you reported is fixed in the latest version of
sympa, which is due to be installed in the Debian FTP archive:

sympa_6.0.1-1.diff.gz
  to main/s/sympa/sympa_6.0.1-1.diff.gz
sympa_6.0.1-1.dsc
  to main/s/sympa/sympa_6.0.1-1.dsc
sympa_6.0.1-1_amd64.deb
  to main/s/sympa/sympa_6.0.1-1_amd64.deb
sympa_6.0.1.orig.tar.gz
  to main/s/sympa/sympa_6.0.1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 501605@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stefan Hornburg (Racke) <racke@linuxia.de> (supplier of updated sympa package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 12 Apr 2010 15:09:48 +0200
Source: sympa
Binary: sympa
Architecture: source amd64
Version: 6.0.1-1
Distribution: unstable
Urgency: low
Maintainer: Debian Sympa team <pkg-sympa@ithilieninc.com>
Changed-By: Stefan Hornburg (Racke) <racke@linuxia.de>
Description: 
 sympa      - Modern mailing list manager
Closes: 338189 423023 440109 466530 496515 501605 519977 537188 539015 544875 549440 550404 556592 563407 565787 566252
Changes: 
 sympa (6.0.1-1) unstable; urgency=low
 .
   * New upstream release. Closes: #566252, #565787, #556592, #549440.
 .
   [ Jonas Smedegaard ]
   * Drop build-dependency on autotools-dev, no longer needed.
   * Update local CDBS snippets:
     + Update package-relations.mk: Cleanup and tighten dependencies.
       Improve whitespace cleanup. Rewrite and silence applying
       dependencies.
     + Let copyright-check.mk investigate top 99999 lines (not just 60 as
       default for licensecheck), and make it configurable with
       DEB_COPYRIGHT_CHECK_PARSELINES. Silence (GENERATED FILE) licensing
       notices. List files grouped by sorted owner list (ignoring years).
       Preserve unusual characters in copyright_hints file.
     + Update upstream-tarball.mk to preserve bzip2 tarballs with source
       format 3.0 (quilt).
   * Fix password handling in debian/postinst. Closes: #501605
     (resurrected from 5.3.4-6.1), thanks to Thomas Viehmann and others.
   * Improve syslog facility handling.
   * reload rsyslog (in addition to sysklogd), and fail those reloads
     gracefully. Related to bug#496074. Closes: #519977
   * Skip copyright-checking binary PO-files.
   * Add DEP3 header to all patches.
   * Adapt patch 2002 (wizard drop localedir) to current source.
   * Disable patch 1009 (postfix virtual aliases support) needing
     extensive adaption work and possibly no longer relevant.
   * Disable patches 2003 and 2991 (sanitize make all) seemingly no
     longer relevant.
   * Add TODOs about possible configure options.
   * Improve referencing some authors (use accents) in debian/copyright.
 .
   [ Stefan Hornburg (Racke) ]
   * Start/stop new bulk daemon in init script.
   * Database and WWSympa is mandatory now.
   * Rewrite (and greatly simplify) patch 2001, and drop no longer needed
     safety check in debian/rules.
   * Rewrite patch 1007 to adapt to upstream changes (array of hashes
     with configuration parameters is now defined in confdef.pm).
   * Dropped build dependency on libmime-base64-perl (Closes: #563407).
   * Don't touch /var/run/sympa in postinst anymore (Closes: #539015,
     thanks to Tim Retout <tim@retout.co.uk> for the report).
   * Moved SOAP client script to examples area (Closes: #496515, thanks to
     Olivier Berger <olivier.berger@it-sudparis.eu> for the report).
   * Don't override preseeded Debconf values (Closes: #550404, thanks to
     John Bazik <jsb@cs.brown.edu> for the report)
   * Rewrite paths in sympa.conf for list and static content directories
     on upgrades from Sympa 5 (Closes: #537188, thanks to Michael
     Stapelberg <michael+db20090501@stapelberg.de> for the report)
   * Revised handling of PostgreSQL install and upgrades
     (Closes: #440109, #466530, #544875)
   * Queue binaries are no longer suid (Closes: #423023)
   * Lintian fixes:
     + Deprecated chown usage in postinst.
     + Bumped up Standards-Version (no changes required).
   * Debconf template changes (Closes: #338189)
     + Removed S/MIME question and in consequence the question for
       private key password.
     + Remove question for WWSympa usage.
     + Fixed question for WWSympa URL.
Checksums-Sha1: 
 e3da62eeaadedc8f0cdf27533766fe3f8cad75d6 1872 sympa_6.0.1-1.dsc
 be8f6c928ee6019811ec68973018bc62cf198b80 6384623 sympa_6.0.1.orig.tar.gz
 886eb1c5a8ae61d5a9d216feddb6be0a6f04e06f 114221 sympa_6.0.1-1.diff.gz
 7d8c12714b5c57206b4bae0bd557999ed4186f1a 2667744 sympa_6.0.1-1_amd64.deb
Checksums-Sha256: 
 3ee3a00b4e381a57086267565f75ac8f4ee7cb1c99ecbc02a845a13d8847eff5 1872 sympa_6.0.1-1.dsc
 3b7d0e7d844b8ca02c5a95186d5d8de05c908a4b7c9ba013fde0ddb2b15a1d1f 6384623 sympa_6.0.1.orig.tar.gz
 9502a18255462b179263abca7e908898b254e19fa227915a2b409ec5355ab578 114221 sympa_6.0.1-1.diff.gz
 27e6931d298fad7f07b177f3bca2f210df28e808957c43d64fb7aa882663a9e8 2667744 sympa_6.0.1-1_amd64.deb
Files: 
 e693064c04d4dad8973b917f2825292f 1872 mail optional sympa_6.0.1-1.dsc
 418fc8f851b4dcaae67785a7b12c4cf5 6384623 mail optional sympa_6.0.1.orig.tar.gz
 cef52e056d21e80eeceb2e169061f345 114221 mail optional sympa_6.0.1-1.diff.gz
 d1bfaa326e6a041ea1f8f5af2ba134dd 2667744 mail optional sympa_6.0.1-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvDJbwACgkQjgVfE5tya3E1FACghLLwOfZ2CvSDhzg9ib4dP5+O
0Z8AnRrV2HrVT+c2ifK59zyAZTgyUrSg
=ehq8
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.