Debian Bug report logs - #500916
hal: FDI cache does not get updated when installing .fdi files from packages

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <martin.pitt@ubuntu.com>

To: Debian BTS Submit <submit@bugs.debian.org>

Subject: hal: FDI cache does not get updated when installing .fdi files from packages

Date: Thu, 2 Oct 2008 17:01:31 +0200

[Message part 1 (text/plain, inline)]

Package: hal
Version: 0.5.11-3
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu intrepid ubuntu-patch

Hi!

It already occurred several times to me that people had trouble with
FDI files which were apparently not "picked up" by hal. One particular
case is https://bugs.launchpad.net/bugs/275825, where I finally saw
the light: time-based comparison of .fdi files vs. the cache, as done
in di_cache_coherency_check(), doesn't work with dpkg, which maintains
the original file timestamps on unpack.

The quick fix for this is to remove the cache in the init script,
which I just did in Ubuntu (we are close to release). It sacrifices
most of the startup speed improvement unfortunately, and hal still
won't pick up fdi changes immediately, but at least it will work after
a reboot.

The more correct long-term solution could be to create a
dh_install_hal_fdi which generates
/usr/lib/hal/hald-generate-fdi-cache postinst snippets, and convert
all packages shipping .fdi files to use it. But that's not really
adequate for Lenny, and with DeviceKit being on the horizon, it might
be obsolete before we even finish..

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[hal.fdi-cache.debdiff (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 500916@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Martin Pitt <martin.pitt@ubuntu.com>, 500916@bugs.debian.org

Subject: Re: [Pkg-utopia-maintainers] Bug#500916: hal: FDI cache does not get updated when installing .fdi files from packages

Date: Fri, 03 Oct 2008 21:48:23 +0200

[Message part 1 (text/plain, inline)]

Martin Pitt wrote:
> Package: hal
> Version: 0.5.11-3
> Tags: patch
> User: ubuntu-devel@lists.ubuntu.com
> Usertags: origin-ubuntu intrepid ubuntu-patch
> 
> Hi!
> 
> It already occurred several times to me that people had trouble with
> FDI files which were apparently not "picked up" by hal. One particular
> case is https://bugs.launchpad.net/bugs/275825, where I finally saw
> the light: time-based comparison of .fdi files vs. the cache, as done
> in di_cache_coherency_check(), doesn't work with dpkg, which maintains
> the original file timestamps on unpack.
> 
> The quick fix for this is to remove the cache in the init script,
> which I just did in Ubuntu (we are close to release). It sacrifices
> most of the startup speed improvement unfortunately, and hal still
> won't pick up fdi changes immediately, but at least it will work after
> a reboot.
> 
> The more correct long-term solution could be to create a
> dh_install_hal_fdi which generates
> /usr/lib/hal/hald-generate-fdi-cache postinst snippets, and convert
> all packages shipping .fdi files to use it. But that's not really
> adequate for Lenny, and with DeviceKit being on the horizon, it might
> be obsolete before we even finish..
> 

Hi Martin,

I had a short discussion with lool on irc, and we had an alternative idea:
Install a dpkg trigger.
For the etch -> lenny upgrade, we would regenerate the fdi cache in hal
postinst as we can't rely on the dpkg triggers functionality yet.

Do you see any downsides of this approach?
It would we much less work than a dh_fdi and avoid the costly
regeneration on each boot.

Cheers,
Michael



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 500916@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Michael Biebl <biebl@debian.org>

Cc: 500916@bugs.debian.org

Subject: Re: [Pkg-utopia-maintainers] Bug#500916: hal: FDI cache does not get updated when installing .fdi files from packages

Date: Sun, 5 Oct 2008 17:15:59 +0200

[Message part 1 (text/plain, inline)]

Hi Michael,

Michael Biebl [2008-10-03 21:48 +0200]:
> I had a short discussion with lool on irc, and we had an alternative idea:
> Install a dpkg trigger.

Ah, indeed that sounds like a great idea, and much less blunt than
changing the init script (sorry for the kneejerk patch, had to do
something quick to unscrew the Ubuntu upgrade to 8.10 beta).

However, so far I thought that dpkg triggers are triggered by postinst
scripts. There are triggers for "any package installed/upgraded", too?
I'm not very familiar with triggers, apparently you know more than me.
:-)

> For the etch -> lenny upgrade, we would regenerate the fdi cache in hal
> postinst as we can't rely on the dpkg triggers functionality yet.

Right, that makes perfect sense.

Thank you,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 500916@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Martin Pitt <mpitt@debian.org>, 500916@bugs.debian.org

Subject: Re: [Pkg-utopia-maintainers] Bug#500916: Bug#500916: hal: FDI cache does not get updated when installing .fdi files from packages

Date: Sun, 05 Oct 2008 17:57:06 +0200

[Message part 1 (text/plain, inline)]

Martin Pitt wrote:
> Hi Michael,
> 
> Michael Biebl [2008-10-03 21:48 +0200]:
>> I had a short discussion with lool on irc, and we had an alternative idea:
>> Install a dpkg trigger.
> 
> Ah, indeed that sounds like a great idea, and much less blunt than
> changing the init script (sorry for the kneejerk patch, had to do
> something quick to unscrew the Ubuntu upgrade to 8.10 beta).
> 
> However, so far I thought that dpkg triggers are triggered by postinst
> scripts. There are triggers for "any package installed/upgraded", too?
> I'm not very familiar with triggers, apparently you know more than me.
> :-)

Calling a trigger explicitely in postinst is only one possibility.

The one I had in mind would be a file based trigger.

This trigger would be installed by the hal package.
Whenever a package installs a file under /usr/share/hal/fdi, the trigger
would be activated. So we don't need to modify all packages shipping fdi
files.

I've committed a proposed fix as r2435 [1]


>> For the etch -> lenny upgrade, we would regenerate the fdi cache in hal
>> postinst as we can't rely on the dpkg triggers functionality yet.
> 
> Right, that makes perfect sense.

Actually, as sjoerd correctly noticed, we don't even need that, as the
etch version doesn't have a cache yet ;-)

Have a nice weekend,
Michael

[1] http://svn.debian.org/wsvn/pkg-utopia/?rev=2435&sc=1
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #25 received at 500916@bugs.debian.org (full text, mbox, reply):

From: Loïc Minier <lool@dooz.org>

To: Michael Biebl <biebl@debian.org>, 500916@bugs.debian.org

Cc: Martin Pitt <mpitt@debian.org>

Subject: Re: [Pkg-utopia-maintainers] Bug#500916: Bug#500916: Bug#500916: hal: FDI cache does not get updated when installing .fdi files from packages

Date: Sun, 5 Oct 2008 18:39:54 +0200

On Sun, Oct 05, 2008, Michael Biebl wrote:
> Actually, as sjoerd correctly noticed, we don't even need that, as the
> etch version doesn't have a cache yet ;-)

 Except for lenny/sid -> lenny/sid upgrades perhaps?

-- 
Loïc Minier

Message #30 received at 500916@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Loïc Minier <lool@dooz.org>, 500916@bugs.debian.org, Martin Pitt <mpitt@debian.org>

Subject: Re: [Pkg-utopia-maintainers] Bug#500916: Bug#500916: Bug#500916: Bug#500916: hal: FDI cache does not get updated when installing .fdi files from packages

Date: Sun, 05 Oct 2008 19:15:36 +0200

[Message part 1 (text/plain, inline)]

Loïc Minier wrote:
> On Sun, Oct 05, 2008, Michael Biebl wrote:
>> Actually, as sjoerd correctly noticed, we don't even need that, as the
>> etch version doesn't have a cache yet ;-)
> 
>  Except for lenny/sid -> lenny/sid upgrades perhaps?
> 

Yeah, right. The cache might be outdated for lenny/sid users.

For sid users it wouldn't be that much of an issue, as a new hal-info
package is coming sooner or later (I'd say sooner, see hal-info 20081001
which was released just a few days ago) which would trigger a cache update.
If we try to get this hal-info version into lenny, then we wouldn't need
it either for users upgrading from lenny->lenny.

Cheers,
Michael



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #35 received at 500916@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Martin Pitt <mpitt@debian.org>, 500916@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: [Pkg-utopia-maintainers] Bug#500916: Bug#500916: hal: FDI cache does not get updated when installing .fdi files from packages

Date: Sun, 05 Oct 2008 19:21:29 +0200

[Message part 1 (text/plain, inline)]

severity important
thanks

I'm raising severity to important as I'd like to see this fix making it
into lenny.
There are quite a few packages now that ship fdi files and the current
behaviour, as Martin already mentioned, can lead to problems, which are
very hard to understand and debug for the user.

Cheers,
Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #42 received at 500916@bugs.debian.org (full text, mbox, reply):

From: Loic Minier <lool@dooz.org>

To: control@bugs.debian.org

Cc: 498132@bugs.debian.org, 498478@bugs.debian.org, 500916@bugs.debian.org, 501004@bugs.debian.org

Subject: setting package to libhal-storage-dev libhal-storage1 libhal1 libhal-dev hal-doc hal, tagging 498132 ...

Date: Mon, 06 Oct 2008 12:28:03 +0200

# Automatically generated email from bts, devscripts version 2.10.26ubuntu13
#
# hal (0.5.11-4) UNRELEASED; urgency=low
#
#  * New patches from upstream git, fixing support of some wifi chips with
#    2.6.27 kernels; closes: #498132, #498478, #501004.
#    - 60_use-phy80211-instead-of-wiphy-symlink-to-detect, fixes the sysfs
#      symlink lookup to use the proper pathname.
#    - 61_use-wext-ioctl-instead-of-sysfs-to-detect-wireless, fixes detection
#      of wifi interfaces with 2.6.27 kernels.
#  * Add file trigger which re-generates the hal fdi cache. (Closes: #500916)
#

package libhal-storage-dev libhal-storage1 libhal1 libhal-dev hal-doc hal
tags 498132 + pending
tags 501004 + pending
tags 500916 + pending
tags 498478 + pending

Message #49 received at 500916-close@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 500916-close@bugs.debian.org

Subject: Bug#500916: fixed in hal 0.5.11-4

Date: Mon, 06 Oct 2008 12:02:04 +0000

Source: hal
Source-Version: 0.5.11-4

We believe that the bug you reported is fixed in the latest version of
hal, which is due to be installed in the Debian FTP archive:

hal-doc_0.5.11-4_all.deb
  to pool/main/h/hal/hal-doc_0.5.11-4_all.deb
hal_0.5.11-4.diff.gz
  to pool/main/h/hal/hal_0.5.11-4.diff.gz
hal_0.5.11-4.dsc
  to pool/main/h/hal/hal_0.5.11-4.dsc
hal_0.5.11-4_i386.deb
  to pool/main/h/hal/hal_0.5.11-4_i386.deb
libhal-dev_0.5.11-4_i386.deb
  to pool/main/h/hal/libhal-dev_0.5.11-4_i386.deb
libhal-storage-dev_0.5.11-4_i386.deb
  to pool/main/h/hal/libhal-storage-dev_0.5.11-4_i386.deb
libhal-storage1_0.5.11-4_i386.deb
  to pool/main/h/hal/libhal-storage1_0.5.11-4_i386.deb
libhal1_0.5.11-4_i386.deb
  to pool/main/h/hal/libhal1_0.5.11-4_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 500916@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <biebl@debian.org> (supplier of updated hal package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 05 Oct 2008 17:50:25 +0200
Source: hal
Binary: hal hal-doc libhal1 libhal-storage1 libhal-dev libhal-storage-dev
Architecture: source all i386
Version: 0.5.11-4
Distribution: unstable
Urgency: low
Maintainer: Utopia Maintenance Team <pkg-utopia-maintainers@lists.alioth.debian.org>
Changed-By: Michael Biebl <biebl@debian.org>
Description: 
 hal        - Hardware Abstraction Layer
 hal-doc    - Hardware Abstraction Layer - documentation
 libhal-dev - Hardware Abstraction Layer - development files
 libhal-storage-dev - Hardware Abstraction Layer - development files
 libhal-storage1 - Hardware Abstraction Layer - shared library for storage devices
 libhal1    - Hardware Abstraction Layer - shared library
Closes: 498132 498478 500916 501004
Changes: 
 hal (0.5.11-4) unstable; urgency=low
 .
   [ Loic Minier ]
   * New patches from upstream git, fixing support of some wifi chips with
     2.6.27 kernels; closes: #498132, #498478, #501004.
     - 60_use-phy80211-instead-of-wiphy-symlink-to-detect, fixes the sysfs
       symlink lookup to use the proper pathname.
     - 61_use-wext-ioctl-instead-of-sysfs-to-detect-wireless, fixes detection
       of wifi interfaces with 2.6.27 kernels.
 .
   [ Michael Biebl ]
   * Add file trigger which re-generates the hal fdi cache. (Closes: #500916)
 .
   [ Loic Minier ]
   * Bump debhelper bdep to >= 5.0.59 for debian/package.triggers support.
Checksums-Sha1: 
 bc16457c8d9bd2ebfe8e283aef0aaa16ffca540e 1607 hal_0.5.11-4.dsc
 7279543b20841a0559b8f18379cee32709b7756f 34357 hal_0.5.11-4.diff.gz
 bf27073fbc4bc5ec2775d3b0c95821fd3e5929d4 671352 hal-doc_0.5.11-4_all.deb
 fea43d62e56006866234099d3d28b847dcbc53da 765426 hal_0.5.11-4_i386.deb
 21628d63a919489384c4b3f09a3aa63220060345 444174 libhal1_0.5.11-4_i386.deb
 5d3b664b5cda69ea1bb7278c307b6d7ed7624c6e 436632 libhal-storage1_0.5.11-4_i386.deb
 1951221d646eada1465e6219a38aaea4d28cf520 449510 libhal-dev_0.5.11-4_i386.deb
 9a0cbe7bcd68492b042bfb4b17ee570528402509 436862 libhal-storage-dev_0.5.11-4_i386.deb
Checksums-Sha256: 
 b6444f692425520289472f3bfda68441f1043851c6fbbae714f3b16ef8711c3c 1607 hal_0.5.11-4.dsc
 4197ebaa4d648bd3565e9353319aa62ea9675fed67beac073b453040d5c6bc7a 34357 hal_0.5.11-4.diff.gz
 81d4cbeb5f8fce3653232ebc30616523f08262b71387c450e42d44962e019d5e 671352 hal-doc_0.5.11-4_all.deb
 7ad9baac0d2fb6743708837cf6ed0b0a020eb482430deccd6059935ce742b843 765426 hal_0.5.11-4_i386.deb
 ca96bb0049306ed2fbcfe762f0302ee83a9f54c629aec49ccadcf1a4792501e5 444174 libhal1_0.5.11-4_i386.deb
 f02e5ac3af8c314913ed5fc7c1224d2b4554d9245a4316e3c6e69488299f39e0 436632 libhal-storage1_0.5.11-4_i386.deb
 54538aa933c33930bcf7ae092a56c63b8ad16d60b6bb2e0e17a9fff92de466bf 449510 libhal-dev_0.5.11-4_i386.deb
 2dde024d4909e638982c062047dd57653a070ef3ad8c8235b723946093bbb239 436862 libhal-storage-dev_0.5.11-4_i386.deb
Files: 
 eaafe12f66ebfc81a7d18e44a0d171a3 1607 admin optional hal_0.5.11-4.dsc
 eeac0da2404a545dc07c3f7338f1e603 34357 admin optional hal_0.5.11-4.diff.gz
 b7f147a5550236b342b1bb1cb8caaa90 671352 doc optional hal-doc_0.5.11-4_all.deb
 ffc0c6be655cd586450ccd96cf82dea0 765426 admin optional hal_0.5.11-4_i386.deb
 c2cd30b227ad705c643e95d9b2b0d3e1 444174 libs optional libhal1_0.5.11-4_i386.deb
 4ad816274e9f0ab52f5e62311ef446e4 436632 libs optional libhal-storage1_0.5.11-4_i386.deb
 20f80429efa540ec51b1370b23423ffe 449510 libdevel optional libhal-dev_0.5.11-4_i386.deb
 3bca22c73f2a42667c0eef1829ac6381 436862 libdevel optional libhal-storage-dev_0.5.11-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkjp87AACgkQ4VUX8isJIMAjfwCeIoLePVIV2iWXTkbPMYyGbpvx
roYAoJE3ryPQYxD/M8gA5hpt+1N16dxT
=30+d
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.