Debian Bug report logs - #495487
[xf86-input-tslib] Emulate right-click by a tap and hold gesture

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Wen-Yen Chuang <caleb@calno.com>

To: submit@bugs.debian.org, Sascha Hauer <s.hauer@pengutronix.de>, Michael Olbrich <m.olbrich@pengutronix.de>

Cc: Joachim Breitner <nomeata@debian.org>, Neil Williams <codehelp@debian.org>, Luca Capello <luca@pca.it>, Timo Juhani Lindfors <timo.lindfors@iki.fi>, Sebastian Ohl <sebastian@ohl.name>

Subject: [xf86-input-tslib] Emulate right-click by a tap and hold gesture

Date: Mon, 18 Aug 2008 05:00:28 +0800

[Message part 1 (text/plain, inline)]

Package: xserver-xorg-input-tslib
Version: 0.0.4-5
Severity: wishlist

Hello,

This is a patch and feature request for xf86-input-tslib.
It emulates right-click by a tap and hold gesture.

Sebastian Ohl is the patch author and he agreed that I paste the patch
to Debian's BTS [1].

Kind regards
 Wen-Yen Chuang (caleb)

[1] http://bugs.debian.org/xf86-input-tslib

Sebastian Ohl wrote:
> on the openmoko phone we have only two buttons so
> using one for rightclick isn't a good option (everyone wants the key
> for himself *g*). so the second try was the tap and hold solution.

> after some looking into the code i developed a patch that makes it
> possible to emulate this feature by a tap and hold gesture. the
> solution to realize this feature in the input driver has big
> advantages over doing this in every framework (i.e. gtk or qt) over
> and over again. i would love to see it included in the next revision
> of your packages, so everyone can use its advantages.

[02_rightbutton-emulation.diff (text/x-diff, inline)]

--- xf86-input-tslib-0.0.4/src/tslib.c	2007-10-19 10:59:29.000000000 +0000
+++ xf86-input-tslib-0.0.4.b3/src/tslib.c	2008-08-16 22:42:55.000000000 +0000
@@ -50,6 +50,8 @@
 #include <mipointer.h>
 
 #include <tslib.h>
+#include <sys/time.h>
+#include <time.h>
 
 #ifdef XFree86LOADER
 #include <xf86Module.h>
@@ -57,21 +59,28 @@
 
 #define TSLIB_DEV_DEFAULT "/dev/event0"
 
-#define MAXBUTTONS 1
+#define MAXBUTTONS 2
+#define TIME23RDBUTTON 0.5
+#define MOVEMENT23RDBUTTON 4
 
 #define DEFAULT_HEIGHT		240
 #define DEFAULT_WIDTH		320
 
 enum { TSLIB_ROTATE_NONE=0, TSLIB_ROTATE_CW=270, TSLIB_ROTATE_UD=180, TSLIB_ROTATE_CCW=90 };
 
+enum button_state { BUTTON_NOT_PRESSED = 0, BUTTON_1_PRESSED = 1, BUTTON_3_CLICK = 3, BUTTON_3_CLICKED=4 };
+
 struct ts_priv {
 	XISBuffer *buffer;
 	struct tsdev *ts;
-	int lastx,lasty,lastp;
+	int lastx,lasty;
 	int screen_num;
 	int rotate;
 	int height;
 	int width;
+	enum button_state state;
+	struct timeval button_down_start;
+	int button_down_x,button_down_y;
 };
 
 static const char *DEFAULTS[] = {
@@ -118,12 +127,25 @@
 	return TRUE;
 }
 
+struct timeval TimevalDiff(struct timeval a, struct timeval b)
+{
+	struct timeval t;
+	t.tv_sec = a.tv_sec-b.tv_sec;
+	t.tv_usec = a.tv_usec - b.tv_usec;
+	if (t.tv_usec < 0) {
+		t.tv_sec--;
+		t.tv_usec += 1000000;
+	}
+	return t;
+}
+
 static void ReadInput (LocalDevicePtr local)
 {
 	struct ts_priv *priv = (struct ts_priv *) (local->private);
 	struct ts_sample samp;
 	int ret;
 	int x,y;
+	struct timeval now;
 
 	ret = ts_read(priv->ts, &samp, 1);
 
@@ -134,6 +156,9 @@
 
 //	ErrorF("%ld.%06ld: %6d %6d %6d\n", samp.tv.tv_sec, samp.tv.tv_usec, samp.x, samp.y, samp.pressure);
 
+	gettimeofday(&now, NULL);
+	struct timeval pressureTime = TimevalDiff(now,priv->button_down_start);
+
 	if(samp.pressure) {
 		int tmp_x = samp.x;
 		
@@ -161,18 +186,78 @@
 
 		xf86PostMotionEvent (local->dev, TRUE, 0, 2,
 				x, y);
+	} 
 
+	/* button pressed state machine
+ 	 * if pressed than press button 1, start timer and remember the tab position
+	 * if pressed longer than TIME23RDBUTTON and it is not moved more than MOVEMENT23RDBUTTON release button 1 and click button 3
+	 * if still pressed do nothing until the pressure is released
+	 */
+	//ErrorF("%d\t",priv->state);
+	switch (priv->state) {
+		case BUTTON_NOT_PRESSED :
+			if (samp.pressure) {
+				priv->button_down_start = now;
+				priv->button_down_y = samp.y;
+				priv->button_down_x = samp.x;
+				priv->state = BUTTON_1_PRESSED;
+				//ErrorF("b1 down");
+				xf86PostButtonEvent(local->dev, TRUE,
+					priv->state, TRUE, 0, 2,
+					priv->lastx,
+					priv->lasty);
+			}
+			break;
+		case BUTTON_1_PRESSED :
+			if (samp.pressure) {	
+				//ErrorF("%d %d ",pressureTime.tv_sec,pressureTime.tv_usec);
+				if ((((double)pressureTime.tv_sec)+(((double)pressureTime.tv_usec)*1e-6) > TIME23RDBUTTON) &&
+				   (abs(priv->lastx-priv->button_down_x) < MOVEMENT23RDBUTTON &&
+				    abs(priv->lasty-priv->button_down_y) < MOVEMENT23RDBUTTON))
+				{
+					//ErrorF("b1 up");
+					xf86PostButtonEvent(local->dev, TRUE,
+						priv->state, FALSE, 0, 2,
+						priv->lastx,
+						priv->lasty);
+					priv->state = BUTTON_3_CLICK;
+					//ErrorF("b3 down");
+					xf86PostButtonEvent(local->dev, TRUE,
+						priv->state, TRUE, 0, 2,
+						priv->lastx,
+						priv->lasty);
+				} 
+				if (abs(priv->lastx-priv->button_down_x) > MOVEMENT23RDBUTTON ||
+				    abs(priv->lasty-priv->button_down_y) > MOVEMENT23RDBUTTON) {
+					priv->button_down_start = now;
+					priv->button_down_y = samp.y;
+					priv->button_down_x = samp.x;
+					//ErrorF("b1 state reset");
+				}
+			} else {
+				//ErrorF("b1 up");
+				xf86PostButtonEvent(local->dev, TRUE,
+					priv->state, FALSE, 0, 2,
+					priv->lastx,
+					priv->lasty);
+				priv->state = BUTTON_NOT_PRESSED;
+			}
+			break;
+		case BUTTON_3_CLICK :
+			//ErrorF("b3 up");
+			xf86PostButtonEvent(local->dev, TRUE,
+				priv->state, FALSE, 0, 2,
+				priv->lastx,
+				priv->lasty);
+			priv->state = BUTTON_3_CLICKED;
+			break;
+		case BUTTON_3_CLICKED :
+			if (!samp.pressure) {
+				//ErrorF("b3 free");
+				priv->state = BUTTON_NOT_PRESSED;
+			}
+			break;
 	}
-
-	if(priv->lastp != samp.pressure) {
-		priv->lastp = samp.pressure;
-
-		xf86PostButtonEvent(local->dev, TRUE,
-			1, !!samp.pressure, 0, 2,
-			priv->lastx,
-			priv->lasty);
-	}
-
 }
 
 /*
@@ -361,6 +446,8 @@
 
 	pInfo->fd = ts_fd(priv->ts);
 
+	priv->state = BUTTON_NOT_PRESSED;
+		
 	/* Mark the device configured */
 	pInfo->flags |= XI86_CONFIGURED;
 

Message #10 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Joachim Breitner <nomeata@debian.org>

To: Wen-Yen Chuang <caleb@calno.com>

Cc: 495487@bugs.debian.org, Sascha Hauer <s.hauer@pengutronix.de>, Michael Olbrich <m.olbrich@pengutronix.de>, Neil Williams <codehelp@debian.org>, Luca Capello <luca@pca.it>, Timo Juhani Lindfors <timo.lindfors@iki.fi>, Sebastian Ohl <sebastian@ohl.name>, smartphones-standards@linuxtogo.org

Subject: Re: [xf86-input-tslib] Emulate right-click by a tap and hold gesture

Date: Sun, 17 Aug 2008 19:10:40 -0300

[Message part 1 (text/plain, inline)]

Hi everyone,

Am Montag, den 18.08.2008, 05:00 +0800 schrieb Wen-Yen Chuang:
> Package: xserver-xorg-input-tslib
> Version: 0.0.4-5
> Severity: wishlist
> 
> Hello,
> 
> This is a patch and feature request for xf86-input-tslib.
> It emulates right-click by a tap and hold gesture.
> 
> Sebastian Ohl is the patch author and he agreed that I paste the patch
> to Debian's BTS [1].
> 
> Kind regards
>  Wen-Yen Chuang (caleb)
> 
> [1] http://bugs.debian.org/xf86-input-tslib
> 
> Sebastian Ohl wrote:
> > on the openmoko phone we have only two buttons so
> > using one for rightclick isn't a good option (everyone wants the key
> > for himself *g*). so the second try was the tap and hold solution.
> 
> > after some looking into the code i developed a patch that makes it
> > possible to emulate this feature by a tap and hold gesture. the
> > solution to realize this feature in the input driver has big
> > advantages over doing this in every framework (i.e. gtk or qt) over
> > and over again. i would love to see it included in the next revision
> > of your packages, so everyone can use its advantages.

thanks for the work, that was quick. I’d like to see this in the
official package (and thus on the Freerunner), if one thing would be
added: Not always do you want a right-click when you hold the pen, some
applications might not like that (e.g. the keyboard, or games), and it
should not be necessary for most apps running on a smartphone anyways.

So if this behavior could be toggle-able while X is running, then one
could have an applet that switches this, and work both with
right-click-needing apps and left-button-hold-needing apps.

Greetings,
Joachim

PS: Wouldn’t it be able to implement this a bit more flexible in a
regular X client program that listens to X input events and “forges” the
right click upon the right gesture?

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Wen-Yen Chuang <caleb@calno.com>

To: 495487@bugs.debian.org

Cc: Sebastian Ohl <sebastian@ohl.name>

Subject: Re: [xf86-input-tslib] Emulate right-click by a tap and hold gesture

Date: Mon, 18 Aug 2008 06:51:07 +0800

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch has odd behavior on Sharp Zaurus SL-C3200.

1. right-click can not work
2. left-click often keeps "pressing" (pressed left mouse key)
   and can not be released.

GTK+ applications can use libgtkstylus to emulate right-click.
I guess Qt applications can also emulate it via a plugin.

Kind regards
 Wen-Yen Chuang (caleb)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkioq1sACgkQdEpXpumNYVlYQACggeAhMd3CWPYPop5rKfUOFcui
j1oAoIFJDXCdainMhpeM2JtOYLHauw8w
=cFgu
-----END PGP SIGNATURE-----

Message #20 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Wen-Yen Chuang <caleb@calno.com>

To: 495487@bugs.debian.org

Subject: Re: [xf86-input-tslib] Emulate right-click by a tap and hold gesture

Date: Mon, 18 Aug 2008 07:34:37 +0800

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

For those devices that have more keys or buttons,
you can try information below to support middle- and right- click.
It also supports middle- and right- double-click.

http://www.calno.com/moto/gcin/mouseclick-20080424.tar.gz
http://www.oesf.org/forum/index.php?showtopic=25459

Kind regards
 Wen-Yen Chuang (caleb)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkiotY0ACgkQdEpXpumNYVlzQQCfX8GF7/CIl7/2mIyh8uIeFxwE
OysAn0/0ayOcztWLMvYJSKr1H42+sNkz
=7As7
-----END PGP SIGNATURE-----

Message #25 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ohl <sebastian@ohl.name>

To: Timo Juhani Lindfors <timo.lindfors@iki.fi>

Cc: 495487@bugs.debian.org

Subject: Re: Right mouse button tslib patch

Date: Tue, 19 Aug 2008 10:33:53 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Tue, 2008-08-19 at 01:49 +0300, Timo Juhani Lindfors wrote:
> how about adding a sticky button to virtual keyboard that will make
> the next click use right button? Hardcoding this in X does not sound
> like a nice solution if it can be avoided at all.

then you always have to open a keyboard to create a rightclick and you
are mixing x-applications and x-drivers. doing this in a lower layer
offers the chance to solve the problem completly and not for qt, gtk or
whatever again and again.

we should better so this dicussion here, so every one can participate in
it:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=495487

-- 
Yours
 Sebastian Ohl

 --
 Sebastian Ohl              sebastian@ohl.name
 Juliusstr. 3               Tel +49 531 7998221
 D-38118 Braunschweig       Mobil +49 172 1837678

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ohl <sebastian@ohl.name>

To: 495487@bugs.debian.org

Subject: Making the Patch optional

Date: Wed, 20 Aug 2008 19:18:26 +0200

[Message part 1 (text/plain, inline)]

Hi,

i still cannot explain to me why it shouldn't work on an other device.
can you provide me with some more information? i don't have a zaurus
device here to test it myself. 

to make it more easy so everyone can decide to use to patch or don't use
it i added a patch for an xorg.conf option to enable the new behavior. 

the hint with the libgtkstylus it in deed right. but why should everyone
implement the wheel again and if you are using a widgetset that doesn't
have this feature you can't used the software. so the implementation in
the xorg driver is the most general and everyone can benefit from it(at
least if it is working everywhere).

Cu
 Sebastian

[03_rightbutton-emulation-option.diff (text/x-patch, attachment)]

Message #35 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Wen-Yen Chuang <caleb@calno.com>

To: 495487@bugs.debian.org

Cc: Sebastian Ohl <sebastian@ohl.name>

Subject: Re: [xf86-input-tslib] Making the Patch optional

Date: Thu, 21 Aug 2008 08:19:32 +0800

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sebastian Ohl wrote:
> can you provide me with some more information?

I use the default /etc/ts.conf provided by the deb,
the linux input layer event interface.

If I enable "EmulateRightButton", the X cursor go with tapping as usual,
but the "left mouse button" often not released.
I can not evoke leafpad's right-click menu, which can be done with
libgtkstylus.

Close "EmulateRightButton" and everything is normal.

Kind regards
 Wen-Yen Chuang (caleb)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkistJQACgkQdEpXpumNYVnGewCdGkb7NFPvfqaYvcYodCCxyvK5
L38AmwcXgccle4LpXCA7bTzw6w/aVq2B
=6d3b
-----END PGP SIGNATURE-----

Message #40 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Joachim Breitner <nomeata@debian.org>

To: Sebastian Ohl <sebastian@ohl.name>

Cc: smartphones-standards@linuxtogo.org, 495487@bugs.debian.org

Subject: Re: tslib patch for 0.0.5-1?

Date: Thu, 28 Aug 2008 19:48:17 +0200

[Message part 1 (text/plain, inline)]

Hi Sebastian,

Am Donnerstag, den 28.08.2008, 19:37 +0200 schrieb Sebastian Ohl:
> Hi,
> 
> On Thu, 2008-08-28 at 14:19 +0200, Joachim Breitner wrote:
> > you might have noticed that version 0.0.5-1 of the tslib x driver was
> > uploaded[1]. Do you plan to build a version of that with your patch
> > applied? This would hopefully then avoid that people have to change
> > their /etc/pointercal.
> thank you for the hint. i just created a new package.

Cool, thanks!

> > I must admit I haven’t used your package myself yet (no need for
> > right-clicks so far). Is it possible to turn the behavior on and off
> > somehow?
> yes you have to add "Option          "EmulateRightButton"    "1"" to
> your xorg.conf in the input section. with a "0" there is the old
> behavoir.

With that in mind, I was about to file a wishlist bug, just to find that
there has been one for quite a while. Could you reproduce the problem
Wen-Yen Chuang hat lastly[2]? And have you tried to have upstream
include the patch?

Anyways, if you had to adjust your patch for 0.0.5, please post that
updated patch to the bug report – I’d like to provide this to the
Freerunner users, but I also don’t want to diverge from Debian :-)

BTW, is there a clean way to make such a configuration option
runtime-changeable? Like the stuff you can set with xset or xrandr?

Thanks for your work,
Joachim


[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=495487
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=495487#35

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

[signature.asc (application/pgp-signature, inline)]

Message #45 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Joachim Breitner <nomeata@debian.org>

To: Sebastian Ohl <sebastian@ohl.name>

Cc: 495487@bugs.debian.org

Subject: Re: tslib patch for 0.0.5-1?

Date: Mon, 01 Sep 2008 11:41:41 +0200

[Message part 1 (text/plain, inline)]

Hallo Sebastian,

Am Freitag, den 29.08.2008, 21:29 +0200 schrieb Sebastian Ohl:
> On Thu, 2008-08-28 at 19:48 +0200, Joachim Breitner wrote:
> > With that in mind, I was about to file a wishlist bug, just to find that
> > there has been one for quite a while. Could you reproduce the problem
> > Wen-Yen Chuang hat lastly[2]? And have you tried to have upstream
> > include the patch?
> no i couldn't reproduce the bug wen described, but i just found a bug report
> about strange behavior in fluxbox. may be that is the same reason. i
> will do futher investigations when i successfully move to my new flat
> this weekend. currently my flat is completely messed up.
> 
> what do you mean by: try to upstream the patch?

In Debian slang, upstream refers to the original author. And it is
always desirable (and sometimes easier) to have non-Debian-specific
changes applied by the original author of the package, instead just the
Debian package.

For the tslibs driver, this seems to be Sascha Hauer
http://www.pengutronix.de/software/xf86-input-tslib/index_de.html

But he was CC:’ed with the patch already, so he is probably in the loop.

> > Anyways, if you had to adjust your patch for 0.0.5, please post that
> > updated patch to the bug report – I’d like to provide this to the
> > Freerunner users, but I also don’t want to diverge from Debian :-)
> no there hadn't be any adjustments. just copied the patched in the 
> patch directory.

Ah, great. I guess you could have just checked it :-)

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

[signature.asc (application/pgp-signature, inline)]

Message #52 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Joachim Breitner <nomeata@debian.org>

To: pkg-fso-maint@lists.alioth.debian.org

Cc: Sascha Hauer <s.hauer@pengutronix.de>, 495487@bugs.debian.org

Subject: Re: [pkg-fso-maint] Official right click

Date: Thu, 20 Nov 2008 15:32:49 +0100

[Message part 1 (text/plain, inline)]

Hi,

Am Donnerstag, den 20.11.2008, 13:26 +0100 schrieb Michele Renda:
> -----BEGIN PGP SIGNED MESSAGE-----
> I am writing because I'd like to update the Debian/Openmoko wiki
> instructions:
> 
> http://wiki.openmoko.org/wiki/Debian

Thanks for taking care of that.

> Which is the official way to simulate right click? The
> xserver-xorg-input-tslib package present in repository contain already
> the Sebastian Ohl's patch?
> 
> Or I have to install the personalized package provided by Sebastian?

There is no official way set. The bug report tracking this is
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=495487
but it hasn’t seen any comments since September. Also, Sascha Hauer
(original author of the driver) hasn’t commented yet, it seems.

Sascha: Have you looked at the patch mentioned in the bug report?

Greetings,
Joachim
-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

[signature.asc (application/pgp-signature, inline)]

Message #57 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Wen-Yen Chuang <caleb@calno.com>

To: 495487@bugs.debian.org

Cc: Sebastian Ohl <sebastian@ohl.name>, pkg-fso-maint@lists.alioth.debian.org, smartphones-standards@linuxtogo.org

Subject: Re: [xf86-input-tslib] Emulate right-click by a tap and hold gesture

Date: Tue, 16 Dec 2008 04:01:25 +0800

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,
I reviewed and tested patches from openembedded.net [1] and #501139. [2]
Those patches works fine, so I uploaded 0.0.5-2 [3] for Debian
experimental repository.

I want to include the right-click-emulation patches, [4]
but it is difficult to merge them with other patches.

The emulation had odd behavior on my Sharp Zaurus SL-C3200, [5]
so I can not check if it work after the patch merging.

If someone can provide a working patch for 0.0.5-2, [3]
I would be happy to include it in coming uploads.

Notice: 0.0.5-2 [3] Build-Depends on libts-dev (>= 1.0-5), which is in
experimental repository.

Kind regards
 Wen-Yen Chuang (caleb)

[1]
http://git.openembedded.net/?p=openembedded.git;a=tree;f=packages/xorg-driver/xf86-input-tslib;hb=HEAD
[2] http://bugs.debian.org/501139#10
[3] http://mentors.debian.net/debian/pool/main/x/xf86-input-tslib/
[4] http://bugs.debian.org/495487#5 and
    http://bugs.debian.org/495487#30
[5] http://bugs.debian.org/495487#15 and
    http://bugs.debian.org/495487#35
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklGt5UACgkQdEpXpumNYVmUcQCfYpTqV4hHwamk0RF2a8oXPKlj
NusAn0XXkPkEK0p6NZoB0v/42MUPhqTK
=UXao
-----END PGP SIGNATURE-----

Message #62 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ohl <sebastian@ohl.name>

To: 495487@bugs.debian.org

Cc: Wen-Yen Chuang <caleb@calno.com>

Subject: Re: [xf86-input-tslib] Emulate right-click by a tap and hold gesture

Date: Sun, 22 Feb 2009 11:25:11 +0100

[Message part 1 (text/plain, inline)]

Hi,

i updated the right button patch to the 0.0.5-3 package. there is also a
fix in the initialization. i told the xserver that there are only two
buttons but the right button is button 3 actually :-( now it also works
under fluxbox on my freerunner with had have a quite odd behavior
before. i hope that your problems with your shard vanished as well... so
we can get this bug report to an end.

regards
 Sebastian

[40_emulate-right-button.diff (text/x-patch, attachment)]

Message #67 received at 495487@bugs.debian.org (full text, mbox, reply):

From: Wen-Yen Chuang <caleb@calno.com>

To: Sebastian Ohl <sebastian@ohl.name>

Cc: 495487@bugs.debian.org

Subject: Re: [xf86-input-tslib] Emulate right-click by a tap and hold gesture

Date: Tue, 24 Feb 2009 03:28:05 +0800

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thank you!

I have tested the patch.
Disable "EmulateRightButton" and everything is normal on
Sharp Zaurus SL-C3200.
It still do not work when "EmulateRightButton" is enabled on Zaurus,
as I mentioned before. [1] [2]
Anyway, since it is ok on freerunner, I am happy to include the patch.
:-)

I have uploaded 0.0.5-4 to mentors.debian.net with yor patch.
I have also mailed an RFS to debian-mentors.

Kind regards
 Wen-Yen Chuang (caleb)

[1] http://bugs.debian.org/495487#15
[2] http://bugs.debian.org/495487#35
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmi+MUACgkQdEpXpumNYVlMKQCaA9Y/yvTBA3Ovq+b3PIpshqfQ
xFwAn3EB4mK8Xa+2kKWGkiIlc7qdhvrI
=rtue
-----END PGP SIGNATURE-----

Message #72 received at 495487-close@bugs.debian.org (full text, mbox, reply):

From: Wen-Yen Chuang <caleb@calno.com>

To: 495487-close@bugs.debian.org

Subject: Bug#495487: fixed in xf86-input-tslib 0.0.5-4

Date: Tue, 24 Feb 2009 17:32:14 +0000

Source: xf86-input-tslib
Source-Version: 0.0.5-4

We believe that the bug you reported is fixed in the latest version of
xf86-input-tslib, which is due to be installed in the Debian FTP archive:

xf86-input-tslib_0.0.5-4.diff.gz
  to pool/main/x/xf86-input-tslib/xf86-input-tslib_0.0.5-4.diff.gz
xf86-input-tslib_0.0.5-4.dsc
  to pool/main/x/xf86-input-tslib/xf86-input-tslib_0.0.5-4.dsc
xserver-xorg-input-tslib_0.0.5-4_amd64.deb
  to pool/main/x/xf86-input-tslib/xserver-xorg-input-tslib_0.0.5-4_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 495487@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Wen-Yen Chuang <caleb@calno.com> (supplier of updated xf86-input-tslib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 23 Feb 2009 23:40:51 +0800
Source: xf86-input-tslib
Binary: xserver-xorg-input-tslib
Architecture: source amd64
Version: 0.0.5-4
Distribution: unstable
Urgency: low
Maintainer: Wen-Yen Chuang <caleb@calno.com>
Changed-By: Wen-Yen Chuang <caleb@calno.com>
Description: 
 xserver-xorg-input-tslib - tslib touchscreen driver for X.Org/XFree86 server
Closes: 495487 511912 514084
Changes: 
 xf86-input-tslib (0.0.5-4) unstable; urgency=low
 .
   * Upload to upstable
     0.0.5-3 has supported HAL (Closes: #511912)
   * Emulate right-click by a tap and hold gesture
     It can be configured via editing xorg.conf. Please see manpage.
     Thanks to Sebastian Ohl. (Closes: #495487)
   * Detect proper XINPUT ABI for latest Xorg. Thanks to Michael Frey.
     (Closes: #514084)
   * Update to latest xsfbs
Checksums-Sha1: 
 1749cdf146511fbf38b323165c1d9d8ddaacf40b 1175 xf86-input-tslib_0.0.5-4.dsc
 e9e4c2e382316a29ebd8b6e3fd98f8afa1653bee 18883 xf86-input-tslib_0.0.5-4.diff.gz
 11a726fd8255fdcfba99854f8a6ef5f6ab7041a2 10298 xserver-xorg-input-tslib_0.0.5-4_amd64.deb
Checksums-Sha256: 
 e2340a646e3eda7d3de13bc9695df9a03d118864b1a28537f394c462bbefac91 1175 xf86-input-tslib_0.0.5-4.dsc
 0fca2f64547bc5486cc507ce43cf5f8901612971c73190cf94491ebdd1dfe269 18883 xf86-input-tslib_0.0.5-4.diff.gz
 cc77393644cbee79fed6ba5f50682ab5df6410d9f55d99c1ed3a80e397f1124e 10298 xserver-xorg-input-tslib_0.0.5-4_amd64.deb
Files: 
 7f4cf621345788867a0e9c84f6afd472 1175 x11 optional xf86-input-tslib_0.0.5-4.dsc
 fea297e35230d7cfa086fe49663b9451 18883 x11 optional xf86-input-tslib_0.0.5-4.diff.gz
 761824376a4063abc1dcefca305d5a97 10298 x11 optional xserver-xorg-input-tslib_0.0.5-4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmkKxoACgkQiAEJSii8s+OHAwCg7wHq63LJCH8qNkCu+NPmSe50
o4MAoIpq7wTTcLl8z/r8Yrp+I3H193oW
=CKvr
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.