Debian Bug report logs - #488275
samba and winbind: initscript miss 'status' option

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Tim Stoop <tim@cidev.nl>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: samba and winbind: initscript miss 'status' option

Date: Fri, 27 Jun 2008 16:25:06 +0200

Package: samba
Version: 3.0.24-6etch10
Severity: wishlist

Hi there,

The initscripts for both samba and winbind are not LSB compliant because
they miss the 'status' option. Please provide the 'status' option in the
initscripts.

In particular I'm running into this problem when trying to create a
Samba failover setup: Heartbeat 2 requires the status option.

More info about LSB compliant initscripts:
<http://www.linuxfoundation.org/spec/refspecs/LSB_3.0.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html>

(Also note that it should exit with status 3 if the application is not
running.)

This would be very appreciated. Thanks in advance for your time and
effort!

-- 
Kind regards,
Tim Stoop

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-xen-amd64
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages samba depends on:
ii  deb 1.5.11etch1                          Debian configuration management sy
ii  lib 2.2.41-1                             Access control list shared library
ii  lib 2.4.32-1                             Extended attribute shared library
ii  lib 2.3.6.ds1-13etch5                    GNU C Library: Shared libraries
ii  lib 1.39+1.40-WIP-2006.11.14+dfsg-2etch1 common error description library
ii  lib 1.2.7-4etch3                         Common UNIX Printing System(tm) - 
ii  lib 1.4.4-3+etch1                        the GNU TLS library - runtime libr
ii  lib 1.4.4-7etch5                         MIT Kerberos runtime libraries
ii  lib 2.1.30-13.3                          OpenLDAP libraries
ii  lib 0.79-5                               Pluggable Authentication Modules f
ii  lib 0.79-5                               Runtime support for the PAM librar
ii  lib 0.79-5                               Pluggable Authentication Modules l
ii  lib 1.10-3                               lib for parsing cmdline parameters
ii  log 3.7.1-3                              Log rotation utility
ii  lsb 3.1-23.2etch1                        Linux Standard Base 3.1 init scrip
ii  net 4.29                                 Basic TCP/IP networking system
ii  pro 1:3.2.7-3                            /proc file system utilities
ii  sam 3.0.24-6etch10                       Samba common files used by both th
ii  zli 1:1.2.3-13                           compression library - runtime

Versions of packages samba recommends:
pn  smbldap-tools                 <none>     (no description available)

-- debconf information:
  samba/generate_smbpasswd: true
  samba/run_mode: daemons
  samba/tdbsam: false

Message #10 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Tim Stoop <tim@cidev.nl>, 488275@bugs.debian.org

Subject: Re: Bug#488275: samba and winbind: initscript miss 'status' option

Date: Fri, 27 Jun 2008 23:36:13 -0700

On Fri, Jun 27, 2008 at 04:25:06PM +0200, Tim Stoop wrote:
> Package: samba
> Version: 3.0.24-6etch10
> Severity: wishlist

> The initscripts for both samba and winbind are not LSB compliant because
> they miss the 'status' option. Please provide the 'status' option in the
> initscripts.

This is indeed most definitely a wishlist.  There is no requirement or
expectation that Debian init scripts comply with the LSB init script policy,
which is targeted at the init scripts of LSB *packages*, not LSB
implementations; and Debian packages are most definitely not LSB packages.

> In particular I'm running into this problem when trying to create a
> Samba failover setup: Heartbeat 2 requires the status option.

I don't think this is a reasonable expectation of heartbeat on a Debian
system and believe this should be regarded as a bug if the Debian heartbeat
package does this.

> More info about LSB compliant initscripts:
> <http://www.linuxfoundation.org/spec/refspecs/LSB_3.0.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html>

That's interesting, I certainly don't remember the LSB init script section
reading like an exact clone of Debian policy with an added mandatory
"status" option... I wonder when that happened? :)

Note that the LSB also specifies meanings for various non-zero return values
for init scripts for actions other than status.  The vast majority of Debian
init scripts do not comply with this, as they simply forward on the exit
value of whatever command failed, which may be of an arbitrary,
service-defined value.

So I really don't believe we should be trying to pick init scripts off
one-by-one with bugs asking to add the LSB status option when this is not
part of Debian policy; we should reach a consensus about whether this is
something that Debian should support, and get it added explicitly to policy
on its own merits.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

Message #15 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Tim Stoop <tim@kumina.nl>

To: Steve Langasek <vorlon@debian.org>

Cc: 488275@bugs.debian.org

Subject: Re: Bug#488275: samba and winbind: initscript miss 'status' option

Date: Sat, 28 Jun 2008 10:34:37 +0200

Hi Steve,

Op 28-jun-2008, om 8:36 heeft Steve Langasek het volgende geschreven:
> This is indeed most definitely a wishlist.

Which is of course why I set it to 'wishlist' :)

> I don't think this is a reasonable expectation of heartbeat on a  
> Debian
> system and believe this should be regarded as a bug if the Debian  
> heartbeat
> package does this.

This is an integral part of the heartbeat-2 workings. The 'status' of  
the init script is used to check, well, if the service is indeed up  
or down :) It allows for correct monitoring from within heartbeat's  
crm, the resource manager. Not a bug, a feature! ;-) Another way  
would be to create an OCF script, but I think this is a bit overkill,  
since the init script does 90% of what's needed. Only the status is  
missing.

At this time, support for Samba in failover with heartbeat-2 is  
unsupported "out of the box". Adding a 'status' that complies with  
the LSB spec would immediately enable this kind of setup out of the box.

> So I really don't believe we should be trying to pick init scripts off
> one-by-one with bugs asking to add the LSB status option when this  
> is not
> part of Debian policy; we should reach a consensus about whether  
> this is
> something that Debian should support, and get it added explicitly  
> to policy
> on its own merits.

Well that's okay, too, but I wasn't picking init scripts one-by-one,  
I came across this when trying to set up a Samba server in failover  
with heartbeat-2 on a Debian Etch system (well, two systems, of  
course). I don't think the case is all that unique, so I think more  
people would run into this, which is why I filed the wishlist-bugreport.

I hope you'll see it from that point of view. If so, I created a  
'status' function in my own samba init script. If you'd like, I can  
post it here. It's not very good (I'm using pidof...), but it seems  
to work and maybe can be a starting point for a proper implementation.

Thanks for taking the time to reply to me and good luck with further  
development of this package!

-- 
Kind regards,
Met vriendelijke groet,

Tim Stoop

Message #20 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: Tim Stoop <tim@kumina.nl>, 488275@bugs.debian.org

Subject: Re: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Sat, 28 Jun 2008 15:25:32 +0200

[Message part 1 (text/plain, inline)]

Quoting Tim Stoop (tim@kumina.nl):

> I hope you'll see it from that point of view. If so, I created a  
> 'status' function in my own samba init script. If you'd like, I can  
> post it here. It's not very good (I'm using pidof...), but it seems  
> to work and maybe can be a starting point for a proper implementation.


I think you're very welcome to propose a patch. We'll review it
(indeed, Steve will criticize it and I'll just look..:-)) and,
hopefully, integrate it.

I have to say that the possibility to have Samba failover being
supported by heartbeat is something that opens interesting
possibilities to me, for once as a user of the samba package, not as
(one of) the maintainer(s)..:-)

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Tim Stoop <tim@kumina.nl>

To: Christian Perrier <bubulle@debian.org>

Cc: 488275@bugs.debian.org

Subject: Re: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Mon, 30 Jun 2008 09:34:17 +0200

Op 28-jun-2008, om 15:25 heeft Christian Perrier het volgende  
geschreven:
> I think you're very welcome to propose a patch. We'll review it
> (indeed, Steve will criticize it and I'll just look..:-)) and,
> hopefully, integrate it.

This is my addition to the initscript for samba:

  status)
    SMBRETURN=3
    NMBRETURN=3
    PIDS_SMBD=`pidof smbd > /dev/null; echo $?`
    PIDS_NMBD=`pidof nmbd > /dev/null; echo $?`
    if [ $PIDS_SMBD -gt 0 ]
    then
      if [ -f $SMBDPID ]
      then
        echo "smbd not running, pidfile exists!"
        SMBRETURN=1
      else
        echo "smbd not running."
      fi
    else
      if [ -f $SMBDPID ]
      then
        echo "smbd running"
        SMBRETURN=0
      else
        echo "smbd running, but no pidfile exists!"
        # No LSB defined return code for this :(
        SMBRETURN=0
      fi
    fi
    if [ $PIDS_NMBD -gt 0 ]
    then
      if [ -f $NMBDPID ]
      then
        echo "nmbd not running, pidfile exists!"
        NMBRETURN=1
      else
        echo "nmbd not running."
      fi
    else
      if [ -f $NMBDPID ]
      then
        echo "nmbd running"
        NMBRETURN=0
      else
        echo "nmbd running, but no pidfile exists!"
        # No LSB defined return code for this :(
        NMBRETURN=0
      fi
    fi
    if [ $SMBRETURN -eq 1 ] || [ $SMBRETURN -eq 1 ]
    then
      exit 1
    elif [ $SMBRETURN -eq $NMBRETURN ]
    then
      exit $SMBRETURN
    else
      # Apparantly, we have an unknown state, or at least something
      # that we can't fix easily
      return 4
    fi
    ;;

I took some liberties here and it's not really nice code, but it  
seems to work in our setup. I believe it's readable.

The same for winbind (much simpler):

  status)
    PIDS_WINBIND=`pidof winbindd > /dev/null; echo $?`
    if [ $PIDS_WINBIND -eq 0 ]
    then
      echo "winbind is running"
      exit 0
    else
      echo "winbind is stopped"
      exit 3
    fi
    ;;

Hope this helps you!

-- 
Kind regards,
Met vriendelijke groet,

Tim Stoop


Kumina bv
www.kumina.nl
kvk nr 14095795

Message #30 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: Tim Stoop <tim@kumina.nl>

Cc: 488275@bugs.debian.org

Subject: Re: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Mon, 30 Jun 2008 19:44:30 +0200

[Message part 1 (text/plain, inline)]

> This is my addition to the initscript for samba:


I rewrote it to fit the indentation style we use. 

I have no deep advice here, except that:

- the "echo" stuff add extra noise and are not handled by the LSB init
functions. Not sure whether this is wanted. Actually, the important
stuff are return codes... I'd vote to remove these echo lines.

- I haven't even checked the resulting script..:-)

[diff (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Tim Stoop <tim@kumina.nl>

To: Christian Perrier <bubulle@debian.org>

Cc: 488275@bugs.debian.org

Subject: Re: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Mon, 30 Jun 2008 19:56:50 +0200

Op 30-jun-2008, om 19:44 heeft Christian Perrier het volgende  
geschreven:
> - the "echo" stuff add extra noise and are not handled by the LSB init
> functions. Not sure whether this is wanted. Actually, the important
> stuff are return codes... I'd vote to remove these echo lines.

Although I wouldn't mind either way (the exit codes are the important  
stuff for my specific case), I added the echo's to make the status  
option is usable by humans. Also, other packages that implement an  
lsb-compatible status do this too (I checked mysql-server-5.0, nfs- 
kernel-server, nfs-common and nscd). Not sure if you'd want to follow  
their example or not :)

-- 
Kind regards,
Met vriendelijke groet,

Tim Stoop


Kumina bv
www.kumina.nl
kvk nr 14095795

Message #40 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Tim Stoop <tim@kumina.nl>, 488275@bugs.debian.org

Cc: Christian Perrier <bubulle@debian.org>

Subject: Re: Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Mon, 30 Jun 2008 14:14:40 -0700

On Mon, Jun 30, 2008 at 09:34:17AM +0200, Tim Stoop wrote:

> Op 28-jun-2008, om 15:25 heeft Christian Perrier het volgende  
> geschreven:
>> I think you're very welcome to propose a patch. We'll review it
>> (indeed, Steve will criticize it and I'll just look..:-)) and,
>> hopefully, integrate it.

Here comes the criticism ;)

> This is my addition to the initscript for samba:

>   status)
>     SMBRETURN=3
>     NMBRETURN=3
>     PIDS_SMBD=`pidof smbd > /dev/null; echo $?`
>     PIDS_NMBD=`pidof nmbd > /dev/null; echo $?`

This is wrong.  'pidof' will check for any running process under this name;
we should be looking for only those processes that are started by this init
script itself, excluding any processes that might randomly have the same
name or that are started by a user outside of this init script (e.g., a
custom set up of samba running on a different port... you'll find that
qemu does this for filesharing, though currently not very successfully on
Debian...)

So the right way to do this is to look at the PID files themselves first,
check their contents, and verify that those processes are still running. 
Something like:

      if [ ! -f $SMBDPID ]; then
          echo "smbd not running."
      else
          PIDS_SMBD=`cat $SMBDPID`
          if ps $PIDS_SMBD | grep -q smbd; then
              echo "smbd running."
              SMBRETURN=0
          else
              echo "smbd running, but pidfile exists."
              SMBRETURN=1
          fi
      fi

Note that procps is required for this functionality to work, because of the
use of ps.  I don't know that a dependency is actually warranted, since this
is optional functionality; anyway, procps is Priority: required, so it will
always be present in practice.

I don't have a problem with the 'echo' statements myself, though I do object
to the use of exclamation marks. :)

>     if [ $SMBRETURN -eq 1 ] || [ $SMBRETURN -eq 1 ]
>     then
>       exit 1
>     elif [ $SMBRETURN -eq $NMBRETURN ]
>     then
>       exit $SMBRETURN
>     else
>       # Apparantly, we have an unknown state, or at least something
>       # that we can't fix easily
>       return 4
>     fi
>     ;;

Well, this means that no meaningful status will be returned if one of the
daemons is running but the other is not.  Concretely, this means it won't
return useful status in the event that smbd is started out of inetd
(RUN_MODE=inetd), or that 'disable netbios' is set, causing nmbd to not be
run.

> The same for winbind (much simpler):
>
>   status)
>     PIDS_WINBIND=`pidof winbindd > /dev/null; echo $?`
>     if [ $PIDS_WINBIND -eq 0 ]
>     then
>       echo "winbind is running"
>       exit 0
>     else
>       echo "winbind is stopped"
>       exit 3
>     fi
>     ;;

I think it would be better to first fix winbind to use a proper PID file,
then use code similar to that in the smbd/nmbd case.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

Message #45 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Tim Stoop <tim@kumina.nl>

To: Steve Langasek <vorlon@debian.org>

Cc: 488275@bugs.debian.org, Christian Perrier <bubulle@debian.org>

Subject: Re: Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Tue, 1 Jul 2008 10:34:09 +0200

Op 30-jun-2008, om 23:14 heeft Steve Langasek het volgende geschreven:
> Here comes the criticism ;)

I prefer the term "constructive remarks" ;-)

> So the right way to do this is to look at the PID files themselves  
> first,
> check their contents, and verify that those processes are still  
> running.

True that. I'll try your code today and report back with a proper diff.

> Note that procps is required for this functionality to work,  
> because of the
> use of ps.  I don't know that a dependency is actually warranted,  
> since this
> is optional functionality; anyway, procps is Priority: required, so  
> it will
> always be present in practice.

Should the script check for the existence of /bin/ps? Or should I  
just leave it as it is?

> I don't have a problem with the 'echo' statements myself, though I  
> do object
> to the use of exclamation marks. :)

Uh... woops? :) Will replace them.

> Well, this means that no meaningful status will be returned if one  
> of the
> daemons is running but the other is not.  Concretely, this means it  
> won't
> return useful status in the event that smbd is started out of inetd
> (RUN_MODE=inetd), or that 'disable netbios' is set, causing nmbd to  
> not be
> run.

Checking /etc/default/samba is easy, but I'm not sure if I can  
reliably check for the 'disable netbios' option. Any hints on how to  
do this?

> I think it would be better to first fix winbind to use a proper PID  
> file,
> then use code similar to that in the smbd/nmbd case.

I'll spend some time today to see if I can fix that. I guess the -- 
make-pidfile option from start-stop-daemon should be used. Will let  
you know when I come up with something that works.

-- 
Kind regards,
Met vriendelijke groet,

Tim Stoop


Kumina bv
www.kumina.nl
kvk nr 14095795

Message #50 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Tim Stoop <tim@kumina.nl>, 488275@bugs.debian.org

Cc: Christian Perrier <bubulle@debian.org>

Subject: Re: Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Tue, 1 Jul 2008 20:54:32 -0700

On Tue, Jul 01, 2008 at 10:34:09AM +0200, Tim Stoop wrote:
>> Note that procps is required for this functionality to work, because of 
>> the
>> use of ps.  I don't know that a dependency is actually warranted,  
>> since this
>> is optional functionality; anyway, procps is Priority: required, so it 
>> will
>> always be present in practice.

> Should the script check for the existence of /bin/ps? Or should I just 
> leave it as it is?

Well, if I actually pay attention, samba already depends on procps, so it
doesn't matter anyway.

Otherwise, I still think it would've been fine because procps is Priority:
required, which means its always installed - it's just not guaranteed to be
configured at any given moment.

>> Well, this means that no meaningful status will be returned if one of 
>> the
>> daemons is running but the other is not.  Concretely, this means it  
>> won't
>> return useful status in the event that smbd is started out of inetd
>> (RUN_MODE=inetd), or that 'disable netbios' is set, causing nmbd to  
>> not be
>> run.

> Checking /etc/default/samba is easy, but I'm not sure if I can reliably 
> check for the 'disable netbios' option. Any hints on how to do this?

There's an example of this already in /etc/init.d/samba.

Perhaps that check is worth refactoring into a small shell function at the
top of the script, perhaps not.

>> I think it would be better to first fix winbind to use a proper PID  
>> file,
>> then use code similar to that in the smbd/nmbd case.

> I'll spend some time today to see if I can fix that. I guess the -- 
> make-pidfile option from start-stop-daemon should be used. Will let you 
> know when I come up with something that works.

Ok, thanks for the interest!

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

Message #55 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Tim Stoop <tim@kumina.nl>

To: Steve Langasek <vorlon@debian.org>

Cc: 488275@bugs.debian.org, Christian Perrier <bubulle@debian.org>

Subject: Re: Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Wed, 2 Jul 2008 16:18:24 +0200

[Message part 1 (text/plain, inline)]

Op 2-jul-2008, om 5:54 heeft Steve Langasek het volgende geschreven:
> There's an example of this already in /etc/init.d/samba.

Ah yes, in testing. Using that version of the init script now for my  
development (seems to work as expected for the version in Etch, too).

> Perhaps that check is worth refactoring into a small shell function  
> at the
> top of the script, perhaps not.

I moved it to the top of the script. Maybe you prefer it otherwise,  
let me know, I'll change it.

I only had time to fix this in the samba init script. Will work on  
winbind later this week (I hope).

[diff (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Kind regards,
Met vriendelijke groet,

Tim Stoop


Kumina bv
www.kumina.nl
kvk nr 14095795

Message #60 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Tim Stoop <tim@kumina.nl>

To: Steve Langasek <vorlon@debian.org>

Cc: 488275@bugs.debian.org, Christian Perrier <bubulle@debian.org>

Subject: Re: Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Thu, 3 Jul 2008 17:39:31 +0200

Op 2-jul-2008, om 5:54 heeft Steve Langasek het volgende geschreven:
>>> I think it would be better to first fix winbind to use a proper PID
>>> file,
>>> then use code similar to that in the smbd/nmbd case.
>
>> I'll spend some time today to see if I can fix that. I guess the --
>> make-pidfile option from start-stop-daemon should be used. Will  
>> let you
>> know when I come up with something that works.
>
> Ok, thanks for the interest!

I'm a bit confused about the following part of the winbind init script:

    mkdir -p /var/run/samba/winbindd_privileged || return 1
    chgrp winbindd_priv $PIDDIR/winbindd_privileged/ || return 1
    chmod 0750 $PIDDIR/winbindd_privileged/ || return 1

I'm guessing it's only used to check if there's already a winbind  
running? Or is the directory used for anything else? Can I remove  
this and replace it with the usage of --make-pidfile in start-stop- 
daemon?

-- 
Kind regards,
Met vriendelijke groet,

Tim Stoop


Kumina bv
www.kumina.nl
kvk nr 14095795

Message #65 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Tim Stoop <tim@kumina.nl>, 488275@bugs.debian.org

Subject: Re: Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Fri, 4 Jul 2008 02:48:26 -0700

On Thu, Jul 03, 2008 at 05:39:31PM +0200, Tim Stoop wrote:

> Op 2-jul-2008, om 5:54 heeft Steve Langasek het volgende geschreven:
>>>> I think it would be better to first fix winbind to use a proper PID
>>>> file,
>>>> then use code similar to that in the smbd/nmbd case.

>>> I'll spend some time today to see if I can fix that. I guess the --
>>> make-pidfile option from start-stop-daemon should be used. Will let 
>>> you
>>> know when I come up with something that works.

>> Ok, thanks for the interest!

> I'm a bit confused about the following part of the winbind init script:

>     mkdir -p /var/run/samba/winbindd_privileged || return 1
>     chgrp winbindd_priv $PIDDIR/winbindd_privileged/ || return 1
>     chmod 0750 $PIDDIR/winbindd_privileged/ || return 1

> I'm guessing it's only used to check if there's already a winbind  
> running? Or is the directory used for anything else? Can I remove this 
> and replace it with the usage of --make-pidfile in start-stop-daemon?

This is to ensure that the /var/run/samba heirarchy is created before use,
in the event that the system uses a tmpfs for /var/run (and therefore
directories don't persist across reboots).

No, this has nothing at all to do with pidfiles - the existing code is
correct and should not be altered.  Nor should the
/var/run/samba/winbindd_privileged directory be used for pidfiles.

(I don't know why we have $PIDDIR used in some cases and not others - that's
an inconsistency that we should correct at some point.)

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

Message #70 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@canonical.com>

To: 488275@bugs.debian.org

Subject: Re: Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Tue, 08 Jul 2008 20:31:18 -0500

[Message part 1 (text/plain, inline)]

Hi-

I'm working on a generic status_of_proc() function to be provided
by /lib/lsb/init-functions in the lsb-base package.

This bug is:
 * http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=483285

This function also currently uses /bin/pidof, although eventually, I'd
like at add some improved support for pidfiles as well.  Having this
functionality in a single library function is far more maintainable than
scattering this sort of functionality across dozens/hundreds/thousands
of init scripts.

Although the patch hasn't been accepted in Debian's lsb-base yet, we
have applied it and are working on it in Ubuntu's development tree
(Intrepid) at the moment.  We're tracking this as a single bug at this
moment here:
 * https://bugs.edge.launchpad.net/ubuntu/+source/sysklogd/+bug/203169

I've modified a handful of service init scripts, including Samba to use
this function.  I don't know if it'll (yet) serve your heartbeat needs,
but in my testing, it seems to work perform correctly, telling you if
nmbd/smbd/winbindd are running or not.
 * http://launchpadlibrarian.net/15898919/samba.status.debdiff

Once the status_of_proc() function is in lsb-base, I intend to push this
patch to Debian's samba.

-- 
:-Dustin

Dustin Kirkland
Ubuntu Server Developer
Canonical, LTD
kirkland@canonical.com
GPG: 1024D/83A61194

[signature.asc (application/pgp-signature, inline)]

Message #75 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@canonical.com>

To: 488275@bugs.debian.org

Subject: Re: Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

Date: Wed, 09 Jul 2008 19:08:14 -0500

[Message part 1 (text/plain, inline)]

Here is a patch that provides the status action functionality for nmbd,
smbd, and winbindd.  I developed this against Ubuntu and am submitting
this for inclusion in Debian.  Thanks to Steve for his copious feedback
on IRC.

Note that the hunk dealing with the debian/control file may need to be
tweaked based on the acceptance of the patch for [1] being accepted into
lsb-based and released.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=490095

-- 
:-Dustin

Dustin Kirkland
Ubuntu Server Developer
Canonical, LTD
kirkland@canonical.com
GPG: 1024D/83A61194

[samba.488275.diff (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #80 received at 488275@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: kirkland@canonical.com, 488275@bugs.debian.org

Subject: Re: [Pkg-samba-maint] Bug#488275: Bug#488275: samba and winbind: initscript miss 'status' option

Date: Tue, 13 Jan 2009 22:52:22 +0100

[Message part 1 (text/plain, inline)]

tags 488275 patch
thanks

Quoting Dustin Kirkland (kirkland@canonical.com):
> Here is a patch that provides the status action functionality for nmbd,
> smbd, and winbindd.  I developed this against Ubuntu and am submitting
> this for inclusion in Debian.  Thanks to Steve for his copious feedback
> on IRC.
> 
> Note that the hunk dealing with the debian/control file may need to be
> tweaked based on the acceptance of the patch for [1] being accepted into
> lsb-based and released.
> 
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=490095


As this bug is now fixed in lsb-base, I think we can probably safely
apply your patch in 3.3 (experimental...will go in unstable as soon as
lenny is released)

[signature.asc (application/pgp-signature, inline)]

Message #89 received at 488275-close@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: 488275-close@bugs.debian.org

Subject: Bug#488275: fixed in samba 2:3.3.0~rc2-4

Date: Sat, 24 Jan 2009 16:17:21 +0000

Source: samba
Source-Version: 2:3.3.0~rc2-4

We believe that the bug you reported is fixed in the latest version of
samba, which is due to be installed in the Debian FTP archive:

libpam-smbpass_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/libpam-smbpass_3.3.0~rc2-4_i386.deb
libsmbclient-dev_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/libsmbclient-dev_3.3.0~rc2-4_i386.deb
libsmbclient_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/libsmbclient_3.3.0~rc2-4_i386.deb
libwbclient0_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/libwbclient0_3.3.0~rc2-4_i386.deb
samba-common_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/samba-common_3.3.0~rc2-4_i386.deb
samba-dbg_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/samba-dbg_3.3.0~rc2-4_i386.deb
samba-doc-pdf_3.3.0~rc2-4_all.deb
  to pool/main/s/samba/samba-doc-pdf_3.3.0~rc2-4_all.deb
samba-doc_3.3.0~rc2-4_all.deb
  to pool/main/s/samba/samba-doc_3.3.0~rc2-4_all.deb
samba-tools_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/samba-tools_3.3.0~rc2-4_i386.deb
samba_3.3.0~rc2-4.diff.gz
  to pool/main/s/samba/samba_3.3.0~rc2-4.diff.gz
samba_3.3.0~rc2-4.dsc
  to pool/main/s/samba/samba_3.3.0~rc2-4.dsc
samba_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/samba_3.3.0~rc2-4_i386.deb
smbclient_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/smbclient_3.3.0~rc2-4_i386.deb
smbfs_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/smbfs_3.3.0~rc2-4_i386.deb
swat_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/swat_3.3.0~rc2-4_i386.deb
winbind_3.3.0~rc2-4_i386.deb
  to pool/main/s/samba/winbind_3.3.0~rc2-4_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 488275@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated samba package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 24 Jan 2009 16:04:57 +0100
Source: samba
Binary: samba samba-common samba-tools smbclient swat samba-doc samba-doc-pdf smbfs libpam-smbpass libsmbclient libsmbclient-dev winbind samba-dbg libwbclient0
Architecture: source all i386
Version: 2:3.3.0~rc2-4
Distribution: experimental
Urgency: low
Maintainer: Debian Samba Maintainers <pkg-samba-maint@lists.alioth.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description: 
 libpam-smbpass - pluggable authentication module for Samba
 libsmbclient - shared library for communication with SMB/CIFS servers
 libsmbclient-dev - development files for libsmbclient
 libwbclient0 - Samba winbind client library
 samba      - SMB/CIFS file, print, and login server for Unix
 samba-common - common files used by both the Samba server and client
 samba-dbg  - Samba debugging symbols
 samba-doc  - Samba documentation
 samba-doc-pdf - Samba documentation in PDF format
 samba-tools - Samba testing utilities
 smbclient  - command-line SMB/CIFS clients for Unix
 smbfs      - Samba file system utilities
 swat       - Samba Web Administration Tool
 winbind    - Samba nameservice integration server
Closes: 488275 491997 511730 512843
Changes: 
 samba (2:3.3.0~rc2-4) experimental; urgency=low
 .
   [ Steve Langasek ]
   * Revert one of the template depersonalization changes from the -2 upload,
     because it loses important context
 .
   [ Christian Perrier ]
   * Use double quotation marks in debconf templates
   * Add 'status" option to init scripts. Thansk to Dustin Kirkland for
     providing the patch. Closes: #488275
   * Move WHATSNEW.txt, README, Roadmap to samba-common. Closes: #491997
   * [Lintian] Add ${misc:Depends} to dependencies of binary packages
     that didn't have it already as we're using debhelper in the source
     package
   * [Lintian] Don't ignore errors in swat.postrm
   * [Lintian] Fix "local foo=bar" bashisms in samba-common.dhcp, samba.config
     and samba-common.config
   * smb.conf.5-undefined-configure.patch: fix syntax error in smb.conf(5)
     Closes: #512843
 .
   [ Debconf translations ]
   * Asturian added. Closes: #511730
Checksums-Sha1: 
 bf44946f3706ac16a2579435321cb2b9e430fc92 1841 samba_3.3.0~rc2-4.dsc
 afaedce9cf758d3af5e53c84447516bb825defb5 223410 samba_3.3.0~rc2-4.diff.gz
 64421d83a195ca4c2459446ea198d0748fa202ba 7940614 samba-doc_3.3.0~rc2-4_all.deb
 b1c3b0964d2c759210c01ad11ba1ef5b8256aa83 6253018 samba-doc-pdf_3.3.0~rc2-4_all.deb
 73dda1d9f9b7a3464014dc16ba77002f91445977 4418858 samba_3.3.0~rc2-4_i386.deb
 b623c528b82f92610683ec4a8ece3e8efe425f3c 3969762 samba-common_3.3.0~rc2-4_i386.deb
 d9e3fca809a885189e890ec948dd923020476e29 4978924 samba-tools_3.3.0~rc2-4_i386.deb
 002b9864ddf34f5362592ac4b33058599c564cfa 7963126 smbclient_3.3.0~rc2-4_i386.deb
 e7ca20eee1fa4638d1ac77447a4564896ce4d05a 1369126 swat_3.3.0~rc2-4_i386.deb
 f8443c9ef62e5e42f889154357a09b6a3fbc24fb 1483106 smbfs_3.3.0~rc2-4_i386.deb
 a140cb3bcd010a6b2986f6cd72f25db04fe8e967 562712 libpam-smbpass_3.3.0~rc2-4_i386.deb
 7880565b24e50ed867c3ba5bf6ca6c5fe2ecdcb1 1317534 libsmbclient_3.3.0~rc2-4_i386.deb
 26db502ffc68870296235ff8f10a8db8b5ce12b4 1999802 libsmbclient-dev_3.3.0~rc2-4_i386.deb
 1b19b5be4bfb9e4acc3db8fd20435e493ec3fde0 3404172 winbind_3.3.0~rc2-4_i386.deb
 527c4ab1cae2a60c7643970b1f4306c2a5c3b260 2346254 samba-dbg_3.3.0~rc2-4_i386.deb
 372fbbd2883d0d37d4d1579fdb1dabc5467e2b04 82400 libwbclient0_3.3.0~rc2-4_i386.deb
Checksums-Sha256: 
 8fcffad37a3b7564aa6c117a56747a9472b4815474780fb4bf6a57d990d2f489 1841 samba_3.3.0~rc2-4.dsc
 952ebe7f34cdc92acf8057759c404a285f3bca1d08801b70219d33ab1181b427 223410 samba_3.3.0~rc2-4.diff.gz
 28798aca7d8afbe9cf257afeee7201790f33bc64c2d703d6923168e59b5ff0aa 7940614 samba-doc_3.3.0~rc2-4_all.deb
 fb1bba83d8b5b1173e604e51ed8fc80a391f5b07565051d788e9d37d60ce5df9 6253018 samba-doc-pdf_3.3.0~rc2-4_all.deb
 77d99cefc6e6d5fd8ffbee2e96a4272183a68cee5c55300e41edd4be448982fa 4418858 samba_3.3.0~rc2-4_i386.deb
 8d5234c5f427f78d91976c69c4858c74b83eb6d3c40f3a3e2bf69be708e04987 3969762 samba-common_3.3.0~rc2-4_i386.deb
 542728cdcb49a197ace5f0ce682e2e2bc4b94c54380e5302f7cd807d9cf750fe 4978924 samba-tools_3.3.0~rc2-4_i386.deb
 3c00650e8a82a8b30b730e84eaba06aaa43974dfef3459cf80abf238233fa8cb 7963126 smbclient_3.3.0~rc2-4_i386.deb
 a348c6c400006db5952d511292f829a58bbfe3f5e31501492cc9f24ba39e2209 1369126 swat_3.3.0~rc2-4_i386.deb
 d207215f0e712e793e164fbee503e6015aa997c40051cb24645ab86b6fdd5a64 1483106 smbfs_3.3.0~rc2-4_i386.deb
 de21c741c9a0155b42d1f4758bf5a8422c5252c57130ffcda7319d968ebc602f 562712 libpam-smbpass_3.3.0~rc2-4_i386.deb
 0e079640eef90fc6b3220b778164f3aff3567e2e0de2ec07c02a01cc08de2d91 1317534 libsmbclient_3.3.0~rc2-4_i386.deb
 8f9e5807739632cd868603f59584a1706fe67100eda95d06b812ec01756faf5f 1999802 libsmbclient-dev_3.3.0~rc2-4_i386.deb
 a6a868a6cfd27c72e5f79726fdd3baf810e1f5d6578163f02529ef16bb33aa50 3404172 winbind_3.3.0~rc2-4_i386.deb
 e21c32052f026c8103ca39f3f2ee1c8f7e9dcbcfed5e10c642ece4fa1183bed1 2346254 samba-dbg_3.3.0~rc2-4_i386.deb
 6ae1d501e67beb12018266b24cb583b084db54ead4ff3d1132f66f111ea051a7 82400 libwbclient0_3.3.0~rc2-4_i386.deb
Files: 
 f236210ae5a5c09d93996f14a980fe69 1841 net optional samba_3.3.0~rc2-4.dsc
 b38d1766237a67a42a1f17d14379a8fc 223410 net optional samba_3.3.0~rc2-4.diff.gz
 5aeddbd9928d77a11c2f1cf8710568cc 7940614 doc optional samba-doc_3.3.0~rc2-4_all.deb
 e49fe5b98971c77a34c6750e12306209 6253018 doc optional samba-doc-pdf_3.3.0~rc2-4_all.deb
 a8c25c4b96140e07e2ff09076d9843c9 4418858 net optional samba_3.3.0~rc2-4_i386.deb
 4083e3fe22ea2fd0160911b3b522c37c 3969762 net optional samba-common_3.3.0~rc2-4_i386.deb
 889e2af3c8965c25dad1b6b32be87fac 4978924 net optional samba-tools_3.3.0~rc2-4_i386.deb
 c74dec5aa0f578348186cd8f26c9bc11 7963126 net optional smbclient_3.3.0~rc2-4_i386.deb
 3510095fb0308644b101ec0dd2c260a4 1369126 net optional swat_3.3.0~rc2-4_i386.deb
 d279a9877af69757fc0fb3302b44d20f 1483106 otherosfs optional smbfs_3.3.0~rc2-4_i386.deb
 c6f5a1a9440f4e63477a144706746edc 562712 admin extra libpam-smbpass_3.3.0~rc2-4_i386.deb
 7b9e0000149ffd538c760937f26bb6d8 1317534 libs optional libsmbclient_3.3.0~rc2-4_i386.deb
 f18e748285005e10fb35859e872df28e 1999802 libdevel extra libsmbclient-dev_3.3.0~rc2-4_i386.deb
 57406b41fb8300a45df9d0725edd69fe 3404172 net optional winbind_3.3.0~rc2-4_i386.deb
 bf7b867d7afbcce56100f51c659c7936 2346254 devel extra samba-dbg_3.3.0~rc2-4_i386.deb
 666a7d360e073ea455c00246a72eee0c 82400 libs optional libwbclient0_3.3.0~rc2-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkl7O14ACgkQ1OXtrMAUPS1piACgvYB+ItpAF8swg4DNUHzo2akS
fGEAn34ykvpgDRVFgZI8tz7fxLqNrPQ2
=SHJK
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.