Debian Bug report logs - #487643
php5-ffmpeg: uses depreciated img_convert function, please port to libswscale

Toggle useless messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Paul Wise <pabs@debian.org>

To: maintonly@bugs.debian.org

Subject: php5-ffmpeg: uses depreciated img_convert function, please port to libswscale

Date: Mon, 23 Jun 2008 18:02:25 +0800

[Message part 1 (text/plain, inline)]

Package: php5-ffmpeg
Version: 0.5.1-2+b1
Severity: wishlist
User: pkg-multimedia-maintainers@lists.alioth.debian.org
Usertags: img-convert

The following files in your package appear to use the img_convert function,
which has been depreciated by ffmpeg upstream in favour of their newer
libswscale library. 

/usr/lib/php5/20060613/ffmpeg.so

Please refer to the following tutorial and the API docs to do the porting.

http://www.dranger.com/ffmpeg/tutorial08.html
http://cekirdek.pardus.org.tr/~ismail/ffmpeg-docs/ffmpeg-r_2libswscale_2swscale_8h.html

-- 
bye,
pabs

http://wiki.debian.org/PaulWise

[signature.asc (application/pgp-signature, inline)]

Message #12 received at 487643-quiet@bugs.debian.org (full text, mbox, reply):

From: Raphael Geissert <atomo64@gmail.com>

To: Paul Wise <pabs@debian.org>

Cc: 487643-quiet@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#487643: php5-ffmpeg: uses depreciated img_convert function, please port to libswscale

Date: Mon, 23 Jun 2008 11:40:35 -0500

[Message part 1 (text/plain, inline)]

tag 487643 upstream
forwarded 487643 Todd Kirby <ffmpeg.php@gmail.com>
thanks

Hi Paul,

On Monday 23 June 2008, Paul Wise wrote:
> Package: php5-ffmpeg
> Version: 0.5.1-2+b1
> Severity: wishlist
> User: pkg-multimedia-maintainers@lists.alioth.debian.org
> Usertags: img-convert
>
> The following files in your package appear to use the img_convert function,
> which has been depreciated by ffmpeg upstream in favour of their newer
> libswscale library.

I and upstream are both aware of this and upstream is already working on it 
(actually I think only crop and resize still use img_convert, I mean in SVN).
By the way, s/depreciated/deprecated? 

Depending on the progress I may make an upload to experimental from upstream's 
swscaler branch.

>
> /usr/lib/php5/20060613/ffmpeg.so
>
> Please refer to the following tutorial and the API docs to do the porting.
>
> http://www.dranger.com/ffmpeg/tutorial08.html
> http://cekirdek.pardus.org.tr/~ismail/ffmpeg-docs/ffmpeg-r_2libswscale_2sws
>cale_8h.html


Regards,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 487643@bugs.debian.org (full text, mbox, reply):

From: Michael Vogt <michael@moep.dyndns.org>

To: 487643@bugs.debian.org

Subject: Patch Avaiable

Date: Wed, 07 Jan 2009 00:28:34 +0100

Hey,
it seems that here are some patches to fix it (end of thread):
http://groups.google.fr/group/ffmpeg-php/browse_thread/thread/a849249cd5f3fc5

May someone please fix this? It would be very nice.

Greets,
Michael

Message #22 received at 487643@bugs.debian.org (full text, mbox, reply):

From: Michael Vogt <michael@moep.dyndns.org>

To: 487643@bugs.debian.org

Subject: New upstream-release avaiable

Date: Wed, 07 Jan 2009 13:53:16 +0100

Sorry, just saw right now that these patch are already in the package.

But there is a new upstream-release avaiable (0.6.0) which seems to fix 
these bugs.

Greets,
Michael

Message #27 received at 487643@bugs.debian.org (full text, mbox, reply):

From: "Raphael Geissert" <atomo64+debian@gmail.com>

To: "Michael Vogt" <michael@moep.dyndns.org>, 487643@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: [php-maint] Bug#487643: New upstream-release avaiable

Date: Mon, 12 Jan 2009 13:42:09 -0600

tag 487643 fixed-upstream
thanks

2009/1/7 Michael Vogt <michael@moep.dyndns.org>:
[...]
>
> But there is a new upstream-release avaiable (0.6.0) which seems to fix
> these bugs.
>

I know, and will upload it as soon as I move the repository to git (in
which case I would upload it to experimental) or lenny is released,
whatever happens first.

Cheers,
-- 
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net

Richard Dawkins  - "By all means let's be open-minded, but not so
open-minded that our brains drop out."

Message #34 received at 487643@bugs.debian.org (full text, mbox, reply):

From: Romain Viovi <imprec@gmail.com>

To: 487643@bugs.debian.org

Subject: Patch

Date: Tue, 17 Feb 2009 18:18:34 +0100

Before lenny, I was using this method, as described on google group
It would be nice to fix this bug


Edit ffmpeg_frame.c from line 396 to 411

delete

   int x, y;
    int *src = (int*)frame->data[0];

    for (y = 0; y < height; y++) {
        for (x = 0; x < width; x++) {

                        if (gdImageBoundsSafeMacro(dest, x, y)) {
                /* copy pixel to gdimage buffer zeroing the alpha channel */
                dest->tpixels[y][x] = src[x] & 0x00ffffff;
            } else {
                return -1;
            }
        }
        src += width;
    }
    return 0;




and replace by



    int x, y;
    int *src = (int*)frame->data[0];

    if (width > dest->sx || height > dest->sy)
    {
        return -1;
    }

    for (y = 0; y < height; y++) {
        for (x = 0; x < width; x++) {
                 dest->tpixels[y][x] = src[x] & 0x00ffffff;
        }
        src += width;
    }
    return 0;





-- 
Romain Viovi

romain.viovi@gmail.com

Message #43 received at 487643-close@bugs.debian.org (full text, mbox, reply):

From: Raphael Geissert <atomo64@gmail.com>

To: 487643-close@bugs.debian.org

Subject: Bug#487643: fixed in ffmpeg-php 0.6.0-1

Date: Mon, 23 Feb 2009 03:02:03 +0000

Source: ffmpeg-php
Source-Version: 0.6.0-1

We believe that the bug you reported is fixed in the latest version of
ffmpeg-php, which is due to be installed in the Debian FTP archive:

ffmpeg-php_0.6.0-1.diff.gz
  to pool/main/f/ffmpeg-php/ffmpeg-php_0.6.0-1.diff.gz
ffmpeg-php_0.6.0-1.dsc
  to pool/main/f/ffmpeg-php/ffmpeg-php_0.6.0-1.dsc
ffmpeg-php_0.6.0.orig.tar.gz
  to pool/main/f/ffmpeg-php/ffmpeg-php_0.6.0.orig.tar.gz
php5-ffmpeg_0.6.0-1_i386.deb
  to pool/main/f/ffmpeg-php/php5-ffmpeg_0.6.0-1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 487643@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Raphael Geissert <atomo64@gmail.com> (supplier of updated ffmpeg-php package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 22 Feb 2009 20:42:18 -0600
Source: ffmpeg-php
Binary: php5-ffmpeg
Architecture: source i386
Version: 0.6.0-1
Distribution: unstable
Urgency: low
Maintainer: Debian PHP Maintainers <pkg-php-maint@lists.alioth.debian.org>
Changed-By: Raphael Geissert <atomo64@gmail.com>
Description: 
 php5-ffmpeg - audio and video support via ffmpeg for php5
Closes: 487643 516365
Changes: 
 ffmpeg-php (0.6.0-1) unstable; urgency=low
 .
   * New upstream release (Closes: #516365)
     - Support for the ffmpeg swscale API (Closes: #487643)
     - API Changes:
       + Removed obsolete resize() and crop() functions.
       + Removed animated gif class.
     - Added check to ensure that gd loads before ffmpeg-php if both are
       compiled as extensions.
   * debian/control:
     + Improve the package description.
     + Add an ORed dependency on a real php5 SAPI package.
     + Add a BuildDep on libswscale-dev
   * debian/rules:
     + Minor cleanup.
   * debian/copyright:
     + Update copyright years
Checksums-Sha1: 
 86970f4b65060ab94bf45a3dc6c8c7aac3ba5656 1392 ffmpeg-php_0.6.0-1.dsc
 b03aacacc25ab0c7d0f01cac55601c95cc4f52ad 277135 ffmpeg-php_0.6.0.orig.tar.gz
 e33d715d2d729d4ce98d702ddb6e61943755ce8a 4176 ffmpeg-php_0.6.0-1.diff.gz
 4789c077ea850d9a69ff8829dd1a19774260496c 20252 php5-ffmpeg_0.6.0-1_i386.deb
Checksums-Sha256: 
 a8ab0715c51c5a1ac34cfc76f710c6123f5a7a93579165a0100db8dd7463b0a6 1392 ffmpeg-php_0.6.0-1.dsc
 d2d41c80e987a16c8c6eb8ba5408db1aaec722c2e7d9d32f6c65cd82d21cc9cf 277135 ffmpeg-php_0.6.0.orig.tar.gz
 06d7c38a593198d637daaee15c79dd06f3641018632f34e1565241b12f5e39cb 4176 ffmpeg-php_0.6.0-1.diff.gz
 75073fd0385faf8d40d796335985ee12b5876286e3475b2c780b5ce79a4e27df 20252 php5-ffmpeg_0.6.0-1_i386.deb
Files: 
 bce1d26e674798bdee6fb8fae5d287d7 1392 web optional ffmpeg-php_0.6.0-1.dsc
 1a1394b1e5ff4d5d79aecdab4180bc13 277135 web optional ffmpeg-php_0.6.0.orig.tar.gz
 9d5d5725f9bf592e1307a2bc64f87e9e 4176 web optional ffmpeg-php_0.6.0-1.diff.gz
 80a57ce1b178f3f280a48701e9c5d826 20252 web optional php5-ffmpeg_0.6.0-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmiDvQACgkQYy49rUbZzlpUlQCfa8nvlcOuZhcj1BF1pqXxRT4R
I3QAniFFsHnueWRvGQeKEGZRh99hQ/4U
=8VgA
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.