Debian Bug report logs - #485167
icedove: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs

Toggle useless messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Raphael Hertzog <hertzog@debian.org>

To: maintonly@bugs.debian.org

Subject: icedove: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs

Date: Sun, 08 Jun 2008 18:11:57 +0200

Package: icedove
Version: 2.0.0.14-1
Severity: wishlist
Usertags: 3.0-quilt-by-default

To prepare a possible switch to the new source package format "3.0
(quilt)" [1], I converted all source packages and tried to rebuild them.
Unfortunately, icedove failed, you can try yourself with those
commands (and dpkg-dev >= 1.14.19 [2]) :

$ apt-get source icedove
$ sed -i -e '/^Source:/ aFormat: 3.0 (quilt)' icedove-2.0.0.14/debian/control
$ dpkg-source -b icedove-2.0.0.14
$ dpkg-source -x icedove_2.0.0.14-1.dsc
$ cd icedove-2.0.0.14 && debuild -us -uc

In this process, if the .diff.gz contains changes to upstream files,
dpkg-source will have created a corresponding patch in
debian/patches/debian-changes-2.0.0.14-1 and will have registered that
patch in a quilt series (debian/patches/series, it is created if needed).
All the patches listed in the "series" file are applied directly during
the extraction (dpkg-source -x). quilt itself is used if available (and
will thus lead to the creation of the .pc directory), otherwise
dpkg-source applies the patches by itself. For more information about the
new source package format see the manual page dpkg-source(1).

In the case of icedove, the quilt series is only applicable
after extraction of a tarball/zipfile/jarfile. But dpkg-source
tries to apply the quilt series immediately after unpack 
and will thus fail.

In several cases the usage of tarball(s) in tarball is justified by the
fact that several upstream tarballs have to be combined. The new format
does support unpacking of multiple upstream tarballs and as such, you
probably want to defer fixing this bug until the new format is accepted
and directly make usage of this new feature.

If your package only contains a single tarball, you might want to
reconsider the choice of using a tarball inside a tarball and 
handle the build like do most other Debian packages.

In all cases, those are heavy changes for a simple wishlist bug and
I can understand that you don't fix this until after lenny's release.
I'm merely filing this bug to keep track of the packages that will cause
troubles when we switch to the new format.


As a side note, you must also pay attention to the following points in
your quilt usage to guarantee compatibility with the new source package
format:
- all your patches must be applicable with the "-p1" option of patch
  (and you shouldn't use options in the series file to override this)
- the patches must be in debian/patches/ together with the "series" file
  (you can use QUILT_PATCHES=debian/patches if needed)
- you should not override QUILT_PC to change the location of quilt's
  internal directory (".pc" by default)
- the patches should not reference absolute filenames (in +++/--- lines)
- your clean target must work even if the patches are already applied
- your build target must work with patches applied even if the clean
  target is supposed to unapply them (because dpkg-source -b might
  have applied them back)

Cheers,

[1] http://lists.debian.org/debian-devel-announce/2008/04/msg00004.html
[2] the upcoming dpkg-dev 1.14.20 is more tolerant with patches, you can
grab it here if you want to try with that version:
http://people.debian.org/~hertzog/packages/dpkg-dev_1.14.20_all.deb
-- 
Raphael Hertzog

Message #10 received at 485167-maintonly@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack <asac@debian.org>

To: Raphael Hertzog <hertzog@debian.org>, 485167-maintonly@bugs.debian.org

Subject: Re: Bug#485167: icedove: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs

Date: Thu, 12 Jun 2008 10:25:14 +0200

[Message part 1 (text/plain, inline)]

On Sun, Jun 08, 2008 at 06:11:57PM +0200, Raphael Hertzog wrote:
> In several cases the usage of tarball(s) in tarball is justified by the
> fact that several upstream tarballs have to be combined. The new format
> does support unpacking of multiple upstream tarballs and as such, you
> probably want to defer fixing this bug until the new format is accepted
> and directly make usage of this new feature.
> 
> If your package only contains a single tarball, you might want to
> reconsider the choice of using a tarball inside a tarball and 
> handle the build like do most other Debian packages.

Do i really need to eliminate my embedded tarball? I have no changes
outside the debian/patches/.

Thanks for clarifying,

 - Alexander

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 485167@bugs.debian.org (full text, mbox, reply):

From: Raphael Hertzog <hertzog@debian.org>

To: Alexander Sack <asac@debian.org>

Cc: 485167@bugs.debian.org

Subject: Re: Bug#485167: icedove: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs

Date: Thu, 12 Jun 2008 11:03:58 +0200

On Thu, 12 Jun 2008, Alexander Sack wrote:
> On Sun, Jun 08, 2008 at 06:11:57PM +0200, Raphael Hertzog wrote:
> > In several cases the usage of tarball(s) in tarball is justified by the
> > fact that several upstream tarballs have to be combined. The new format
> > does support unpacking of multiple upstream tarballs and as such, you
> > probably want to defer fixing this bug until the new format is accepted
> > and directly make usage of this new feature.
> > 
> > If your package only contains a single tarball, you might want to
> > reconsider the choice of using a tarball inside a tarball and 
> > handle the build like do most other Debian packages.
> 
> Do i really need to eliminate my embedded tarball? I have no changes
> outside the debian/patches/.

Well, if the source package is using the new format, during build
of a new source package it does want to apply patches on top of
the extracted .orig.tar.gz and obviously if the new orig.tar.gz doesn't
contain the required files to patch (because they are in the tarball), it will
fail:

dpkg-source: info: building icedove using existing ./icedove_2.0.0.14.orig.tar.gz
dpkg-source: failure: quilt --quiltrc /dev/null push main-fsh gave error exit status 1

Using tarball inside tarball goes against the spirit of the format evolution
that adds the required features so that a package is ready for further
modifications directly after "dpkg-source -x".

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/

Message #20 received at 485167@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack <asac@debian.org>

To: Raphael Hertzog <hertzog@debian.org>, 485167@bugs.debian.org

Subject: Re: Bug#485167: icedove: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs

Date: Thu, 12 Jun 2008 11:26:08 +0200

On Thu, Jun 12, 2008 at 11:03:58AM +0200, Raphael Hertzog wrote:
> On Thu, 12 Jun 2008, Alexander Sack wrote:
> > On Sun, Jun 08, 2008 at 06:11:57PM +0200, Raphael Hertzog wrote:
> > > In several cases the usage of tarball(s) in tarball is justified by the
> > > fact that several upstream tarballs have to be combined. The new format
> > > does support unpacking of multiple upstream tarballs and as such, you
> > > probably want to defer fixing this bug until the new format is accepted
> > > and directly make usage of this new feature.
> > > 
> > > If your package only contains a single tarball, you might want to
> > > reconsider the choice of using a tarball inside a tarball and 
> > > handle the build like do most other Debian packages.
> > 
> > Do i really need to eliminate my embedded tarball? I have no changes
> > outside the debian/patches/.
> 
> Well, if the source package is using the new format, during build
> of a new source package it does want to apply patches on top of
> the extracted .orig.tar.gz and obviously if the new orig.tar.gz doesn't
> contain the required files to patch (because they are in the tarball), it will
> fail:
> 
> dpkg-source: info: building icedove using existing ./icedove_2.0.0.14.orig.tar.gz
> dpkg-source: failure: quilt --quiltrc /dev/null push main-fsh gave error exit status 1
> 
> Using tarball inside tarball goes against the spirit of the format evolution
> that adds the required features so that a package is ready for further
> modifications directly after "dpkg-source -x".
> 

But isnt that the same for any patchsystem package? or will you apply
some rule in future on dpkg-source -x to guarantee that its in "ready
for modifications" state?


 - Alexander

Message #25 received at 485167@bugs.debian.org (full text, mbox, reply):

From: Raphael Hertzog <hertzog@debian.org>

To: Alexander Sack <asac@debian.org>

Cc: 485167@bugs.debian.org

Subject: Re: Bug#485167: icedove: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs

Date: Thu, 12 Jun 2008 11:52:28 +0200

On Thu, 12 Jun 2008, Alexander Sack wrote:
> > Using tarball inside tarball goes against the spirit of the format evolution
> > that adds the required features so that a package is ready for further
> > modifications directly after "dpkg-source -x".
> 
> But isnt that the same for any patchsystem package? or will you apply
> some rule in future on dpkg-source -x to guarantee that its in "ready
> for modifications" state?

I don't understand your question. 

Basically this new format makes quilt the official patchsystem and support
it properly. Any package that use another patchsystem will not satify the
requirement above but they can (and hopefully will) be converted over
time (once the new format is the default format).

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/

Message #30 received at 485167@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack <asac@debian.org>

To: Raphael Hertzog <hertzog@debian.org>, 485167@bugs.debian.org

Cc: Alexander Sack <asac@debian.org>

Subject: Re: Bug#485167: icedove: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs

Date: Thu, 12 Jun 2008 12:21:57 +0200

On Thu, Jun 12, 2008 at 11:52:28AM +0200, Raphael Hertzog wrote:
> On Thu, 12 Jun 2008, Alexander Sack wrote:
> > > Using tarball inside tarball goes against the spirit of the format evolution
> > > that adds the required features so that a package is ready for further
> > > modifications directly after "dpkg-source -x".
> > 
> > But isnt that the same for any patchsystem package? or will you apply
> > some rule in future on dpkg-source -x to guarantee that its in "ready
> > for modifications" state?
> 
> I don't understand your question. 
> 
> Basically this new format makes quilt the official patchsystem and support
> it properly. Any package that use another patchsystem will not satify the
> requirement above but they can (and hopefully will) be converted over
> time (once the new format is the default format).

OK, but given that i already use quilt and all the changes are already
in debian/patches, why do i need to change my package?

 - Alexander

Message #35 received at 485167@bugs.debian.org (full text, mbox, reply):

From: Raphael Hertzog <hertzog@debian.org>

To: Alexander Sack <asac@debian.org>

Cc: 485167@bugs.debian.org

Subject: Re: Bug#485167: icedove: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs

Date: Thu, 12 Jun 2008 14:18:00 +0200

On Thu, 12 Jun 2008, Alexander Sack wrote:
> On Thu, Jun 12, 2008 at 11:52:28AM +0200, Raphael Hertzog wrote:
> > On Thu, 12 Jun 2008, Alexander Sack wrote:
> > > > Using tarball inside tarball goes against the spirit of the format evolution
> > > > that adds the required features so that a package is ready for further
> > > > modifications directly after "dpkg-source -x".
> > > 
> > > But isnt that the same for any patchsystem package? or will you apply
> > > some rule in future on dpkg-source -x to guarantee that its in "ready
> > > for modifications" state?
> > 
> > I don't understand your question. 
> > 
> > Basically this new format makes quilt the official patchsystem and support
> > it properly. Any package that use another patchsystem will not satify the
> > requirement above but they can (and hopefully will) be converted over
> > time (once the new format is the default format).
> 
> OK, but given that i already use quilt and all the changes are already
> in debian/patches, why do i need to change my package?

Urgh! I showed you the error that happens when you try to build your
package with the new source format... the new format assumes that patches
listed in debian/patches/series can be applied on top of the unpacked
*.orig.tar.gz and you must make sure to match that criteria with your
package.

It's not the case as long as you keep the sources in a tarball inside the
.orig.tar.gz.

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/

Message #40 received at 485167@bugs.debian.org (full text, mbox, reply):

From: Tim Retout <tim@retout.co.uk>

To: 485167@bugs.debian.org

Subject: embedded tarball in icedove's orig.tar.gz

Date: Wed, 11 Feb 2009 12:11:30 +0000

Given that the maintainer seems to have changed since this Debian bug
was opened, I thought it might be worth asking: can we consider removing
the tarball-within-a-tarball approach in the icedove source package?

It's inconvenient for development, and the single tarball is getting
repacked anyway to remove trademarked icons.

-- 
Tim Retout <tim@retout.co.uk>

Message #45 received at 485167@bugs.debian.org (full text, mbox, reply):

From: srchance59@aol.com

To: tim@retout.co.uk, 485167@bugs.debian.org

Subject: Re: Bug#485167: embedded tarball in icedove's orig.tar.gz

Date: Wed, 11 Feb 2009 12:30:35 -0500

[Message part 1 (text/plain, inline)]

 


 Having absolutely no idea what you just told me, I had to solve the problem myself. Being a neophyte and simple desk top user, I don't speak the language. I went to the 'net and downloaded a free version of "Adobe Flash Player", after navigating through some impostors. I needed it to play "Pandora Radio". Thanks so much for your feedback and I am trying to learn this stuff! Peace-out, src


 

-----Original Message-----
From: Tim Retout <tim@retout.co.uk>
To: 485167@bugs.debian.org
Sent: Wed, 11 Feb 2009 5:11 am
Subject: Bug#485167: embedded tarball in icedove's orig.tar.gz










Given that the maintainer seems to have changed since this Debian bug
was opened, I thought it might be worth asking: can we consider removing
the tarball-within-a-tarball approach in the icedove source package?

It's inconvenient for development, and the single tarball is getting
repacked anyway to remove trademarked icons.

-- 
Tim Retout <tim@retout.co.uk>




-- 
Ubuntu-mozillateam mailing list
Ubuntu-mozillateam@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-mozillateam



 

[Message part 2 (text/html, inline)]

Message #50 received at 485167@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack <asac@debian.org>

To: Tim Retout <tim@retout.co.uk>, 485167@bugs.debian.org

Subject: Re: Bug#485167: embedded tarball in icedove's orig.tar.gz

Date: Mon, 2 Mar 2009 09:41:02 +0100

On Wed, Feb 11, 2009 at 12:11:30PM +0000, Tim Retout wrote:
> Given that the maintainer seems to have changed since this Debian bug
> was opened, I thought it might be worth asking: can we consider removing
> the tarball-within-a-tarball approach in the icedove source package?
> 
> It's inconvenient for development, and the single tarball is getting
> repacked anyway to remove trademarked icons.
> 

For now there is no change planned.

 - Alexander

Message #55 received at 485167@bugs.debian.org (full text, mbox, reply):

From: Raphael Hertzog <hertzog@debian.org>

To: Raphael Hertzog <hertzog@debian.org>

Subject: Source format "3.0 (quilt)" allowed in testing/unstable

Date: Wed, 4 Nov 2009 19:36:15 +0100

[ Same message sent in bcc to all remaining "FTBFS with new source format" ]

Hello,

the new source format "3.0 (quilt)" is now allowed in testing/unstable and
having all packages buildable with the new format is a release goal
(http://wiki.debian.org/ReleaseGoals/NewDebFormats).

Thus it would be nice to see this bug fixed. If you want, you can directly
fix the bug by switching the package to use the new format. In order to
help you in this process, I have put some advice on the project page and
will continue to complete it with answers to your questions:
http://wiki.debian.org/Projects/DebSrc3.0#FAQ

If you need help, please tag the bug help and someone might provide you a
patch. Ask explicitely if you want a patch to convert the package to the
new source format.

The few packages that contain multiple tarballs in the .orig tarball
should (ideally) be converted to the new format by using the multiple
upstream tarball feature that it offers.

I also recommend switching to quilt if you use another patch system
since it's now the patch system that is endorsed by the dpkg maintainers.

If you have questions, please ask.

Cheers,
-- 
Raphaël Hertzog

Message #60 received at 485167-done@bugs.debian.org (full text, mbox, reply):

From: Raphael Hertzog <hertzog@debian.org>

To: 482699-done@bugs.debian.org, 482700-done@bugs.debian.org, 482706-done@bugs.debian.org, 484905-done@bugs.debian.org, 484907-done@bugs.debian.org, 484909-done@bugs.debian.org, 484918-done@bugs.debian.org, 484923-done@bugs.debian.org, 484943-done@bugs.debian.org, 484946-done@bugs.debian.org, 484948-done@bugs.debian.org, 484955-done@bugs.debian.org, 484967-done@bugs.debian.org, 485027-done@bugs.debian.org, 485029-done@bugs.debian.org, 485030-done@bugs.debian.org, 485031-done@bugs.debian.org, 485032-done@bugs.debian.org, 485041-done@bugs.debian.org, 485102-done@bugs.debian.org, 485111-done@bugs.debian.org, 485113-done@bugs.debian.org, 485136-done@bugs.debian.org, 485145-done@bugs.debian.org, 485158-done@bugs.debian.org, 485166-done@bugs.debian.org, 485167-done@bugs.debian.org, 485170-done@bugs.debian.org, 485174-done@bugs.debian.org, 485176-done@bugs.debian.org, 485177-done@bugs.debian.org, 485179-done@bugs.debian.org, 485241-done@bugs.debian.org, 485244-done@bugs.debian.org, 485268-done@bugs.debian.org, 485330-done@bugs.debian.org, 485346-done@bugs.debian.org, 485354-done@bugs.debian.org, 485356-done@bugs.debian.org, 485370-done@bugs.debian.org, 538532-done@bugs.debian.org, 538545-done@bugs.debian.org, 538550-done@bugs.debian.org, 538554-done@bugs.debian.org, 538556-done@bugs.debian.org, 538561-done@bugs.debian.org, 538562-done@bugs.debian.org, 538570-done@bugs.debian.org, 538573-done@bugs.debian.org, 538575-done@bugs.debian.org, 538576-done@bugs.debian.org, 538580-done@bugs.debian.org, 538581-done@bugs.debian.org, 538606-done@bugs.debian.org, 538609-done@bugs.debian.org, 538615-done@bugs.debian.org, 538616-done@bugs.debian.org, 538623-done@bugs.debian.org, 538628-done@bugs.debian.org, 538630-done@bugs.debian.org, 538633-done@bugs.debian.org, 538634-done@bugs.debian.org, 538671-done@bugs.debian.org, 538673-done@bugs.debian.org, 538684-done@bugs.debian.org, 538686-done@bugs.debian.org, 538689-done@bugs.debian.org

Subject: Release goal 3.0-quilt-by-default is dropped

Date: Tue, 25 May 2010 09:19:18 +0200

Hello,

as announced in http://lists.debian.org/debian-devel-announce/2010/05/msg00010.html
the dpkg team no longer has any plan to switch the default source format
to "3.0 (quilt)" and as such this bug is meaningless.

However you have to create a debian/source/format file and be explicit
about the format that you want. That file will become mandatory in the
future. You are still highly encouraged to use one of the newer formats:
either "3.0 (quilt)" or "3.0 (native)".

http://lintian.debian.org/tags/missing-debian-source-format.html

Thanks for your work.

Regards,
-- 
Raphaël Hertzog

Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/
My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/

Send a report that this bug log contains spam.