Debian Bug report logs - #483285
lsb-base: lsb status_of_proc() function

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@canonical.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: lsb-base: lsb status_of_proc() function

Date: Tue, 27 May 2008 20:08:15 -0500

[Message part 1 (text/plain, inline)]

Package: lsb-base
Version: 3.2-4
Severity: wishlist
Tags: patch

The Linux Standard Base init script specification:
http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
describes the status action in detail.  In brief, it provides a
centralized and direct way of determining if a given service is running
or not, with a bit more sophistication than grepping a process listing.
It logs a message to standard output, and exits with one of a number of
meaningful codes, also defined in the LSB specification.

This has been discussed in a round-about way in a couple of bugs against
debian-policy before:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=291148
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=208010

More recently, we posted this patch to the debian-lsb mailing-list:
http://lists.debian.org/debian-lsb/2008/05/msg00000.html

We're filing a bug here against lsb-base in hopes of having the attached
patch accepted into the lsb-base package.

We suggest adding a function, status_of_proc(),
to /lib/lsb/init-functions, which is already sourced by most scripts
in /etc/init.d.  The heavy lifting is performed by the pidofproc()
function, which is already defined in that same file.

+status_of_proc () {
+    local daemon name status
+    daemon="$1"
+    name="$2"
+    pidofproc $daemon >/dev/null
+    status=$?
+    if [ $status -eq 0 ]; then
+        log_success_msg "$name is running."
+    else
+        log_failure_msg "$name is not running."
+    fi
+    return $status
+}


This addition would be followed by a series of patches to various init
scripts essentially adding the following to the case handler:

+ status)
+   status_of_proc "$DAEMON" "$NAME"
+   exit $?
+   ;;


-- 
:-Dustin

Dustin Kirkland
Ubuntu Server Developer
Canonical, LTD
kirkland@canonical.com
GPG: 1024D/83A61194


-- System Information:
Debian Release: lenny/sid
  APT prefers hardy-updates
  APT policy: (500, 'hardy-updates'), (500, 'hardy-security'), (500, 'hardy')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-17-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lsb-base depends on:
ii  libncurses5        5.6+20071124-1ubuntu2 Shared libraries for terminal hand
ii  libpam0g           0.99.7.1-5ubuntu6.1   Pluggable Authentication Modules l
ii  ncurses-bin        5.6+20071124-1ubuntu2 Terminal-related programs and man
ii  sed                4.1.5-5               The GNU sed stream editor

lsb-base recommends no packages.

-- no debconf information

[lsb-base.diff (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 483285@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@canonical.com>

To: 483285@bugs.debian.org

Subject: re: lsb-base: lsb status_of_proc() function

Date: Wed, 04 Jun 2008 13:43:41 -0500

[Message part 1 (text/plain, inline)]

I have update the patch for this bug with two changes.

The first makes killproc more "set -e" safe, by:

+        /bin/pidof -o %PPID $1 || status="$?"


The second quotes "$status" and uses shell string comparisons rather
than numerical comparisons.  Surveying the rest of the init-functions
script, this seems to be relatively more consistent.

Thanks,
:-Dustin

[lsb-base.483285.diff (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 483285@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@canonical.com>

To: 483285@bugs.debian.org

Subject: re: lsb-base: lsb status_of_proc() function

Date: Mon, 09 Jun 2008 10:52:49 -0500

[Message part 1 (text/plain, inline)]

Another minor update to this patch, also in the vein of making it "set
-e" safe.

These changes have been integrated into Ubuntu Intrepid.  We thought you
might integrate them into Debian Unstable as well.


:-Dustin

[lsb-base.483285.diff (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 483285@bugs.debian.org (full text, mbox, reply):

From: "Chris Lawrence" <lawrencc@debian.org>

To: kirkland@canonical.com, 483285@bugs.debian.org

Subject: Re: Bug#483285: lsb-base: lsb status_of_proc() function

Date: Mon, 9 Jun 2008 21:16:16 -0500

On Mon, Jun 9, 2008 at 10:52 AM, Dustin Kirkland <kirkland@canonical.com> wrote:
> Another minor update to this patch, also in the vein of making it "set
> -e" safe.
>
> These changes have been integrated into Ubuntu Intrepid.  We thought you
> might integrate them into Debian Unstable as well.

Thanks, Dustin.  I'm holding off on integrating these patches until I
get 3.2-12 into testing; adding functionality would break the spirit
of the freeze, but I'll plan on getting status_of_proc() into unstable
soon after that migration happens (hopefully soon).

BTW, we may want to consider specifying this interface and the
enhanced init logging functions for a future iteration of the LSB
proper.


Chris

Message #25 received at 483285@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@canonical.com>

To: Chris Lawrence <lawrencc@debian.org>

Cc: 483285@bugs.debian.org

Subject: Re: Bug#483285: lsb-base: lsb status_of_proc() function

Date: Fri, 13 Jun 2008 13:44:12 -0500

[Message part 1 (text/plain, inline)]

On Mon, 2008-06-09 at 21:16 -0500, Chris Lawrence wrote:
> Thanks, Dustin.  I'm holding off on integrating these patches until I
> get 3.2-12 into testing; adding functionality would break the spirit
> of the freeze, but I'll plan on getting status_of_proc() into unstable
> soon after that migration happens (hopefully soon).

Sounds great, thanks!

> BTW, we may want to consider specifying this interface and the
> enhanced init logging functions for a future iteration of the LSB
> proper.

By "LSB proper", do you mean the LSB specification itself, or something
else?

If you mean the specification, see the link I mentioned in my initial
bug report: 
 * http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

Quoting:
        If the status action is requested, the init script will return
        the following exit status codes. 
                0       program is running or service is OK
                1       program is dead and /var/run pid file exists
                2       program is dead and /var/lock lock file exists
                3       program is not running
                4       program or service status is unknown
                5-99    reserved for future LSB use
                100-149 reserved for distribution use
                150-199 reserved for application use
                200-254 reserved

status_of_proc() currently returns whatever status pifofproc() returns.
pidofproc() handles returns of [0,1,3,4].  It could easily be made to
handle case 2 as well.  I'll open a new bug and send a patch.


-- 
:-Dustin

Dustin Kirkland
Ubuntu Server Developer
Canonical, LTD
kirkland@canonical.com
GPG: 1024D/83A61194

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 483285@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@canonical.com>

To: Chris Lawrence <lawrencc@debian.org>

Cc: 483285@bugs.debian.org

Subject: Re: Bug#483285: lsb-base: lsb status_of_proc() function

Date: Tue, 08 Jul 2008 19:27:07 -0500

[Message part 1 (text/plain, inline)]

Chris-

I have attached an updated patch for the status_of_proc() function, that
we're currently carrying in Ubuntu.

I have replaced the call to pidofproc() with an invocation
of /bin/pidof.

It seems that pidofproc() will attempt to call "kill -0" on a pid, if a
pidfile is found.  This "kill" operation will only succeed if the euid
is that of the user owning the daemon, or the root user.

Querying the status of a daemon is an operation that should be
accessible by non-privileged users.  I think this is a reasonable
tradeoff.  I have tested this with modifications to the init scripts of:
(at, bind9, cron, dovecot, openssh-server, samba, sysklogd).  It works
very well.


Additionally, you mentioned the current lenny freeze.  This is a very
small, compact, standalone function within lsb-base.  This change should
not affect any existing functionality.  Would you reconsider including
this under the current freeze?  Patches to a number of init scripts are
gated upon this functionality being incorporated into lsb-base.

Thanks,
-- 
:-Dustin

Dustin Kirkland
Ubuntu Server Developer
Canonical, LTD
kirkland@canonical.com
GPG: 1024D/83A61194

[lsb.483285.diff (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 483285@bugs.debian.org (full text, mbox, reply):

From: "Chris Lawrence" <lawrencc@debian.org>

To: kirkland@canonical.com, 483285@bugs.debian.org

Subject: Re: Bug#483285: lsb-base: lsb status_of_proc() function

Date: Tue, 8 Jul 2008 21:50:14 -0500

On Tue, Jul 8, 2008 at 7:27 PM, Dustin Kirkland <kirkland@canonical.com> wrote:
> I have attached an updated patch for the status_of_proc() function, that
> we're currently carrying in Ubuntu.
>
> I have replaced the call to pidofproc() with an invocation
> of /bin/pidof.
>
> It seems that pidofproc() will attempt to call "kill -0" on a pid, if a
> pidfile is found.  This "kill" operation will only succeed if the euid
> is that of the user owning the daemon, or the root user.
>
> Querying the status of a daemon is an operation that should be
> accessible by non-privileged users.  I think this is a reasonable
> tradeoff.  I have tested this with modifications to the init scripts of:
> (at, bind9, cron, dovecot, openssh-server, samba, sysklogd).  It works
> very well.
>
>
> Additionally, you mentioned the current lenny freeze.  This is a very
> small, compact, standalone function within lsb-base.  This change should
> not affect any existing functionality.  Would you reconsider including
> this under the current freeze?  Patches to a number of init scripts are
> gated upon this functionality being incorporated into lsb-base.

I will see what I can do, but I'm not the gatekeeper for whether or
not it will actually make it in; lsb-base is already frozen, so the
decision is above my pay grade.


Chris

Message #40 received at 483285@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@canonical.com>

To: Chris Lawrence <lawrencc@debian.org>

Cc: 483285@bugs.debian.org

Subject: Re: Bug#483285: lsb-base: lsb status_of_proc() function

Date: Tue, 08 Jul 2008 22:15:31 -0500

[Message part 1 (text/plain, inline)]

On Tue, 2008-07-08 at 21:50 -0500, Chris Lawrence wrote:
> I will see what I can do, but I'm not the gatekeeper for whether or
> not it will actually make it in; lsb-base is already frozen, so the
> decision is above my pay grade.

Just to clarify, I'm looking for this to make it into 'unstable'.  Your
note from 2008-06-09 said that you were holding off until you got
'3.2-12 into testing'.

Looks like that happened on 2008-06-11.

I'm not nearly so concerned about this making 'lenny'!

Thanks,
:-Dustin

[signature.asc (application/pgp-signature, inline)]

Message #45 received at 483285@bugs.debian.org (full text, mbox, reply):

From: "Chris Lawrence" <lawrencc@debian.org>

To: kirkland@canonical.com

Cc: 483285@bugs.debian.org

Subject: Re: Bug#483285: lsb-base: lsb status_of_proc() function

Date: Tue, 8 Jul 2008 22:26:24 -0500

On Tue, Jul 8, 2008 at 10:15 PM, Dustin Kirkland <kirkland@canonical.com> wrote:
> On Tue, 2008-07-08 at 21:50 -0500, Chris Lawrence wrote:
>> I will see what I can do, but I'm not the gatekeeper for whether or
>> not it will actually make it in; lsb-base is already frozen, so the
>> decision is above my pay grade.
>
> Just to clarify, I'm looking for this to make it into 'unstable'.  Your
> note from 2008-06-09 said that you were holding off until you got
> '3.2-12 into testing'.
>
> Looks like that happened on 2008-06-11.
>
> I'm not nearly so concerned about this making 'lenny'!

Ah :)  In which case, you'll be happy, since I just rolled up 3.2-12
with your patch and some other bits.  Most of the changes are pretty
small, so there's a decent chance it will make lenny too.


Chris

Message #50 received at 483285-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lawrence <lawrencc@debian.org>

To: 483285-close@bugs.debian.org

Subject: Bug#483285: fixed in lsb 3.2-13

Date: Wed, 09 Jul 2008 03:32:07 +0000

Source: lsb
Source-Version: 3.2-13

We believe that the bug you reported is fixed in the latest version of
lsb, which is due to be installed in the Debian FTP archive:

lsb-base_3.2-13_all.deb
  to pool/main/l/lsb/lsb-base_3.2-13_all.deb
lsb-core_3.2-13_amd64.deb
  to pool/main/l/lsb/lsb-core_3.2-13_amd64.deb
lsb-cxx_3.2-13_amd64.deb
  to pool/main/l/lsb/lsb-cxx_3.2-13_amd64.deb
lsb-desktop_3.2-13_amd64.deb
  to pool/main/l/lsb/lsb-desktop_3.2-13_amd64.deb
lsb-graphics_3.2-13_amd64.deb
  to pool/main/l/lsb/lsb-graphics_3.2-13_amd64.deb
lsb-languages_3.2-13_amd64.deb
  to pool/main/l/lsb/lsb-languages_3.2-13_amd64.deb
lsb-multimedia_3.2-13_amd64.deb
  to pool/main/l/lsb/lsb-multimedia_3.2-13_amd64.deb
lsb-printing_3.2-13_amd64.deb
  to pool/main/l/lsb/lsb-printing_3.2-13_amd64.deb
lsb-qt4_3.2-13_amd64.deb
  to pool/main/l/lsb/lsb-qt4_3.2-13_amd64.deb
lsb-release_3.2-13_all.deb
  to pool/main/l/lsb/lsb-release_3.2-13_all.deb
lsb_3.2-13.dsc
  to pool/main/l/lsb/lsb_3.2-13.dsc
lsb_3.2-13.tar.gz
  to pool/main/l/lsb/lsb_3.2-13.tar.gz
lsb_3.2-13_all.deb
  to pool/main/l/lsb/lsb_3.2-13_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 483285@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lawrence <lawrencc@debian.org> (supplier of updated lsb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 08 Jul 2008 22:03:10 -0500
Source: lsb
Binary: lsb-core lsb-graphics lsb-cxx lsb-desktop lsb-qt4 lsb-languages lsb-multimedia lsb-printing lsb lsb-base lsb-release
Architecture: source all amd64
Version: 3.2-13
Distribution: unstable
Urgency: low
Maintainer: Chris Lawrence <lawrencc@debian.org>
Changed-By: Chris Lawrence <lawrencc@debian.org>
Description: 
 lsb        - Linux Standard Base 3.2 support package
 lsb-base   - Linux Standard Base 3.2 init script functionality
 lsb-core   - Linux Standard Base 3.2 core support package
 lsb-cxx    - Linux Standard Base 3.2 C++ support package
 lsb-desktop - Linux Standard Base 3.2 Desktop support package
 lsb-graphics - Linux Standard Base 3.2 graphics support package
 lsb-languages - Linux Standard Base 3.2 Runtime Languages package
 lsb-multimedia - Linux Standard Base 3.2 Multimedia package
 lsb-printing - Linux Standard Base 3.2 Printing package
 lsb-qt4    - Linux Standard Base 3.2 Qt4 support package
 lsb-release - Linux Standard Base version reporting utility
Closes: 452992 461340 479542 481281 483285 489265
Changes: 
 lsb (3.2-13) unstable; urgency=low
 .
   * Include status_of_proc() function from Ubuntu's lsb-base.
     Thanks to Dustin Kirkland.  (Closes: #483285)
   * This patch also allows pidofproc to work on other users' processes.
     (Closes: #452992)
   * Fix output of lsb_release -h to properly describe what -s does.
     (Closes: #479542)
   * Add Slovak translation.  (Closes: #489265)
   * Fix dependencies to not use >>.  (Closes: #461340)
   * Document init-functions license in debian/copyright.
     (Closes: #481281)
   * Also fix text of init-functions license to remove the reference to
     "the Regents," who didn't author any of init-functions.
Checksums-Sha1: 
 6ad535c324fb064c135ffea3adf68cd80fdac8e1 966 lsb_3.2-13.dsc
 de59e230e78fd0e67c71166613aba82e7631a5b9 51044 lsb_3.2-13.tar.gz
 cbe336aca90071a3b91a2e7e0cb39e21916e1a99 13776 lsb_3.2-13_all.deb
 ddc6a707db7f59a02644458bb4899bb3243e2d8d 18642 lsb-base_3.2-13_all.deb
 c1b8d2c7831a15880255af41b2abacb43886fed5 19178 lsb-release_3.2-13_all.deb
 85ba89a69696a45e9c129e9179004c8b7d2eee8c 36986 lsb-core_3.2-13_amd64.deb
 aa106c9f502f5a3a787eb661eca347f5c29d6fe5 13812 lsb-graphics_3.2-13_amd64.deb
 b782967329215dbbd4cc3382ee73a6a2ab965bc4 13782 lsb-cxx_3.2-13_amd64.deb
 0e6745c1fc110f2f663cac94c67b4890f429f4cc 13910 lsb-desktop_3.2-13_amd64.deb
 5671f9aac4aa94141cd1edb570e12eebc4c1c79f 13846 lsb-qt4_3.2-13_amd64.deb
 705b6eb26e163a865053b24e5741638c7d7c7bc6 13808 lsb-languages_3.2-13_amd64.deb
 b5f300fd4cb206c2ce883b53c7141845801b88cc 13788 lsb-multimedia_3.2-13_amd64.deb
 2f73bf5a9684058aeb4237ab20b3dc92719d550e 13812 lsb-printing_3.2-13_amd64.deb
Checksums-Sha256: 
 c82d67322443a22cf3b9533eb7acaa43cd0566315d16796d2a9dc759694e2949 966 lsb_3.2-13.dsc
 74dc69a1d8d20db9f3d85dcba71ebccdbaf721f63d206e3a7f093363ee5abc48 51044 lsb_3.2-13.tar.gz
 e9882d217442445ef422746dcb3646869af60809bf0920f7ecfb622acf391e3f 13776 lsb_3.2-13_all.deb
 328a7c952bbb42d3be32ca7e697c0b13075c904e030a51b5af6bb80418e49ea9 18642 lsb-base_3.2-13_all.deb
 d4b531c6b293d731cd870f66e12eab3af44a12b81aa168553bdf5908f431894f 19178 lsb-release_3.2-13_all.deb
 03946b0b9ad036428ea62573e2bbb869bc6c83e8917c9b992b1ebf3f0466f4d2 36986 lsb-core_3.2-13_amd64.deb
 7e7f4c0f39bf065bac86452e3c3425135b450c2a3bce606a406960b37c870396 13812 lsb-graphics_3.2-13_amd64.deb
 4a55e702f6d7d982a457a08cb413014341e39146af301ccf07ea4a62e3dde53a 13782 lsb-cxx_3.2-13_amd64.deb
 0b6eb517d4dc6109fa1afee47f7ff4c88d510007d5517a18011e0e707657f1df 13910 lsb-desktop_3.2-13_amd64.deb
 bd2adaabc7713dee66d52813282dca7a30ae96a3121a63bbf6a196cf5de4bd42 13846 lsb-qt4_3.2-13_amd64.deb
 049ef04227406a6454f2f9d9e9a775f24040c988ff9674d497b46839ad80ade3 13808 lsb-languages_3.2-13_amd64.deb
 d54d495b50dd977bebf0fbaa21ab5c91b339eb111ddb8e365d4bcf78181bc31d 13788 lsb-multimedia_3.2-13_amd64.deb
 61939c74944a1b330fd8facb1a9ef9c406bd7bab2b6a83fae73fb1fce68a93c0 13812 lsb-printing_3.2-13_amd64.deb
Files: 
 07c161a174e4832943ef99f1a08ffe62 966 misc extra lsb_3.2-13.dsc
 df298a57e4c952f3639b78265456c0c3 51044 misc extra lsb_3.2-13.tar.gz
 5c094bb4a0348dc5ba693d965bb8454c 13776 misc extra lsb_3.2-13_all.deb
 787bcbd43164afbfaf6677cd0d97b656 18642 misc required lsb-base_3.2-13_all.deb
 d0aedffc0399cccee06f6d959031639c 19178 misc extra lsb-release_3.2-13_all.deb
 9600578ab371c0887f65f050165b6e27 36986 misc extra lsb-core_3.2-13_amd64.deb
 934c912ceb3aba2139957b9ab4c6ca38 13812 misc extra lsb-graphics_3.2-13_amd64.deb
 8fd87f3ac558ed6bc297a6b53dc3ddf7 13782 misc extra lsb-cxx_3.2-13_amd64.deb
 45b77be0231568d3c56dacabc7c51838 13910 misc extra lsb-desktop_3.2-13_amd64.deb
 f45802e50a841b0a94acad829cbe5c31 13846 misc extra lsb-qt4_3.2-13_amd64.deb
 24beb47760a8c4334acb17abb593a8af 13808 misc extra lsb-languages_3.2-13_amd64.deb
 917ed2be0b39c1ffa9a42c1592d91c1c 13788 misc extra lsb-multimedia_3.2-13_amd64.deb
 a453bf68611abbc7496fef4bd89bc349 13812 misc extra lsb-printing_3.2-13_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkh0LsEACgkQ2wQKE6PXubxkLQCffIR4KlInGDNENJPrm6uPhvC7
m5gAoIzjSozMVB/CmMvsZF74f5JerbWT
=jguD
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.