Debian Bug report logs - #479824
elinks: Spams syslog about /dev/gpmctl

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sami Liedes <sliedes@cc.hut.fi>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: elinks: Spams syslog about /dev/gpmctl

Date: Tue, 6 May 2008 23:12:30 +0300

[Message part 1 (text/plain, inline)]

Package: elinks
Version: 0.11.3-7
Severity: normal

Whenever I run elinks, I get messages like this in my syslog:

------------------------------------------------------------
May  5 23:35:52 lh elinks: *** info
May  5 23:35:52 lh elinks: /dev/gpmctl: No such file or directory
May  5 23:35:52 lh elinks: *** info
May  5 23:35:52 lh elinks: /dev/gpmctl: No such file or directory
May  5 23:35:52 lh elinks: *** err
May  5 23:35:52 lh elinks: Oh, oh, it's an error! possibly I die!
May  5 23:36:27 lh elinks: *** info
May  5 23:36:27 lh elinks: /dev/gpmctl: No such file or directory
May  5 23:36:27 lh elinks: *** info
May  5 23:36:27 lh elinks: /dev/gpmctl: No such file or directory
May  5 23:36:27 lh elinks: *** err
May  5 23:36:27 lh elinks: Oh, oh, it's an error! possibly I die!
May  5 23:36:36 lh elinks: *** info
May  5 23:36:36 lh elinks: /dev/gpmctl: No such file or directory
May  5 23:36:36 lh elinks: *** info
May  5 23:36:36 lh elinks: /dev/gpmctl: No such file or directory
May  5 23:36:36 lh elinks: *** err
May  5 23:36:36 lh elinks: Oh, oh, it's an error! possibly I die!
------------------------------------------------------------

I don't run gpm.

	Sami


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.25 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=C, LC_CTYPE=fi_FI@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages elinks depends on:
ii  elinks-data            0.11.3-7          advanced text-mode WWW browser - d
ii  libbz2-1.0             1.0.5-0.1         high-quality block-sorting file co
ii  libc6                  2.7-10            GNU C Library: Shared libraries
ii  libexpat1              1.95.8-4          XML parsing C library - runtime li
ii  libfsplib0             0.9-1             FSP v2 protocol stack library - sh
ii  libgnutls26            2.2.3~rc-1        the GNU TLS library - runtime libr
ii  libgpmg1               1.20.3~pre3-3     General Purpose Mouse - shared lib
ii  libidn11               1.8-1             GNU libidn library, implementation
ii  liblua50               5.0.3-3           Main interpreter library for the L
ii  liblualib50            5.0.3-3           Extension library for the Lua 5.0 
ii  libperl5.8             5.8.8-12          Shared Perl library
ii  libruby1.8             1.8.6.114-2       Libraries necessary to run Ruby 1.
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

elinks recommends no packages.

-- no debconf information

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 479824@bugs.debian.org (full text, mbox, reply):

From: Kalle Olavi Niemitalo <kon@iki.fi>

To: Sami Liedes <sliedes@cc.hut.fi>

Cc: 479824@bugs.debian.org

Subject: Re: Bug#479824: elinks: Spams syslog about /dev/gpmctl

Date: Fri, 16 May 2008 11:34:14 +0300

[Message part 1 (text/plain, inline)]

Sami Liedes <sliedes@cc.hut.fi> writes:

> Whenever I run elinks, I get messages like this in my syslog:
>
> ------------------------------------------------------------
> May  5 23:35:52 lh elinks: *** info
> May  5 23:35:52 lh elinks: /dev/gpmctl: No such file or directory
> May  5 23:35:52 lh elinks: *** info
> May  5 23:35:52 lh elinks: /dev/gpmctl: No such file or directory
> May  5 23:35:52 lh elinks: *** err
> May  5 23:35:52 lh elinks: Oh, oh, it's an error! possibly I die!

These messages come from gpm-1.20.3~pre3/src/liblow.c.  They
weren't there in the venerable gpm-1.19.6.  The messages are
output via gpm_report() in src/report.c.  According to the
comments there, GPM does not provide a way to entirely disable
the messages; it can only direct them to stdout/stderr.  To do
this, we'd have to set option.run_status = GPM_RUN_DEBUG.
However, the option variable is not exported from libgpm.so, and
the only places that set option.run_status = GPM_RUN_DEBUG are
cmdline() in src/gpn.c and cmdline() in prog/gpm-root.y, which
also do not appear to end up in libgpm.

Thus, it seems GPM does not allow applications such as ELinks to
disable this syslog output.  This excessive logging has already
been reported:

http://bugs.debian.org/469933  (libgpmg1 package)
http://bugs.debian.org/474516  (gpm package, perhaps not pertinent)

The only sane way to fix this in the elinks package would be to
disable GPM support.  Alternatively, you could downgrade GPM or
avoid the errors by installing the GPM server.

[Message part 2 (application/pgp-signature, inline)]

Message #21 received at 479824@bugs.debian.org (full text, mbox, reply):

From: Jonathan Nieder <jrnieder@uchicago.edu>

To: 479824@bugs.debian.org, 482138@bugs.debian.org

Subject: progress

Date: Mon, 26 May 2008 13:50:30 -0500 (CDT)

I have been working on getting gpm to be quiet about the lack of /dev/gpmctl,
and, while I'm at it, using the latest stable upstream gpm version. My progress
so far is at http://home.uchicago.edu/~jrnieder/gpm.bdl as a git bundle.

(To use it:

   wget http://home.uchicago.edu/~jrnieder/gpm.bdl
   mkdir gpm && cd gpm && git init
   git bundle verify ../gpm.bdl
   git fetch ../gpm.bdl refs/*:refs/*
   git checkout build
   gitk --all

and go from there.)

It works for me. Please let me know if you have any advice. By tomorrow I
should have some reasonable patches to look at. (I am mentioning the changes
now just as a heads up.) I hope this is helpful and that I have not stepped
on anyone's toes.

Message #26 received at 479824@bugs.debian.org (full text, mbox, reply):

From: Nico Schottelius <nico-debian-pkg-gpm-devel@schottelius.org>

To: Jonathan Nieder <jrnieder@uchicago.edu>

Cc: 479824@bugs.debian.org, 482138@bugs.debian.org

Subject: Re: Bug#479824: progress

Date: Tue, 27 May 2008 23:14:23 +0200

[Message part 1 (text/plain, inline)]

Jonathan Nieder [Mon, May 26, 2008 at 01:50:30PM -0500]:
> [gpm-stuff in a git-bundle]

I just fetched it, but have to go to sleep soon. Will have a look at it
in the next days.

Which branch is designed for merge with upstream?

jrnieder/upstream or jrnieder/upstream-patches?
I guess the last one?

Btw, I preferred

git-remote add jrnieder /home/user/nico/projekte/gpm/git-bundles/jrnieder.bdl

to be easier able to merge with you later on.

If you could push your stuff to a non-bundle it would make life even
easier for me :-)

Sincerly,

Nico

-- 
Think about Free and Open Source Software (FOSS).
http://nico.schottelius.org/documentations/foss/the-term-foss/

PGP: BFE4 C736 ABE5 406F 8F42  F7CF B8BE F92A 9885 188C

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 479824@bugs.debian.org (full text, mbox, reply):

From: Jonathan Nieder <jrnieder@uchicago.edu>

To: Nico Schottelius <nico-debian-pkg-gpm-devel@schottelius.org>

Cc: 479824@bugs.debian.org, 482138@bugs.debian.org

Subject: Re: Bug#479824: progress

Date: Tue, 27 May 2008 20:53:48 -0500 (CDT)

> I just fetched it, but have to go to sleep soon. Will have a look at it
> in the next days.

Thank you, but note that it is a work in progress - I haven't looked over
everything to make sure it makes sense yet. I hope to put something more
reasonable out tonight.

> Which branch is designed for merge with upstream?
>
> jrnieder/upstream or jrnieder/upstream-patches?
> I guess the last one?

Actually, jrnieder/my-patches. jrnieder/upstream-patches contains refreshed
versions of the patches already in Debian that had not been applied upstream
yet.

> Btw, I preferred
>
> git-remote add jrnieder /home/user/nico/projekte/gpm/git-bundles/jrnieder.bdl
>
> to be easier able to merge with you later on.

I didn't realize you could do that. Thanks!

> If you could push your stuff to a non-bundle it would make life even
> easier for me :-)

I was planning to make a patch series with format-patch, but because you
ask I will make the changes available for http access as well :)

Thanks again for all the suggestions.

Until later,
Jonathan

Message #36 received at 479824@bugs.debian.org (full text, mbox, reply):

From: Jonathan Nieder <jrnieder@uchicago.edu>

To: Nico Schottelius <nico-debian-pkg-gpm-devel@schottelius.org>

Cc: 479824@bugs.debian.org, 482138@bugs.debian.org

Subject: Re: Bug#479824: progress

Date: Wed, 28 May 2008 15:44:52 -0500 (CDT)

> If you could push your stuff to a non-bundle it would make life even
> easier

Ack! Sorry I have been taking so long. I was bitten by the bug described
at http://article.gmane.org/gmane.comp.version-control.git/83101 - serves
me right for trying to get things done using a prerelease version of git.

Anyway, please take a look at

    http://home.uchicago.edu/~jrnieder/gpm.git for-nico

once you get a chance. The 'upstream' corresponds to gpm-1-stable from
http://unix.schottelius.org/git/gpm. The "for-nico" branch contains
changes that I think should be pushed upstream.

Message #41 received at 479824-quiet@bugs.debian.org (full text, mbox, reply):

From: Jonathan Nieder <jrnieder@uchicago.edu>

To: 479824-quiet@bugs.debian.org

Subject: [PATCH 2/2] libgpm: do not log debug messages

Date: Wed, 28 May 2008 16:22:15 -0500 (CDT)

This change puts src/lib/report-lib.c more in line
with src/report.c by suppressing debug messages by
default (although here, the only way to change that
default is to change the code and recompile :).

This is particularly important to users of logcheck,
which for some reason considers any syslog message
containing the text "debug" to represent a
misconfigured system and a security risk.
---
 src/lib/report-lib.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/lib/report-lib.c b/src/lib/report-lib.c
index 812fdb8..4596fd8 100644
--- a/src/lib/report-lib.c
+++ b/src/lib/report-lib.c
@@ -29,6 +29,9 @@ void gpm_report(int line, char *file, int stat, char *text, ... )
    char *string = NULL;
    int log_level;
    va_list ap;
+ 
+   if (stat == GPM_STAT_DEBUG) return;
+
    va_start(ap,text);
 
    switch(stat) {
-- 
1.5.5.2

Message #46 received at 479824-quiet@bugs.debian.org (full text, mbox, reply):

From: Jonathan Nieder <jrnieder@uchicago.edu>

To: 479824-quiet@bugs.debian.org

Subject: [PATCH 1/2] libgpm: Make "/dev/gpmctl: No such file" into a debug message

Date: Wed, 28 May 2008 16:21:18 -0500 (CDT)

For the record, here is the fix I put in ~jrnieder/gpm.git:

Programs using libgpm should function without complaint
even on systems without the gpm daemon installed. Thus,
not finding /dev/gpmctl is not an error, nor even something
unexpected. Change the message priority accordingly.

(We introduce a new variable gpm_is_disabled to remember
whether failure is due to ENOENT or some other condition.
I would rather avoid this kind of thing. If we did not have
to check separately for GPM_NODE_CTL and GPM_NODE_DEV, then
the variable would be unnecessary. Actually, by default
GPM_NODE_CTL and GPM_NODE_DEV are the same. Something to
think about...)

Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>
---
 src/lib/liblow.c |   21 ++++++++++++++++++---
 1 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/src/lib/liblow.c b/src/lib/liblow.c
index 3eeee30..efa2aa8 100644
--- a/src/lib/liblow.c
+++ b/src/lib/liblow.c
@@ -202,6 +202,7 @@ int Gpm_Open(Gpm_Connect *conn, int flag)
    Gpm_Stst *new = NULL;
    char* sock_name = 0;
    static char *consolename = NULL;
+   int gpm_is_disabled = 0;
 #ifdef HAVE_TERM_H
    char *mousecap;
    int terror;
@@ -333,15 +334,28 @@ int Gpm_Open(Gpm_Connect *conn, int flag)
       if(connect(gpm_fd,(struct sockaddr *)(&addr),i)<0 ) {
          struct stat stbuf;
 
-         gpm_report(GPM_PR_INFO,GPM_MESS_DOUBLE_S,GPM_NODE_CTL,strerror(errno));
+         if (errno == ENOENT) {
+            gpm_report(GPM_PR_DEBUG,"cannot find %s; ignoring (gpm disabled?)",
+                            GPM_NODE_CTL);
+            gpm_is_disabled++;
+         } else {
+            gpm_report(GPM_PR_INFO,GPM_MESS_DOUBLE_S,GPM_NODE_CTL,
+                            strerror(errno));
+         }
           /*
            * Well, try to open a chr device called /dev/gpmctl. This should
            * be forward-compatible with a kernel server
            */
           close(gpm_fd); /* the socket */
           if ((gpm_fd=open(GPM_NODE_DEV,O_RDWR))==-1) {
-            gpm_report(GPM_PR_ERR,GPM_MESS_DOUBLE_S,GPM_NODE_DEV
+            if (errno == ENOENT) {
+               gpm_report(GPM_PR_DEBUG,"Cannot find %s; ignoring (gpm disabled?)",
+                               GPM_NODE_DEV);
+               gpm_is_disabled++;
+            } else {
+               gpm_report(GPM_PR_ERR,GPM_MESS_DOUBLE_S,GPM_NODE_DEV
                                                    ,strerror(errno));
+            }
             goto err;
           }
          if (fstat(gpm_fd,&stbuf)==-1 || (stbuf.st_mode&S_IFMT)!=S_IFCHR) {
@@ -384,7 +398,8 @@ int Gpm_Open(Gpm_Connect *conn, int flag)
 
   /*....................................... Error: free all memory */
    err:
-   gpm_report(GPM_PR_ERR,"Oh, oh, it's an error! possibly I die! ");
+   if (gpm_is_disabled < 2) /* be quiet if no gpmctl socket found */
+      gpm_report(GPM_PR_ERR,"Oh, oh, it's an error! possibly I die! ");
    while(gpm_stack) {
       new=gpm_stack->next;
       free(gpm_stack);
-- 
1.5.5.2

Message #73 received at 479824-close@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: 479824-close@bugs.debian.org

Subject: Bug#479824: fixed in gpm 1.20.4-3

Date: Sun, 26 Oct 2008 03:32:05 +0000

Source: gpm
Source-Version: 1.20.4-3

We believe that the bug you reported is fixed in the latest version of
gpm, which is due to be installed in the Debian FTP archive:

gpm_1.20.4-3.diff.gz
  to pool/main/g/gpm/gpm_1.20.4-3.diff.gz
gpm_1.20.4-3.dsc
  to pool/main/g/gpm/gpm_1.20.4-3.dsc
gpm_1.20.4-3_i386.deb
  to pool/main/g/gpm/gpm_1.20.4-3_i386.deb
libgpm-dev_1.20.4-3_i386.deb
  to pool/main/g/gpm/libgpm-dev_1.20.4-3_i386.deb
libgpm2_1.20.4-3_i386.deb
  to pool/main/g/gpm/libgpm2_1.20.4-3_i386.deb
libgpmg1-dev_1.20.4-3_i386.deb
  to pool/main/g/gpm/libgpmg1-dev_1.20.4-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 479824@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillem Jover <guillem@debian.org> (supplier of updated gpm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 26 Oct 2008 04:36:14 +0200
Source: gpm
Binary: gpm libgpm2 libgpm-dev libgpmg1-dev
Architecture: source i386
Version: 1.20.4-3
Distribution: unstable
Urgency: low
Maintainer: Debian GPM Team <pkg-gpm-devel@lists.alioth.debian.org>
Changed-By: Guillem Jover <guillem@debian.org>
Description: 
 gpm        - General Purpose Mouse interface
 libgpm-dev - General Purpose Mouse - development files
 libgpm2    - General Purpose Mouse - shared library
 libgpmg1-dev - transitional dummy package which can be safely removed
Closes: 469933 479474 479824 480070 488053 490895 492954 493168 494924
Changes: 
 gpm (1.20.4-3) unstable; urgency=low
 .
   * Remove myself from Uploaders.
   * Group related patches:
     - debian/patches/030_daemon_quit: Rename to ...
     - debian/patches/020_daemon_quit_noverbose.patch: ... this.
   * Demote syslog message when the gpmctl node cannot be opened to debugging
     output, that's the case when gpm is not running. And change libgpm to not
     log into syslog debugging messages. (Closes: #469933, #479474, #479824)
     (Closes: #480070, #488053, #490895, #492954, #494924)
     Thanks to Jonathan Nieder <jrnieder@uchicago.edu>.
     - debian/patches/015_libgpm_noverbose.patch: Replace with ...
     - debian/patches/021_libgpm_dev_gpmctl_debug_msg.patch: ... this.
     - debian/patches/022_libgpm_no_log_debug_msg.patch: New file.
   * Fix a segfault on startup produced by an off-by-one error when accessing
     the console information array due to a missmatch between some files
     using the kernel and others the gpm definition for the number of
     supported consoles. (Closes: #493168)
     Thanks to Nico Schottelius <nico-debian-pkg-gpm-devel@schottelius.org>
     and Samuel Thibault <samuel.thibault@ens-lyon.org>.
     - debian/patches/031_max_consoles.patch: New file.
   * Update Catalan debconf translation.
Checksums-Sha1: 
 bc1cf9990239ac35da47900344b2ef760e173157 1247 gpm_1.20.4-3.dsc
 bc7f8928f88fd9bcda4f9dcffdd0112379607ca4 86782 gpm_1.20.4-3.diff.gz
 4503ef8718964735a2df0433dae5ce5f824f6c41 212924 gpm_1.20.4-3_i386.deb
 55e17380dc3d818a6643931a7a025aa85408817f 33800 libgpm2_1.20.4-3_i386.deb
 12483925d276bb033fa524a8a9c3220ff94ac562 37040 libgpm-dev_1.20.4-3_i386.deb
 f4fde889dcde28128eebc03e4f11d5ed2fc16b69 23606 libgpmg1-dev_1.20.4-3_i386.deb
Checksums-Sha256: 
 a461a870e9649f5dca08ed4558f4c4c939e13f938711ea058b3974b77a391623 1247 gpm_1.20.4-3.dsc
 fdf9bc3148fd3a5808baaac3ca71076b733d40e783dd37c10942e8db6333f37d 86782 gpm_1.20.4-3.diff.gz
 750434d0c597d7109bd31eab75c882e2e680a735d85d1f35966f4fd609c8d77d 212924 gpm_1.20.4-3_i386.deb
 20cfaf7552d0174abbeed2af770342948a4f44dd13de6799b37d4dcbd2c0138f 33800 libgpm2_1.20.4-3_i386.deb
 c2dcdd0ebac4a9cf6a1d10e6d31f65e2f5b737ceea3213531509c6ffdae07827 37040 libgpm-dev_1.20.4-3_i386.deb
 60bff7c913900bc6eccf0b4886cb92685129622da23524bd195ff91d53e5a7f6 23606 libgpmg1-dev_1.20.4-3_i386.deb
Files: 
 0267566bb88d3c0fbf7afa48433f711f 1247 misc optional gpm_1.20.4-3.dsc
 a090a82338ad95df105eac11387f025b 86782 misc optional gpm_1.20.4-3.diff.gz
 1444faeb547c5237112e36cf7ec5773f 212924 misc optional gpm_1.20.4-3_i386.deb
 367db1166570d63ede0811f4001c6543 33800 libs standard libgpm2_1.20.4-3_i386.deb
 1a17057e54a8f7da8826a0513acd95b4 37040 libdevel optional libgpm-dev_1.20.4-3_i386.deb
 bda0a3c1f49065d436a2ac65e72228f3 23606 oldlibs extra libgpmg1-dev_1.20.4-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkkD2RsACgkQuW9ciZ2SjJvphwCfdtjPV4S21Pb9wSP1Z6qSumfm
sq0Anils1KpqHAvd+A82Vuc20Mixnzjq
=Oz/f
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.