Debian Bug report logs - #477999
screen script "startx" checks for XFCFG variable in wrong way.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Erik Thiele <erik@thiele-hydraulik.de>

To: submit@bugs.debian.org

Subject: screen script "startx" checks for XFCFG variable in wrong way.

Date: Sat, 26 Apr 2008 11:03:38 +0200

Package: ltsp-server
Version: 5.0.40~bzr20080319-1

/opt/ltsp/i386/usr/share/ltsp/screen.d/startx:

# If XFCFG is defined then attempt to use it instead of autoconfiguration
if [ -e ${XFCFG} ]; then
    XF_ARGS="$XF_ARGS -config ${XFCFG}"
fi

this code is wrong. it adds "-config" without anything behind it, if XFCFG is 
unset. thus i get a X calling line like this:

X -query 192.168.1.1 -config -terminate vt11 :10.0

obviously either -config must be gone or the filename of a configfile has to 
be passed.

this code would probably work better:


# If XFCFG is defined then attempt to use it instead of autoconfiguration
if [ -z "${XFCFG}" ]; then
    true
else
    if [ -e "${XFCFG}" ]; then
        XF_ARGS="$XF_ARGS -config ${XFCFG}"
    fi
fi


thx
cya
erik

Message #12 received at 477999-done@bugs.debian.org (full text, mbox, reply):

From: vagrant@freegeek.org

To: Erik Thiele <erik@thiele-hydraulik.de>, 477999-done@bugs.debian.org

Subject: Bug#477999: screen script "startx" checks for XFCFG variable in wrong way.

Date: Sat, 26 Apr 2008 08:19:47 -0700

reassign 477999 ltsp-client-core
thanks

Version: 5.1.3-1

On Sat, Apr 26, 2008 at 11:03:38AM +0200, Erik Thiele wrote:
> /opt/ltsp/i386/usr/share/ltsp/screen.d/startx:
> 
> # If XFCFG is defined then attempt to use it instead of autoconfiguration
> if [ -e ${XFCFG} ]; then
>     XF_ARGS="$XF_ARGS -config ${XFCFG}"
> fi
> 
> this code is wrong. it adds "-config" without anything behind it, if XFCFG is 
> unset. thus i get a X calling line like this:
> 
> X -query 192.168.1.1 -config -terminate vt11 :10.0
> 
> obviously either -config must be gone or the filename of a configfile has to 
> be passed.

thanks for using ltsp!

i believe that version 5.1.3-1 and newer handles this differently, and
shouldn't have this problem. please re-open if this is not the case.

also in the future, please consider using reportbug, which will include
the versions of ltsp related packages in the ltsp chroot with your bug
report, or manually including the the version info.

live well,
  vagrant

Send a report that this bug log contains spam.