Debian Bug report logs - #476177
irssi-plugin-silc: prints /actions twice like * foo did bar\n * foo did bar\n

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Helmut Grohne <helmut@subdivi.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: irssi-plugin-silc: prints /actions twice like * foo did bar\n * foo did bar\n

Date: Mon, 14 Apr 2008 23:27:30 +0200

Package: irssi-plugin-silc
Version: 1.1.4-1
Severity: normal

When someone (or oneself) does /me did bar it appears like
 * foo did bar
 * foo did bar

This behaviour is wrong.

Helmut

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.23.14 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=de_DE (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages irssi-plugin-silc depends on:
ii  irssi                         0.8.12-3   terminal based IRC client
ii  libc6                         2.7-10     GNU C Library: Shared libraries
ii  perl                          5.8.8-12   Larry Wall's Practical Extraction 
ii  perl-base [perlapi-5.8.8]     5.8.8-12   The Pathologically Eclectic Rubbis

irssi-plugin-silc recommends no packages.

-- no debconf information

Message #10 received at 476177@bugs.debian.org (full text, mbox, reply):

From: Jérémy Bobbio <lunar@debian.org>

To: Helmut Grohne <helmut@subdivi.de>, 476177@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: [Pkg-silc-devel] Bug#476177: irssi-plugin-silc: prints /actions twice like * foo did bar\n * foo did bar\n

Date: Wed, 16 Apr 2008 14:06:22 +0200

[Message part 1 (text/plain, inline)]

tags 476177 + confirmed
thanks

On Mon, Apr 14, 2008 at 11:27:30PM +0200, Helmut Grohne wrote:
> When someone (or oneself) does /me did bar it appears like
>  * foo did bar
>  * foo did bar
> 
> This behaviour is wrong.

Indeed.  I will try to find out the reason soon.

Cheers,
-- 
Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 476177@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

To: 476177@bugs.debian.org

Subject: other line doubling in irssi-plugin-silc

Date: Thu, 12 Jun 2008 12:36:34 -0400

[Message part 1 (text/plain, inline)]

In addition to printing doubled /me lines, irssi-plugin-silc
1.1.4-1+b1 appears to double up on signed messages (it also doesn't
print the usual angle brackets around the nick of a signed message):

12:24   dkghi folks.  just trying out a different silc client.
12:24   dkghi folks.  just trying out a different silc client.
12:26 <@mattc> hey, dkg
12:26 <@mattc> which client?
12:26 <@mjgoins> which silc client?
12:29 < dkg> irssi-plugin-silc
12:29 < dkg> it has the lovely property of displaying all signed messages 
             twice, for some reason.
12:29  * dkg scratches head
12:29  * dkg scratches head
12:31 <@mattc> i only saw your signed message once
12:32 < dkg> i know, but i'm seeing it twice.
12:32 < dkg> it's a display problem, i think, not a networking problem.
12:33 @ mattchere's a test signed message from me
12:33 @ mattchere's a test signed message from me
12:33 < dkg> yeah, i'm seeing that twice also.
12:33 < dkg> i need to see a neurologist!

      --dkg

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 476177@bugs.debian.org (full text, mbox, reply):

From: "Jacob Winther" <jacob.winther@gmail.com>

To: 476177@bugs.debian.org

Subject: fix for the double /me

Date: Wed, 1 Oct 2008 11:42:20 +1300

I *think* I have found the issue :)

The upstream put a symlink between
/usr/lib/irssi/modules/libfe_common_silc.so and
/usr/lib/irssi/modules/libfe_silc.so to support old clients that did
not look for libfe_common_silc.so.

The issue for debian is the the version of irssi in use loads both
libs. The fix for me was to just rm libfe_silc.so, and this has been
tested by a few people.

This fix is now considered redundant, and is also not an issue in
newer versions of irssi. The recommendation is to remove the symlink
creation. For debian, this is the problem:

if SILCPLUGIN
install-data-hook: libfe_common_silc.la
       -ln -s libfe_common_silc.so $(DESTDIR)$(moduledir)/libfe_silc.so

in this file:

http://svn.debian.org/wsvn/pkg-silc/silc-client/trunk/apps/irssi/src/fe-common/silc/Makefile.am?op=file&rev=0&sc=0

I'm no Makefile expert, but I assume the fix is to remove the second line.

I hope this is all you need to fix the issue in lenny.

This is where the issue was discussed, however its still not fixed upstream:

https://lists.silcnet.org/pipermail/silc-devel/2008-March/002070.html

Cheers,
Jacob



On Fri, Aug 22, 2008 at 7:59 PM, Jérémy Bobbio <lunar@debian.org> wrote:
>
> On Fri, Aug 22, 2008 at 03:31:33PM +1200, Jacob Winther wrote:
> > There has been a bug in the irssi-plugin-silc package for a few months that
> > I was hoping would be fixed for lenny. Do you know if a fix is in the works,
> > or do you have any pointers that may enable me to find the bug?
>
> I have been busy getting the debian-installer in shape for Lenny and
> thus I did not have time to look up this issue.  If the fix is simple
> enough, there is a good chance we could get it in Lenny but we would
> need someone to work on such fix.  If you want to look it up, that would
> be great! :)
>
> Upstream is often quite responsive on the "silc" channel of SILCnet.
> Maybe you could find help there…
>
> Cheers,
> --
> Jérémy Bobbio                        .''`.
> lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
>                                    `. `'`
>                                      `-
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFIrmPZ2PUjs9fQ72URAvk5AKCuEhUkgkiDKcFYfYD408feuS+TLACgjNAh
> vGc4FLYvuDUaZP+DGa0i9UU=
> =Uy2I
> -----END PGP SIGNATURE-----
>

Message #27 received at 476177@bugs.debian.org (full text, mbox, reply):

From: "Jacob Winther" <jacob.winther@gmail.com>

To: "Jérémy Bobbio" <lunar@debian.org>

Subject: Re: Bug 476177

Date: Wed, 1 Oct 2008 11:13:57 +1300

Hi again,

I have found the issue :)

The upstream put a symlink between
/usr/lib/irssi/modules/libfe_common_silc.so and
/usr/lib/irssi/modules/libfe_silc.so tosupport old clients that did
not look for libfe_common_silc.so.

The issue for debian is the the version of irssi in use loads both
libs. The fix for me was to just rm libfe_silc.so, and this has been
tested by a few people.

This fix is now considered redundant, and is also not an issue in
newer versions of irssi. The recommendation is to remove the symlink
creation. For debian, this is the problem:

if SILCPLUGIN
install-data-hook: libfe_common_silc.la
        -ln -s libfe_common_silc.so $(DESTDIR)$(moduledir)/libfe_silc.so

in this file:

http://svn.debian.org/wsvn/pkg-silc/silc-client/trunk/apps/irssi/src/fe-common/silc/Makefile.am?op=file&rev=0&sc=0

I'm no Mikefile expert, but I assume the fix is to remove the second line.

I hope this is all you need to fix the issue in lenny, please let me
know if you need any more info.

this is where the issue was discussed, however its still not fixed upstream.

https://lists.silcnet.org/pipermail/silc-devel/2008-March/002070.html

Cheers,
Jacob



On Fri, Aug 22, 2008 at 7:59 PM, Jérémy Bobbio <lunar@debian.org> wrote:
>
> On Fri, Aug 22, 2008 at 03:31:33PM +1200, Jacob Winther wrote:
> > There has been a bug in the irssi-plugin-silc package for a few months that
> > I was hoping would be fixed for lenny. Do you know if a fix is in the works,
> > or do you have any pointers that may enable me to find the bug?
>
> I have been busy getting the debian-installer in shape for Lenny and
> thus I did not have time to look up this issue.  If the fix is simple
> enough, there is a good chance we could get it in Lenny but we would
> need someone to work on such fix.  If you want to look it up, that would
> be great! :)
>
> Upstream is often quite responsive on the "silc" channel of SILCnet.
> Maybe you could find help there…
>
> Cheers,
> --
> Jérémy Bobbio                        .''`.
> lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
>                                    `. `'`
>                                      `-
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFIrmPZ2PUjs9fQ72URAvk5AKCuEhUkgkiDKcFYfYD408feuS+TLACgjNAh
> vGc4FLYvuDUaZP+DGa0i9UU=
> =Uy2I
> -----END PGP SIGNATURE-----
>

Message #32 received at 476177@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

To: 476177@bugs.debian.org

Subject: confirming the diagnosis for debian #476177

Date: Thu, 16 Oct 2008 13:56:22 -0400

[Message part 1 (text/plain, inline)]

I can confirm Jacob Winther's diagnosis:

 rm /usr/lib/irssi/modules/libfe_silc.so

was sufficient for me to avoid getting the duplicated messages.

I have not yet tried the modification of the Makefile to see if that
builds acceptable packages.

Thanks for the heads-up, Jacob!

       --dkg

[Message part 2 (application/pgp-signature, inline)]

Message #39 received at 476177-close@bugs.debian.org (full text, mbox, reply):

From: Jérémy Bobbio <lunar@debian.org>

To: 476177-close@bugs.debian.org

Subject: Bug#476177: fixed in silc-client 1.1.7-1

Date: Fri, 24 Jul 2009 23:00:18 +0000

Source: silc-client
Source-Version: 1.1.7-1

We believe that the bug you reported is fixed in the latest version of
silc-client, which is due to be installed in the Debian FTP archive:

irssi-plugin-silc-dbg_1.1.7-1_i386.deb
  to pool/main/s/silc-client/irssi-plugin-silc-dbg_1.1.7-1_i386.deb
irssi-plugin-silc_1.1.7-1_i386.deb
  to pool/main/s/silc-client/irssi-plugin-silc_1.1.7-1_i386.deb
silc-client_1.1.7-1.diff.gz
  to pool/main/s/silc-client/silc-client_1.1.7-1.diff.gz
silc-client_1.1.7-1.dsc
  to pool/main/s/silc-client/silc-client_1.1.7-1.dsc
silc-client_1.1.7.orig.tar.gz
  to pool/main/s/silc-client/silc-client_1.1.7.orig.tar.gz
silc_1.1.7-1_all.deb
  to pool/main/s/silc-client/silc_1.1.7-1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 476177@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jérémy Bobbio <lunar@debian.org> (supplier of updated silc-client package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 26 Jun 2009 15:14:26 +0200
Source: silc-client
Binary: irssi-plugin-silc irssi-plugin-silc-dbg silc
Architecture: source i386 all
Version: 1.1.7-1
Distribution: unstable
Urgency: low
Maintainer: Debian SILC Team <pkg-silc-devel@lists.alioth.debian.org>
Changed-By: Jérémy Bobbio <lunar@debian.org>
Description: 
 irssi-plugin-silc - SILC plugin for irssi
 irssi-plugin-silc-dbg - debug symbols for the SILC plugin for irssi
 silc       - transitional package for the SILC client
Closes: 448186 476177 482145 522080
Changes: 
 silc-client (1.1.7-1) unstable; urgency=low
 .
   [ Jérémy Bobbio ]
   * New upstream release:
     - Fix crash on expired keyboard prompts.  (Closes: #482145)
   * Update Vcs-* field and document Git usage in README.source.
   * Update watch file.
   * Build-Depends on libsilc-dev instead of libsilc-1.1-2-dev, as provided by
     silc-toolkit 1.1.9-1.
   * Since Debian Policy 3.8.0, embedded code copy are officially not allowed in
     Debian anymore.  As it was a minor fork of irssi, the silc package
     providing the official SILC client has been discontinued.
   * Use a custom build system for the irssi plugin.  We now Build-Depends on
     irssi-dev instead of relying on irssi embedded code copy.
     (Closes: #448186, #522080)
   * Remove extra symlinks for irssi plugin.  (Closes: #476177)
   * Ship the silc package as a transitional package which depends
     on irssi and irssi-plugin-silc and contains a NEWS file.
   * Bump Standards-Version to 3.8.2, no further changes required.
 .
   [ Daniel Kahn Gillmor ]
   * cleaned up debian/control: thanks, Lintian!
 .
   [ Micah Anderson ]
   * Changed installation of upstream CHANGES to ChangeLog
   * Added debugging symbols package irssi-plugin-silc-dbg
Checksums-Sha1: 
 4c2b4155f0eeb90d1910f81d0c96f4544b26ef18 1346 silc-client_1.1.7-1.dsc
 9f86fc0e774acde43a28ffd9f271f8dc5bbc133b 1999852 silc-client_1.1.7.orig.tar.gz
 254f5b95563bffc771fc10ee027c75d15f88e492 12512 silc-client_1.1.7-1.diff.gz
 5dd9e08193758ba87ce0ba63d6a3c7ab3fd0257f 134916 irssi-plugin-silc_1.1.7-1_i386.deb
 5e561d960867ee5b50243c5c74ccb5f4c7426633 200220 irssi-plugin-silc-dbg_1.1.7-1_i386.deb
 8d55e898c657eb6966a69fdc6c24973ed36bacfb 11412 silc_1.1.7-1_all.deb
Checksums-Sha256: 
 94695b008b79d1177eae2e83fb3d9146620e0bd7534462446ecb20a968c6fa30 1346 silc-client_1.1.7-1.dsc
 2d9b9099550a475648260b713b9192d28656230d71d9fab12798df6ab4c2f9ad 1999852 silc-client_1.1.7.orig.tar.gz
 a7bc7e4cd6e87fb3e77dbae2d7372c49b995e95c04e644cb947165fb9379d25f 12512 silc-client_1.1.7-1.diff.gz
 e125388a1d03ffc6c41e9e33f3018b28a08f09becec5149a1473d6d6e47e2880 134916 irssi-plugin-silc_1.1.7-1_i386.deb
 d2653114e7fd7b2eb1a0c2b17e632c47b904e9f4762b7bc75550a549f1fbb0e7 200220 irssi-plugin-silc-dbg_1.1.7-1_i386.deb
 84b130ba4e49d47d78d5f296cf30953a722c626c1106af991e463a5a73f5fe98 11412 silc_1.1.7-1_all.deb
Files: 
 7f89e4f0b1b2c9d7fcc485971d754f64 1346 net optional silc-client_1.1.7-1.dsc
 1f92de53ea0e7a578210988620af97b2 1999852 net optional silc-client_1.1.7.orig.tar.gz
 f1fda9d3229cb9f3e35ee12f5a95f67f 12512 net optional silc-client_1.1.7-1.diff.gz
 fc8ba0001c5d6d392dcff07eee78655f 134916 net optional irssi-plugin-silc_1.1.7-1_i386.deb
 bb2e9c2d8b3c95b77f96f543ca5a1ef0 200220 debug extra irssi-plugin-silc-dbg_1.1.7-1_i386.deb
 d448dfad1c7e2b5252c5fc1941073f8b 11412 net optional silc_1.1.7-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkpotbQACgkQ2PUjs9fQ72VnlQCgl+nNrL+uqgdgz0zeGxQ720te
+lcAoJdfqM8FMqJC3mBimbtCv7o8QMIn
=EdAz
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.