Debian Bug report logs - #474587
boxbackup-client: improve handling of ucf

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: James Westby <jw+debian@jameswestby.net>

To: submit@bugs.debian.org

Subject: boxbackup-client: improve handling of ucf

Date: Sun, 06 Apr 2008 17:45:00 +0100

Package: boxbackup-client
Version: 0.10+really0.10-1
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu hardy ubuntu-patch

Hi,

I am forwarding Ubuntu's changes for this package. The patch
changes the way that ucf is handled. Unfortunately I can't
give you a detailed reasoning for the patch, as I don't really
understand it.

The changelog entries associated with the changes are

boxbackup (0.10+really0.10-1ubuntu3) hardy; urgency=low

  * Don't redirect ucf calls.  This was forgotten in the previous upload,
    but should have been there.

 -- Tollef Fog Heen <tfheen@ubuntu.com>  Thu, 06 Mar 2008 07:17:35 +0100

boxbackup (0.10+really0.10-1ubuntu2) hardy; urgency=low

  * Fix up postinst so we don't call db_stop too early, and use
    --debconf-ok to ucf.  (No versioned dependency since even oldstable
    has a new enough ucf.)  Use db_stop near the end to make sure we don't
    hang after starting the daemon though.

 -- Tollef Fog Heen <tfheen@ubuntu.com>  Wed, 05 Mar 2008 22:33:57 +0100


Please consider applying the patch. If you disagree with the changes
please reply to the mail and explain why.

You can find the patch at

http://patches.ubuntu.com/b/boxbackup/

I include it inline at the end of this message as well.

Thanks,

James

diff -pruN 0.10+really0.10-1/debian/boxbackup-client.postinst 0.10
+really0.10-1ubuntu3/debian/boxbackup-client.postinst
--- 0.10+really0.10-1/debian/boxbackup-client.postinst	2008-03-06 08:13:41.000000000 +0000
+++ 0.10+really0.10-1ubuntu3/debian/boxbackup-client.postinst	2008-03-06 08:12:30.000000000 +0000
@@ -314,37 +314,33 @@ EOM
 fi
 __EOF
 
-	    db_stop
-
 	    if [ -x /usr/bin/ucf ]; then
-		/usr/bin/ucf --three-way $DEBCONFBB $BBCONF >&2 </dev/tty
+		/usr/bin/ucf --three-way --debconf-ok $DEBCONFBB $BBCONF
 	    fi
 	    rm -f $DEBCONFBB
 	    chmod 644 $BBCONF || true
 	    chown root:root $BBCONF || true
 
 	    if [ -x /usr/bin/ucf ]; then
-		/usr/bin/ucf --three-way $DEBCONFNOTIFY $NOTIFYSCRIPT >&2 </dev/tty
+		/usr/bin/ucf --three-way --debconf-ok $DEBCONFNOTIFY $NOTIFYSCRIPT
 	    fi
 	    rm -f $DEBCONFNOTIFY
 	    chmod 755 $NOTIFYSCRIPT || true
 	    chown root:root $NOTIFYSCRIPT || true
-	else
-	    db_stop
 	fi
     ;;
 
     abort-upgrade|abort-remove|abort-deconfigure)
-	db_stop
     ;;
 
     *)
 	echo "postinst called with unknown argument \`$1'" >&2
-	db_stop
 	exit 1
     ;;
 esac
 
+db_stop
+
 # dh_installdeb will replace this with shell code automatically
 # generated by other debhelper scripts.
 

Message #10 received at 474587@bugs.debian.org (full text, mbox, reply):

From: Tollef Fog Heen <tfheen@err.no>

To: 474587@bugs.debian.org

Subject: Not having this breaks installations

Date: Sat, 12 Apr 2008 09:00:20 +0200

severity 474587 grave
thanks

Calling ucf like it is done in the current postinst makes unattended
upgrades fail, since ucf is never told that it doesn't have a tty to
talk to.

I'll NMU the package for this fix if it's not fixed within a couple of
days.

-- 
Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are

Message #17 received at 474587-close@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@tauware.de>

To: 474587-close@bugs.debian.org

Subject: Bug#474587: fixed in boxbackup 0.10+really0.10-2

Date: Sun, 13 Apr 2008 10:17:03 +0000

Source: boxbackup
Source-Version: 0.10+really0.10-2

We believe that the bug you reported is fixed in the latest version of
boxbackup, which is due to be installed in the Debian FTP archive:

boxbackup-client_0.10+really0.10-2_i386.deb
  to pool/main/b/boxbackup/boxbackup-client_0.10+really0.10-2_i386.deb
boxbackup-server_0.10+really0.10-2_i386.deb
  to pool/main/b/boxbackup/boxbackup-server_0.10+really0.10-2_i386.deb
boxbackup_0.10+really0.10-2.diff.gz
  to pool/main/b/boxbackup/boxbackup_0.10+really0.10-2.diff.gz
boxbackup_0.10+really0.10-2.dsc
  to pool/main/b/boxbackup/boxbackup_0.10+really0.10-2.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 474587@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Reinhard Tartler <siretart@tauware.de> (supplier of updated boxbackup package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 13 Apr 2008 11:38:01 +0200
Source: boxbackup
Binary: boxbackup-server boxbackup-client
Architecture: source i386
Version: 0.10+really0.10-2
Distribution: unstable
Urgency: medium
Maintainer: Reinhard Tartler <siretart@tauware.de>
Changed-By: Reinhard Tartler <siretart@tauware.de>
Description: 
 boxbackup-client - client for the BoxBackup remote backup system
 boxbackup-server - server for the BoxBackup remote backup system
Closes: 442640 467628 467635 467636 470060 474587
Changes: 
 boxbackup (0.10+really0.10-2) unstable; urgency=medium
 .
   * raise urgency because of RC bug!
   * use rather 'nocheck' instead of 'notest'. Thanks to Michael Banck
     <mbanck@debian.org> for notifying me about this.
   * Ack NMUs. Thanks Amaya for handling these! (Closes: #470060, #467628).
   * Merge Ubuntu changes, fixing installations without tty. (Closes: #474587).
   * build against libdb4.6 (Closes: #442640)
   * don't ignores errors on clean. Thanks lintian.
   * update Standards Version to 3.7.3, no changes needed.
   * clarify debconf question "boxbackup-client/IncorrectNumber" (Closes: #467635).
   * clarify debconf question "boxbackup-server/raidBlockSize" (Closes: #467636).
Files: 
 a77872afec7c1c8e215dae729a98bfc5 865 utils optional boxbackup_0.10+really0.10-2.dsc
 3fe051462ed988856995e9dba8cea71f 37218 utils optional boxbackup_0.10+really0.10-2.diff.gz
 b4962834965c85c9d109539060255cd8 293880 utils optional boxbackup-server_0.10+really0.10-2_i386.deb
 53aa274b9b0e657d6e7a286b4982595c 292902 utils optional boxbackup-client_0.10+really0.10-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Debian Powered!

iD8DBQFIAdtfmAg1RJRTSKQRApUwAJsG/dKhlVlXQt+yE7Tgu1GSd3JZuQCfU+gv
OibNC58SLOgLmxUHVFPwEX8=
=cZzA
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.