Debian Bug report logs - #462760
ldm: autologin (using LDM_USERNAME or LDM_PASSWORD in lts.conf) does not work

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: SZABO Zsolt <szazs@mm.bme.hu>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: ldm: autologin (using LDM_USERNAME or LDM_PASSWORD in lts.conf) does not work

Date: Sun, 27 Jan 2008 12:16:40 +0100

Package: ldm
Version: 0.1~bzr20071217
Severity: normal
Tags: patch


I think that get_host(), get_language(), get_session() and maybe
close_greeter() function called from ldm.c should be fixed for the case of
automated login (defining LDM_USERNAME or LDM_PASSWORD in lts.conf).
Or one has to define LDM_SERVER, LDM_LANGUAGE and LDM_SESSION, as well.

The patch below give a rough (not thoroghly tested) solution:

--- ldm-0.1~bzr20071217/src/ldm.c	2007-12-18 01:36:17.000000000 +0100
+++ ldm-0.1~bzr20071217.new/src/ldm.c	2008-01-26 02:13:00.000000000 +0100
@@ -482,22 +482,25 @@
             close(ldminfo.sshfd);
         }
     }
+    fprintf(ldmlog, "Established ssh session.\n");
 
     /*
      * Clear out the password so it's not sitting in memory anywhere
      */
 
     bzero(ldminfo.password, sizeof ldminfo.password);
+    fprintf(ldmlog, "Password cleared.\n");
 
+  if (!ldminfo.autologin) {
     if (get_language())
         die("Couldn't get a valid language setting");
     if (get_session())
         die("Couldn't get a valid session setting");
 
 
-    fprintf(ldmlog, "Established ssh session.\n");
     if (ldminfo.greeterpid)
         close_greeter();
+  }
 
     fprintf(ldmlog, "Executing rc files.\n");
     rc_files("start");                      /* Execute any rc files */
--- ldm-0.1~bzr20071217/src/greeter_iface.c	2007-12-18 01:36:17.000000000 +0100
+++ ldm-0.1~bzr20071217.new/src/greeter_iface.c	2008-01-26 02:15:49.000000000 +0100
@@ -129,7 +129,13 @@
 get_host()
 {
     char *cmd = "hostname\n";
+    char *p;
 
+    if (ldminfo.autologin) {
+	p = getenv("SERVER");
+        scopy(ldminfo.server, p);
+        return 0;
+    }
     write(ldminfo.greeterwfd, cmd, strlen(cmd));
     return get_greeter_string(ldminfo.server, sizeof ldminfo.server);
 }
@@ -141,8 +147,10 @@
     char lang[LDMSTRSZ];
     int status;
 
+//    if (!ldminfo.autologin) {
     write(ldminfo.greeterwfd, cmd, strlen(cmd));
     status =  get_greeter_string(lang, sizeof lang);
+//    }
     if (*(ldminfo.lang) != '\0')
         return 0;                           /* admin has set LDM_LANGUAGE */
     if (strncmp(lang, "None", 4))          /* If "None", use default */
@@ -157,8 +165,10 @@
     char session[LDMSTRSZ];
     int status;
 
+//    if (!ldminfo.autologin) {
     write(ldminfo.greeterwfd, cmd, strlen(cmd));
     status =  get_greeter_string(session, sizeof session);
+//    }
     if (strncmp(session, "None", 4))        /* If "None", use default */
         scopy(ldminfo.session, session);
     return status;


-- System Information:
Debian Release: 4.0
  APT prefers proposed-updates
  APT policy: (500, 'proposed-updates'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-5-686
Locale: LANG=hu_HU, LC_CTYPE=hu_HU (charmap=ISO-8859-2)

Message #10 received at 462760@bugs.debian.org (full text, mbox, reply):

From: vagrant@freegeek.org

To: SZABO Zsolt <szazs@mm.bme.hu>, 462760@bugs.debian.org

Subject: Bug#462760: ldm: autologin (using LDM_USERNAME or LDM_PASSWORD in lts.conf) does not work

Date: Sun, 27 Jan 2008 17:15:37 -0800

tags 462760 - patch
thanks

On Sun, Jan 27, 2008 at 12:16:40PM +0100, SZABO Zsolt wrote:
> I think that get_host(), get_language(), get_session() and maybe
> close_greeter() function called from ldm.c should be fixed for the case of
> automated login (defining LDM_USERNAME or LDM_PASSWORD in lts.conf).
> Or one has to define LDM_SERVER, LDM_LANGUAGE and LDM_SESSION, as well.
> 
> The patch below give a rough (not thoroghly tested) solution:

while the provided patch makes autologin work, it appears to break
normal login where the user supplies a username and password.

so, this patch doesn't really work, though it may be a starting point
for someone i to get it working for both autologin and normal logins :)

live well,
  vagrant

Message #17 received at 462760@bugs.debian.org (full text, mbox, reply):

From: vagrant@freegeek.org

To: SZABO Zsolt <szazs@mm.bme.hu>, 462760@bugs.debian.org

Subject: Bug#462760: ldm: autologin (using LDM_USERNAME or LDM_PASSWORD in lts.conf) does not work

Date: Tue, 29 Jan 2008 13:29:33 -0800

On Sun, Jan 27, 2008 at 12:16:40PM +0100, SZABO Zsolt wrote:
> I think that get_host(), get_language(), get_session() and maybe
> close_greeter() function called from ldm.c should be fixed for the case of
> automated login (defining LDM_USERNAME or LDM_PASSWORD in lts.conf).
> Or one has to define LDM_SERVER, LDM_LANGUAGE and LDM_SESSION, as well.

found this patch that appears to work:

  http://launchpadlibrarian.net/10690096/fix-autologin-lp161794.dpatch

applied the patch upstream, and hope to upload new ldm once the current
version hits lenny.

live well,
  vagrant

Message #24 received at 462760-close@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@freegeek.org>

To: 462760-close@bugs.debian.org

Subject: Bug#462760: fixed in ldm 2:0.1~bzr20080219-1

Date: Wed, 20 Feb 2008 09:02:08 +0000

Source: ldm
Source-Version: 2:0.1~bzr20080219-1

We believe that the bug you reported is fixed in the latest version of
ldm, which is due to be installed in the Debian FTP archive:

ldm_0.1~bzr20080219-1.diff.gz
  to pool/main/l/ldm/ldm_0.1~bzr20080219-1.diff.gz
ldm_0.1~bzr20080219-1.dsc
  to pool/main/l/ldm/ldm_0.1~bzr20080219-1.dsc
ldm_0.1~bzr20080219-1_amd64.deb
  to pool/main/l/ldm/ldm_0.1~bzr20080219-1_amd64.deb
ldm_0.1~bzr20080219.orig.tar.gz
  to pool/main/l/ldm/ldm_0.1~bzr20080219.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 462760@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@freegeek.org> (supplier of updated ldm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 19 Feb 2008 22:18:05 -0800
Source: ldm
Binary: ldm
Architecture: source amd64
Version: 2:0.1~bzr20080219-1
Distribution: unstable
Urgency: low
Maintainer: LTSP Debian/Ubuntu Maintainers <pkg-ltsp-devel@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagrant@freegeek.org>
Description: 
 ldm        - LTSP display manager
Closes: 462760 462764
Changes: 
 ldm (2:0.1~bzr20080219-1) unstable; urgency=low
 .
   * new upstream release from bzr:
     - install ldmgtkgreeter and ldm-scripts in /usr/lib
     - fixed autologin using slightly modified patch by Francis Giraldeau
       (Closes: #462760)
     - patch from SZABO Zsolt to fix login using ssh keys
       (Closes: #462764)
     - LDM_THEME variable to override default ldm theme
     - LDM_ALLOW_GUEST variable to display a "Guest Login" button that behaves
       similarly to autologin when pressed.
     - thanks to Ryan Niebur for help with autologin, ldm theme and guest login
       code
     - only ask password once. (thanks to Oliver Gravert for the patch)
     - do not display month or date on login screen. (idea from Gideon Romm)
     - when displaying status message, make entry fields not editable.
       (patch from Gideon Romm)
 .
   * debian/control:
     - conflict with older versions of ltsp-client-core, as it also shipped an
       ldm screen.d script
Files: 
 59178e1ebc65e52819e394a1325115f5 876 misc extra ldm_0.1~bzr20080219-1.dsc
 c2a968e2f48cf7fee34108df5df81922 443527 misc extra ldm_0.1~bzr20080219.orig.tar.gz
 39da11bd143c73212427f66921974f80 63910 misc extra ldm_0.1~bzr20080219-1.diff.gz
 ce7a54f92e7681531e26356d5745d3a0 139292 misc extra ldm_0.1~bzr20080219-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHu9l9mqVR2WapDeIRAs0sAKCcV1XhA56J1dMCfZtRWUjw6dPErwCgwCFU
rDpvOmwUnWCt1FiK0XLbfMw=
=AZ0m
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.