Debian Bug report logs - #459935
abook: export all email addresses to mutt aliases file

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: markus schnalke <meillo@marmaro.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: abook: export all email addresses to mutt aliases file

Date: Wed, 09 Jan 2008 17:37:11 +0100

[Message part 1 (text/plain, inline)]

Package: abook
Version: 0.5.6-3
Severity: wishlist


The following command

abook --convert --infile ~/.abook/addressbook --informat abook
	--outfile mutt.aliases_test --outformat mutt

does only export the first (primary) email address of each contact.
All further (secondary) email addresses are simply ignored.
If you want to generate mutt.aliases from abook, you have to create
multiple entries for one person in abook - for every email address
one.


Also, contacts without email addresses at all, are exported. This
leads to entries in the aliases file that are useless.


The attached patch is an example solution for both "problems".


meillo



-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-5-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages abook depends on:
ii  debconf [debconf-2.0]  1.5.11            Debian configuration management sy
ii  libc6                  2.3.6.ds1-13etch2 GNU C Library: Shared libraries
ii  libncursesw5           5.5-5             Shared libraries for terminal hand
ii  libreadline5           5.2-2             GNU readline and history libraries

abook recommends no packages.

-- debconf information:
  abook/muttrc.d: true

[abook_export-mutt-all-email-addresses.diff (text/x-c, attachment)]

Message #10 received at 459935@bugs.debian.org (full text, mbox, reply):

From: Gerfried Fuchs <rhonda@deb.at>

To: markus schnalke <meillo@marmaro.de>, 459935@bugs.debian.org

Subject: Re: Bug#459935: abook: export all email addresses to mutt aliases file

Date: Thu, 22 Jul 2010 16:25:07 +0200

	Hi!

 First of all, sorry for the late response. I just recently got adopted
into the upstream team and am looking through patches now that make
sense to incorporate there directly instead of having them potential rot
within Debian alone. ;)

* markus schnalke <meillo@marmaro.de> [2008-01-09 17:37:11 CET]:
> Package: abook
> Version: 0.5.6-3
> Severity: wishlist
> 
> The following command
> 
> abook --convert --infile ~/.abook/addressbook --informat abook
> 	--outfile mutt.aliases_test --outformat mutt
> 
> does only export the first (primary) email address of each contact.
> All further (secondary) email addresses are simply ignored.
> If you want to generate mutt.aliases from abook, you have to create
> multiple entries for one person in abook - for every email address
> one.
> 
> Also, contacts without email addresses at all, are exported. This
> leads to entries in the aliases file that are useless.

 I agree that these are both an annoyance and am taking a look at your
patch now and trying to bring it up to the 0.6.0 pre2 codebase, quite
some things have changed, so it isn't a straight forward patch.

 I got a working version so far, though somehow I got for the rotated
email as realname all the email addresses, have to check again wether I
have adjusted something wrongly here, or wether there is some logic
error involved.

 Also, the exit you did for no email did make the function quit on the
first addressbook entry that didn't had an email address attached to it
- I somehow guess this wasn't your attention. ;)  Fixed that in my local
copy already (moved the "if (*email) {" level to the outermost part of
the loop).

 Again, thanks for your suggestion, sorry for the delay, and a fix for
it will be soon get applied upstream.

 Enjoy!
Rhonda
-- 
"Lediglich 11 Prozent der Arbeitgeber sind der Meinung, dass jeder
Mensch auch ein Privatleben haben sollte."
        -- http://www.karriere.at/artikel/884/

Message #15 received at 459935@bugs.debian.org (full text, mbox, reply):

From: markus schnalke <meillo@marmaro.de>

To: Gerfried Fuchs <rhonda@deb.at>

Cc: 459935@bugs.debian.org

Subject: Re: Bug#459935: abook: export all email addresses to mutt aliases file

Date: Thu, 22 Jul 2010 18:31:58 +0200

[2010-07-22 16:25] Gerfried Fuchs <rhonda@deb.at>
> 	Hi!
Hoi


>  First of all, sorry for the late response.

A response, a response, .... great! :-)

> I just recently got adopted
> into the upstream team and am looking through patches now that make
> sense to incorporate there directly instead of having them potential rot
> within Debian alone. ;)

Thanks for working on abook.

I don't use abook's export function anymore because I switched from
mutt to nmh and don't use an alias database there. But anyway the
issue surely needs a fix.


> * markus schnalke <meillo@marmaro.de> [2008-01-09 17:37:11 CET]:
> > Package: abook
> > Version: 0.5.6-3
> > Severity: wishlist
> > 
> > The following command
> > 
> > abook --convert --infile ~/.abook/addressbook --informat abook
> > 	--outfile mutt.aliases_test --outformat mutt
> > 
> > does only export the first (primary) email address of each contact.
> > All further (secondary) email addresses are simply ignored.
> > If you want to generate mutt.aliases from abook, you have to create
> > multiple entries for one person in abook - for every email address
> > one.
> > 
> > Also, contacts without email addresses at all, are exported. This
> > leads to entries in the aliases file that are useless.
> 
>  I agree that these are both an annoyance and am taking a look at your
> patch now and trying to bring it up to the 0.6.0 pre2 codebase, quite
> some things have changed, so it isn't a straight forward patch.
> 
>  I got a working version so far, though somehow I got for the rotated
> email as realname all the email addresses, have to check again wether I
> have adjusted something wrongly here, or wether there is some logic
> error involved.
> 
>  Also, the exit you did for no email did make the function quit on the
> first addressbook entry that didn't had an email address attached to it
> - I somehow guess this wasn't your attention. ;)

Surely not. Two and a half year ago, my C knowledge wasn't as good as
it is now. ;-)

> Fixed that in my local
> copy already (moved the "if (*email) {" level to the outermost part of
> the loop).
> 
>  Again, thanks for your suggestion, sorry for the delay, and a fix for
> it will be soon get applied upstream.

Thank you very much for this information mail; that's a great service.

I hope fixing it completely won't be too difficult. Unfortunately, I
can't offer my help, because I'm very busy at the moment. I would have
loved to help, but it's not possible currently.


Have good times.


meillo

Message #20 received at 459935@bugs.debian.org (full text, mbox, reply):

From: Gerfried Fuchs <rhonda@deb.at>

To: markus schnalke <meillo@marmaro.de>

Cc: 459935@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#459935: abook: export all email addresses to mutt aliases file

Date: Fri, 23 Jul 2010 10:06:04 +0200

tags 459935 + fixed-upstream
thanks

	Hi!

* markus schnalke <meillo@marmaro.de> [2010-07-22 18:31:58 CEST]:
> [2010-07-22 16:25] Gerfried Fuchs <rhonda@deb.at>
> >  First of all, sorry for the late response.
> 
> A response, a response, .... great! :-)

 :)

> > I just recently got adopted into the upstream team and am looking
> > through patches now that make sense to incorporate there directly
> > instead of having them potential rot within Debian alone. ;)
> 
> Thanks for working on abook.

 Thanks for using it!

> I don't use abook's export function anymore because I switched from
> mutt to nmh and don't use an alias database there. But anyway the
> issue surely needs a fix.

 Right, and it got one now.

> I hope fixing it completely won't be too difficult. Unfortunately, I
> can't offer my help, because I'm very busy at the moment. I would have
> loved to help, but it's not possible currently.

 http://abook.cvs.sourceforge.net/viewvc/abook/abook/ - see the last
changes to edit.c, edit.h and filter.c. I tested them and it looks fine.
Not sure though when we can get around to send out a new release,
though. There is some more cleanup pending for that.

 Enjoy!
Rhonda
-- 
"Lediglich 11 Prozent der Arbeitgeber sind der Meinung, dass jeder
Mensch auch ein Privatleben haben sollte."
        -- http://www.karriere.at/artikel/884/

Message #33 received at 459935-quiet@bugs.debian.org (full text, mbox, reply):

From: Denis Briand <debian@denis-briand.fr>

To: Rhonda D'Vine <rhonda@debian.org>, control <control@bugs.debian.org>, quiet <459935-quiet@bugs.debian.org>

Subject: abook: export all email addresses to mutt aliases file

Date: Tue, 29 Sep 2015 00:56:02 +0200

[Message part 1 (text/plain, inline)]

tags 459935 moreinfo
thanks

Hello Rhonda,
Bug is tagged "fixed-upstream".
Is this patch is merged into debian version?
Can we close this bug?
regards

Denis

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.