Debian Bug report logs - #455510
bash completion patterns for zgrep &c. are wrong

version graph

Package: bash-completion; Maintainer for bash-completion is Gabriel F. T. Gomes <gabriel@debian.org>; Source for bash-completion is src:bash-completion (PTS, buildd, popcon).

Reported by: Reuben Thomas <rrt@sc3d.org>

Date: Mon, 10 Dec 2007 15:27:01 UTC

Severity: normal

Tags: confirmed

Merged with 318571

Fixed in version bash-completion/20080617

Done: Luk Claes <luk@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Matthias Klose <doko@debian.org>:
Bug#455510; Package bash. (full text, mbox, link).


Acknowledgement sent to Reuben Thomas <rrt@sc3d.org>:
New Bug report received and forwarded. Copy sent to Matthias Klose <doko@debian.org>. (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reuben Thomas <rrt@sc3d.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: bash completion patterns for zgrep &c. are wrong
Date: Mon, 10 Dec 2007 15:19:30 +0000
Package: bash
Version: 3.1dfsg-8
Severity: normal

The bash completion patterns for

bzcat bzcmp bzdiff bzegrep bzfgrep bzgrep
zcmp zdiff zcat zegrep zfgrep zgrep zless zmore

are all wrong: the point of these commands is that they work both with
compressed and uncompressed files, so they should not be restricted to
working only with compressed files.

As far as I can see, the relevant completions are in
/etc/bash_completion at lines 81 and 84, but there's something about
those lines being "completions that are redefined later", which is
odd, because I can see no such definition.

In any case, the above-listed commands only complete on compressed
file names, and that's wrong.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (700, 'testing'), (600, 'experimental'), (600, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-686 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages bash depends on:
ii  base-files                4.0.2          Debian base system miscellaneous f
ii  debianutils               2.28.2         Miscellaneous utilities specific t
ii  libc6                     2.7-3          GNU C Library: Shared libraries
ii  libncurses5               5.6+20071124-1 Shared libraries for terminal hand

bash recommends no packages.

-- no debconf information




Bug reassigned from package `bash' to `bash-completion'. Request was from Luk Claes <luk@debian.org> to control@bugs.debian.org. (Sun, 02 Mar 2008 15:24:52 GMT) (full text, mbox, link).


Tags added: confirmed, pending Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Sun, 11 May 2008 14:51:08 GMT) (full text, mbox, link).


Information stored:
Bug#455510; Package bash-completion. (full text, mbox, link).


Acknowledgement sent to David Paleino <d.paleino@gmail.com>:
Extra info received and filed, but not forwarded. (full text, mbox, link).


Message #14 received at 455510-quiet@bugs.debian.org (full text, mbox, reply):

From: David Paleino <d.paleino@gmail.com>
To: 455510-quiet@bugs.debian.org
Cc: Reuben Thomas <rrt@sc3d.org>, Bash-Completion Developers <bash-completion-devel@lists.alioth.debian.org>
Subject: Re: bash completion patterns for zgrep &c. are wrong
Date: Sun, 11 May 2008 16:50:48 +0200
[Message part 1 (text/plain, inline)]
tags 455510 confirmed pending
thanks

Hi Reuben,

On Mon, 10 Dec 2007 15:19:30 +0000, Reuben Thomas wrote:

> The bash completion patterns for
> 
> bzcat bzcmp bzdiff bzegrep bzfgrep bzgrep
> zcmp zdiff zcat zegrep zfgrep zgrep zless zmore
> 
> are all wrong: the point of these commands is that they work both with
> compressed and uncompressed files, so they should not be restricted to
> working only with compressed files.

Uhm, right.

> As far as I can see, the relevant completions are in
> /etc/bash_completion at lines 81 and 84, but there's something about
> those lines being "completions that are redefined later", which is
> odd, because I can see no such definition.

It's at line 4159, or around there (it depends on your version). Look for a
comment stating "makeinfo and texi2dvi are defined elsewhere" ;)

> In any case, the above-listed commands only complete on compressed
> file names, and that's wrong.

Right.
I've just commented out those entries (well, keeping safe bunzip2 and gunzip),
but I believe there's no special rule for those commands, if they must match on
*all* filenames.

I've applied the changes to our Bzr repository (@devs: commit 1101).

Kindly,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
[signature.asc (application/pgp-signature, attachment)]

Tags added: confirmed, pending Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Sun, 11 May 2008 15:45:12 GMT) (full text, mbox, link).


Forcibly Merged 318571 455510. Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Fri, 16 May 2008 22:27:13 GMT) (full text, mbox, link).


Tags added: confirmed, pending Request was from David Paleino <d.paleino@gmail.com> to control@bugs.debian.org. (Fri, 16 May 2008 22:27:15 GMT) (full text, mbox, link).


Reply sent to Luk Claes <luk@debian.org>:
You have taken responsibility. (full text, mbox, link).


Notification sent to Reuben Thomas <rrt@sc3d.org>:
Bug acknowledged by developer. (full text, mbox, link).


Message #25 received at 455510-close@bugs.debian.org (full text, mbox, reply):

From: Luk Claes <luk@debian.org>
To: 455510-close@bugs.debian.org
Subject: Bug#455510: fixed in bash-completion 20080617
Date: Sat, 21 Jun 2008 21:02:04 +0000
Source: bash-completion
Source-Version: 20080617

We believe that the bug you reported is fixed in the latest version of
bash-completion, which is due to be installed in the Debian FTP archive:

bash-completion_20080617.dsc
  to pool/main/b/bash-completion/bash-completion_20080617.dsc
bash-completion_20080617.tar.gz
  to pool/main/b/bash-completion/bash-completion_20080617.tar.gz
bash-completion_20080617_all.deb
  to pool/main/b/bash-completion/bash-completion_20080617_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 455510@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luk Claes <luk@debian.org> (supplier of updated bash-completion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 21 Jun 2008 21:59:43 +0200
Source: bash-completion
Binary: bash-completion
Architecture: source all
Version: 20080617
Distribution: unstable
Urgency: low
Maintainer: Bash Completion Maintainers <bash-completion-devel@lists.debian.org>
Changed-By: Luk Claes <luk@debian.org>
Description: 
 bash-completion - programmable completion for the bash shell
Closes: 347316 365658 376433 394636 404976 409423 416655 424736 428641 432289 441017 455510 468254 470539 470742 472132 472940 474094 474517 474974 475242 478596 480879
Changes: 
 bash-completion (20080617) unstable; urgency=low
 .
   [ David Paleino ]
   * New upstream release
     - add more completions to aptitude (Closes: #432289)
     - fixed UTF-8 problem with _get_cword(), thanks to
       Andrei Paskevich (Closes: #472132)
     - fixed autoremove completion, thanks to Flavio Visentin
       (Closes: #474974)
     - cmf and CMF added to playmidi completion (Closes: #365658)
     - added rrdtool completion, thanks to Justin Pryzby (Closes: #428641)
     - added OpenDocument completion for unzip/zipinfo (.od{f,g,p,s,t})
       (Closes: #472940)
     - fixed escaping problems with job control (i.e. disown, jobs, bg,
       fg): the argument is now surrounded by "" (Closes: #347316)
     - make mkdir complete also on filenames (Closes: #376433)
     - {bz,z}{cat,cmp,diff,egrep,fgrep,grep,less,more} now should complete
       on all filenames, not just compressed archives (just commented out)
       (Closes: #455510)
     - fixes Perl completion (Closes: #470742)
     - fixes get_cword -> _get_cword typo (Closes: #478596)
     - fixes _get_cword() function to properly handle filenames with
       whitespaces (Closes: #394636, #468254, #474094)
     - added .pdf.bz2 completion to evince (Closes: #424736)
     - added .svg completion to display (Closes: #441017)
     - added .m2ts completion to mplayer (Closes: #480879)
     - added extra/dh_bash-completion to ease future rewrite of bc.
   * debian/copyright - now in a fancier machine-parsable format.
   * debian/control:
     - added myself to Uploaders
     - debhelper Build-Depends updated to >= 6.
   * debian/watch:
     - improved current watch line regex
     - added (commented out) probable future watch line
   * debian/compat bumped to 6
   * debian/dirs, debian/install and debian/links added
   * debian/rules:
     - refactored to make use of debian/{dirs,install,links}
 .
   [ Steve Kemp ]
   * Applied patch to fix completion of umount command.
     (Closes: #470539)
   * Fixed the completion of Perl manpages.
     (Closes: #404976)
   * Added 'aif' to the filenames offed for completion for mplayer.
     (Closes: #474517)
   * Allow tsocks completion.
     (Closes: #409423)
   * Update mutt completion to handle local usernames.
     (Closes: #416655)
   * Update apt-get completion to include the flag "--no-install-recommends"
     (Closes: #475242)
Checksums-Sha1: 
 a267866b73de860449ddbc4374faa0b27cb14652 854 bash-completion_20080617.dsc
 d0fc2f36ee0d896f98c1e5dfd49e8623bb936aaa 97143 bash-completion_20080617.tar.gz
 91dc4ad723ecbff302047187e65f6aefedf5ebbf 83372 bash-completion_20080617_all.deb
Checksums-Sha256: 
 9aa0ed60aa9fc88fcc3a542a0d296ead12c23dbae025d158ff414267b22c960b 854 bash-completion_20080617.dsc
 57cd6ee1abc39182183eebeeb1378bdd2438363bf766d69dcabd0320378b6b22 97143 bash-completion_20080617.tar.gz
 e88bd724c2e44629c27fe0346369fe450f0cae12f846ae08fc3794b7dcb1ae32 83372 bash-completion_20080617_all.deb
Files: 
 058c2c5c7a2da8c58f3fbf4f117caf26 854 shells standard bash-completion_20080617.dsc
 902c045bb9fce960571f44200b476cec 97143 shells standard bash-completion_20080617.tar.gz
 7997031028650ef5f5ae30bf1ba5488f 83372 shells standard bash-completion_20080617_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkhdZpQACgkQ5UTeB5t8Mo2n+ACcC7WR8B82ilcQ7iB69fQ/SLQ7
BAwAn3aAUrB08bRSg5QD3/wF9qdPGtC0
=CoOt
-----END PGP SIGNATURE-----





Reply sent to Luk Claes <luk@debian.org>:
You have taken responsibility. (full text, mbox, link).


Notification sent to Jakob Bohm <jbj@image.dk>:
Bug acknowledged by developer. (full text, mbox, link).


Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 21 Jul 2008 07:26:35 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Jul 2 09:25:12 2023; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.