Debian Bug report logs - #453419
adduser: should depend on bzip2

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Loris Boillet <lb@2m.dk>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: adduser: should depend on bzip2

Date: Thu, 29 Nov 2007 14:16:06 +0100

Package: adduser
Version: 3.102
Severity: normal

Hi,

deluser's --backup option assumes bzip2 is installed, but adduser does
not depend on it.

Ex of command that fails if bzip2 is not installed:
deluser --remove-home --backup --backup-to . u111
Looking for files to backup/remove ...
Backing up files to be removed to . ...
backup_name = ./u111.tar/bin/tar: Removing leading `/' from member names
/usr/sbin/deluser: `1 ./u111.tar' returned error code 16777215. Exiting.

Thanks,

Loris

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-686
Locale: LANG=en_DK, LC_CTYPE=en_DK (charmap=ISO-8859-1)

Versions of packages adduser depends on:
ii  debconf [debconf-2.0]       1.5.11       Debian configuration management sy
ii  passwd                      1:4.0.18.1-7 change and administer password and
ii  perl-base                   5.8.8-7etch1 The Pathologically Eclectic Rubbis

adduser recommends no packages.

-- debconf information:
* adduser/homedir-permission: true

Message #10 received at 453419@bugs.debian.org (full text, mbox, reply):

From: Joerg Hoh <joerg@joerghoh.de>

To: Loris Boillet <lb@2m.dk>, 453419@bugs.debian.org

Subject: Re: Bug#453419: adduser: should depend on bzip2

Date: Sat, 29 Dec 2007 16:09:12 +0100

[Message part 1 (text/plain, inline)]

tags 453419 more-info-required
thanks

Hi


On Thu, Nov 29, 2007 at 02:16:06PM +0100, Loris Boillet wrote:
> Package: adduser
> Version: 3.102
> Severity: normal
> 
> Hi,
> 
> deluser's --backup option assumes bzip2 is installed, but adduser does
> not depend on it.

No, it doesn't. If available in the path, deluser makes use of bzip2,
otherwise it falls back to gzip.


> Ex of command that fails if bzip2 is not installed:
> deluser --remove-home --backup --backup-to . u111
> Looking for files to backup/remove ...
> Backing up files to be removed to . ...
> backup_name = ./u111.tar/bin/tar: Removing leading `/' from member names
> /usr/sbin/deluser: `1 ./u111.tar' returned error code 16777215. Exiting.

This looks really strange, as it seems that the which function returns
wrong values.  Can you paste the output of the small script attached? It
will test the return values of the which function.

It should be something like this:

joerg@bastet temp $ perl test-adduser-which
found gzip: /bin/gzip
found bzip2: /bin/bzip2
test-adduser-which: Kein Programm mit dem Namen »bzip3« in Verzeichnisliste $PATH gefunden.

Jörg


-- 
What did you do to the cat? It looks half-dead. -Schroedinger's wife

[test-adduser-which (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 453419@bugs.debian.org (full text, mbox, reply):

From: "Michael Geminden" <mgemindn@austincc.edu>

To: <453419@bugs.debian.org>

Date: Sat, 26 Jan 2008 03:27:34 -0000

testing with adduser version 3.102

I ran into this bug as well. Your test script outputs:

found gzip: /bin/gzip
testwhich.pl: Could not find program named `bzip2' in $PATH.

(i found it odd that it didn't continue to the bzip3 test)

but when i modified your script to call it like it is in deluser i got this:

found gzip: /bin/gzip
found bzip2: 1
found bzip3: 1 (unlikely)

it looks like its related to if you call &which('name',1) like in deluser and
wont happen if you call &which('name') like in your test script.

it seems &which is returning 1 for not found if you tell it to be nonfatal via
the second parameter.

Message #20 received at 453419@bugs.debian.org (full text, mbox, reply):

From: Joerg Hoh <joerg@joerghoh.de>

To: mgemindn@austincc.edu, 453419@bugs.debian.org

Subject: Re: [Adduser-devel] Bug#453419:

Date: Sat, 26 Jan 2008 10:02:47 +0100

[Message part 1 (text/plain, inline)]

Hi Michael

thanks for pointing in the right direction.

On Sat, Jan 26, 2008 at 03:27:34AM -0000, Michael Geminden wrote:

> it looks like its related to if you call &which('name',1) like in deluser and
> wont happen if you call &which('name') like in your test script.
> 
> it seems &which is returning 1 for not found if you tell it to be nonfatal via
> the second parameter.

&which returned garbage when the binary was not found and nonfatal was set
to 1. I fixed that in subversion, the bugfix will be contained in next
release. 
Thanks for your help.

Jörg


-- 
What did you do to the cat? It looks half-dead. -Schroedinger's wife

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 453419-close@bugs.debian.org (full text, mbox, reply):

From: Stephen Gran <sgran@debian.org>

To: 453419-close@bugs.debian.org

Subject: Bug#453419: fixed in adduser 3.106

Date: Sun, 02 Mar 2008 17:17:03 +0000

Source: adduser
Source-Version: 3.106

We believe that the bug you reported is fixed in the latest version of
adduser, which is due to be installed in the Debian FTP archive:

adduser_3.106.dsc
  to pool/main/a/adduser/adduser_3.106.dsc
adduser_3.106.tar.gz
  to pool/main/a/adduser/adduser_3.106.tar.gz
adduser_3.106_all.deb
  to pool/main/a/adduser/adduser_3.106_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 453419@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stephen Gran <sgran@debian.org> (supplier of updated adduser package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 02 Mar 2008 16:57:21 +0000
Source: adduser
Binary: adduser
Architecture: source all
Version: 3.106
Distribution: unstable
Urgency: low
Maintainer: Debian Adduser Developers <adduser-devel@lists.alioth.debian.org>
Changed-By: Stephen Gran <sgran@debian.org>
Description: 
 adduser    - add and remove users and groups
Closes: 145430 435778 439212 442203 447104 447868 451321 451967 452289 452290 453419 454928 468152
Changes: 
 adduser (3.106) unstable; urgency=low
 .
   [ Joerg Hoh ]
   * adduser exits with returncode 1 if trying to add an already existing user
     as system user. Thanks to Vincent Bernat; Closes: #435778
   * deluser: warn if you want to remove the root account. Closes: #145430
   * deluser: fix backup when bzip2 is not available. Closes: #453419
   * deluser: print correct warning when you removed the last user in a group;
     thanks Marc 'Zugschlus' Haber and Peter Eisentraut
     (Closes: #454928,#451967)
 .
   [ Stephen Gran ]
   * Translation:
     be (thanks Pavel Piatruk <berserker@neolocation.com>)( closes: #447104)
     fr (thanks Nicolas François <nicolas.francois@centraliens.net>)
     (closes: #442203)
     ru (thanks Yuri Kozlov <kozlov.y@gmail.com>)(closes: #452289, #452290)
     sk (thanks Ivan Masár <helix84@centrum.sk>)(closes: #439212)
     zh_CN (thanks LI Daobing <lidaobing@gmail.com>)(closes: #447868)
   * Clarify --in-group documentation (closes: #468152)
   * deluser: Let tar gzip/bzip backups directly (closes: #451321)
   * Update Standards Version (no changes)
   * Homepage, Vcs-Svn and Vcs-Browser fields added
   * Do nothing in binary-arch
Files: 
 542e266dab99f99dea31a4ba016fd7d7 835 admin important adduser_3.106.dsc
 3329395cc47d3f5f147e87028736387b 262830 admin important adduser_3.106.tar.gz
 be4885c8629de328cc18cff8352d280e 183366 admin important adduser_3.106_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHyt0bSYIMHOpZA44RAoekAKDP4rjhUqCdHRv0lnrQyQTGnK2fbgCfX/Jo
ffCcTqO+7IMpzabvF+jGodA=
=bPI8
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.