Debian Bug report logs - #453308
If timidity.cfg is not present, please try to load freepats.cfg

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <greffrath@leat.rub.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: If timidity.cfg is not present, please try to load freepats.cfg

Date: Wed, 28 Nov 2007 16:01:33 +0100

[Message part 1 (text/plain, inline)]

Package: libsdl-mixer1.2
Version: 1.2.8-1
Severity: minor
Tags: patch

Dear SDL-Developers,

sdl-mixer does not depend on timidity to play midi; at least not 
technically, i.e. it does not need any of the binaries provided by the 
timidity package.
However, games do only play music if *both* the timidity and the 
freepats packages are installed, although sdl-mixer could play music 
with only the freepats package installed. The reason for this is, that 
sdl-mixer tries to load timidity's configuration file, which is provided 
in '/etc/timidity/timidity.cfg', to find out which patchset is used by 
timidity.
By now, the only patchset available in Debian is freepats. Thus the only 
line in timidity.cfg (from the Debian package) that is not commented out 
is 'source freepats.cfg'. That file is in turn provided by the freepats 
package. So the only reason, why sdl-mixer might need the timidity 
package is to learn that it should parse the freepats configuration file 
instead.

Please find applied a patch that changes the default behaviour to look 
for the timidity.cfg file (as before) and then - if it does not succeed 
- try to load the freepats.cfg file (in '/etc/timidity/freepats.cfg', as 
provided by the Debian package). This way, sdl-mixer can make use of the 
patchset provided by the freepats package without even having the 
timidity package installed. An existing freepats.cfg will still be first 
choice, however.

Thank you very much!

Cheers,
Fabian

-- 
Dipl.-Phys. Fabian Greffrath

Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum

Telefon: +49 (0)234 / 32-26334
Fax:     +49 (0)234 / 32-14227
E-Mail:  greffrath@leat.ruhr-uni-bochum.de

[config-file-freepats.diff (text/x-patch, inline)]

diff -Naru sdl-mixer1.2-1.2.8~/timidity/config.h sdl-mixer1.2-1.2.8/timidity/config.h
--- sdl-mixer1.2-1.2.8~/timidity/config.h	2007-07-02 04:03:51.000000000 +0200
+++ sdl-mixer1.2-1.2.8/timidity/config.h	2007-11-28 07:41:40.000000000 +0100
@@ -172,6 +172,7 @@
 #define CONFIG_FILE	"timidity.cfg"
 #define CONFIG_FILE_ETC "/etc/timidity.cfg"
 #define CONFIG_FILE_ETC_TIMIDITY "/etc/timidity/timidity.cfg"
+#define CONFIG_FILE_ETC_TIMIDITY_FREEPATS "/etc/timidity/freepats.cfg"
 
 #if defined(__WIN32__) || defined(__OS2__)
 #define DEFAULT_PATH	"\\TIMIDITY"
diff -Naru sdl-mixer1.2-1.2.8~/timidity/timidity.c sdl-mixer1.2-1.2.8/timidity/timidity.c
--- sdl-mixer1.2-1.2.8~/timidity/timidity.c	2007-07-02 04:03:52.000000000 +0200
+++ sdl-mixer1.2-1.2.8/timidity/timidity.c	2007-11-28 07:42:01.000000000 +0100
@@ -297,7 +297,9 @@
   if (read_config_file(CONFIG_FILE)<0) {
     if (read_config_file(CONFIG_FILE_ETC)<0) {
       if (read_config_file(CONFIG_FILE_ETC_TIMIDITY)<0) {
-        return(-1);
+        if (read_config_file(CONFIG_FILE_ETC_TIMIDITY_FREEPATS)<0) {
+          return(-1);
+        }
       }
     }
   }

Message #10 received at 453308-close@bugs.debian.org (full text, mbox, reply):

From: Barry deFreese <bdefreese@debian.org>

To: 453308-close@bugs.debian.org

Subject: Bug#453308: fixed in sdl-mixer1.2 1.2.8-6

Date: Fri, 22 May 2009 15:17:28 +0000

Source: sdl-mixer1.2
Source-Version: 1.2.8-6

We believe that the bug you reported is fixed in the latest version of
sdl-mixer1.2, which is due to be installed in the Debian FTP archive:

libsdl-mixer1.2-dev_1.2.8-6_i386.deb
  to pool/main/s/sdl-mixer1.2/libsdl-mixer1.2-dev_1.2.8-6_i386.deb
libsdl-mixer1.2_1.2.8-6_i386.deb
  to pool/main/s/sdl-mixer1.2/libsdl-mixer1.2_1.2.8-6_i386.deb
sdl-mixer1.2_1.2.8-6.diff.gz
  to pool/main/s/sdl-mixer1.2/sdl-mixer1.2_1.2.8-6.diff.gz
sdl-mixer1.2_1.2.8-6.dsc
  to pool/main/s/sdl-mixer1.2/sdl-mixer1.2_1.2.8-6.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 453308@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Barry deFreese <bdefreese@debian.org> (supplier of updated sdl-mixer1.2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 22 May 2009 10:33:13 -0400
Source: sdl-mixer1.2
Binary: libsdl-mixer1.2 libsdl-mixer1.2-dev
Architecture: source i386
Version: 1.2.8-6
Distribution: unstable
Urgency: low
Maintainer: Debian SDL packages maintainers <pkg-sdl-maintainers@lists.alioth.debian.org>
Changed-By: Barry deFreese <bdefreese@debian.org>
Description: 
 libsdl-mixer1.2 - mixer library for Simple DirectMedia Layer 1.2
 libsdl-mixer1.2-dev - development files for SDL1.2 mixer library
Closes: 398805 453308
Changes: 
 sdl-mixer1.2 (1.2.8-6) unstable; urgency=low
 .
   [ Barry deFreese ]
   * Add myself to uploaders.
   * 04_timidity_cfg_opts.diff - (Closes: #398805).
     + Ignore unknown options in timidity.cfg.
     + Thanks to Brandon Barnes for the patch.
   * 05_fallback_to_freepats.diff - (Closes: #453308).
     + Use freepats config if timidity isn't present.
     + Thanks to Fabian Greffrath for the patch.
   * Bump debhelper build-dep and compat to 5.
   * Bump Standards Version to 3.8.1.
     + Move Homepage from package description to source stanza.
Checksums-Sha1: 
 77f92294217e7bf638340af14eb0da1477650ff8 1418 sdl-mixer1.2_1.2.8-6.dsc
 7311dc16aa65244090e3e92e5473bd19a7fd0c85 81219 sdl-mixer1.2_1.2.8-6.diff.gz
 1aaa66c42d4e6cdca2b1c38864931d44d067141a 93600 libsdl-mixer1.2_1.2.8-6_i386.deb
 4177f43a9f03593c8011aa76f3093a6e3bc84eaf 118242 libsdl-mixer1.2-dev_1.2.8-6_i386.deb
Checksums-Sha256: 
 e53c1bdd16374b5e79ecf1f1494effe78f92c891ff0290a1d7cf9d9ca3bcc080 1418 sdl-mixer1.2_1.2.8-6.dsc
 a60823a36395a5182dd6df6c201d9bfcb4534dfe3e2bd17d8467cabf5fe7bcbe 81219 sdl-mixer1.2_1.2.8-6.diff.gz
 0b7c5b64f0ce08f19a1508035d0e130523352e8c7f5a16054760c0c017c6e7d4 93600 libsdl-mixer1.2_1.2.8-6_i386.deb
 b9a95f84070e94ee2e24d2b08eab4fa0c151edf3295a0c35e03d8b7e0bde8285 118242 libsdl-mixer1.2-dev_1.2.8-6_i386.deb
Files: 
 3f41b4586df0e1317bb65db337f1bdd2 1418 libs optional sdl-mixer1.2_1.2.8-6.dsc
 ed315ef53d666d803ab2c947411170a2 81219 libs optional sdl-mixer1.2_1.2.8-6.diff.gz
 da9b4e9eca0cd1e09b6b4e7ad0e525d8 93600 libs optional libsdl-mixer1.2_1.2.8-6_i386.deb
 dfbf81d00938fd2fab1582d0df50ba8a 118242 libdevel optional libsdl-mixer1.2-dev_1.2.8-6_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkoWwVYACgkQ5ItltUs5T37BhgCfWBVReYC/9Fz26CdlDhiRdT/3
5TMAoNNNvODP9JV+GsHqpa02C3Glrh5j
=6cgB
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.