Debian Bug report logs - #451878
/usr/sbin/ltsp-build-client: Doesn't properly clean up environment

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Roberto C. Sanchez" <roberto@connexer.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: /usr/sbin/ltsp-build-client: Doesn't properly clean up environment

Date: Sun, 18 Nov 2007 21:43:40 -0500

Package: ltsp-server
Version: 0.99debian11
Severity: normal
File: /usr/sbin/ltsp-build-client

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I use pam_tmpdir on my system.  So, for example, root has this in his
environment:

TMP=/tmp/user/0
TMPDIR=/tmp/user/0

One or both of those values are sticking around when ltsp-build-client
is called, resulting in this failure:

Running depmod.
Finding valid ramdisk creators.
Using mkinitramfs-kpkg to build the ramdisk.
mktemp: cannot make temp dir /tmp/user/0/mkinitramfs_W13305: No such file or directory
mkinitramfs-kpkg failed to create initrd image.

It looks like the call to mktemp is making use of one of the variables.
Of course, since the chroot for the client created in /opt/ltsp is
clean, there is no user/0 directory below /tmp.

Regards,

- -Roberto

- -- Package-specific info:

- -- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-5-486
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages ltsp-server depends on:
ii  debconf [debconf-2.0]  1.5.11            Debian configuration management sy
ii  debconf-utils          1.5.11            debconf utilities
ii  debootstrap            0.3.3.2etch1      Bootstrap a basic Debian system
ii  esound-clients         0.2.36-3          Enlightened Sound Daemon - clients
ii  gettext-base           0.16.1-1          GNU Internationalization utilities
ii  inetutils-inetd [inet- 2:1.5.dfsg.1-2    Internet super server
ii  iproute                20061002-3        Professional tools to control the 
ii  lsb-release            3.1-23.2etch1     Linux Standard Base version report
ii  nfs-kernel-server      1:1.0.10-6+etch.1 Kernel NFS server support
ii  openssh-client         1:4.3p2-9         Secure shell client, an rlogin/rsh
ii  python                 2.4.4-2           An interactive high-level object-o
ii  tcpd                   7.6.dbs-13        Wietse Venema's TCP wrapper utilit
ii  tftpd-hpa              0.43-1.1          HPA's tftp server
ii  update-inetd           4.27-0.5          inetd.conf updater

Versions of packages ltsp-server recommends:
pn  nbd-server                    <none>     (no description available)
ii  openssh-server                1:4.3p2-9  Secure shell server, an rshd repla

- -- debconf information excluded

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHQPhc5SXWIKfIlGQRAhJwAKCKZ0ZZH00Iy0kYin/J0ZFr9dXfqQCglid9
Fs885X0iWYP6kr+jyRUbCwo=
=tU+u
-----END PGP SIGNATURE-----

Message #10 received at 451878@bugs.debian.org (full text, mbox, reply):

From: vagrant@freegeek.org

To: "Roberto C. Sanchez" <roberto@connexer.com>, 451878@bugs.debian.org

Subject: Re: [Pkg-ltsp-devel] Bug#451878: /usr/sbin/ltsp-build-client: Doesn't properly clean up environment

Date: Fri, 30 Nov 2007 19:26:45 -0800

On Sun, Nov 18, 2007 at 09:43:40PM -0500, Roberto C. Sanchez wrote:
> I use pam_tmpdir on my system.  So, for example, root has this in his
> environment:
> 
> TMP=/tmp/user/0
> TMPDIR=/tmp/user/0
> 
> One or both of those values are sticking around when ltsp-build-client
> is called, resulting in this failure:
> 
> Running depmod.
> Finding valid ramdisk creators.
> Using mkinitramfs-kpkg to build the ramdisk.
> mktemp: cannot make temp dir /tmp/user/0/mkinitramfs_W13305: No such file or directory
> mkinitramfs-kpkg failed to create initrd image.
> 
> It looks like the call to mktemp is making use of one of the variables.
> Of course, since the chroot for the client created in /opt/ltsp is
> clean, there is no user/0 directory below /tmp.

indeed.

do you propose we change ltsp-build-client to ignore TMP and TMPDIR?
then any non-chrooted calls ltsp-build-client makes will disregard the
user's TMP/TMPDIR setting, which doesn't seem right either.

i guess i could implement this as part of the long-lost ltsp-chroot
idea, which is a chroot wrapper that ltsp-build-client calls, and could
set and unset some environment variables.

live well,
  vagrant

Message #15 received at 451878@bugs.debian.org (full text, mbox, reply):

From: Roberto C. Sánchez <roberto@connexer.com>

To: 451878@bugs.debian.org

Subject: Re: [Pkg-ltsp-devel] Bug#451878: /usr/sbin/ltsp-build-client: Doesn't properly clean up environment

Date: Fri, 30 Nov 2007 22:41:28 -0500

[Message part 1 (text/plain, inline)]

On Fri, Nov 30, 2007 at 07:26:45PM -0800, vagrant@freegeek.org wrote:
> On Sun, Nov 18, 2007 at 09:43:40PM -0500, Roberto C. Sanchez wrote:
> > I use pam_tmpdir on my system.  So, for example, root has this in his
> > environment:
> > 
> > TMP=/tmp/user/0
> > TMPDIR=/tmp/user/0
> > 
> > One or both of those values are sticking around when ltsp-build-client
> > is called, resulting in this failure:
> > 
> > Running depmod.
> > Finding valid ramdisk creators.
> > Using mkinitramfs-kpkg to build the ramdisk.
> > mktemp: cannot make temp dir /tmp/user/0/mkinitramfs_W13305: No such file or directory
> > mkinitramfs-kpkg failed to create initrd image.
> > 
> > It looks like the call to mktemp is making use of one of the variables.
> > Of course, since the chroot for the client created in /opt/ltsp is
> > clean, there is no user/0 directory below /tmp.
> 
> indeed.
> 
> do you propose we change ltsp-build-client to ignore TMP and TMPDIR?
> then any non-chrooted calls ltsp-build-client makes will disregard the
> user's TMP/TMPDIR setting, which doesn't seem right either.
> 
I agree.  Always disregarding them is probably worse.

> i guess i could implement this as part of the long-lost ltsp-chroot
> idea, which is a chroot wrapper that ltsp-build-client calls, and could
> set and unset some environment variables.
> 
I'm not sure.  I have also found that dchroot has the exact same
problem, as does chroot.  Incidentally, if something is called with
sudo, you have the benefit that sudo mostly sanitizes the environment.
Perhaps this is something that can be solved in concert with the other
packages that share the problem.

Regards,

-Roberto
-- 
Roberto C. Sánchez
http://people.connexer.com/~roberto
http://www.connexer.com

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 451878-close@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@freegeek.org>

To: 451878-close@bugs.debian.org

Subject: Bug#451878: fixed in ltsp 5.0.40~bzr20080319-1

Date: Thu, 20 Mar 2008 01:32:03 +0000

Source: ltsp
Source-Version: 5.0.40~bzr20080319-1

We believe that the bug you reported is fixed in the latest version of
ltsp, which is due to be installed in the Debian FTP archive:

ltsp-client-builder_5.0.40~bzr20080319-1_all.udeb
  to pool/main/l/ltsp/ltsp-client-builder_5.0.40~bzr20080319-1_all.udeb
ltsp-client-core_5.0.40~bzr20080319-1_i386.deb
  to pool/main/l/ltsp/ltsp-client-core_5.0.40~bzr20080319-1_i386.deb
ltsp-client_5.0.40~bzr20080319-1_all.deb
  to pool/main/l/ltsp/ltsp-client_5.0.40~bzr20080319-1_all.deb
ltsp-server-standalone_5.0.40~bzr20080319-1_all.deb
  to pool/main/l/ltsp/ltsp-server-standalone_5.0.40~bzr20080319-1_all.deb
ltsp-server_5.0.40~bzr20080319-1_all.deb
  to pool/main/l/ltsp/ltsp-server_5.0.40~bzr20080319-1_all.deb
ltsp_5.0.40~bzr20080319-1.diff.gz
  to pool/main/l/ltsp/ltsp_5.0.40~bzr20080319-1.diff.gz
ltsp_5.0.40~bzr20080319-1.dsc
  to pool/main/l/ltsp/ltsp_5.0.40~bzr20080319-1.dsc
ltsp_5.0.40~bzr20080319.orig.tar.gz
  to pool/main/l/ltsp/ltsp_5.0.40~bzr20080319.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 451878@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@freegeek.org> (supplier of updated ltsp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 19 Mar 2008 20:26:49 -0400
Source: ltsp
Binary: ltsp-server ltsp-server-standalone ltsp-client-core ltsp-client ltsp-client-builder
Architecture: source all i386
Version: 5.0.40~bzr20080319-1
Distribution: unstable
Urgency: low
Maintainer: LTSP Debian/Ubuntu Maintainers <pkg-ltsp-devel@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagrant@freegeek.org>
Description: 
 ltsp-client - LTSP client environment
 ltsp-client-builder - build an LTSP environment in the installer target (udeb)
 ltsp-client-core - LTSP client environment
 ltsp-server - basic LTSP server environment
 ltsp-server-standalone - complete LTSP server environment
Closes: 451878
Changes: 
 ltsp (5.0.40~bzr20080319-1) unstable; urgency=low
 .
   * new upstream:
     - improved FHS compliance (/usr/lib/ltsp -> /usr/share/ltsp)
     - support for network booting on arm and mips (untested)
     - support for legacy versions of etherboot (untested)
     - rename startx screen script to xdmcp and simplify to use only X.org
     - drop checks for sdm
     - make /etc/fstab configuration optional
     - only report UTF-8 languages in ldminfod
     - nbdswapd: create a sparse file
     - plugins:
       + create filesystem images for use with NBD
       + bind-mount server's package cache
       + handle when TMP and/or TMPDIR are set (Closes: #451878)
       + upgrade packages after initial install
     - detect default server with NBD root
 .
    * use ltsp-client* init scripts from upstream:
      - drop defaults for bind_mounts variables (was difficult to unset them)
      - drop preseed function (un-used debian-ism)
      - don't put /var/cache/debconf in temp_copy_dirs (it's big, un-used, and
        debian-specific)
      - add /root to copy_dirs
 .
    * ltsp-build-client: only install plugins for common, Debian, and Ubuntu.
      other plugins are un-used on Debian.
Files: 
 83363ceb856ea10cb906e238de09bd54 1019 misc extra ltsp_5.0.40~bzr20080319-1.dsc
 9b6fbf76948f82b3f2bdc991061b0db6 116871 misc extra ltsp_5.0.40~bzr20080319.orig.tar.gz
 4ad1bf183858d06e63a81f5eb6c2105b 65253 misc extra ltsp_5.0.40~bzr20080319-1.diff.gz
 e52cab181f8b55b31945b34b87be402d 90858 misc extra ltsp-server_5.0.40~bzr20080319-1_all.deb
 c26f2cf098749a77ef2b5cebba59ccfc 39110 misc extra ltsp-server-standalone_5.0.40~bzr20080319-1_all.deb
 0c565c792556a73752a018c43bc84e68 38108 misc extra ltsp-client_5.0.40~bzr20080319-1_all.deb
 0344f6763009fe8c637354b70e7015d4 7354 debian-installer extra ltsp-client-builder_5.0.40~bzr20080319-1_all.udeb
 085f00ef670eff7702e6bf256e24b32d 71668 misc extra ltsp-client-core_5.0.40~bzr20080319-1_i386.deb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFH4bqElPc63BPWGpkRApDJAJ9e0v2qeoZbGRqPdU0GSPeSTGrJ0QCggVj2
21vBGEPWRyKGcPfN5yADkaY=
=/4z+
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.