Debian Bug report logs - #445011
xfsprogs: fsck.xfs doesn't verify that the device exists

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Wayne Tucker <wtucker@donobi.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: xfsprogs: fsck.xfs doesn't verify that the device exists

Date: Tue, 02 Oct 2007 10:38:24 -0700

[Message part 1 (text/plain, inline)]

Package: xfsprogs
Version: 2.8.11-1
Severity: normal
Tags: patch

fsck.xfs doesn't check to see if the device it is asked to check
exists.  This can result in a system booting with an incomplete set of
filesystem mounts.  The included patch works for me, although I only
have a limited number of systems on which to test it.

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-xen-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages xfsprogs depends on:
ii  libc6    2.3.6.ds1-13etch2               GNU C Library: Shared libraries
ii  libreadl 5.2-2                           GNU readline and history libraries
ii  libuuid1 1.39+1.40-WIP-2006.11.14+dfsg-2 universally unique id library

xfsprogs recommends no packages.

-- no debconf information

[fsck.xfs.diff (text/plain, attachment)]

Message #10 received at 445011@bugs.debian.org (full text, mbox, reply):

From: Nathan Scott <nscott@aconex.com>

To: Wayne Tucker <wtucker@donobi.com>, 445011@bugs.debian.org

Subject: Re: Bug#445011: xfsprogs: fsck.xfs doesn't verify that the device exists

Date: Wed, 03 Oct 2007 08:59:48 +1000

Hi Wayne,

On Tue, 2007-10-02 at 10:38 -0700, Wayne Tucker wrote:
> 
> 
> fsck.xfs doesn't check to see if the device it is asked to check
> exists.  This can result in a system booting with an incomplete set of
> filesystem mounts.  The included patch works for me, although I only
> have a limited number of systems on which to test it. 

Hmm, OK - seems safe enough I guess.  It'd be nice to understand
the root cause here a bit - is the problem that we dont attempt to
access /dev/foo at all, so udev doesn't see any requests for that
device and doesnt create the device node?  Then later when we try
to mount, the mount userspace code gets ENODEV?  If so, I wonder
why the mount doesn't populate the device nodes on its access?

Also, the NFS fsck program is also a shell script, I wonder if it
might suffer similar issues and need a similar patch?  Possibly not
since theres no local device involved there.

I'll send the patch upstream and solicit their thoughts as well.

thanks.

--
Nathan

Message #15 received at 445011@bugs.debian.org (full text, mbox, reply):

From: Wayne Tucker <wtucker@donobi.com>

To: nscott@aconex.com

Cc: 445011@bugs.debian.org

Subject: Re: Bug#445011: xfsprogs: fsck.xfs doesn't verify that the device exists

Date: Tue, 02 Oct 2007 17:23:38 -0700

Nathan Scott wrote:
> Hi Wayne,

Hello Nathan,

> On Tue, 2007-10-02 at 10:38 -0700, Wayne Tucker wrote:
>>
>> fsck.xfs doesn't check to see if the device it is asked to check
>> exists.  This can result in a system booting with an incomplete set of
>> filesystem mounts.  The included patch works for me, although I only
>> have a limited number of systems on which to test it. 
> 
> Hmm, OK - seems safe enough I guess.  It'd be nice to understand
> the root cause here a bit - is the problem that we dont attempt to
> access /dev/foo at all, so udev doesn't see any requests for that
> device and doesnt create the device node?  Then later when we try
> to mount, the mount userspace code gets ENODEV?  If so, I wonder
> why the mount doesn't populate the device nodes on its access?

My knowledge of udev is pretty limited, so I'm not sure if that would 
come into play at all.

The situation I ran into is when the device that is supposed to contain 
the xfs filesystem is missing.  fsck.xfs doesn't tell checkfs.sh that 
there's a problem, and mountall.sh gladly assumes that checkfs.sh did 
all of the legwork.

This bug might be more appropriately applied to the initscripts package, 
but I decided to file it here since:

1.) this was an easier fix
2.) in the same scenario, fsck.(ext(2|3)|minix|cramfs|jfs) return errors
3.) this was a much easier fix. :)

In my case, the missing devices are being caused by intermittent XENBUS 
timeouts.  The the VM boots but doesn't realize that /var/log isn't 
mounted.  There's an underlying issue that needs to be resolved there, 
but the same problem could happen on normal machines in the event that a 
physical device is dead.


> Also, the NFS fsck program is also a shell script, I wonder if it
> might suffer similar issues and need a similar patch?  Possibly not
> since theres no local device involved there.

It looks like fsck.nfs may just be a kludge for people that specify a 
pass other than 0 on nfs mounts.  mountnfs.sh is smarter than 
mountlocal.sh and doesn't seem to be dependent on fsck for anything.


> I'll send the patch upstream and solicit their thoughts as well.

Thanks for your time and consideration.

- Wayne

Message #20 received at 445011@bugs.debian.org (full text, mbox, reply):

From: Nathan Scott <nscott@aconex.com>

To: Wayne Tucker <wtucker@donobi.com>

Cc: 445011@bugs.debian.org

Subject: Re: Bug#445011: xfsprogs: fsck.xfs doesn't verify that the device exists

Date: Wed, 03 Oct 2007 10:56:04 +1000

On Tue, 2007-10-02 at 17:23 -0700, Wayne Tucker wrote:
> 
> In my case, the missing devices are being caused by intermittent
> XENBUS 
> timeouts.  The the VM boots but doesn't realize that /var/log isn't 
> mounted.  There's an underlying issue that needs to be resolved
> there, 
> but the same problem could happen on normal machines in the event that
> a 
> physical device is dead.
> 

Fair enough.  I'm sure the xfs maintainers will merge this (I've
sent them some mail), & I'll upload the fixed package once they do.

cheers.

--
Nathan

Message #25 received at 445011-close@bugs.debian.org (full text, mbox, reply):

From: Niv Sardi <xaiki@debian.org>

To: 445011-close@bugs.debian.org

Subject: Bug#445011: fixed in xfsprogs 2.9.4-1

Date: Wed, 31 Oct 2007 04:17:03 +0000

Source: xfsprogs
Source-Version: 2.9.4-1

We believe that the bug you reported is fixed in the latest version of
xfsprogs, which is due to be installed in the Debian FTP archive:

xfslibs-dev_2.9.4-1_i386.deb
  to pool/main/x/xfsprogs/xfslibs-dev_2.9.4-1_i386.deb
xfsprogs-udeb_2.9.4-1_i386.udeb
  to pool/main/x/xfsprogs/xfsprogs-udeb_2.9.4-1_i386.udeb
xfsprogs_2.9.4-1.diff.gz
  to pool/main/x/xfsprogs/xfsprogs_2.9.4-1.diff.gz
xfsprogs_2.9.4-1.dsc
  to pool/main/x/xfsprogs/xfsprogs_2.9.4-1.dsc
xfsprogs_2.9.4-1_i386.deb
  to pool/main/x/xfsprogs/xfsprogs_2.9.4-1_i386.deb
xfsprogs_2.9.4.orig.tar.gz
  to pool/main/x/xfsprogs/xfsprogs_2.9.4.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 445011@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niv Sardi <xaiki@debian.org> (supplier of updated xfsprogs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 29 Oct 2007 17:42:00 +1100
Source: xfsprogs
Binary: xfsprogs-udeb xfslibs-dev xfsprogs
Architecture: source i386
Version: 2.9.4-1
Distribution: unstable
Urgency: low
Maintainer: Nathan Scott <nathans@debian.org>
Changed-By: Niv Sardi <xaiki@debian.org>
Description: 
 xfslibs-dev - XFS filesystem-specific static libraries and headers
 xfsprogs   - Utilities for managing the XFS filesystem
 xfsprogs-udeb - A stripped-down version of xfsprogs for debian-installer (udeb)
Closes: 144876 148123 148150 293631 339717 347561 385090 387057 409063 414073 414079 420764 445011
Changes: 
 xfsprogs (2.9.4-1) unstable; urgency=low
 .
   * New upstream release.
   * There are bugs that do not apply anymore (but were never closed)
     (closes: #339717, #347561, #414073, #409063, #387057, #385090, #293631, #420764, #414079, #445011, #148150, #148123)
   * Repackage as non-native. (closes: #144876)
   * Updated to latest standards, no change was needed.
   * Remove coma in udeb description as it confuses debconf (at least linda says so)
   * Remove checkver call, and let debian/compat be.
Files: 
 d8f567065b63aba4c1724e575ec23528 647 admin optional xfsprogs_2.9.4-1.dsc
 1cf0d30b35c6ba5b5d181602537bedf3 1005884 admin optional xfsprogs_2.9.4.orig.tar.gz
 1901235de651974c341b68093e84af8e 15695 admin optional xfsprogs_2.9.4-1.diff.gz
 4b9a57deb2ab2512a3ba94c2b0775c32 1397718 admin optional xfsprogs_2.9.4-1_i386.deb
 63f2fb85fde4c8af08ac511a4b9cdcd5 298304 libdevel extra xfslibs-dev_2.9.4-1_i386.deb
 d61662f4d2253a2d3418bc6d87e58afc 128586 debian-installer optional xfsprogs-udeb_2.9.4-1_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHJ/eAvD4bToVllT0RArXNAJwPOe7N/zalZmGYhHbfos+4Z3+LnwCeItZf
83tjqKyxOAcUunOkuGxFhrY=
=v0SN
-----END PGP SIGNATURE-----

Message #30 received at 445011-done@bugs.debian.org (full text, mbox, reply):

From: Christoph Hellwig <hch@lst.de>

To: 445011-done@bugs.debian.org

Subject: Verified to be fixed in lenny

Date: Thu, 1 Jan 2009 11:25:07 +0100

The patch in this bug has been included upstream, and I verified that
the installed fsck.xfs from xfsprogs-2.9.8-1 includes it.

Send a report that this bug log contains spam.