Debian Bug report logs - #440634
PHP Bug #39449 - Overloaded array properties do not work correctly

[Message part 1 (text/plain, inline)]
Package: php5
Version: 5.2.0-8+etch7
Severity: important

--- Please enter the report below this line. ---

Hi,

I'm hit by PHP Bug #39449.

Testing the first Reproduce code of http://bugs.php.net/bug.php?id=39449, I 
get:

$ php test2.php
0 => a
1 => b
2 => c
0 => a
1 => b
2 => c

So I guess the bug isn't fixed in 5.2.0-8+etch7.

We have some customers, which are using the symfony framework and having 
troubles with php5 5.2.0-8+etch7.

--- System information. ---
Architecture: i386
Kernel:       Linux 2.6.21-2-686

Debian Release: 4.0
  500 stable          ftp.de.debian.org
    1 etch-backports  www.backports.org 
    1 etch-backports  217.145.103.253 

With kind regards, Jan.
-- 
Never write mail to <waja@spamfalle.info>, you have been warned!
-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GIT d-- s+: a- C+++ UL++++ P+ L+++ E- W+++ N+++ o++ K++ w--- O M V- PS PE
Y++ PGP++ t-- 5 X R tv- b+ DI- D++ G++ e++ h-- r+++ y+++
------END GEEK CODE BLOCK------

[test2.php (application/x-php, attachment)]
[Message part 3 (application/pgp-signature, inline)]
[Message part 1 (text/plain, inline)]
tags 440634 upstream
forwarded 440634 http://bugs.php.net/bug.php?id=39449
thanks

hi jan,

the standard "i'm too overwhelmed with other stuff but if you found a patch 
from the typically unhelpful this-is-fixed-in-cvs php bug report then we can 
revisit the issue" blurb applies :/

	sean

[signature.asc (application/pgp-signature, inline)]
Hey Sean, Jan:

  This is the same issue myself and Andi wrote about not quite a month 
ago.  This problem was fixed in 5.2.1, if I remember correctly (it was 
some time back), it went away between 5.2.0-RC4 and 5.2.1.

I am CC'ing Andi as he might have resources to help you find the exact 
patch which fixed this issue.

I have a pretty detailed summary of the same issue here:

http://framework.zend.com/issues/browse/ZF-1743

-ralph

sean finney wrote:
> tags 440634 upstream
> forwarded 440634 http://bugs.php.net/bug.php?id=39449
> thanks
> 
> hi jan,
> 
> the standard "i'm too overwhelmed with other stuff but if you found a patch 
> from the typically unhelpful this-is-fixed-in-cvs php bug report then we can 
> revisit the issue" blurb applies :/
> 
> 
> 	sean
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> pkg-php-maint mailing list
> pkg-php-maint@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-php-maint

Sorry, I dropped the ball on this as I was very busy. Let me circle back
with my team and look into this.

> -----Original Message-----
> From: Ralph Schindler [mailto:ralph@smashlabs.com]
> Sent: Monday, September 03, 2007 10:52 AM
> To: sean finney; 440634@bugs.debian.org
> Cc: Jan Wagner; Andi Gutmans
> Subject: Re: [php-maint] Bug#440634: Bug#440634: PHP Bug #39449 -
> Overloaded array properties do not work correctly
> 
> Hey Sean, Jan:
> 
>    This is the same issue myself and Andi wrote about not quite a
month
> ago.  This problem was fixed in 5.2.1, if I remember correctly (it was
> some time back), it went away between 5.2.0-RC4 and 5.2.1.
> 
> I am CC'ing Andi as he might have resources to help you find the exact
> patch which fixed this issue.
> 
> I have a pretty detailed summary of the same issue here:
> 
> http://framework.zend.com/issues/browse/ZF-1743
> 
> -ralph
> 
> sean finney wrote:
> > tags 440634 upstream
> > forwarded 440634 http://bugs.php.net/bug.php?id=39449
> > thanks
> >
> > hi jan,
> >
> > the standard "i'm too overwhelmed with other stuff but if you found
a
> patch
> > from the typically unhelpful this-is-fixed-in-cvs php bug report
then
> we can
> > revisit the issue" blurb applies :/
> >
> >
> > 	sean
> >
> >
> >
---------------------------------------------------------------------
> ---
> >
> > _______________________________________________
> > pkg-php-maint mailing list
> > pkg-php-maint@lists.alioth.debian.org
> > http://lists.alioth.debian.org/mailman/listinfo/pkg-php-maint

[Message part 1 (text/plain, inline)]

[forwarded message (message/rfc822, inline)]
[Message part 3 (text/plain, inline)]
Hi Sean,

Dmitry who made the necessary fixes in the PHP 5.2.x tree just forwarded
me the patch.

It is attached.

With this patch the said Zend Framework functionality should work.

Btw, once you bundle a PHP version which actually works with Zend
Framework, would you be interested in bundling ZF itself? I will also be
talking to some other Linux distros about that.

Best,

Andi

From: Dmitry Stogov [mailto:dmitry@php.net] 
Sent: Wednesday, January 10, 2007 7:58 AM
To: zend-engine-cvs@lists.php.net
Subject: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) / zend_compile.c
zend_compile.h zend_execute.c zend_execute.h zend_hash.c zend_hash.h
zend_language_parser.y zend_object_handlers.c zend_vm_def.h
zend_vm_execute.h /tests bug35106.phpt bug36214.ph

dmitry          Wed Jan 10 15:58:09 2007 UTC 

  Added files:                 (Branch: PHP_5_2) 
    /ZendEngine2/tests  bug35106.phpt bug36214.phpt bug39449.phpt 
                        bug39990.phpt 

  Modified files:              
    /php-src    NEWS 
    /ZendEngine2        zend_compile.c zend_compile.h zend_execute.c 
                        zend_execute.h zend_hash.c zend_hash.h 
                        zend_language_parser.y zend_object_handlers.c 
                        zend_vm_def.h zend_vm_execute.h 
    /ZendEngine2/tests  bug38146.phpt 
  Log: 
  - Fixed bug #35106 (nested foreach fails when array variable has a
reference). 
  - Fixed bug #36214 (__get method works properly only when conditional
operator is used). 
  - Fixed bug #39449 (Overloaded array properties do not work
correctly). 
  - Fixed bug #39990 (Cannot "foreach" over overloaded properties). 

[Message part 4 (text/html, inline)]
[dmitry-20070110155809.txt (text/plain, attachment)]
[ATT00009.txt (text/plain, attachment)]
[Message part 7 (text/plain, inline)]
_______________________________________________
pkg-php-maint mailing list
pkg-php-maint@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-php-maint
[Message part 1 (text/plain, inline)]
hi ralph, andi, et al.

On Tuesday 06 May 2008 10:27:46 pm Ralph Schindler wrote:
> Just curious if you had time to follow up with this.  A patch was found and
> supplied, but I think at some point this thread died out.
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=440634#10

i've spent a bit of time looking at the patch, and unfortunately parts of it 
do not apply:

rangda[/home/sean/debian/build-area/php5-5.2.0] patch --dry-run -p1 < 
~/overloaded_array_properties.patch                :)
(Stripping trailing CRs from patch.)
patching file Zend/zend_compile.c
Hunk #1 succeeded at 3634 (offset -43 lines).
Hunk #2 succeeded at 3647 (offset -43 lines).
Hunk #3 succeeded at 3660 (offset -43 lines).
Hunk #4 succeeded at 3675 (offset -43 lines).
Hunk #5 succeeded at 3694 (offset -43 lines).
Hunk #6 succeeded at 3706 (offset -43 lines).
Hunk #7 succeeded at 3737 (offset -43 lines).
(Stripping trailing CRs from patch.)
patching file Zend/zend_compile.h
(Stripping trailing CRs from patch.)
patching file Zend/zend_execute.c
Hunk #1 FAILED at 1163.
1 out of 1 hunk FAILED -- saving rejects to file Zend/zend_execute.c.rej
(Stripping trailing CRs from patch.)
patching file Zend/zend_execute.h
(Stripping trailing CRs from patch.)
patching file Zend/zend_hash.c
Hunk #1 succeeded at 992 (offset -14 lines).
(Stripping trailing CRs from patch.)
patching file Zend/zend_hash.h
(Stripping trailing CRs from patch.)
patching file Zend/zend_language_parser.y
(Stripping trailing CRs from patch.)
patching file Zend/zend_object_handlers.c
Hunk #1 FAILED at 334.
1 out of 1 hunk FAILED -- saving rejects to file 
Zend/zend_object_handlers.c.rej
(Stripping trailing CRs from patch.)
patching file Zend/zend_vm_def.h
Hunk #1 succeeded at 3198 (offset -9 lines).
Hunk #2 succeeded at 3243 (offset -9 lines).
Hunk #3 FAILED at 3255.
Hunk #4 succeeded at 3265 (offset -11 lines).
Hunk #5 succeeded at 3274 (offset -11 lines).
1 out of 5 hunks FAILED -- saving rejects to file Zend/zend_vm_def.h.rej
(Stripping trailing CRs from patch.)
patching file Zend/zend_vm_execute.h
Hunk #1 succeeded at 2255 (offset -1 lines).
Hunk #2 succeeded at 4795 (offset -2 lines).
Hunk #3 succeeded at 7917 (offset -11 lines).
Hunk #4 succeeded at 7962 (offset -11 lines).
Hunk #5 FAILED at 7974.
Hunk #6 succeeded at 7984 (offset -13 lines).
Hunk #7 succeeded at 7993 (offset -13 lines).
Hunk #8 succeeded at 19967 (offset -22 lines).
1 out of 8 hunks FAILED -- saving rejects to file Zend/zend_vm_execute.h.rej
(Stripping trailing CRs from patch.)
patching file Zend/tests/bug38146.phpt
Hunk #1 FAILED at 14.
1 out of 1 hunk FAILED -- saving rejects to file Zend/tests/bug38146.phpt.rej
rangda[/home/sean/debian/build-area/php5-5.2.0]                         [1] :(

and the first failed hunk does indeed seem nontrivial (seems the surrounding 
logic hash changed enough that someone who knows the code should review the 
change).  i've stopped there, so i don't know if it's the same for the rest 
of the failures.

fwiw, i've reattached the patch in question, in which i've made the following 
modificaitons:

- removed NEWS changes
- removed cvs id related changes
- s,ZendEngine2,foo/Zend, in patch references, so the whole patch applies 
cleanly to an unpacked php5 tarball at -p1.

if someone wants to comment on what should be done (or beter, provide a patch 
that applies against 5.2.0), i can take the next step of providing updated 
packages for testing.

thanks,
	sean

[overloaded_array_properties.patch (text/x-diff, attachment)]
[signature.asc (application/pgp-signature, inline)]
Version 5.2.6-5

Closing bugs found only in etch (or something in between etch and
lenny) versions which are no longer supported.

--
Ondřej Surý <ondrej@sury.org>

Debian Bug report logs - #440634 PHP Bug #39449 - Overloaded array properties do not work correctly

Debian Bug report logs - #440634
PHP Bug #39449 - Overloaded array properties do not work correctly