Debian Bug report logs - #439717
run dh_desktop if needed

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Bernd Zeimetz <bernd@bzed.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: cdbs: run dh_desktop if there's a debian/package.desktop file

Date: Sun, 26 Aug 2007 21:50:48 +0200

Package: cdbs
Version: 0.4.49
Severity: wishlish

If I understand my fast grep right, dh_desktop is only run in the gnome
include file. It should be run for all packaging types, if there's a
package.desktop file present - for example for python applications,
which are using gtk/wx/qt/...



Thanks,

Bernd


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-ck1 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

cdbs depends on no packages.

Versions of packages cdbs recommends:
ii  autotools-dev                 20070725.1 Update infrastructure for config.{
ii  debhelper                     5.0.53     helper programs for debian/rules

-- no debconf information

Message #10 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Peter Eisentraut <peter_e@gmx.net>

To: Bernd Zeimetz <bernd@bzed.de>, 439717@bugs.debian.org

Subject: Re: Bug#439717: cdbs: run dh_desktop if there's a debian/package.desktop file

Date: Sun, 26 Aug 2007 22:52:24 +0200

Bernd Zeimetz wrote:
> If I understand my fast grep right, dh_desktop is only run in the
> gnome include file. It should be run for all packaging types, if
> there's a package.desktop file present - for example for python
> applications, which are using gtk/wx/qt/...

The thing about dh_desktop is, it's barely documented.  I have no idea 
what it does or why one would want to call it.  I'd like that to be 
addressed first.

Message #15 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Bernd Zeimetz <bernd@bzed.de>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: 439717@bugs.debian.org

Subject: Re: Bug#439717: cdbs: run dh_desktop if there's a debian/package.desktop file

Date: Sun, 26 Aug 2007 23:33:51 +0200

Peter Eisentraut wrote:
> Bernd Zeimetz wrote:
>   
>> If I understand my fast grep right, dh_desktop is only run in the
>> gnome include file. It should be run for all packaging types, if
>> there's a package.desktop file present - for example for python
>> applications, which are using gtk/wx/qt/...
>>     
>
> The thing about dh_desktop is, it's barely documented.  I have no idea 
> what it does or why one would want to call it.  I'd like that to be 
> addressed first.
>   
Imho the manpage documents it pretty well, there's not much to document
about it. As the manpage describs it, the developer has to take care of
installing the file, so I guess that's not a problem cdbs needs to take
care of. JoeyH can probably tell you more.

-- 
Bernd Zeimetz
<bernd@bzed.de>                         <http://bzed.de/>

Message #20 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Peter Eisentraut <peter_e@gmx.net>

To: Bernd Zeimetz <bernd@bzed.de>

Cc: 439717@bugs.debian.org

Subject: Re: Bug#439717: cdbs: run dh_desktop if there's a debian/package.desktop file

Date: Mon, 27 Aug 2007 00:13:35 +0200

Bernd Zeimetz wrote:
> Imho the manpage documents it pretty well, there's not much to
> document about it. As the manpage describs it, the developer has to
> take care of installing the file, so I guess that's not a problem
> cdbs needs to take care of. JoeyH can probably tell you more.

Well, what the script actually does it add a call 
to "update-desktop-database -q" to postinst and postrm.  This program 
doesn't exist on my machine, and I run a fairly bloated desktop.  It 
looks like it comes from the package desktop-file-utils, which has a 
total of 9 reverse dependencies in the archive.  It also doesn't 
contain a man page or any other documentation about that program.  So 
that leads me to believe that whatever that program does can't be so 
terribly important.

In reference to your original issue, the fact that there is a 
debian/package.desktop file is unrelated to dh_desktop anyway, because 
dh_desktop acts on installed files, not on files in the debian/ 
directory.

Message #27 received at 439717-done@bugs.debian.org (full text, mbox, reply):

From: Peter Eisentraut <peter_e@gmx.net>

To: 439717-done@bugs.debian.org

Subject: Re: Bug#439717: cdbs: run dh_desktop if there's a debian/package.desktop file

Date: Tue, 27 Nov 2007 13:14:19 +0100

This feature request is semantically incorrect in my mind.

Message #32 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Bernd Zeimetz <bernd@bzed.de>

To: 439717@bugs.debian.org, control@debian.org

Subject: Re: Bug#439717 closed by Peter Eisentraut <peter_e@gmx.net> (Re: Bug#439717: cdbs: run dh_desktop if there's a debian/package.desktop file)

Date: Tue, 27 Nov 2007 14:00:12 +0100

reopen 439717
retitle 439717 run dh_desktop if needed
thanks

> 
> This feature request is semantically incorrect in my mind.
> 

Then fix the semantics instead of closing it with a useless reason please.

dh_desktop is what you need to use if you install a desktop file
(currently only if it contains Mime-types, but dh_desktop takes care of
that).

The better check (instead of looking for a debian/package.desktop file)
would be to look into debian/packagename/usr/share/applications
to see if there's a desktop file, and run dh_desktop then.

At the moment dh_desktop is only called by the gnome class, but that's
nothing you want to include by default.
The proper way would be to check if running dh_desktop is needed for
every package. Remember, desktop files are a freedesktop.org standard
and not a gnome-only standard.


-- 
Bernd Zeimetz
<bernd@bzed.de>                         <http://bzed.de/>

Message #41 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Peter Eisentraut <peter_e@gmx.net>

To: Bernd Zeimetz <bernd@bzed.de>, 439717@bugs.debian.org

Subject: Re: [Build-common-hackers] Bug#439717: closed by Peter Eisentraut <peter_e@gmx.net> (Re: Bug#439717: cdbs: run dh_desktop if there's a debian/package.desktop file)

Date: Tue, 27 Nov 2007 15:35:37 +0100

Am Dienstag, 27. November 2007 schrieb Bernd Zeimetz:
> dh_desktop is what you need to use if you install a desktop file

I have installed many desktop files in my lifetime and I've never felt the 
need to run this program.  I would like to see some documentation for why 
this is needed.

> Remember, desktop files are a freedesktop.org standard  and not a gnome-only
> standard.

Sure, but "you need to run dh_desktop in every package" is not a 
freedesktop.org standard.  And we certainly won't make every package 
containing desktop files depend on a GNOME base package.  See #432851 for 
similar discussions.

Message #46 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Bernd Zeimetz <bernd@bzed.de>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: 439717@bugs.debian.org

Subject: Re: [Build-common-hackers] Bug#439717: closed by Peter Eisentraut <peter_e@gmx.net> (Re: Bug#439717: cdbs: run dh_desktop if there's a debian/package.desktop file)

Date: Tue, 27 Nov 2007 15:53:11 +0100

Peter Eisentraut wrote:
> Am Dienstag, 27. November 2007 schrieb Bernd Zeimetz:
>> dh_desktop is what you need to use if you install a desktop file
> 
> I have installed many desktop files in my lifetime and I've never felt the 
> need to run this program.  I would like to see some documentation for why 
> this is needed.

dh_desktop (only) takes care of adding maintainer script fragments to
call update-desktop-database, which is needed to update the desktop-MIME
mapping. And that's just needed if your .desktop file has a MimeType
entry. That's what man dh_desktop days.

>> Remember, desktop files are a freedesktop.org standard  and not a gnome-only
>> standard.
> 
> Sure, but "you need to run dh_desktop in every package" is not a 
> freedesktop.org standard.  And we certainly won't make every package 
> containing desktop files depend on a GNOME base package.  See #432851 for 
> similar discussions.

update-desktop-database is only part of desktop-file-utils.
Imho dh_desktop should add desktop-file-utils to misc:Depends, but
that's not a problem of cdbs.

-- 
Bernd Zeimetz
<bernd@bzed.de>                         <http://bzed.de/>

Message #51 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Peter Eisentraut <peter_e@gmx.net>

To: Bernd Zeimetz <bernd@bzed.de>

Cc: 439717@bugs.debian.org

Subject: Re: [Build-common-hackers] Bug#439717: closed by Peter Eisentraut <peter_e@gmx.net> (Re: Bug#439717: cdbs: run dh_desktop if there's a debian/package.desktop file)

Date: Tue, 27 Nov 2007 16:07:08 +0100

Am Dienstag, 27. November 2007 schrieb Bernd Zeimetz:
> dh_desktop (only) takes care of adding maintainer script fragments to
> call update-desktop-database, which is needed to update the desktop-MIME
> mapping. And that's just needed if your .desktop file has a MimeType
> entry. That's what man dh_desktop days.

Curiously, MIME mappings have worked fine for everyone else so far.  Or those 
not using whatever it is you are using.

> update-desktop-database is only part of desktop-file-utils.
> Imho dh_desktop should add desktop-file-utils to misc:Depends, but
> that's not a problem of cdbs.

Well, it is.  Either dh_desktop should add desktop-file-utils to misc:Depends 
(which seems reasonable to me), in which case we create useless dependencies 
for a lot of packages, or dh_desktop is effectively useless unless there is 
some other magic that installs desktop-file-utils for everyone.

Message #56 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Daniel Leidert <daniel.leidert@wgdd.de>

To: 439717@bugs.debian.org, Peter Eisentraut <peter_e@gmx.net>

Cc: 439717-submitter@bugs.debian.org

Subject: run dh_desktop if needed

Date: Tue, 22 Jan 2008 17:09:09 +0100

I read your discussion and I think, you are wrong Peter.

Everything done by dh_desktop is to add an *optional* call to
update-mime-database to create the central MIME mapping
database /usr/share/applications/mimeinfo.cache, if the
installed .desktop file contains a MimeType field. Running dh_desktop is
just a simplification of work. Otherwise maintainers would have to check
installed .desktop files for the MimeType field by hand.

The update-desktop-database tool itself is a cross-desktop tool, the
specification is a cross-desktop specification and it is already used by
GNOME, KDE, ROX and XFCE4. So where is the problem? The idea behind the
spec is to create a common system for MIME mappings to replace the
different solutions created and used by the mentioned desktops in the
past. And that's already the case. GNOME has changed to this system as
of version 2.4, KDE has already changed (/usr/share/applnk is already
pretty empty, but /usr/share/applications/kde has been filled) - but I
cannot remember the exact time - ditto for ROX and XFCE4.

So the database is used by all these desktops. So dh_desktop should run
by default and not just for GNOME. Why you refuse it?

And about the dependency on desktop-file-utils: Does dh_installmenu add
a dependency on menu? Is menu marked "required"? No for both questions.
So why should dh_desktop add a dependency on desktop-file-utils, also an
optional package?

PS: About "MIME mappings have worked fine for everyone else so far". I
often observe questions about evolution not opening MIME types with
special programs and similar questions. Please check the archives, if
you do not believe me. Further KDE AFAIK *additionally* uses the
metamail system and it currently still uses /usr/share/applnk too. So
KDE users probably see some MIME mappings, but also miss a lot, if
desktop-file-utils are not installed.

Regards, Daniel

Message #66 received at 439717@bugs.debian.org (full text, mbox, reply):

From: "Trent W. Buck" <trentbuck@gmail.com>

To: Peter Eisentraut <peter_e@gmx.net>, 439717@bugs.debian.org

Cc: Bernd Zeimetz <bernd@bzed.de>

Subject: Re: Bug#439717: cdbs: run dh_desktop if needed.

Date: Sat, 31 Jan 2009 11:37:18 +1100

On Tue, Nov 27, 2007 at 03:35:37PM +0100, Peter Eisentraut wrote:
> Am Dienstag, 27. November 2007 schrieb Bernd Zeimetz:
>> dh_desktop is what you need to use if you install a desktop file
>
> I have installed many desktop files in my lifetime and I've never
> felt the need to run this program.  I would like to see some
> documentation for why this is needed.

With respect, I am more interested in what lintian says than how you
feel.

W: midori: desktop-mimetype-without-update-call /usr/share/applications/midori.desktop
N:
N:    Your package installs a .desktop file which contains a MimeType setting,
N:    but it doesn't call update-desktop-database in the package postinst
N:    maintainer script. This program updates the MIME type cache and should
N:    be called whenever installing a package with a new MimeType
N:    registration.
N:
N:    If you are using debhelper, you can add the necessary fragment to your
N:    postinst by calling dh_desktop in debian/rules.
N:
N:    Severity: minor; Certainty: certain

Taking dh(1) as exemplary, this call should happen unconditionally in
the following sequence of the "install" target.  I assume it is a noop
rather than an error when dh_desktop is unnecessary.

        dh_installwm
        dh_installxfonts
        dh_lintian
        dh_desktop
        dh_gconf
        dh_icons
        dh_perl

Message #71 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Jay Berkenbilt <qjb@debian.org>

To: 439717@bugs.debian.org

Subject: dh_desktop: offer to patch

Date: Sat, 04 Apr 2009 22:24:57 -0400

I'm running into the lintian warning that Trent Buck included in this
bug report with nip2 as well.  The change looks easy enough and, as
Trent points out, harmless if not needed for some packages.  I'd be
happy to submit a patch if it would help.  I'd rather not have to work
around it in my own debian/rules files, as using cdbs has always kept
my rules files nice and simple.  I'm a big fan of cdbs because it
generally just does the Right Thing.  Thanks again for your
consideration.

-- 
Jay Berkenbilt <qjb@debian.org>

Message #76 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: Jay Berkenbilt <qjb@debian.org>, 439717@bugs.debian.org

Subject: Re: [Build-common-hackers] Bug#439717: dh_desktop: offer to patch

Date: Sun, 5 Apr 2009 11:31:47 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sat, Apr 04, 2009 at 10:24:57PM -0400, Jay Berkenbilt wrote:
>
>I'm running into the lintian warning that Trent Buck included in this 
>bug report with nip2 as well.  The change looks easy enough and, as 
>Trent points out, harmless if not needed for some packages.  I'd be 
>happy to submit a patch if it would help.  I'd rather not have to work 
>around it in my own debian/rules files, as using cdbs has always kept 
>my rules files nice and simple.  I'm a big fan of cdbs because it 
>generally just does the Right Thing.  Thanks again for your 
>consideration.

Please do prepare a patch.  I will make sure to look over it and apply 
it if it is sane (which I sincerely expect that it will be :-)  ).

I don't expect this to be complicated and could also do it myself, but 
indeed help is nice: Small typos in CDBS can have big consequences, so 
more eyeballs is certainly appreciated.


Kind regards,

  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknYeoMACgkQn7DbMsAkQLjBbgCeMa0qyEzC9/SRVpK0JXgP+eWP
hD0AnAl8BQ2pl6miD6i4M8tbBBoTdGty
=CGnH
-----END PGP SIGNATURE-----

Message #81 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Jay Berkenbilt <qjb@debian.org>

To: 439717@bugs.debian.org

Subject: Re: [Build-common-hackers] Bug#439717: dh_desktop: offer to patch

Date: Sun, 05 Apr 2009 10:26:31 -0400

Jonas Smedegaard <dr@jones.dk> wrote:

> Please do prepare a patch.  I will make sure to look over it and apply 
> it if it is sane (which I sincerely expect that it will be :-)  ).
>
> I don't expect this to be complicated and could also do it myself, but 
> indeed help is nice: Small typos in CDBS can have big consequences, so 
> more eyeballs is certainly appreciated.

Sounds good.  I use all cdbs for all my packages, so it will get some
testing both with those that do and don't use desktop files.

-- 
Jay Berkenbilt <qjb@debian.org>

Message #86 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Jay Berkenbilt <qjb@debian.org>

To: 439717@bugs.debian.org

Subject: dh_desktop: no patch needed

Date: Mon, 06 Apr 2009 19:50:40 -0400

Looking into this further, I believe no patch to cdbs is required.
Simply including /usr/share/cdbs/1/class/gnome.mk sometime after
including /usr/share/cdbs/1/rules/debhelper.mk appears to be
sufficient to cause dh_desktop to be run at the correct time.  At
least for my package, this is sufficient to remove the lintian
warning.

-- 
Jay Berkenbilt <qjb@debian.org>

Message #91 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: Jay Berkenbilt <qjb@debian.org>, 439717@bugs.debian.org

Subject: Re: [Build-common-hackers] Bug#439717: dh_desktop: no patch needed

Date: Tue, 7 Apr 2009 02:33:35 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, Apr 06, 2009 at 07:50:40PM -0400, Jay Berkenbilt wrote:
>
>Looking into this further, I believe no patch to cdbs is required.
>Simply including /usr/share/cdbs/1/class/gnome.mk sometime after
>including /usr/share/cdbs/1/rules/debhelper.mk appears to be
>sufficient to cause dh_desktop to be run at the correct time.  At
>least for my package, this is sufficient to remove the lintian
>warning.

Hm.  If you won't do it then I will: It is wrong to require a specific 
order of including the CDBS snippets, if at all possible to avoid it.


Thanks for raising attention to the issue, even if you do not see it as 
relevant to fix it (properly). :-)


Kind regards,

  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknan18ACgkQn7DbMsAkQLimfgCfSkmCyZ+wTjRip6EknnLGKp1D
xXIAniSY65cZrhtXJBFQH2C2Q+gNkBz6
=40Ml
-----END PGP SIGNATURE-----

Message #96 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Jay Berkenbilt <qjb@debian.org>

To: 439717@bugs.debian.org

Subject: Re: [Build-common-hackers] Bug#439717: dh_desktop: no patch needed

Date: Mon, 06 Apr 2009 21:09:28 -0400

Jonas Smedegaard <dr@jones.dk> wrote:

> On Mon, Apr 06, 2009 at 07:50:40PM -0400, Jay Berkenbilt wrote:
>>
>>Looking into this further, I believe no patch to cdbs is required.
>>Simply including /usr/share/cdbs/1/class/gnome.mk sometime after
>>including /usr/share/cdbs/1/rules/debhelper.mk appears to be
>>sufficient to cause dh_desktop to be run at the correct time.  At
>>least for my package, this is sufficient to remove the lintian
>>warning.
>
> Hm.  If you won't do it then I will: It is wrong to require a specific 
> order of including the CDBS snippets, if at all possible to avoid it.
>
>
> Thanks for raising attention to the issue, even if you do not see it as 
> relevant to fix it (properly). :-)

Actually, I didn't really check carefully about the order.  The order
may not matter.  I didn't have gnome.mk included at all, so I figured
the problem was just my omission.  However, I see code in gnome.mk
that is conditional inside of

ifdef _cdbs_rules_debhelper
...
endif

which is most likely order-dependent since the ifdef will be evaluated
at the time that the file is loaded rather than at the time that the
rules are evaluated as with ordinary macros.

Anyway, if you'd still like me to patch, I can still look into it.  I
wasn't trying to punt it...just thinking that the error was actually
in my rules rather than in cdbs. :-)  However, I won't have another
chance to look at it until at least the weekend.

--Jay

Message #101 received at 439717@bugs.debian.org (full text, mbox, reply):

From: "Trent W. Buck" <trentbuck@gmail.com>

To: Jay Berkenbilt <qjb@debian.org>, 439717@bugs.debian.org

Subject: Re: Bug#439717: dh_desktop: no patch needed

Date: Tue, 7 Apr 2009 11:22:24 +1000

On Mon, Apr 06, 2009 at 07:50:40PM -0400, Jay Berkenbilt wrote:
> Looking into this further, I believe no patch to cdbs is required.
> Simply including /usr/share/cdbs/1/class/gnome.mk sometime after
> including /usr/share/cdbs/1/rules/debhelper.mk appears to be
> sufficient to cause dh_desktop to be run at the correct time.  At
> least for my package, this is sufficient to remove the lintian
> warning.

I can't help thinking that may have disastrous consequences for
packages that have nothing to do with GNOME, particularly if gnome.mk
decides to do something "more gnomey" in future -- currently it
appears to merely invoke dh_gconf, dh_desktop and dh_icons.

Message #106 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: Jay Berkenbilt <qjb@debian.org>, 439717@bugs.debian.org

Subject: Re: [Build-common-hackers] Bug#439717: Bug#439717: dh_desktop: no patch needed

Date: Tue, 7 Apr 2009 09:50:45 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, Apr 06, 2009 at 09:09:28PM -0400, Jay Berkenbilt wrote:
>Jonas Smedegaard <dr@jones.dk> wrote:
>
>> On Mon, Apr 06, 2009 at 07:50:40PM -0400, Jay Berkenbilt wrote:
>>>
>>>Looking into this further, I believe no patch to cdbs is required. 
>>>Simply including /usr/share/cdbs/1/class/gnome.mk sometime after 
>>>including /usr/share/cdbs/1/rules/debhelper.mk appears to be 
>>>sufficient to cause dh_desktop to be run at the correct time.  At 
>>>least for my package, this is sufficient to remove the lintian 
>>>warning.
>>
>> Hm.  If you won't do it then I will: It is wrong to require a 
>> specific order of including the CDBS snippets, if at all possible to 
>> avoid it.
>>
>>
>> Thanks for raising attention to the issue, even if you do not see it 
>> as relevant to fix it (properly). :-)
>
>Actually, I didn't really check carefully about the order.  The order
>may not matter.  I didn't have gnome.mk included at all, so I figured
>the problem was just my omission.  However, I see code in gnome.mk
>that is conditional inside of
>
>ifdef _cdbs_rules_debhelper
>...
>endif
>
>which is most likely order-dependent since the ifdef will be evaluated 
>at the time that the file is loaded rather than at the time that the 
>rules are evaluated as with ordinary macros.

Yes, that indeed sounds like order-dependent.  Many places in the CDBS 
code has such without being strictly needed.  I want to clean that up - 
I apologize if I am now stealing your attention from something related 
but slightly different: I just really would appreciate help :-)


>Anyway, if you'd still like me to patch, I can still look into it.  I
>wasn't trying to punt it...just thinking that the error was actually
>in my rules rather than in cdbs. :-)  However, I won't have another
>chance to look at it until at least the weekend.

Yes, please.  If I can persuade you to cook up a patch then please do.  
Just take your time.


Another thought (but please note that I still haven't looked looked 
closely at this bugreport - am just replying to your recent messages): 
If it is safe to always run dh_debhelper (e.g. it does not require new 
dependencies) then perhaps it should be added to debhelper.mk (and 
dropped from gnome.mk if that snippet depend on debhelper).  My 
reasoning here is that I suspect desktop files are not GNOME-specific, 
so should be equally easy handled for other desktops too.


Thanks,

  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknbBdUACgkQn7DbMsAkQLjwaQCfXzhHC/+LRguBT9vK+JK0M34v
LoIAmgI0HgI4nJE2zqSVDtI4nhgZNmd2
=zsPg
-----END PGP SIGNATURE-----

Message #111 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Peter Eisentraut <peter_e@gmx.net>

To: build-common-hackers@lists.alioth.debian.org, 439717@bugs.debian.org

Cc: Jay Berkenbilt <qjb@debian.org>

Subject: Re: [Build-common-hackers] Bug#439717: Bug#439717: Bug#439717: dh_desktop: no patch needed

Date: Tue, 7 Apr 2009 16:29:53 +0300

On Tuesday 07 April 2009 10:50:45 Jonas Smedegaard wrote:
> Another thought (but please note that I still haven't looked looked
> closely at this bugreport - am just replying to your recent messages):
> If it is safe to always run dh_debhelper (e.g. it does not require new
> dependencies) then perhaps it should be added to debhelper.mk (and
> dropped from gnome.mk if that snippet depend on debhelper).  My
> reasoning here is that I suspect desktop files are not GNOME-specific,
> so should be equally easy handled for other desktops too.

Desktop files are not GNOME-specific, but the actions that dh_desktop produces 
are apparently GNOME-specific.

Ultimately, converting dh_desktop and dh_icons to dpkg triggers will be the 
best solution.

Message #116 received at 439717@bugs.debian.org (full text, mbox, reply):

From: Eric Lavarde <deb@zorglub.s.bawue.de>

To: Debian Bug Tracking System <439717@bugs.debian.org>

Subject: cdbs: dh_desktop obsolete as per lintian!?

Date: Sun, 06 Sep 2009 20:41:25 +0200

Package: cdbs
Version: 0.4.61
Severity: normal


Hi,

this bug can be closed as dh_desktop is now obsolete (check the man page).

Eric

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.30-bpo.1-686 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages cdbs depends on:
ii  debhelper                     7.4.0      helper programs for debian/rules

Versions of packages cdbs recommends:
pn  autotools-dev                 <none>     (no description available)

Versions of packages cdbs suggests:
ii  devscripts                    2.10.54    scripts to make the life of a Debi
ii  doc-base                      0.9.3      utilities to manage online documen

-- no debconf information

Message #121 received at 439717-close@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: 439717-close@bugs.debian.org

Subject: Bug#439717: fixed in cdbs 0.4.90

Date: Mon, 27 Dec 2010 03:47:05 +0000

Source: cdbs
Source-Version: 0.4.90

We believe that the bug you reported is fixed in the latest version of
cdbs, which is due to be installed in the Debian FTP archive:

cdbs_0.4.90.dsc
  to main/c/cdbs/cdbs_0.4.90.dsc
cdbs_0.4.90.tar.gz
  to main/c/cdbs/cdbs_0.4.90.tar.gz
cdbs_0.4.90_all.deb
  to main/c/cdbs/cdbs_0.4.90_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 439717@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonas Smedegaard <dr@jones.dk> (supplier of updated cdbs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 27 Dec 2010 04:30:08 +0100
Source: cdbs
Binary: cdbs
Architecture: source all
Version: 0.4.90
Distribution: experimental
Urgency: low
Maintainer: CDBS Hackers <build-common-hackers@lists.alioth.debian.org>
Changed-By: Jonas Smedegaard <dr@jones.dk>
Description: 
 cdbs       - common build system for Debian packages
Closes: 377965 424898 439717 523642 583559 594042 598410 599218 604548 604718 606703
Changes: 
 cdbs (0.4.90) experimental; urgency=low
 .
   [ Jonas Smedegaard ]
   * Tighten resolved build-dependency on cdbs when using debhelper
     compat level 7, to ensure use of dh_prep (see bug#586616).
   * Fix add support for DEB_CONFIGURE_FLAGS_$flavor variables.
   * Introduce new variable DEB_UPSTREAM_WGET_OPTS to upstream-
     tarball.mk.
   * Sync copyright-check with recent draft of DEP5 (Bazaar rev. 132).
   * Have debhelper.mk invoke dh_bugfiles if available.
     Closes: bug#604548. Thanks to Laurent Bigonville.
   * Reorganize autotools-vars.mk variables for clarity.
   * Have autotools add --enable-debug when DEB_BUILD_OPTIONS contains
     debug.
     Closes: bug#599218. Thanks to Emilio Pozuelo Monfort.
   * Have python-distutils.mk quote --root path to work when parent of
     builddir contains spaces.
     Closes: bug#598410. Thanks to Michael Terry.
   * Fix documentation to use relative DEB_SRCDIR in autotools.mk
     example.
     Closes: bug#594042. Thanks to IOhannes m zmoelnig.
   * Reorganize langcore.mk variables in preparation for improvements.
   * Deprecate DEB_OPT_FLAG (if ever used it should be done differently).
   * Have langcore.mk resolve compile flags using dpkg-buildflags when
     possible.
     Closes: bug#583559. Thanks to Raphaël Hertzog.
   * Fix cdbs_expand_nondefaultvar function, and extend to also avoid
     undefined (not only default) and support fallback.
   * Introduce new variable CDBS_FIX_COMPILE_FLAGS (uset by default).
     Closes: bug#523642 (as best possible). Thanks to Robert Millan.
   * Fix respect DEB_MAKE_DESTDIRSKEL when flavors are used in
     makefile.mk. Keep install flavors in same destdir for python-
     autotools. Add NEWS item about the change.
   * Support per-flavor DEB_MAKE_BUILDDIRSKEL and DEB_MAKE_DESTDIRSKEL.
   * Use newline+space delimiter in copyright-hints by default,
     configurable through DEB_COPYRIGHT_CHECK_DELIMITER.
   * Improve cleanup rules in python-distutils.mk: also clean python3
     __pycache__ dirs (even if currently unused).
   * Use new python-2 system by default (i.e. when DEB_PYTHON_SYSTEM not
     set).
   * Tighten resolved build-dependency on python when using default
     python-2 system.
   * Rewrite copyright file using Bazaar rev.132 draft of DEP5 format.
   * Simplify python-vars.mk to expand recursively (drop colon): no
     longer used for rules expansion (and apparently never were).
   * Revert filter out python3 modules by default: May cause regressions,
     and is handled better for python2/python3 system anyway.
   * Fix avoid marking stampfile targets as PHONY in python-distutils.mk.
   * Fix invoke python debhelper only for relevant packages.
     Really closes: bug#377965, but since that bug is 4+ years old we fix
     only for new python2/python3 and keep broken behavior for legacy
     systems to avoid surprises.
   * Extend python classes to support dh_python3 packaging system.
   * Add new copyright holder to debian/copyright (no new licensing).
 .
   [ Piotr Ożarowski ]
   * No longer creates debian/pycompat files in clean rule.
     Closes: bug#424898. Thanks to Bernd Zeimetz and others.
   * Extend python classes to support dh_python2 packaging system.
     Add corresponding distutils-9 distutils-10 and distutils-11
     regression test.
     Closes: bug#604718.
   * Ignore python3 packages in python-vars.mk.
 .
   [ Emilio Pozuelo Monfort ]
   * dh_desktop is deprecated, don't call it anymore.
     Closes: bug#439717.
   * Fix permissions of new python2 regression test.
   * Fix variable substitution in DEB_CONFIGURE_FLAGS_$flavor expansion.
   * debhelper.mk: Invoke dh_girepository if available.
     Closes: bug#606703.
 .
   [ Rémi Thebault ]
   * Add waf class.
Checksums-Sha1: 
 f9f3b8f5b627de6521add28918faddced8d91646 1967 cdbs_0.4.90.dsc
 af65b993e37ce0348c7dd268a799c8c4d82bff13 260340 cdbs_0.4.90.tar.gz
 91a587938dcf1b0d31f9bc2e802e2b33317cb0aa 1252130 cdbs_0.4.90_all.deb
Checksums-Sha256: 
 b24dbbf9124282d33af9e5b1dfcd9d60348d620d0fc194628f95f6ef6a7c255b 1967 cdbs_0.4.90.dsc
 818539cf9444d0fc58b38d8ce3817a2431bc4a9b26a6aab43f51c93af6c879ac 260340 cdbs_0.4.90.tar.gz
 1af497e037ce2d555d659e19cad517c0e2766a36e84a8ed1f31d6d4a927edf10 1252130 cdbs_0.4.90_all.deb
Files: 
 38c2c17e2cb46fbc7da243c66237da25 1967 devel optional cdbs_0.4.90.dsc
 7022ed68328d5236b45662d2681aefe7 260340 devel optional cdbs_0.4.90.tar.gz
 452df2f478365717ff31b8987c128d4c 1252130 devel optional cdbs_0.4.90_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCgAGBQJNGArbAAoJECx8MUbBoAEh6PgP/0o7vRd0xn/FRjhM9zZ8+vYp
rbcn/GLEMmwzgoUG/q9iutPYIWpGkiz0YFlbef2T+YW2PFKclFYptyLTt+bs9Ck4
F3GlHZd6IZ+a76RtlXh/yrsqQln/W1IAB3gFhT65O3s2RvsYJtSfFLIX3Kz4jZQ6
WiPB0b4cRWseonDFDybfK2NSjbhzrhgmTuBLgH/rV2thwj17Idj0joitFFT7Z32L
Q8M7HWI01PMEkK+hW+B9rAf1JIHO1tuUVwp0c/k6sqpDQjkQh6SoRNo1pNYeYryo
6tTmROPvF/CTVEa+VKsXhaVAqZdKZNac8jzWrQEd3CSIUHGqZtK6WQ7bIz/gH7Ad
67Rx68mmcfpla7ijbQgnH201YfaJC9cQRq4+nXU0lqsxFMJWDFk30U9HQc+MGpjM
S4MnnTp05bc5UUl1m/2lVFzYBfuVNL/RpbPkV+bXGL2HQPhYa3xFgPSxuR0GdsR2
peD+EXntbsW0XUAXh6n9uXe96l3W5QSRgyPgBKueL7E/VT9xh/CeTZT1JK3IvBp/
NCN/QQEuo5aQbAiEcvguHclVLtNOVbPrFzDhXblFzr31Px+ezgDnj//ckXJiQDer
SCd8kjIxiXOTO/GuXSMqt8+baPR25QfTnuyucv3wyxEwkuA3YwEYbM9+riYC/SeM
QifnY8ZuX0Kb1xqc/1PD
=qSGv
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.