Debian Bug report logs - #437466
module-assistant: prepare (and thus auto-install) doesn't like --kernel-dir

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Frédéric Brière <fbriere@fbriere.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: module-assistant: prepare (and thus auto-install) doesn't like --kernel-dir

Date: Sun, 12 Aug 2007 14:13:59 -0400

[Message part 1 (text/plain, inline)]

Package: module-assistant
Version: 0.10.11
Severity: normal
Tags: patch

If --kernel-dir is provided, and @opt_kverslist is therefore empty,
prep() will fail at line 566.  And since it is called by auto-install,
this makes it impossible to use this handy little command for custom
kernels.

I see three possible ways to fix this:

  1) Don't call prep() unless @opt_kverslist.  This has the unfortunate
     side-effect of also disabling the install of build-essential.

  2) Run $todo foreach @opt_kverslist in prep().  This potentially calls
     apt-get multiple times (which is annoying if there's a yes/no
     question each time), and renders the whole idea of the
     /usr/src/linux symlink somewhat moot.

  3) Replace the for with a if($todo = ...).  This is the simplest, and
     works fine for me.  I'm attaching a measily patch that does this.


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.21-2-k7 (SMP w/1 CPU core)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

[prep_kdir.diff (text/plain, attachment)]

Message #10 received at 437466@bugs.debian.org (full text, mbox, reply):

From: Matthijs Kooijman <matthijs@stdin.nl>

To: Debian Bug Tracking System <437466@bugs.debian.org>

Subject: module-assistant: Fourth option: Listen to the manpage

Date: Sun, 30 Dec 2007 14:17:10 +0100

[Message part 1 (text/plain, inline)]

Package: module-assistant
Version: 0.10.11
Tags: patch
Followup-For: Bug #437466

Hey,

I didn't really get your second option, so excuse me if my proposal is
similary.

I see a fourth option to fix this: Do what the manpage says.

 --kernel-dir
              The kernel source directories to be used for builds. You can specify multiple directories with multiple options or  separated  by  commas  or
              line separators (e.g using -k "`echo /usr/src/kernel-headers-*`" ).  The kernel versions detected in this directories are automatically added
              to the list of target kernel versions (see --kvers-list for details).

The manpage promises to add the kernel versions found in the source dirs
to the --kvers-list option, but module-assistant doesn't.

The attached patch does exactly this.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-rc3-gd928769a-dirty (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages module-assistant depends on:
ii  libtext-wrapi18n-perl         0.06-5     internationalized substitute of Te
ii  perl                          5.8.8-7    Larry Wall's Practical Extraction 

Versions of packages module-assistant recommends:
ii  liblocale-gettext-perl        1.05-1     Using libc functions for internati

-- no debconf information

[add-to-kvers-list.diff (text/plain, attachment)]

Message #15 received at 437466@bugs.debian.org (full text, mbox, reply):

From: Steffen Grunewald <steffen.grunewald@aei.mpg.de>

To: Debian Bug Tracking System <437466@bugs.debian.org>

Subject: module-assistant: Please integrate Matthijs Kooijman's patch

Date: Thu, 29 May 2008 13:17:51 +0200

Package: module-assistant
Version: 0.10.8
Followup-For: Bug #437466


As I could prove with my local installation, Matthijs' fix indeed works,
and allows me to run 
	m-a -t -k "`echo /lib/modules/*/build/" a-i openafs-modules
to build openafs-modules for all installed kernels.

Version 0.10.11.0 in sid (and probably lenny) still has the same
problem. 
I'd like to see the importance of this bug raised and a fixed version to
be released with Lenny...


-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-5-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages module-assistant depends on:
ii  libtext-wrapi18n-perl       0.06-5       internationalized substitute of Te
ii  perl                        5.8.8-7etch3 Larry Wall's Practical Extraction 

Versions of packages module-assistant recommends:
ii  liblocale-gettext-perl        1.05-1     Using libc functions for internati

-- no debconf information

Message #20 received at 437466@bugs.debian.org (full text, mbox, reply):

From: Dominique Brazziel <dbrazziel@snet.net>

To: 437466@bugs.debian.org

Subject: Please fix

Date: Sun, 11 Apr 2010 18:29:20 -0400

As of Version 0.11.3 this bug still exists and 
we have to patch again.  The latest version
line number of the start of the previous patch changed from
1286 to 1287 but that's about it.  

Message #25 received at 437466@bugs.debian.org (full text, mbox, reply):

From: Frédéric Brière <fbriere@fbriere.net>

To: 437466@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: Bug#437466: module-assistant: prepare (and thus auto-install) doesn't like --kernel-dir

Date: Mon, 27 May 2013 21:29:33 -0400

usertags 437466 - orphaned
submitter 437466 Frédéric Brière <orphaned-bug@fbriere.net>
thanks


I've long ago switched from module-assistant to DKMS, so I don't really
care what happens of this bug report anymore.

If anyone out there has any interest in this bug, please feel free to
adopt it and set yourself as its new submitter.


-- 
I had the rare misfortune of being one of the first people to try and
implement a PL/1 compiler.
		-- T. Cheatham

Message #32 received at 437466-close@bugs.debian.org (full text, mbox, reply):

From: Eduard Bloch <blade@debian.org>

To: 437466-close@bugs.debian.org

Subject: Bug#437466: fixed in module-assistant 0.11.9

Date: Sat, 03 Sep 2016 18:23:24 +0000

Source: module-assistant
Source-Version: 0.11.9

We believe that the bug you reported is fixed in the latest version of
module-assistant, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 437466@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Eduard Bloch <blade@debian.org> (supplier of updated module-assistant package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 03 Sep 2016 20:02:21 +0200
Source: module-assistant
Binary: module-assistant
Architecture: source all
Version: 0.11.9
Distribution: unstable
Urgency: low
Maintainer: Eduard Bloch <blade@debian.org>
Changed-By: Eduard Bloch <blade@debian.org>
Description:
 module-assistant - tool to make module package creation easier
Closes: 437466 829595
Changes:
 module-assistant (0.11.9) unstable; urgency=low
 .
   * When debian/rules is called without frontend, try to get information from
     include/generated/utsrelease.h as well
   * In generic.sh, rename the internal override variable $BUILDDIR to avoid
     confusion by environments like pbuilder shell
   * Also considering tar.lzma extension in tarball lookup
   * Don't attempt to install linux headers if they have been configured by the
     user via command line option (closes: #437466)
   * Mark module packages as auto-installed (by David Kalnischkies,
     closes: #829595)
Checksums-Sha1:
 e3754076e42b4eedd8f19cae1fa4623c4b899403 1733 module-assistant_0.11.9.dsc
 480e0ef45936220aa625e54947aa7a154cae961a 93680 module-assistant_0.11.9.tar.xz
 c0099693b3da7e8804fdf0bd11d8dd29ee404ab2 100538 module-assistant_0.11.9_all.deb
Checksums-Sha256:
 a3a1e3e21ed5d48797b737185b834a1782511ba725854075e0587376c07d75db 1733 module-assistant_0.11.9.dsc
 fd4349b41dbadf706291ab462b045831363b8da85edfcee2044725f19d03fa24 93680 module-assistant_0.11.9.tar.xz
 b9ba353c9c3e15d1520c7bea8d67790fb029f441b6d4c46c60051c8781438d67 100538 module-assistant_0.11.9_all.deb
Files:
 21da2969e9ef3b0989c4bb5345356029 1733 kernel optional module-assistant_0.11.9.dsc
 0a3f6590bc6c6f9ecd3072b1b9e82729 93680 kernel optional module-assistant_0.11.9.tar.xz
 c9f1116236bd937b40810290c5b844d7 100538 kernel optional module-assistant_0.11.9_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBV8sTGGl0DlyzX+w8AQhmTA/+J2WR6GqvNk2ZPuidfvhUlC+yFeDGtff1
aNIasz5Ja+64CrC+EFOhnJu4thez/6Ytm2dwFHgRbAxbro97p7zTuSkF9QE2g/8P
1aAxcLdFtAHmFeeTkwnEgKMH80rS0+2+NJAz066BNub3xEZyA9z0c1dcqMXINOR9
jFhKwfSeVc9CAdI+Z21a0IsCyGd4cjvSS4Cd0541pBDur7yPKdwiBxzulfdVs9ME
aQ1eNDkZfjQA1Y2ROBcjilYTKQnn6Rlu6+9tmMMT/D4HYj6ZRhXvBHGBaSnHsQ6d
8WpO/AqlBuNeapDZfYkbJc+jBPjrBpOcV87JB+FUdE5rFvAfrw9KP17jZAI4+1EN
Ba+ZLQ7Myg408VqrIp6fnFNQNaDILKbDTM7jA5miABUdghJXWaG2UW/UIYPlfzW8
gO4RmnjigXqWKCJbKw3acURrRvnKXQLV6pR3AWIW53sVbzBuX/GD1SwlmSP7Y0cZ
YFKvmZt1q9SBbIIvCoetOepnKeb9qlegnYWCQwbbGr6zdnBxu0IG5iP5I2z0olyc
mGLSbHd5SIsM7BBAEArc4DiUsKxT9MPJgaS05kfs/LoDGT6H2nhVncTFRwQ7UTvc
qvzDZ2pRXdWbPAL5OweXXoCCWvkb+1JE4MrBGeZGC5aQLpbv8RVY0dzFiQQ35Iwx
ZjI/pJlhlyw=
=aBO2
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.