Debian Bug report logs - #429147
locking bugs in libxi6

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: David Weinehall <tao@debian.org>

To: Debian BTS <submit@bugs.debian.org>

Subject: Incorrect X locking in wacom-tools?

Date: Fri, 15 Jun 2007 22:49:17 +0200

Package: wacom-tools
Version: 0.7.7.11-1
Severity: important

Using wacom-tools with an XCB enabled X-server causes xsetwacom to
die.  A simple harmless example of a command that triggers this:

$ xsetwacom get stylus BottomY
xsetwacom: xcb_xlib.c:41: xcb_xlib_lock: Assertion `!c->xlib.lock'
failed.
Aborted

backtrace:

#0  0xb7fbe7f2 in ?? () from /lib/ld-linux.so.2
#1  0xb7e93d60 in raise () from /lib/i686/cmov/libc.so.6
#2  0xb7e955b1 in abort () from /lib/i686/cmov/libc.so.6
#3  0xb7e8d42b in __assert_fail () from /lib/i686/cmov/libc.so.6
#4  0xb7d756f4 in xcb_xlib_lock (c=0x804f7f8) at xcb_xlib.c:41
#5  0xb7dc0e38 in ?? () from /usr/lib/libX11.so.6
#6  0x0804f7f8 in ?? ()
#7  0x04d59e4c in ?? ()
#8  0xb7fd9ff4 in ?? () from /lib/ld-linux.so.2
#9  0xb7fbd858 in ?? ()
#10 0xb7d7e968 in ?? () from /usr/lib/libXi.so.6
#11 0x0804f008 in ?? ()
#12 0xbfc22f18 in ?? ()
#13 0xb7d79ca1 in XGetDeviceControl (dpy=0x804f008, dev=0x1, control=1)
    at ../../src/XGetDCtl.c:80


Regards: David
-- 
 /) David Weinehall <tao@debian.org> /) Rime on my window           (\
//  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   //  Diamond-white roses of fire //
\)  http://www.acc.umu.se/~tao/    (/   Beautiful hoar-frost       (/

Message #10 received at 429147@bugs.debian.org (full text, mbox, reply):

From: Ron <ron@debian.org>

To: David Weinehall <tao@debian.org>, 429147@bugs.debian.org, linuxwacom-discuss@lists.sourceforge.net

Subject: Re: Bug#429147: Incorrect X locking in wacom-tools?

Date: Sat, 16 Jun 2007 07:29:53 +0930

Hi,

I've just received this report from a user of the Debian packages,
can anyone shed any light on this?

Cheers,
Ron


On Fri, Jun 15, 2007 at 10:49:17PM +0200, David Weinehall wrote:
> Package: wacom-tools
> Version: 0.7.7.11-1
> Severity: important
> 
> Using wacom-tools with an XCB enabled X-server causes xsetwacom to
> die.  A simple harmless example of a command that triggers this:
> 
> $ xsetwacom get stylus BottomY
> xsetwacom: xcb_xlib.c:41: xcb_xlib_lock: Assertion `!c->xlib.lock'
> failed.
> Aborted
> 
> backtrace:
> 
> #0  0xb7fbe7f2 in ?? () from /lib/ld-linux.so.2
> #1  0xb7e93d60 in raise () from /lib/i686/cmov/libc.so.6
> #2  0xb7e955b1 in abort () from /lib/i686/cmov/libc.so.6
> #3  0xb7e8d42b in __assert_fail () from /lib/i686/cmov/libc.so.6
> #4  0xb7d756f4 in xcb_xlib_lock (c=0x804f7f8) at xcb_xlib.c:41
> #5  0xb7dc0e38 in ?? () from /usr/lib/libX11.so.6
> #6  0x0804f7f8 in ?? ()
> #7  0x04d59e4c in ?? ()
> #8  0xb7fd9ff4 in ?? () from /lib/ld-linux.so.2
> #9  0xb7fbd858 in ?? ()
> #10 0xb7d7e968 in ?? () from /usr/lib/libXi.so.6
> #11 0x0804f008 in ?? ()
> #12 0xbfc22f18 in ?? ()
> #13 0xb7d79ca1 in XGetDeviceControl (dpy=0x804f008, dev=0x1, control=1)
>     at ../../src/XGetDCtl.c:80
> 
> 
> Regards: David
> -- 
>  /) David Weinehall <tao@debian.org> /) Rime on my window           (\
> //  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   //  Diamond-white roses of fire //
> \)  http://www.acc.umu.se/~tao/    (/   Beautiful hoar-frost       (/
> 

Message #15 received at 429147@bugs.debian.org (full text, mbox, reply):

From: "Ping@LinuxWacom" <pinglinux@gmail.com>

To: Ron <ron@debian.org>

Cc: "David Weinehall" <tao@debian.org>, 429147@bugs.debian.org, linuxwacom-discuss@lists.sourceforge.net

Subject: Re: [Linuxwacom-discuss] Bug#429147: Incorrect X locking in wacom-tools?

Date: Fri, 15 Jun 2007 16:20:37 -0700

I have no clue except that Jacek has just filed a bug
(https://sourceforge.net/tracker/index.php?func=detail&aid=1720328&group_id=69596&atid=525124)
against linuxwacom.  From his reference to Xorg, it looks like I need
to fix something in xsetwacom.  But, after reading those links, I
still have no clue what to do to fix it.

Ping

On 6/15/07, Ron <ron@debian.org> wrote:
>
> Hi,
>
> I've just received this report from a user of the Debian packages,
> can anyone shed any light on this?
>
> Cheers,
> Ron
>
>
> On Fri, Jun 15, 2007 at 10:49:17PM +0200, David Weinehall wrote:
> > Package: wacom-tools
> > Version: 0.7.7.11-1
> > Severity: important
> >
> > Using wacom-tools with an XCB enabled X-server causes xsetwacom to
> > die.  A simple harmless example of a command that triggers this:
> >
> > $ xsetwacom get stylus BottomY
> > xsetwacom: xcb_xlib.c:41: xcb_xlib_lock: Assertion `!c->xlib.lock'
> > failed.
> > Aborted
> >
> > backtrace:
> >
> > #0  0xb7fbe7f2 in ?? () from /lib/ld-linux.so.2
> > #1  0xb7e93d60 in raise () from /lib/i686/cmov/libc.so.6
> > #2  0xb7e955b1 in abort () from /lib/i686/cmov/libc.so.6
> > #3  0xb7e8d42b in __assert_fail () from /lib/i686/cmov/libc.so.6
> > #4  0xb7d756f4 in xcb_xlib_lock (c=0x804f7f8) at xcb_xlib.c:41
> > #5  0xb7dc0e38 in ?? () from /usr/lib/libX11.so.6
> > #6  0x0804f7f8 in ?? ()
> > #7  0x04d59e4c in ?? ()
> > #8  0xb7fd9ff4 in ?? () from /lib/ld-linux.so.2
> > #9  0xb7fbd858 in ?? ()
> > #10 0xb7d7e968 in ?? () from /usr/lib/libXi.so.6
> > #11 0x0804f008 in ?? ()
> > #12 0xbfc22f18 in ?? ()
> > #13 0xb7d79ca1 in XGetDeviceControl (dpy=0x804f008, dev=0x1, control=1)
> >     at ../../src/XGetDCtl.c:80
>

Message #28 received at 429147@bugs.debian.org (full text, mbox, reply):

From: David Weinehall <tao@debian.org>

To: 429147@bugs.debian.org

Subject: Patch to fix the issue...

Date: Wed, 4 Jul 2007 04:00:45 +0200

[Message part 1 (text/plain, inline)]

The attached patch seems to fix the issue with xsetwacom (and should fix
some other locking issues in libxi6 at the same time).

Hopefully correct; this is my first dive into X-land =)


Regards: David
-- 
 /) David Weinehall <tao@debian.org> /) Rime on my window           (\
//  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   //  Diamond-white roses of fire //
\)  http://www.acc.umu.se/~tao/    (/   Beautiful hoar-frost       (/

[libxi6-locking.patch (text/plain, attachment)]

Message #33 received at 429147@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: David Weinehall <tao@debian.org>

Cc: 429147@bugs.debian.org

Subject: Re: Locking bugs in libxi6?

Date: Wed, 4 Jul 2007 04:05:04 +0200

tags 429147 - patch
kthxbye

On Wed, Jul  4, 2007 at 03:59:04 +0200, David Weinehall wrote:

> reassign 429147 libxi6 2:1.1.0-2
> retitle 429147 locking bugs in libxi6
> severity 429147 important
> tags 429147 + patch
> thanks
> 
There is no patch in this bugreport.

Cheers,
Julien

Message #42 received at 429147@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: David Weinehall <tao@debian.org>, 429147@bugs.debian.org

Cc: Josh Triplett <josh@freedesktop.org>, Jamey Sharp <sharpone@debian.org>

Subject: Re: Bug#429147: Patch to fix the issue...

Date: Tue, 10 Jul 2007 18:08:40 +0200

[Message part 1 (text/plain, inline)]

Hi Josh and Jamey,

Could you have a look at this bug and David's patch?  It looks like the
locking in XChangeDeviceControl() and XGetSelectedExtensionEvents()
causes problems.

Thanks,
Julien

On Wed, Jul  4, 2007 at 04:00:45 +0200, David Weinehall wrote:

> The attached patch seems to fix the issue with xsetwacom (and should fix
> some other locking issues in libxi6 at the same time).
> 
> Hopefully correct; this is my first dive into X-land =)
> 
> 
> Regards: David
> -- 
>  /) David Weinehall <tao@debian.org> /) Rime on my window           (\
> //  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   //  Diamond-white roses of fire //
> \)  http://www.acc.umu.se/~tao/    (/   Beautiful hoar-frost       (/

> diff -urN tmp/libxi-1.1.0/src/XChgDCtl.c libxi-1.1.0/src/XChgDCtl.c
> --- tmp/libxi-1.1.0/src/XChgDCtl.c	2006-10-21 12:07:21.000000000 +0300
> +++ libxi-1.1.0/src/XChgDCtl.c	2007-07-04 04:21:16.000000000 +0300
> @@ -105,6 +105,8 @@
>  	    SyncHandle();
>  	    return (NoSuchExtension);
>  	} else
> +	    UnlockDisplay(dpy);
> +	    SyncHandle();
>  	    return (rep.status);
>      }
>      case DEVICE_ABS_CALIB:
> @@ -132,6 +134,8 @@
>              return NoSuchExtension;
>          }
>          else {
> +	    UnlockDisplay(dpy);
> +	    SyncHandle();
>              return rep.status;
>          }
>      }
> @@ -158,6 +162,8 @@
>              return NoSuchExtension;
>          }
>          else {
> +	    UnlockDisplay(dpy);
> +	    SyncHandle();
>              return rep.status;
>          }
>      }
> @@ -179,6 +185,8 @@
>              return NoSuchExtension;
>          }
>          else {
> +	    UnlockDisplay(dpy);
> +	    SyncHandle();
>              return rep.status;
>          }
>      }
> @@ -200,6 +208,8 @@
>              return NoSuchExtension;
>          }
>          else {
> +	    UnlockDisplay(dpy);
> +	    SyncHandle();
>              return rep.status;
>          }
>      }
> diff -urN tmp/libxi-1.1.0/src/XGtSelect.c libxi-1.1.0/src/XGtSelect.c
> --- tmp/libxi-1.1.0/src/XGtSelect.c	2006-10-20 00:45:43.000000000 +0300
> +++ libxi-1.1.0/src/XGtSelect.c	2007-07-04 04:25:22.000000000 +0300
> @@ -106,6 +106,8 @@
>  					sizeof(XEventClass));
>  	    if (!*this_client_list) {
>  		_XEatData(dpy, (unsigned long)tlen + alen);
> +		UnlockDisplay(dpy);
> +		SyncHandle();
>  		return (Success);
>  	    }
>  	    for (i = 0; i < *this_client_count; i++) {
> @@ -122,6 +124,8 @@
>  		Xfree((char *)*this_client_list);
>  		*this_client_list = NULL;
>  		_XEatData(dpy, (unsigned long)alen);
> +		UnlockDisplay(dpy);
> +		SyncHandle();
>  		return (Success);
>  	    }
>  	    for (i = 0; i < *all_clients_count; i++) {

[signature.asc (application/pgp-signature, inline)]

Message #47 received at 429147@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: David Weinehall <tao@debian.org>, 429147@bugs.debian.org

Subject: Re: Bug#429147: Patch to fix the issue...

Date: Wed, 1 Aug 2007 04:22:30 +0200

[Message part 1 (text/plain, inline)]

tags 429147 fixed-upstream
kthxbye

On Wed, Jul  4, 2007 at 04:00:45 +0200, David Weinehall wrote:

> The attached patch seems to fix the issue with xsetwacom (and should fix
> some other locking issues in libxi6 at the same time).
> 
> Hopefully correct; this is my first dive into X-land =)
> 
Thanks, this is now committed upstream.

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Message #54 received at 429147-close@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: 429147-close@bugs.debian.org

Subject: Bug#429147: fixed in libxi 2:1.1.2-1

Date: Wed, 01 Aug 2007 03:32:03 +0000

Source: libxi
Source-Version: 2:1.1.2-1

We believe that the bug you reported is fixed in the latest version of
libxi, which is due to be installed in the Debian FTP archive:

libxi-dev_1.1.2-1_i386.deb
  to pool/main/libx/libxi/libxi-dev_1.1.2-1_i386.deb
libxi6-dbg_1.1.2-1_i386.deb
  to pool/main/libx/libxi/libxi6-dbg_1.1.2-1_i386.deb
libxi6_1.1.2-1_i386.deb
  to pool/main/libx/libxi/libxi6_1.1.2-1_i386.deb
libxi_1.1.2-1.diff.gz
  to pool/main/libx/libxi/libxi_1.1.2-1.diff.gz
libxi_1.1.2-1.dsc
  to pool/main/libx/libxi/libxi_1.1.2-1.dsc
libxi_1.1.2.orig.tar.gz
  to pool/main/libx/libxi/libxi_1.1.2.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 429147@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien Cristau <jcristau@debian.org> (supplier of updated libxi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 01 Aug 2007 05:07:05 +0200
Source: libxi
Binary: libxi-dev libxi6-dbg libxi6
Architecture: source i386
Version: 2:1.1.2-1
Distribution: unstable
Urgency: low
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Julien Cristau <jcristau@debian.org>
Description: 
 libxi-dev  - X11 Input extension library (development headers)
 libxi6     - X11 Input extension library
 libxi6-dbg - X11 Input extension library (debug package)
Closes: 429147
Changes: 
 libxi (2:1.1.2-1) unstable; urgency=low
 .
   * New upstream release
     + fixes locking bugs (closes: #429147).
   * Add myself to Uploaders and remove Branden and Fabio with their
     permission.
   * Use ${binary:Version} instead of ${Source-Version}.
   * Add a XS-Vcs-Browser header.
Files: 
 165dfdacb28273116863c6a03155f0a5 1021 x11 optional libxi_1.1.2-1.dsc
 8530454ef925ab8df129b737101ec953 366896 x11 optional libxi_1.1.2.orig.tar.gz
 8ebc62ccbeb04c129c6f98bf0c807db8 51438 x11 optional libxi_1.1.2-1.diff.gz
 58fee94bb12ef50cf915be2b08489d5c 24176 libs optional libxi6_1.1.2-1_i386.deb
 fbc064c3b6df85eee127974bb82dacf3 207254 libdevel extra libxi6-dbg_1.1.2-1_i386.deb
 e0975f7ed9c9ee6cb195c03802c853e2 68684 libdevel optional libxi-dev_1.1.2-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGr/w6mEvTgKxfcAwRAiajAJ9uEPmc+3knWXPfG5S09MjqehBCHACeKjTP
TJdHMZAWjl2hZs1a/aRHoN4=
=Q75H
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.